#metabrainz

/

      • CatQuest
        it sounds like whining
      • 2017-03-25 08413, 2017

      • reosarevok
        Well, it does say there that it's split from another, so it's quite clear why it starts like that
      • 2017-03-25 08415, 2017

      • CatQuest
        (which is probably why it sohuldn't have been there in the first place)
      • 2017-03-25 08422, 2017

      • CatQuest
        hmm
      • 2017-03-25 08450, 2017

      • CatQuest
        it says "Disparity between “Guess case” and style guideline" in the bottom
      • 2017-03-25 08401, 2017

      • CatQuest
        it doesnt really indicate that it's been "split off"
      • 2017-03-25 08408, 2017

      • CatQuest
        it does in that topic but
      • 2017-03-25 08437, 2017

      • reosarevok
        I dunno. It's not like anyone is going around topics rating them according to a "what makes a good topic" set of points
      • 2017-03-25 08439, 2017

      • CatQuest
        but I wish I was given an option to alter what I said to be more in topic instead of force topicising it
      • 2017-03-25 08455, 2017

      • CatQuest
        did anyone ask this "Piz" dude what hey thing?
      • 2017-03-25 08457, 2017

      • CatQuest
        think*
      • 2017-03-25 08429, 2017

      • reosarevok
        That looks like it was posted after the split? (because the original post says "split 1 post")
      • 2017-03-25 08437, 2017

      • CatQuest
        I don't know what to say.. I guess I made that reply as a repyl to the topic and conversation at hand, it never occured to me that this would be "too different" to belong
      • 2017-03-25 08408, 2017

      • CatQuest
        uh
      • 2017-03-25 08415, 2017

      • reosarevok
        But actually, if the reply was added before the split, that would be a stronger reason to do a split "hey, this is a somewhat different conversation, let's continue it in its own topic"
      • 2017-03-25 08432, 2017

      • CatQuest
        yea thats more ok
      • 2017-03-25 08449, 2017

      • CatQuest
        i don't midn if there is liek a conversation of about a differnt thing going on is splitted
      • 2017-03-25 08401, 2017

      • CatQuest
        but it was just my comment right?
      • 2017-03-25 08418, 2017

      • CatQuest
        it's like "that wasn't good enough, it's too OT for this, here move it somewhere else"
      • 2017-03-25 08429, 2017

      • CatQuest
        i *KNOW* that's not "what it really measn"
      • 2017-03-25 08437, 2017

      • CatQuest
        but that's what it.. well it feels liek tha
      • 2017-03-25 08439, 2017

      • CatQuest
        t
      • 2017-03-25 08421, 2017

      • CatQuest
        especially since I honestly don't feel that it was going off on a tangent and it was a completely On Topic reply to that conversation
      • 2017-03-25 08423, 2017

      • CatQuest
        I'd never intentionally reply to some topic with a "so far on a tangent that it should be a different topic" on purpose
      • 2017-03-25 08424, 2017

      • CatQuest
        i'd make a different topic!
      • 2017-03-25 08409, 2017

      • reosarevok
        Sure, so would everyone :)
      • 2017-03-25 08415, 2017

      • CatQuest
        yes?
      • 2017-03-25 08433, 2017

      • CatQuest
        like I'm feeling that maybe I should take this conversation somewhere else than #meta becasue it's weering oftopic here now
      • 2017-03-25 08445, 2017

      • CatQuest
        but I want to make that
      • 2017-03-25 08439, 2017

      • reosarevok
        Well, the whole point of having a forum with moderators is that they get to decide if something seems to belong better elsewhere, or not at all (spam/full OT), or what
      • 2017-03-25 08455, 2017

      • CatQuest
        yea sure
      • 2017-03-25 08401, 2017

      • CatQuest
        just.. wish i had a say
      • 2017-03-25 08416, 2017

      • CatQuest
        i'd rather amend my text thna move it t oa topic wnhe it wasnt a topic intended
      • 2017-03-25 08440, 2017

      • amanmehta joined the channel
      • 2017-03-25 08448, 2017

      • D4RK-PH0ENiX has quit
      • 2017-03-25 08410, 2017

      • arbenina_ has quit
      • 2017-03-25 08445, 2017

      • colbydray joined the channel
      • 2017-03-25 08432, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-03-25 08435, 2017

      • D4RK-PH0ENiX has quit
      • 2017-03-25 08405, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-03-25 08429, 2017

      • github joined the channel
      • 2017-03-25 08429, 2017

      • github
        [picard] samj1912 opened pull request #664: Port to Py3(WIP) (master...py3) https://git.io/vSkhO
      • 2017-03-25 08429, 2017

      • github has left the channel
      • 2017-03-25 08438, 2017

      • colbydray_ joined the channel
      • 2017-03-25 08428, 2017

      • colbydray has quit
      • 2017-03-25 08403, 2017

      • agentsim joined the channel
      • 2017-03-25 08436, 2017

      • colbydray_ has quit
      • 2017-03-25 08423, 2017

      • Nyanko-sensei has quit
      • 2017-03-25 08435, 2017

      • Zialus has quit
      • 2017-03-25 08428, 2017

      • Zialus joined the channel
      • 2017-03-25 08454, 2017

      • samj1912
        zas: can review the qt5 specific code on pr gh:P#503?
      • 2017-03-25 08454, 2017

      • BrainzBot
        PICARD-817, PICARD-960: Port Picard to Qt5(Continued): https://github.com/metabrainz/picard/pull/503
      • 2017-03-25 08410, 2017

      • samj1912
        I might have missed a few things while merging/rebasing
      • 2017-03-25 08419, 2017

      • zas
        samj1912: i think most occurences of map()/filter() can be replaced by list comprehensions
      • 2017-03-25 08437, 2017

      • samj1912
        okay :)
      • 2017-03-25 08408, 2017

      • samj1912
        zas: how do you want to handle the unicode conversions?
      • 2017-03-25 08426, 2017

      • samj1912
        do you want me to handle each case individually in case it needs to be casted into str or not
      • 2017-03-25 08433, 2017

      • samj1912
        or the current solution will do?
      • 2017-03-25 08440, 2017

      • zas
        samj1912: i think most str() are in fact useless with Py3, but .... we can't blindly remove them. So each case has to be handled individually.
      • 2017-03-25 08459, 2017

      • samj1912
        ah
      • 2017-03-25 08401, 2017

      • zas
        That said, it can be done in a second pass
      • 2017-03-25 08413, 2017

      • samj1912
        so ill leave it for later?
      • 2017-03-25 08456, 2017

      • zas
        Yep, just make a working version for now, that's already a lot of changes
      • 2017-03-25 08407, 2017

      • samj1912
        zas: also mutagen isnt completely ported to py3 apparently :\
      • 2017-03-25 08414, 2017

      • samj1912
        score doesn't work
      • 2017-03-25 08417, 2017

      • zas
        huh?
      • 2017-03-25 08432, 2017

      • samj1912
        we use a file.score method in guess_format
      • 2017-03-25 08437, 2017

      • samj1912
        from mutagen
      • 2017-03-25 08444, 2017

      • samj1912
        it isn't ported properly
      • 2017-03-25 08450, 2017

      • samj1912
        bytes/str problems
      • 2017-03-25 08416, 2017

      • zas
        I guess it has to be fixed upstream, open a mutagen ticket
      • 2017-03-25 08424, 2017

      • samj1912
        ok
      • 2017-03-25 08433, 2017

      • zas
        Can we provide a dirty workaround in the meantime ?
      • 2017-03-25 08442, 2017

      • samj1912
        I dont think so
      • 2017-03-25 08417, 2017

      • samj1912
        score is subclasses for each format
      • 2017-03-25 08440, 2017

      • zas
        Hmmm, that's really annoying, one condition for the move to Py3 was the mutagen Py3 compat
      • 2017-03-25 08446, 2017

      • samj1912
        the problem can be fixed by append a header.startswith(b'stringhere') instead of header.startswith('string')
      • 2017-03-25 08406, 2017

      • samj1912
        it will hardly take a single search/replace
      • 2017-03-25 08406, 2017

      • zas
        I have to go off for a while, i'll look into this issue later. The best we can do for now is to report the issue to mutagen team.
      • 2017-03-25 08410, 2017

      • samj1912
        zas: hmm this is weird
      • 2017-03-25 08423, 2017

      • samj1912
        when I did a manual search, all of it is properly handled
      • 2017-03-25 08432, 2017

      • samj1912
        but my pip3 mutagen causes an issue :\
      • 2017-03-25 08443, 2017

      • samj1912
        wait let me see my local copy
      • 2017-03-25 08454, 2017

      • samj1912
        * manual search on the GH repo
      • 2017-03-25 08407, 2017

      • samj1912
        ugh zas... nvm, it was an absolute import problem
      • 2017-03-25 08440, 2017

      • Sophist
        sam1912: I am not sure what we are proposing as the minimum version for Py3 - but we should definitely avoid 3.1 because 3.2 has better multi-threading support (which is pretty old so I am assuming that anyway).
      • 2017-03-25 08458, 2017

      • samj1912
        Sophist: 3.6 actually...
      • 2017-03-25 08433, 2017

      • Sophist
        sam1912: If you know what is needed to fix mutagen, then why not submit a PR.
      • 2017-03-25 08431, 2017

      • samj1912
        Sophist: was a problem on my end
      • 2017-03-25 08433, 2017

      • samj1912
        not mutagen
      • 2017-03-25 08453, 2017

      • Sophist
        Py3.6 sounds good - I haven't looked at the async stuff in the latest Py3, so not sure whether it would be an alternative to multi-threading or not.
      • 2017-03-25 08400, 2017

      • Sophist
        Ah.
      • 2017-03-25 08404, 2017

      • Sophist
        Missed that above.
      • 2017-03-25 08444, 2017

      • ZarkBit has quit
      • 2017-03-25 08405, 2017

      • Zialus has quit
      • 2017-03-25 08406, 2017

      • Zialus joined the channel
      • 2017-03-25 08423, 2017

      • lazka joined the channel
      • 2017-03-25 08403, 2017

      • nupurbaghel has quit
      • 2017-03-25 08429, 2017

      • nupurbaghel joined the channel
      • 2017-03-25 08435, 2017

      • nupurbaghel has quit
      • 2017-03-25 08402, 2017

      • deeptibaghel has left the channel
      • 2017-03-25 08444, 2017

      • ZarkBit joined the channel
      • 2017-03-25 08431, 2017

      • saifulbkhan joined the channel
      • 2017-03-25 08405, 2017

      • samj1912
        lazka: ping
      • 2017-03-25 08400, 2017

      • samj1912
        needed some help with porting picard to py3 and file formats
      • 2017-03-25 08413, 2017

      • samj1912
        getting some string/byte errors with mutagen
      • 2017-03-25 08400, 2017

      • lazka
        samj1912, what's the problem?
      • 2017-03-25 08416, 2017

      • samj1912
        1 sec
      • 2017-03-25 08406, 2017

      • samj1912
      • 2017-03-25 08411, 2017

      • samj1912
        lazka: ^
      • 2017-03-25 08432, 2017

      • samj1912
        Got a working ui build
      • 2017-03-25 08452, 2017

      • samj1912
        The only tests that are failing are the encoding and format ones
      • 2017-03-25 08437, 2017

      • lazka
        imo the errors are mostly self explanatory
      • 2017-03-25 08408, 2017

      • lazka
        mutagen is less strict on py2 regarding bytes/unicode
      • 2017-03-25 08448, 2017

      • samj1912
        so all the tag names should be bytes?
      • 2017-03-25 08454, 2017

      • lazka
        the data arg of UFID has to be bytes
      • 2017-03-25 08414, 2017

      • lazka
        bytes is an alias for str on py2, for py3 you need to add a text alias yourself
      • 2017-03-25 08428, 2017

      • lazka
      • 2017-03-25 08444, 2017

      • lazka
        (QL currently runs under Py2 and Py3)
      • 2017-03-25 08457, 2017

      • samj1912
        thanks! :D
      • 2017-03-25 08401, 2017

      • samj1912
        helped :)
      • 2017-03-25 08407, 2017

      • ZarkBit has quit
      • 2017-03-25 08423, 2017

      • ZarkBit joined the channel
      • 2017-03-25 08445, 2017

      • lazka
        samj1912, one possibly confusing thing is that keys for MP4 are str on both py2/3
      • 2017-03-25 08421, 2017

      • lazka
        (bytes on py2, text on py3)
      • 2017-03-25 08424, 2017

      • samj1912
        umm, can you tell me which keys are supposed to be bytes and which ones str (acc. to py3)
      • 2017-03-25 08432, 2017

      • samj1912
        I am confused
      • 2017-03-25 08450, 2017

      • CatQuest has quit
      • 2017-03-25 08455, 2017

      • samj1912
        stuck on 19 failing tests now
      • 2017-03-25 08407, 2017

      • samj1912
        that UFID thing helped pass 5 tests :P
      • 2017-03-25 08409, 2017

      • lazka
        all should be str
      • 2017-03-25 08428, 2017

      • samj1912
        i.e. unicode of py2?
      • 2017-03-25 08447, 2017

      • lazka
        as far as I remember, yes
      • 2017-03-25 08430, 2017

      • samj1912
        okay so I need to convert the texttags in MP4 appropriately?
      • 2017-03-25 08442, 2017

      • samj1912
        they are currently encoded byte objects
      • 2017-03-25 08452, 2017

      • samj1912
      • 2017-03-25 08430, 2017

      • lazka
        looks fine to me
      • 2017-03-25 08451, 2017

      • lazka
        samj1912, btw, never use "from __future__ import unicode_literals"
      • 2017-03-25 08419, 2017

      • lazka
        some guides mention it, but it just makes things complicated
      • 2017-03-25 08440, 2017

      • samj1912
        I haven't
      • 2017-03-25 08443, 2017

      • lazka
        ok
      • 2017-03-25 08411, 2017

      • samj1912
        umm, image data is expected to be string?
      • 2017-03-25 08412, 2017

      • CatQuest joined the channel
      • 2017-03-25 08429, 2017

      • lazka
        should be bytes I guess
      • 2017-03-25 08404, 2017

      • lazka
        not sure what the cause is, the stack trace isn't helpful
      • 2017-03-25 08405, 2017

      • arbenina_ joined the channel
      • 2017-03-25 08416, 2017

      • lazka
        g2g
      • 2017-03-25 08418, 2017

      • lazka has quit
      • 2017-03-25 08428, 2017

      • chirlu joined the channel
      • 2017-03-25 08434, 2017

      • samj1912