This week I worked on making the alpha-importer and influx-writer a bit more intelligent in handling bad data. Also, did some rebases on old PRs, nothing much else
Kinda off topic but I also went to see a cricket match this weekend in what has to be one of the most beautiful cricket grounds in the world. Was a great day!
iliekcomputers: wow. And I even kinda understand cricket, so I wouldn't even be that out of place! If I ever make it to Asia I should check this kind of places
you can see the general idea outlined in sub-tasks and related issues
samj1912
okay :) (I got confused since the time changed :P)
Gentlecat
the only question is whether we want to have separate ratings on reviews
which is actually related to moving ratings
reosarevok
That's required to have multiple reviews with different ratings, right?
Freso
Neat. :)
reosarevok
If so, yes, IMO
bitmap thinks no
Freso is lagging a lot tonight, it seems :(
Gentlecat
if we decide to have ratings separately, then moving shouldn't be an issue later
arbenina_ joined the channel
Freso
ruaok: Can you take over leading the meeting? It's no good with a meeting leader that lags a minute behind everyone else.
Gentlecat
reosarevok: not necessarily multiple
ruaok
I'm half asleep.
but I can try.
CatQuest
lol
reosarevok
Gentlecat: just saying that we do need this if we want to have that possibility, right?
Gentlecat
but yes, to avoid conflicts
if someone has a review with a rating on CB and also a rating on MB for the same entity
psolanki
May be we can begin with release-groups, events and place and urge users from MB to CB for detailed ratings and reviews.
CatQuest
yea
reosarevok
bitmap: why no?
yvanzo
Reviews and ratings are clearly not the same level of critique analysis.
bitmap
I assume "separate ratings on reviews" = ratings on reviews + some other rating not associated with anything
I still lean toward the idea I presented in the ticket
CatQuest
I feel that we can avoid those conflicts if we move the ratings to CB proper, it makes sense and, if implementing that one with "admit review only with rating" it would work
Gentlecat
I think of it as a "review" being either a rating, some text, or both
CatQuest
i forget it's coe number
yes
reosarevok
bitmap: that was "every rating is a review, but only the latest can be empty?"
(text-empty)
bitmap
yeah, though I don't feel strongly about the last part
and whether someone sees any general issues with CB-244
reosarevok
Gentlecat: Well, if we decide to do 244 in bitmap's way, we're deciding that one by default I guess
I see no issue with doing 244 in either unrelated-to-"MB"-ratings way or related, we just need to decide
If you're happy with bitmap's idea, I think I'd be too
CatQuest
I do think that having ratings in two places is odd
so yea?
Gentlecat
it makes sense
ruaok
I'd like to take a closer look at this, but like I said a minute ago, I'm asleep.
reosarevok
Yeah, I guess bitmap's suggestion avoids the "there's two kinds of ratings"
Gentlecat
so is anyone against that?
ruaok
can I respond tomorrow?
reosarevok
I'd say go for it? I'd probably be able to give a better opinion on whether it feels natural once we have it on a sandbox to check
Or somewhere, anyway
CatQuest rereads the bitmap suggestion
But the general idea seems sensible
CatQuest
yea, i liek that
Gentlecat
ruaok: ok
reosarevok
So if ruaok likes it tomorrow, let's do that? :)
ruaok
lol, ok.
onward, next item: Picard feat. plugin (reo)
Gentlecat
can we say that it's ok to proceed with all that if there are no objections during this week
reosarevok
+1
CatQuest
+1
reosarevok
ruaok: No, next was samj1912's review, because he was late. Luckily, they're connected anyway! :)
Leftmost
+0.9...
yvanzo
+1.1
reosarevok
samj1912: go?
ruaok
lol.
samj1912
reosarevok: hehe yup :P
Hi everyone
yvanzo
Leftmost: do not unbalance the vote please ;)
ruaok
reosarevok: you should lead the meeting. you seem with it. :)
reosarevok
k
Leftmost
yvanzo, 0.9... = 1. :-P
CatQuest
+1
ruaok
_ø_
ZarkBit has quit
reosarevok
Gentlecat: seems like a +n
;)
FresosIRCCloudIs joined the channel
samj1912: go on :)
ZarkBit joined the channel
samj1912
so last week, I worked on reviewing picard PRs as usual, and volunteered for the feat. plugin for which I managed to write a pretty compact code than I expected
the latter half of the week, I worked on porting picard to py3 since the qt5 port is almost done
My IRCCloud is messing up, so I'll use the Freenode IRCterface.
reosarevok
Sophist: this was you too IIRC?
CatQuest
wait what about the jira thing?
FresosIRCCloudIs
Sophist mentioned on GitHub that they think picard-plugins issues should go to Jira instead of GH issues.
Quesito has quit
dna6a has quit
dna6a joined the channel
I think picard-plugins should still live GH issues, since picard-plugins are not supported by "MetaBrainz", but are meant to be much more like a "hotpot"(?) for Picard users to submit their things too.
