#metabrainz

/

      • github
        [picard-plugins] zas closed pull request #92: New paper CD case plugin (master...papercdcase) https://git.io/vSR8c
      • 2017-04-04 09443, 2017

      • github has left the channel
      • 2017-04-04 09415, 2017

      • LeRoberte
        Cool, I think there is some data i could use from MB for sure
      • 2017-04-04 09456, 2017

      • samj1912
        zas, we really should shift to decorators for plugin registration :p
      • 2017-04-04 09407, 2017

      • samj1912
        And other plugin enhancements
      • 2017-04-04 09413, 2017

      • zas
        samj1912: yup
      • 2017-04-04 09429, 2017

      • samj1912
        Hmm, I should write all the plugin stuff down somewhere
      • 2017-04-04 09433, 2017

      • madmouser1 has quit
      • 2017-04-04 09436, 2017

      • samj1912
        To keep track
      • 2017-04-04 09459, 2017

      • madmouser1 joined the channel
      • 2017-04-04 09415, 2017

      • madmouse_ joined the channel
      • 2017-04-04 09435, 2017

      • CatQuest
        more venue data? \o/
      • 2017-04-04 09446, 2017

      • madmouser1 has quit
      • 2017-04-04 09402, 2017

      • arbenina_ joined the channel
      • 2017-04-04 09436, 2017

      • UmkaDK has quit
      • 2017-04-04 09413, 2017

      • CatQuest
        sadface
      • 2017-04-04 09415, 2017

      • ruaok
      • 2017-04-04 09416, 2017

      • ruaok
        :)
      • 2017-04-04 09424, 2017

      • CatQuest
        two spam accouunts on oslo again
      • 2017-04-04 09402, 2017

      • ruaok
        iliekcomputers__: when you get back, lets chat about the JSON. :)
      • 2017-04-04 09442, 2017

      • ferbncode_ has quit
      • 2017-04-04 09406, 2017

      • Sophist-UK
        @sam1912: A JIRA ticket? (just kidding)
      • 2017-04-04 09417, 2017

      • iliekcomputers__
        ruaok: did I mess something up?
      • 2017-04-04 09435, 2017

      • ruaok
        > "work_mbids": ["fdjkaljfadkl"],
      • 2017-04-04 09435, 2017

      • Sophist-UK
        p.s. How would the plugin decorator look? Can you give an example?
      • 2017-04-04 09445, 2017

      • ruaok
        that is why the data is rejected. which is good.
      • 2017-04-04 09406, 2017

      • ruaok
        but why are slashes escaped in the URL?
      • 2017-04-04 09409, 2017

      • ruaok
        that is a problem.
      • 2017-04-04 09406, 2017

      • Sophist-UK
        samj1912: would you have time to review / merge PICARD-1034 https://github.com/metabrainz/picard/pull/667
      • 2017-04-04 09406, 2017

      • BrainzBot
        PICARD-1034: Picard not seeing TOPE and TOAL https://tickets.metabrainz.org/browse/PICARD-1034
      • 2017-04-04 09429, 2017

      • samj1912
        Sophist-UK lgtm
      • 2017-04-04 09445, 2017

      • samj1912
        I'll let zas merge it however
      • 2017-04-04 09413, 2017

      • samj1912
        We are introducing new tags and I'd like to know his opinion on the matter
      • 2017-04-04 09437, 2017

      • iliekcomputers__
        Is that json from the alpha importer logs? We don't really do anything to the data there. I don't know why it is escaped.
      • 2017-04-04 09438, 2017

      • Sophist-UK
        Ok.
      • 2017-04-04 09433, 2017

      • ruaok
        iliekcomputers__: yes. we need to track that down and figure out why that is happening.
      • 2017-04-04 09426, 2017

      • github joined the channel
      • 2017-04-04 09426, 2017

      • github
        [picard] samj1912 closed pull request #666: PICARD-1034: Add support for TOAL id3 frame (master...picard1034) https://git.io/vSsfB
      • 2017-04-04 09426, 2017

      • github has left the channel
      • 2017-04-04 09449, 2017

      • iliekcomputers__
        ruaok: okay. Will do tonight.
      • 2017-04-04 09419, 2017

      • saifulbkhan has quit
      • 2017-04-04 09430, 2017

      • ruaok
        iliekcomputers__: thx
      • 2017-04-04 09442, 2017

      • LeRoberte
        Hello everyone
      • 2017-04-04 09411, 2017

      • LeRoberte
        So I talked to ruaok about joining forces, I will provide all the venue data you need and keep it updated in your site regularly with the fields you need
      • 2017-04-04 09417, 2017

      • LeRoberte
        And I asked him if there was a way I could in exchange use some venues data for the venue map of my site
      • 2017-04-04 09411, 2017

      • ruaok nudges LeRoberte to finally ask a question
      • 2017-04-04 09442, 2017

      • ruaok goes offline for a while to hammer on the accounting for a bit
      • 2017-04-04 09442, 2017

      • LeRoberte
        ?
      • 2017-04-04 09413, 2017

      • SothoTalKer joined the channel
      • 2017-04-04 09455, 2017

      • outsidecontext
        samj1912, I had been updating the packaging recipes on launchpad.net in the past. but this is all a bit outdated now. not sure if somebody already touched this for the 1.4 release
      • 2017-04-04 09458, 2017

      • outsidecontext
        but at least it needs to be migrated to the new git repo there
      • 2017-04-04 09408, 2017

      • samj1912
        outsidecontext: I dont have much experience with packaging picard debs, I can continue maintaining it if you can give me a few pointers and access right to package :)
      • 2017-04-04 09410, 2017

      • outsidecontext
        I can set this up again so we have the packaging recipes running again. after that it is easy to update
      • 2017-04-04 09428, 2017

      • samj1912
        cool :D
      • 2017-04-04 09445, 2017

      • outsidecontext
        would be good if you become a member of https://launchpad.net/~musicbrainz-developers , AFAIK only luks can approve you there
      • 2017-04-04 09405, 2017

      • samj1912
        I applied for it :)
      • 2017-04-04 09414, 2017

      • samj1912
        waiting for approval
      • 2017-04-04 09437, 2017

      • outsidecontext
        I will have a few free evenings the next days, will setup the packaging then
      • 2017-04-04 09445, 2017

      • samj1912
        cool :D
      • 2017-04-04 09449, 2017

      • samj1912
        thanks a bunch! :D
      • 2017-04-04 09411, 2017

      • Sophist-UK
        sam1912: Now that we have qt5 merged I need to install it for python2 on windows - but apparently there is only a binary version available for Py3, and for Py2 you have to compile it yourself. So I need to find a MS C++ compiler and try to do this. My question is whether this is an issue for future maintenance versions of 1.4.x for anyone who runs Picard from source ? I presume we have done
      • 2017-04-04 09411, 2017

      • Sophist-UK
        the necessary compilations for Travis.
      • 2017-04-04 09458, 2017

      • samj1912
        Sophist-UK: travis compiles just fine for the current master
      • 2017-04-04 09416, 2017

      • samj1912
        that was one of the reasons we added docker
      • 2017-04-04 09438, 2017

      • samj1912
        yes, I know building qt5 for py2 might be a bit of a pain
      • 2017-04-04 09451, 2017

      • samj1912
        if you want to wait for a couple of weeks, I will have the py3 version up
      • 2017-04-04 09424, 2017

      • Sophist-UK
        I can wait - however we should decide whether the 1.4.x branch will run PyQt5 or not - because if it will then we will probably all need to do the compile in order to support it.
      • 2017-04-04 09448, 2017

      • UmkaDK joined the channel
      • 2017-04-04 09431, 2017

      • Sophist-UK
        And if we decide not to use Qt5 in 1.4.x then we need to do the Git magic to split it off prior to merge of #503 and start cherry picking.
      • 2017-04-04 09441, 2017

      • samj1912
        Sophist-UK: 1.4.X is going to be strictly qt4
      • 2017-04-04 09407, 2017

      • samj1912
        Sophist-UK: we already have dont that?
      • 2017-04-04 09423, 2017

      • samj1912
      • 2017-04-04 09440, 2017

      • samj1912
        https://github.com/metabrainz/picard the master is already on qt5 and 2.0 dev
      • 2017-04-04 09417, 2017

      • samj1912
        I do not think people use qt5 with py2 :P
      • 2017-04-04 09423, 2017

      • samj1912
        its a very very rare combo :P
      • 2017-04-04 09439, 2017

      • samj1912
        thus the lack of binaries and support :P
      • 2017-04-04 09404, 2017

      • Sophist-UK
        Yes - just looked. Are there any PRs which need merging into 1.4.x? #671?
      • 2017-04-04 09447, 2017

      • Sophist-UK
        I'll concentrate on installing Py3 then :-)
      • 2017-04-04 09457, 2017

      • samj1912
        671?
      • 2017-04-04 09422, 2017

      • samj1912
        nope, that was because of merge conflicts on the master
      • 2017-04-04 09437, 2017

      • github joined the channel
      • 2017-04-04 09437, 2017

      • github
        [picard] zas closed pull request #667: PICARD-1034: Add support for loading and saving TOAL & TOPE id3 frames (master...PICARD-1034_Add-partial-TOPE-support) https://git.io/vSZ4M
      • 2017-04-04 09437, 2017

      • github has left the channel
      • 2017-04-04 09456, 2017

      • samj1912
        zas: we should back port these changes in 1.4.X as well?
      • 2017-04-04 09425, 2017

      • zas
        Yes, i think so, in case we release 1.4.2 before 2.0 ;)
      • 2017-04-04 09408, 2017

      • samj1912
        we should mark the PRs for 1.4.X in some way in case we are not merging em immediately :P
      • 2017-04-04 09427, 2017

      • travis-ci joined the channel
      • 2017-04-04 09428, 2017

      • travis-ci
        metabrainz/picard#2266 (master - 0ca726f : Laurent Monin): The build passed.
      • 2017-04-04 09428, 2017

      • travis-ci
      • 2017-04-04 09428, 2017

      • travis-ci
      • 2017-04-04 09428, 2017

      • travis-ci has left the channel
      • 2017-04-04 09450, 2017

      • zas
        samj1912: are you planning to come to the summit at end of september ?
      • 2017-04-04 09459, 2017

      • samj1912
        I would like to :D
      • 2017-04-04 09440, 2017

      • zas
        it would be great to have you among us
      • 2017-04-04 09429, 2017

      • samj1912
        it would be an amazing experience for me too :D
      • 2017-04-04 09404, 2017

      • zas
        You can add you to https://wiki.musicbrainz.org/MusicBrainz_Summit/17 at any moment (before the summit...)
      • 2017-04-04 09443, 2017

      • amanmehta has quit
      • 2017-04-04 09421, 2017

      • samj1912
        added :D
      • 2017-04-04 09415, 2017

      • samj1912
        hopefully ruaok can help me with the planning :P
      • 2017-04-04 09404, 2017

      • deepti has quit
      • 2017-04-04 09437, 2017

      • D4RK-PH0ENiX has quit
      • 2017-04-04 09458, 2017

      • Sophist-UK
        sam1912 / zas: what is the process for e.g. applying #667 to 1.4.x? Are authors expected to resubmit against the 1.4.x branch, will one of you cherry pick?
      • 2017-04-04 09449, 2017

      • Sophist-UK
        samj1912 / zas: Can I draw your attention to PICARD-1049 to see what you guys think?
      • 2017-04-04 09449, 2017

      • BrainzBot
        PICARD-1049: Picard should use TXXX:WORK rather than TXXX:Work https://tickets.metabrainz.org/browse/PICARD-1049
      • 2017-04-04 09433, 2017

      • zas
        cherry-picking to 1.4.x branches, with care about py2/py3/qt4/qt5 stuff
      • 2017-04-04 09432, 2017

      • samj1912
        Sophist-UK: the arguments are valid, we will have to do something about migrating the existing Work tags to WORK though
      • 2017-04-04 09443, 2017

      • samj1912
        any idea what foobar2000 uses?
      • 2017-04-04 09421, 2017

      • justharshal joined the channel
      • 2017-04-04 09404, 2017

      • samj1912
        hmm, they dont have it
      • 2017-04-04 09435, 2017

      • zas
        It means Picard needs to be able to read TXXX:Work as well as TXXX:WORK
      • 2017-04-04 09409, 2017

      • zas
        And write to TXXX:WORK only
      • 2017-04-04 09442, 2017

      • samj1912
        we read all TXXX tags, we will have to decide whether to be case sensitive about them or not or treat work as a special case
      • 2017-04-04 09452, 2017

      • zas
        Yes, but what happens if we have 2 tags in the same file, TXXX:WORK and TXXX:Work...
      • 2017-04-04 09408, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-04-04 09452, 2017

      • D4RK-PH0ENiX has quit
      • 2017-04-04 09458, 2017

      • D4RK-PH0ENiX joined the channel
      • 2017-04-04 09450, 2017

      • ruaok
        help with travel planning
      • 2017-04-04 09408, 2017

      • ruaok
        I'm starting to think we will need a consenting adult around here. question, you're a mom. You fit that bill, yes??
      • 2017-04-04 09434, 2017

      • ruaok
        question? Quesito...
      • 2017-04-04 09406, 2017

      • Quesito
        Si?
      • 2017-04-04 09425, 2017

      • Quesito
        I'm not an adult. ;)
      • 2017-04-04 09418, 2017

      • ruaok
        crap.
      • 2017-04-04 09426, 2017

      • ruaok
        maybe we should put an ad in the paper.
      • 2017-04-04 09448, 2017

      • Quesito
        For an adult? Possible hard to find locally....
      • 2017-04-04 09400, 2017

      • ruaok
        I've only ever seen adults with gantt charts.
      • 2017-04-04 09405, 2017

      • ruaok
        how do you explain that??
      • 2017-04-04 09438, 2017

      • Quesito
        Just pretending!!! ;)
      • 2017-04-04 09451, 2017

      • ruaok
        fake it 'til you make it.
      • 2017-04-04 09456, 2017

      • ruaok
        that should be our motto.
      • 2017-04-04 09459, 2017

      • Quesito
        Right?
      • 2017-04-04 09402, 2017

      • Quesito
        Tots
      • 2017-04-04 09408, 2017

      • Sophist-UK
        I would suggest that on file load we see if TXXX:CaSe matches case-independently a freetext field CASE/Case/case and if so we:
      • 2017-04-04 09428, 2017

      • Sophist-UK
        a. Rename the tax in the file to the correct case; and
      • 2017-04-04 09431, 2017

      • Sophist-UK
        b. Load it into the known tag
      • 2017-04-04 09437, 2017

      • samj1912
        hmmm
      • 2017-04-04 09450, 2017

      • Sophist-UK
        So it gets fixed even if user doesn't have "Clear existing tags" checked.
      • 2017-04-04 09459, 2017

      • samj1912
        still the above logic applies
      • 2017-04-04 09412, 2017

      • samj1912
        how to handle the case with TXXX:Work and TXXX:WORK
      • 2017-04-04 09417, 2017

      • samj1912
        when both are present
      • 2017-04-04 09428, 2017

      • Sophist-UK
        Only issue is that unless there are other changes, the need to save the file will not be highlighted in the UI.
      • 2017-04-04 09440, 2017

      • Sophist-UK
        If both are present, then:
      • 2017-04-04 09444, 2017

      • samj1912
        we can append?
      • 2017-04-04 09453, 2017

      • Sophist-UK
        1. If the values are the same, we can discard one.
      • 2017-04-04 09453, 2017

      • samj1912
        if they are not same
      • 2017-04-04 09408, 2017

      • Sophist-UK
        2. If the values are different then we append as you suggest.
      • 2017-04-04 09418, 2017

      • samj1912
        you willing to work on that?
      • 2017-04-04 09424, 2017

      • Sophist-UK
        Yes. I'll take it.
      • 2017-04-04 09429, 2017

      • samj1912
        cool :)
      • 2017-04-04 09405, 2017

      • samj1912
        Sophist-UK: while you are at it, are you willing to take a look at all the id3 spec tags we dont support and add a PR to read and write into those tags disregarding filling em up with MeB data
      • 2017-04-04 09434, 2017

      • Sophist-UK
        PICARD-1048?