#metabrainz

ruaok: gotcha

and thoughts on officially kept plugins?

Anyway, I'm happy to say "let's talk about it further with a more clear idea on the table" too, though

samj1912: I think that will become clear after the discussion from your doc

The feat. thing, the ASCII thing, there's probably a few more

i don't really know the differnce with "offically kept" and the ones we ave now..

the thing is that plugins are just modules, and it doesn't make much difference in pratice... that's an issue with current plugins (no sandbox)

what we have now is made by comunity members anyway

okay, will make a doc and we can continue this in the future

anyone has anything to add?

CatQuest: officially maintained means that we ensure they work when we do a release.

hmm

let's move on for now, please.

well if they are "core" needed things, ie samj1912's idea, we'd *have* to do that

UKL?

Actually, plugins are in many way an alternative to options. Because users select the plugins the want isntead of setting an option if it was built in.

hmm..

i agree with soem things and inverive in others

like reo's idea

Anyway, yeah, go on with the tags bit I guess :)

Comprehensive Tags is about analysing what each format can support and making sure we can load and save those tags, and ditto for making sure that we have tags to hold the data that is on MB.

but other plugin are like "i wish it was main part of picard"

Sophist-UK: I have no problem with that

the same tags for every type of file type?

mb-tags?

The thing I wanted to discuss was howto make this happen in a sequence of small frequent PRs.

CatQuest: we currently dont cover all the tags that a file format supports

aaha

I tried it once before as a mega PR and quite rightly people didn't like the size of it.

(we mostly don't support obscure rare ones, AFAICT, but some people use them)

I am not against more tag support, but in case it requires more option pages, I think they are better as plugins

So this time I would like to do it in smaller pieces. First define a more comprehensive list of tags, then add file loading and saving / population from MB data tag by tag.

Not thinking of any new options.

Sophist-UK: I also would not like to see our dependencies rise for some obscure formats

Not thinking of any new formats either.

(and named)

I'd say "add all the tags as stuff that can be kept unchanged" first maybe, and then worry abotu the others later?

*about

Just extending existing formats.

But I guess that's basically what Sophist-UK suggested

+1 from me then

er. about the other stuff, like actually saving MB data to them or not

Sophist-UK: you will be targetting 2.0 with that then?

Yes.

Too much to try to target 1.4.x and 2.0

The only thing that has come up from Paul Taylor (Jaikoz/Song Kong) is to save work in ID3 as TXXX:WORK (which is industry standard) instead of TXXX:Work (which is MB historical).

better target 2.x with new features from now on

almost out of time.

probably only bugfixes for 1.4.x from now on

did you get enough feedback Sophist-UK?

+1 CatQuest

I don't think we really adressed the "how to do this in small increments" did we?

The only thing I would ask (in order to try to get the multitude of small PRs merged is that people review them reasonably quickly.

smaller PRs are reviewed much more easliy than large ones.

it might also be good to specifcally remind people about reviewing them from time to time.

I think picard development right now involves a lot of quick reviewing anyway?

hmm we're going over the time now D:

reosarevok: yes :P

First PR would be to add a more comprehensive list of tags to /constants/tags.py. I expect there to be some discussion about the additional tags which we should get out of the way first.

Ok - enough from me.

woo, almost on time.

:)

!m ruaok

You're doing good work, ruaok!

thanks Sophist-UK, thanks everyone!

Sounds like a good start, I guess do that one and talk about the next steps later ;)

ok.

/bang !

Other small stuff to do first. And the iTunes Moement stuff needs to be merged before the first PR.

I would actually prefer to leave a bit more time for reviewing picard pull requests - in the last few weeks, there usually have been only 2-4 hours between the last commit to a pull request and it being merged

Mineo: +1

[musicbrainz-server] reosarevok closed pull request #458: MBS-9248: Don't show artist name in hover if same as sort name (master...mbs-9248) https://git.io/vDV9A

But some PRs languish for days or even weeks.

CatQuest: I cleared the db on beta.listenbrainz again. care to do another import from last.fm?

.. alright :)

After all, we did set 48 h review time in MB itself for stuff so people could see the changes and react :)

thx

ruaok: now on page 12

21

it's fast, but many pages

whoo already 50

48h sounds OK to me.

it doesn't need to be 48 hours, but the python 3 pull request was like 1 hour between the last commit and the merge

(again, I really don't want to blame anyone, but we're not trying to build some MVP nonsense to be the first ones on the market or something like that :-) )

Sophist-UK: more py3 bugs on your latest PR

http://portingguide.readthedocs.io/en/latest/sy... might help while porting PRs

Freso, getting this when trying to install picard-plugins-v2-git cp: cannot stat '/opt/aur/picard-plugins-v2-git/src/picard-plugins/plugins/*.zip': No such file or directory

zas, sam1912: Picard 1.4.1 is not getting list of plugins from server.

huh?

Sorry - might not be a good explanation of symptoms. Investigating.

Its working again now. Some sort of glitch.

[picard-plugins] Sophist-UK opened pull request #95: Smart Title Case plugin (master...patch-4) https://git.io/vSiiG

zas: I have no idea what the cause was. I didn't see my internet connection drop. It was working fine on installed 1.4.1, then not, then it worked again. Just one of those things I guess.

[picard] zas closed pull request #697: PICARD-1064: Fix verbose tests (master...picard1064) https://git.io/vSiOH

[picard] zas opened pull request #700: Fix astrcmp tests when C version of astrcmp() isn't available (master...fix_astrcmp_test) https://git.io/vSi7X

[picard] zas closed pull request #700: Fix astrcmp tests when C version of astrcmp() isn't available (master...fix_astrcmp_test) https://git.io/vSi7X

[picard] zas closed pull request #696: PICARD-1063: Fix astrcmp tests if not compiled (master...PICARD-1063_Fix-astrcmp-tests-if-not-compiled) https://git.io/vS6sW

[picard] zas closed pull request #698: PICARD-1066: Fix update_constants (master...picard1066) https://git.io/vSiZB

[picard] zas closed pull request #699: PICARD-1065: Fix patch_version (master...picard1065) https://git.io/vSinF

ruaok: seems stuck on 11354 of 22749 pages :/

sorry, I'm messing with the server. :(

trying to torture it more...

dude don't do that when I'm doing this :/

(or, wanr me that you're going to)

warn*

do you want me to continue(restart) this or can I just turn it of

?

odd. the server was idle when I started.

hmm :/

I think it may have crashed somehow.

I'll soon be done being rude to the server.

double :/

it'll have to wait until tomorrow then, as I'm going to bed/showering in a few mins

and I should be alive to chekc up on it incase it stalls again and so you can cgeck why/if