Because it allows easily adding new "genre tags" to the list and immediately have them working
The main benefit of using a closed, not-tags-only list IMO is linkability and mbids and rels
yvanzo
reosarevok, bitmap: Most inconvenient shortcoming is the editing system: attributes do not have gids.
reosarevok
And attributes don't offer that, so
yvanzo: they should :) But that's Q4 I guess?
yvanzo
yes
reosarevok
Anyway, definitely in favour of adding IDs in more places
yvanzo
although it might be possible to create temporary join tables for that
reosarevok
CallerNo6: in general, I'd say either make them full entities that can be linked to, say, their Wikipedia page, or leave them as tags
Any in-between solutions sound like a lot of work for little practical gain
bitmap
gids for work attributes?
CatQuest joined the channel
reosarevok
Well, some permanent way of calling an attribute sounds reasonable, we have them for reltypes
bitmap
I know the types and values already have them
yvanzo
yes
or at least something comparable to aliases
bitmap is confused which table you want gids on
GIDs are not the only possible solution.
Freso
All of them!!
GIDs!! GIDs everywhere!!!
CallerNo6 doesn't know things. GIDs are internal only? (as opposed to MBIDs)
yvanzo
bitmap: The issue is more that concurrent edits of attributes can overwrite each other.
bitmap
hmm
yvanzo
CallerNo6: MBIDs are GIDs, the reverse is not true.
bitmap
can't use locking?
CatCat approves more entities
CatCat
but that DR about changing all credits :/
i want the feature to be able to edit all credits no matter what :O
yvanzo
Actually aliases don't have GIDs either and don't have this issue.
bitmap: What is probably lacking is specific edit types for editing attributes.
CatCat
aliases aren't like dyn.atrib. though...
reosarevok
yvanzo: can't all edits overwrite each other? Or you mean that they should conflict and fail?
In which case, shouldn't that be done by just storing the original value and comparing?
CatCat
they are user entered date.. not unlike tags in away, the ones what are "official anmes" could and maybe should) have gids..., but search hints.. not as much
yvanzo
reosarevok: Sorry, it is just that the last one wins.
reosarevok
(I see the attribute types have MBIDs)
Oh. I'd say maybe just do like with artist names and whatnot
If the data has changed, fail the edit
bitmap
I know either iswcs/isrcs or ipis/isnis use some 3-way-merge
CatCat agrees
reosarevok
Which I assume we do by just storing the original value in the edit and comparing on application
CatCat
anyway, the ticket was more about letting someone batch alter artist credits in the rel-editor :/
(which would be a huge boon)
reosarevok
Which of the tickets? :)
CatCat
the last DR?
wasnt that about the "change all " instances of artist credit
reosarevok
If you mean the 6666 one then I *quite* strongly disagree with that as an option
CatCat
in the rel ed
yvanzo
Ultimately, ISWC/ISRC/… will be attributes, right?
bitmap
probably
reosarevok
That'd just lead to even more people changing stuff wrongly because for some reason people like checking checkboxes even when it makes no sense if they're there :D
No, that was about edit artist credits when editing the artist name :)
anthony25 has quit
CatCat
that you can vbatch alter crreditas? heavens why? if for example I want to changella instances of This guy making trumpet whne i know for a fact that is hould be trombone (or subultimate credits, hoi) then Y noT??
reosarevok
No, batch-changing credits for relationships would be awesome, but it's unrelated to that, that's on edit artist pages
bitmap
anyway, it was IPIs and ISNIs that use MusicBrainz::Server::Edit::Role::ValueSet
CatCat
reosarevok: edit artist creds when editing artists?
bitmap
which merges the values using the current, old, and new values
CatCat
uh. i thought that was already unchecked by default because that's a better idea?
samj1912 joined the channel
yvanzo
There are specific edit types for adding/removing ISWC/ISRC too, so it won't be a nuisance to replace it with edit types for attributes.
bitmap
but I'm probably misunderstanding the issue, that might not apply
reosarevok
CatCat: it's unchecked by default. But it only does anything when you actually change the artist name
CatCat
uh.. of course? that's the actual only thing artist credits do :D
reosarevok
CatCat: so, if you just check a box without changing the artist name, you might think it'll do something, but it doesn't. That's why we want to hide it instead :)
CatCat
changing the name :D
bitmap
in general I'd like there to be less edit types, though they are useful for searching at present...
since you can't search for edits that change a certain field