I don't understand interators quite enough to know whether "return dict.items" is correct or whether it needs to yield.
2017-04-26 11640, 2017
Sophist-UK
So I have no idea whether it is right or wrong.
2017-04-26 11640, 2017
samj1912
its correct
2017-04-26 11659, 2017
samj1912
I thought I had done a yield dict.items(self)
2017-04-26 11603, 2017
samj1912
that wouldve been wrong
2017-04-26 11616, 2017
Sophist-UK
Ok. :-)
2017-04-26 11637, 2017
Sophist-UK
If you have time to review P & PP PRs that would be useful.
2017-04-26 11643, 2017
Sophist-UK
Thanks.
2017-04-26 11651, 2017
samj1912
Sophist-UK: end sem times :P
2017-04-26 11655, 2017
samj1912
barely here on irc :P
2017-04-26 11618, 2017
Sophist-UK
Ah - that's fine - end sem is much much more important.
2017-04-26 11630, 2017
Sophist-UK
.whois samj1912
2017-04-26 11654, 2017
samj1912
Sophist-UK: you might wanna shift on irccloud :P
2017-04-26 11616, 2017
samj1912
its got better shortcuts for stuff like that and more
2017-04-26 11618, 2017
Sophist-UK
I use mirc.
2017-04-26 11644, 2017
samj1912
ah :P
2017-04-26 11600, 2017
samj1912
too use to the irc cloud experience to shift back to any other irc client now :P
2017-04-26 11613, 2017
samj1912
its a much more integrated and modern experience :P
2017-04-26 11632, 2017
Sophist-UK
Ah - I am old fashioned. I like the scriptability of mIRC.
2017-04-26 11624, 2017
iliekcomputers__ has quit
2017-04-26 11639, 2017
hugo_ joined the channel
2017-04-26 11602, 2017
hugo_
im using the vm, do i need to reindex all regularly or get new junks also indexed directly?
2017-04-26 11615, 2017
Sophist-UK
samj1912: I think I understand now - dict.items is a view not an iterator. Do you think metadata.items should be made into a view in order to remain compatible with dict.items?
2017-04-26 11636, 2017
samj1912
Sophist-UK: do you think it matters?
2017-04-26 11651, 2017
samj1912
we wont be changing the dictionary anyways while iterating
2017-04-26 11658, 2017
regagain joined the channel
2017-04-26 11601, 2017
Sophist-UK
Probably not - for exactly that reason.
2017-04-26 11616, 2017
Sophist-UK
OK - back to test_metadata
2017-04-26 11621, 2017
samj1912
and also the fact that it throws a runtime error
2017-04-26 11619, 2017
ruaok
reosarevok: I'm on it.
2017-04-26 11653, 2017
reosarevok
The "legal department"? k
2017-04-26 11608, 2017
reosarevok sighs at "owner of that information". Good try defending that legally, dude-who-has-the-info-publicly-at- https://tributealbum64.bandcamp.com/track/goldeneyes-goldeneye-007
2017-04-26 11646, 2017
reosarevok
(but don't mention that to him yet, would be a shame for the music to get taken down because of this)
2017-04-26 11635, 2017
ruaok
the legal departments has responded. :)
2017-04-26 11602, 2017
ruaok
and he's backpedaled already.
2017-04-26 11652, 2017
ruaok
do you want to pick it back up, reosarevok ?
2017-04-26 11647, 2017
reosarevok
Not really, I don't feel I have anything else to say than "no, we're not removing this data"
2017-04-26 11641, 2017
reosarevok
I mean, I could say "if someone minds the fact you made some music once, they're not the right fucking customer", but I don't think that'd help...
2017-04-26 11614, 2017
ruaok
that is about all I would say.
2017-04-26 11641, 2017
ruaok
I'll respond tomorrow.
2017-04-26 11600, 2017
reosarevok
I mean, ffs, it's not like they'll even know it's the same guy
