Yes - I didn't spot that gh:P#623 had been reverted by gh:P#626, so repeated it as a new PR for v2 - I want to find out why it was reverted so I can fix it properly. But so far I can't find out why.
IMO #623 was the right approach, but presumably there were some cases for which it stopped working.
2017-04-28 11854, 2017
samj1912
Sophist-UK: presumably because of Add a inmulti2 function which works as inmulti but gets a variable name
2017-04-28 11854, 2017
samj1912
as first parameter, instead of the contents of the variable
2017-04-28 11802, 2017
alastairp has quit
2017-04-28 11821, 2017
alastairp joined the channel
2017-04-28 11843, 2017
arbenina_ joined the channel
2017-04-28 11850, 2017
agentsim joined the channel
2017-04-28 11820, 2017
Mineo joined the channel
2017-04-28 11802, 2017
Sophist-UK
sam1912: I was against introducing a $inmulti2 function when the $inmulti could and should be made to work correctly. gh:P#623 seemed to be a good piece of code - with one exception which is easily fixed. But it was reverted and before making another attempt I need to understand why it was reverted.
samj1912: I raised PICARD-922 for this issue, so I suppose I can claim to understand what the issue is. Essentially $in should match a substring within a string and $inmulti should match a string to an entire value in a multi-value variable. If you want to search for a string somewhere in a multi-value variable then generally speaking $in will do it for you (the corner case being if you
2017-04-28 11807, 2017
Sophist-UK
the search string has "; " in it - in which case it could match the end of one value and the beginning of the next instead of only matching within one of the values).
I guess we could create a new function $matchmulti which matches complete strings and make $inmulti search for a substring entirely within a single value of a multi-value variable.
I am so confused--(mostly because I lack knowledge on Picard)--but I'd like to know what causes this
2017-04-28 11811, 2017
Quesito
and the audio deck is 'becker' brand?
2017-04-28 11859, 2017
Quesito
Would that make a difference?
2017-04-28 11823, 2017
Sophist-UK
Quesito - the pictures on Twitter have the words Traffic Pro on them. From the Becker site product page http://www.mybecker.com/enUK/main-navigation/auto… it looks like a Becker Cascade or Cascade Pro except they say Cascade not Traffic Pro and there is no Traffic Pro product on this page.
2017-04-28 11858, 2017
Sophist-UK
Ah - there are two Traffic Pros on their product archive page
2017-04-28 11822, 2017
Sophist-UK
The product manuals only say that they supports ID3v1 and v2 - no further detail.
2017-04-28 11858, 2017
Quesito
hmmm Sophist-UK do you think that the brand's programming is causing this issue?
2017-04-28 11820, 2017
Quesito
I guess it'd also be interesting to know how 'we' work in most car audio systems....
2017-04-28 11847, 2017
Sophist-UK
I cannot believe that if this space was in every mp3 track Picard had tagged that it would not have been spotted before.
2017-04-28 11820, 2017
Sophist-UK
I believe it is something specific in the Becker player combined with some difference in the tagged files (all of which couold still be within the ID3 spec).
well if we can get to the bottom of it, I would be interested in finding out....might be something we could do a follow up with Becker, if it is indeed something on that side of things.
2017-04-28 11817, 2017
kepstin
when writing ID3v2.3 tags, UTF-16 is recommended (and is the only unicode encoding supported); with ID3v2.4, UTF-16 and UTF-8 are both supported, but UTF-8 is less compatible
if ID3v2 is listed with no other details, then I'd expect it to be either 2.3 only or maybe both 2.3 and 2.4 :/
2017-04-28 11847, 2017
Sophist-UK
Regardless of what the technical issue is, the Musicbrainz response to his tweet is excellent.
2017-04-28 11853, 2017
Freso
kepstin: Just because it's officially part of the spec, it doesn't mean that implementors actually implement it.
2017-04-28 11845, 2017
kepstin
I have a lot of japanese music, and I've tried with a variety of players - support for UTF-16 in ID3v2.3 is usually rather good, and the limitation is most often missing fonts
2017-04-28 11857, 2017
Freso
kepstin: How many car audio systems have you tried?
2017-04-28 11803, 2017
kepstin
but yeah, 8-bit encoding is worth a try if it's not seeing UTF-16
2017-04-28 11849, 2017
kepstin
Freso: not that many, but a few from different brands. Usually the japanese characters are missing and latin characters show up, which means the encoding was understood, but it can't render the japanese characters :/
2017-04-28 11815, 2017
Freso
Right. Maybe he just needs to switch to UTF-16 then.
2017-04-28 11849, 2017
kepstin
switching to ID3v2.3 (which will disable UTF-8, since it's not supported) will probably fix the issue
2017-04-28 11845, 2017
kepstin
switching from UTF-8, which has somewhat poor support, to UTF-16 might also fix the issue, particularly if they've seen other ID3v2.4 tags work
2017-04-28 11855, 2017
Sophist-UK
Except he is explicitly testing ID3v24.
2017-04-28 11835, 2017
Freso
kepstin: Are you on Twitter? Feel like joining the conversation? :)
2017-04-28 11859, 2017
kepstin
I guess so.
2017-04-28 11807, 2017
Sophist-UK
Summary of Picard recommended options - disable id3v1, try different encodings, try id3v23 with various encodings.
2017-04-28 11803, 2017
Sophist-UK
I would also point out that he is manually entering tags for these tests - which should work fine in Picard, but it is possible he typed a leading space.
2017-04-28 11840, 2017
Freso
Sophist-UK: Which is why I asked for the test files and/or procedure.
2017-04-28 11831, 2017
Sophist-UK
Exactly!!
2017-04-28 11808, 2017
Mineo has quit
2017-04-28 11824, 2017
Quesito
Sophist-UK: 'Regardless of what the technical issue is, the Musicbrainz response to his tweet is excellent.' I couldn't agree more!!!! Good work Freso & reosarevok!
2017-04-28 11848, 2017
Freso
And kepstin :)
2017-04-28 11856, 2017
iliekcomputers__
ruaok: your skepticism about the escaping was justified, I wrote a test and it failed :)
2017-04-28 11806, 2017
Sophist-UK
!m Freso, reosarevok & kepstin
2017-04-28 11806, 2017
BrainzBot
You're doing good work, Freso, reosarevok & kepstin!
2017-04-28 11827, 2017
iliekcomputers__
ruaok: the measurement name in the dict we send is escaped but when I do "show measurements" in influx it isn't escaped
2017-04-28 11822, 2017
iliekcomputers__
ruaok: I don't know if it is a bug in our code or in influx yet (most probably ours) but I'll see if what's causing it
2017-04-28 11827, 2017
D4RK-PH0ENiX joined the channel
2017-04-28 11818, 2017
ruaok
Heh. :-)
2017-04-28 11835, 2017
D4RK-PH0ENiX has quit
2017-04-28 11839, 2017
d4rkie has quit
2017-04-28 11809, 2017
drsaunders joined the channel
2017-04-28 11819, 2017
khan has quit
2017-04-28 11807, 2017
D4RK-PH0ENiX joined the channel
2017-04-28 11835, 2017
D4RK-PH0ENiX has quit
2017-04-28 11844, 2017
D4RK-PH0ENiX joined the channel
2017-04-28 11807, 2017
outsidecontext has quit
2017-04-28 11846, 2017
lazka joined the channel
2017-04-28 11851, 2017
ZaphodBeeblebrox
Quesito: I just had a brainztorm!
2017-04-28 11854, 2017
ZaphodBeeblebrox
how about we issue a "banner making contest"!?
2017-04-28 11854, 2017
ZaphodBeeblebrox
so like then get our community (who there are maybe even pro designer of, what do we know?)
2017-04-28 11854, 2017
ZaphodBeeblebrox
and give him or her like, idk, some chocolate as a price as well as recognition asa designer
2017-04-28 11800, 2017
ZaphodBeeblebrox
idk sounded lie kan idea
2017-04-28 11812, 2017
ZaphodBeeblebrox
(and they could use some of our banner ideas as consept ideas too)
2017-04-28 11820, 2017
ZaphodBeeblebrox
or not
2017-04-28 11810, 2017
drsaunders has quit
2017-04-28 11838, 2017
github joined the channel
2017-04-28 11838, 2017
github
[metabrainz.org] gentlecat opened pull request #278: Retrieve name of the Sentry environment from Consul (master...sentry-env) https://git.io/v9cfd
2017-04-28 11838, 2017
github has left the channel
2017-04-28 11841, 2017
ZaphodBeeblebrox
peopel love contests
2017-04-28 11853, 2017
ZaphodBeeblebrox
even the winning part isn't the greatest, it's the contest part srsly
2017-04-28 11810, 2017
ZaphodBeeblebrox
great motivator
2017-04-28 11832, 2017
ZaphodBeeblebrox
but yes, ask on the blog ,and the twitter accoutns themselves, facebook, etc
2017-04-28 11848, 2017
ZaphodBeeblebrox
for input about the banners and new banners ideas etc
oh also we could use that spooky catbrainz thing as a temp one for halloween :D
2017-04-28 11819, 2017
github joined the channel
2017-04-28 11819, 2017
github
[metabrainz.org] gentlecat opened pull request #279: [WIP] MEB-91: EUR support for other types of payments and additional improvements (paypal...paypal-rest) https://git.io/v9cUg
2017-04-28 11819, 2017
github has left the channel
2017-04-28 11802, 2017
Quesito
ZaphodBeeblebrox: do you think we get enough interest? currently we don't have that many votes...I love the idea of a contest to get everyone engaged--its a great idea! I'm only worried about low turnout....
2017-04-28 11814, 2017
Quesito
also--what spooky catbrainz?!?!?!
2017-04-28 11819, 2017
UmkaDK has quit
2017-04-28 11839, 2017
gcilou
Guess who's going to be in EU from June 4 - 13 ? 😏😏😏
2017-04-28 11820, 2017
UmkaDK joined the channel
2017-04-28 11839, 2017
ruaok
sweet, where>
2017-04-28 11840, 2017
ruaok
?
2017-04-28 11857, 2017
gcilou
Starting in Sweden, ending in Hungary, with like 7 days in-between so we're going to tour around a few other countries. Not sure exactly where yet
2017-04-28 11805, 2017
github joined the channel
2017-04-28 11805, 2017
github
[metabrainz.org] gentlecat closed pull request #278: Retrieve name of the Sentry environment from Consul (master...sentry-env) https://git.io/v9cfd
