#metabrainz

/

      • zas
        extra containers ? because of redundancy ?
      • 2017-05-29 14916, 2017

      • ruaok
      • 2017-05-29 14935, 2017

      • zas
        well i would say when it comes to maintainance stopping one container will not affect as much services if they are splitted
      • 2017-05-29 14901, 2017

      • ruaok
        iliekcomputers finished production side of things, but got stuck with the dev side of things.
      • 2017-05-29 14911, 2017

      • jesus2099 has quit
      • 2017-05-29 14916, 2017

      • zas
        ok, so it is a problem with that
      • 2017-05-29 14926, 2017

      • ruaok
        since it is unrealistic to have subdomains for dev work
      • 2017-05-29 14942, 2017

      • zas
        if you feel it is too complex on this side, i guess not much choice left ;)
      • 2017-05-29 14931, 2017

      • ruaok
        complexity now on our side is better than a production nightmare.
      • 2017-05-29 14910, 2017

      • zas
        well, it means we'll need to add more complex stuff on gateways, but ok
      • 2017-05-29 14922, 2017

      • ruaok
        doesn't MB already do this?
      • 2017-05-29 14932, 2017

      • ruaok
        since everything there runs on on domain, no?
      • 2017-05-29 14940, 2017

      • alastairp
        hmm, sorry to interrupt here
      • 2017-05-29 14947, 2017

      • alastairp
        perhaps we decided to not do different things
      • 2017-05-29 14948, 2017

      • zas
        yes it does, and it isn't very clean, according to current nginx config ;)
      • 2017-05-29 14906, 2017

      • ruaok
        I envisioned using mm.musicbrainz.org for this, but was never used and became a point of contention.
      • 2017-05-29 14909, 2017

      • alastairp
        was our decision to not have separate flask apps
      • 2017-05-29 14916, 2017

      • alastairp
        or to not have a separate domain for the api?
      • 2017-05-29 14941, 2017

      • ruaok
        I want neither, but not if it is going to sabotage production.
      • 2017-05-29 14946, 2017

      • alastairp
        right
      • 2017-05-29 14955, 2017

      • alastairp
        I agree we don't need separate flask apps
      • 2017-05-29 14922, 2017

      • alastairp
        I'm ambivalent about the domain, but I recall it caused this much discussion when we decided to do it in the first place
      • 2017-05-29 14936, 2017

      • alastairp
        I'm happy to rely on your past experience with it not working out
      • 2017-05-29 14945, 2017

      • ruaok
        lets turn this around: zas: ideally from your perspective what should we do?
      • 2017-05-29 14958, 2017

      • ruaok
        there is a decent change that LB will get a lot of traffic before long.
      • 2017-05-29 14945, 2017

      • zas
        according to mb ws vs website stuff, about stats/configuration/upgrades/general maintenance i think it is preferrable to split apps (because they are different by nature)
      • 2017-05-29 14908, 2017

      • ruaok
        please elaborate on "split".
      • 2017-05-29 14909, 2017

      • zas
        also it makes it easier to control access or move to api frontends like kong
      • 2017-05-29 14914, 2017

      • ruaok
        containers, flask apps, domains?
      • 2017-05-29 14939, 2017

      • zas
        i think a domain + its backends
      • 2017-05-29 14904, 2017

      • alastairp
        however it is technically possible to redirect a url -> different backends?
      • 2017-05-29 14929, 2017

      • ruaok
        zas: can you please be more explicit? specifically tell us how many domains, flask apps and containers you'd ideally like to see.
      • 2017-05-29 14926, 2017

      • zas
        one domain for website, one domain for api, website = as much containers needed in the backend, api = as much containers needed in the backend
      • 2017-05-29 14928, 2017

      • ruaok
        so you don't care if the containers in the backend are actually different between web and WS?
      • 2017-05-29 14931, 2017

      • zas
        basically what we have for mb, apart the subdomain (which is a mess if you ask me, requiring much more complex nginx config, for nothing), and requires common certs
      • 2017-05-29 14943, 2017

      • ruaok
        we could just use one image for both and create instances as needed.
      • 2017-05-29 14958, 2017

      • zas
        ruaok: you can point 2 domains to the same container, if the container is able to manage it
      • 2017-05-29 14920, 2017

      • ruaok
        its all one codebase and it would be more work to create separate images.
      • 2017-05-29 14921, 2017

      • zas
        or you may use the same image with a different config
      • 2017-05-29 14949, 2017

      • zas
        or you can use a common base image and 2 child images
      • 2017-05-29 14905, 2017

      • ruaok
        same image is easiest.
      • 2017-05-29 14923, 2017

      • ruaok
        ok, what I am understanding, and I think alastairp, is already there:
      • 2017-05-29 14923, 2017

      • zas
        same image -> multiple containers then ?
      • 2017-05-29 14930, 2017

      • alastairp
        yes, I think we would always be running with the same image, even if we had kept iliekcomputers' PR
      • 2017-05-29 14933, 2017

      • ruaok
        1. use api.lb.org and lb.org
      • 2017-05-29 14902, 2017

      • alastairp
        and we run multiple instances of that container, and point 2 domains to as many instances as are required for each domain (frontend or api)
      • 2017-05-29 14903, 2017

      • ruaok
        2. have 1 image for both, whether or not we have 1 or 2 instances is docker-server-config tweak
      • 2017-05-29 14925, 2017

      • ruaok
        3. If we need to grow, we can have more containers and easily split traffic based on domain.
      • 2017-05-29 14933, 2017

      • zas
        yup^^
      • 2017-05-29 14936, 2017

      • alastairp
        I am in agreement with 1. and 2. and 3. <- trying to be super explicit here
      • 2017-05-29 14904, 2017

      • ruaok
        ok, I see us not using more than 1 image at start, but that doesn't really matter.
      • 2017-05-29 14923, 2017

      • alastairp
        just to be super picky (and for now I don't care): it's technically possible for someone to submit listens to lb.org, or browse the website on api.lb.org
      • 2017-05-29 14929, 2017

      • alastairp
        unless we filter at the nginx level
      • 2017-05-29 14930, 2017

      • ruaok
        then we need to figure out how to deal with the sub-domain in the dev env.
      • 2017-05-29 14905, 2017

      • ruaok
        alastairp: we should disallow this and filter that case. otherwise when we make the switch internally some clients will break.
      • 2017-05-29 14913, 2017

      • alastairp
        ruaok: do we want:
      • 2017-05-29 14917, 2017

      • alastairp
      • 2017-05-29 14922, 2017

      • alastairp
      • 2017-05-29 14956, 2017

      • ruaok
      • 2017-05-29 14959, 2017

      • ruaok
        so, 1.
      • 2017-05-29 14903, 2017

      • alastairp
        ah, yeah
      • 2017-05-29 14912, 2017

      • ruaok
        whether that is still what we want, not sure.
      • 2017-05-29 14925, 2017

      • ruaok
        2 is easier to do in dev.
      • 2017-05-29 14928, 2017

      • alastairp
        I think in development it's quite possible to keep this
      • 2017-05-29 14931, 2017

      • ruaok
        there you don't filter requests.
      • 2017-05-29 14948, 2017

      • alastairp
        dev - you mean development on my laptop?
      • 2017-05-29 14952, 2017

      • ruaok
        yes
      • 2017-05-29 14957, 2017

      • alastairp
        honestly, I don't think there is any difference?
      • 2017-05-29 14909, 2017

      • alastairp
        (let me just look up code_
      • 2017-05-29 14908, 2017

      • alastairp
        right. the API is already mounted into /
      • 2017-05-29 14928, 2017

      • alastairp
      • 2017-05-29 14934, 2017

      • alastairp
      • 2017-05-29 14948, 2017

      • alastairp
        so localhost/1/submit-listens works as expected
      • 2017-05-29 14907, 2017

      • alastairp
        if you're thinking of some other problem, I'm not following you
      • 2017-05-29 14912, 2017

      • ruaok
        lets say that I am working on a client and I am using the LB dev setup.
      • 2017-05-29 14935, 2017

      • github joined the channel
      • 2017-05-29 14935, 2017

      • github
        [critiquebrainz] gentlecat closed pull request #104: CB-257: Fix filtering reviews based on entity type (master...filter-review) https://git.io/vHCfX
      • 2017-05-29 14935, 2017

      • github has left the channel
      • 2017-05-29 14935, 2017

      • ruaok
        my client makes calls to api.lb.org and perhaps sends users to lb.org
      • 2017-05-29 14956, 2017

      • ruaok is thinking out loud
      • 2017-05-29 14920, 2017

      • ruaok
        I guess it is just a matter of me managing /etc/hosts to handle this.
      • 2017-05-29 14925, 2017

      • agentsim joined the channel
      • 2017-05-29 14912, 2017

      • alastairp
        if (DEBUG) { api_host="localhost"; web_host="localhost"; } else { api_host="api.lb.org"; web_host="lb.org"; }
      • 2017-05-29 14932, 2017

      • ruaok
        so, if I understand it right, we have to do nothing, except filter deny requests to lb.org/1/
      • 2017-05-29 14954, 2017

      • alastairp
        right, but I would consider doing that in nginx instead of flask
      • 2017-05-29 14901, 2017

      • alastairp
        unless you have a compelling reason to do it in flask
      • 2017-05-29 14903, 2017

      • ruaok
        of course.
      • 2017-05-29 14908, 2017

      • ruaok
        no, not at all.
      • 2017-05-29 14921, 2017

      • alastairp
        do we have nginx in dev, or does it go right to flask's runserver?
      • 2017-05-29 14921, 2017

      • ruaok
        in fact, I would not even put this into place in dev env, only in production.
      • 2017-05-29 14926, 2017

      • alastairp
        bingo
      • 2017-05-29 14926, 2017

      • ruaok
        flask.
      • 2017-05-29 14941, 2017

      • alastairp
        as I understand it, this is not a problem for dev
      • 2017-05-29 14902, 2017

      • ruaok
        iliekcomputers, zas: I'm clear on this now. are you? are there open questions?
      • 2017-05-29 14925, 2017

      • alastairp
        ruaok: last chance for adafruit
      • 2017-05-29 14937, 2017

      • alastairp
        I'm getting you 5 shields, 1 thermometer, 1 accelerometer
      • 2017-05-29 14943, 2017

      • ruaok
        which accel?
      • 2017-05-29 14954, 2017

      • alastairp
        MMA8451
      • 2017-05-29 14906, 2017

      • ruaok
        one more thing...
      • 2017-05-29 14947, 2017

      • ruaok
        grrr, out of stock.
      • 2017-05-29 14954, 2017

      • ruaok
      • 2017-05-29 14907, 2017

      • alastairp
        ah, cute
      • 2017-05-29 14939, 2017

      • ruaok
        I'll take one of these for good measure too.
      • 2017-05-29 14941, 2017

      • ruaok
        thx
      • 2017-05-29 14951, 2017

      • alastairp
        uh. un what?
      • 2017-05-29 14906, 2017

      • CatQuest has left the channel
      • 2017-05-29 14917, 2017

      • ruaok
      • 2017-05-29 14926, 2017

      • CatQuest joined the channel
      • 2017-05-29 14940, 2017

      • ruaok
        sorry, does it happen where sometimes ircloud goes to a new line when hitting enter?
      • 2017-05-29 14941, 2017

      • alastairp
        x1
      • 2017-05-29 14944, 2017

      • ruaok
        and not send?
      • 2017-05-29 14944, 2017

      • ruaok
        yes
      • 2017-05-29 14901, 2017

      • alastairp
        I've not seen irccloud do that
      • 2017-05-29 14947, 2017

      • alastairp looks up Quesito's name on MeB.org
      • 2017-05-29 14908, 2017

      • alastairp
        I wonder what UPS will say if I try to ship to "The Little Cheese"
      • 2017-05-29 14930, 2017

      • ruaok
        they'll just ship it to wisconsin. they'll know what to do.
      • 2017-05-29 14944, 2017

      • alastairp
        $9 for UPS ground, or $13 for UPS 3 day
      • 2017-05-29 14904, 2017

      • alastairp
        I guess UPS ground will get there in ~a week? Is that soon enough?
      • 2017-05-29 14925, 2017

      • ruaok
        hang on.
      • 2017-05-29 14943, 2017

      • ruaok
        55124 dest zip
      • 2017-05-29 14954, 2017

      • alastairp
        yes, I got that
      • 2017-05-29 14934, 2017

      • ruaok
        meh, ups site is web fail
      • 2017-05-29 14939, 2017

      • gcilou joined the channel
      • 2017-05-29 14956, 2017

      • alastairp
        UPS Ground is low cost ground delivery, and is insured and tracked. Delivery time is not guaranteed, but is almost always under 6 days.
      • 2017-05-29 14956, 2017

      • alastairp
        UPS 3-Day, 2-Day and Next-day are high-speed air delivery, and are insured and tracked.
      • 2017-05-29 14901, 2017

      • ruaok
        the site says 3 days with ground.
      • 2017-05-29 14923, 2017

      • alastairp
        it's 10:30am, so if I order now they 90% promise that it'll ship today
      • 2017-05-29 14924, 2017

      • ruaok
      • 2017-05-29 14933, 2017

      • ruaok
        adafruit is in NYC.
      • 2017-05-29 14903, 2017

      • alastairp
        OK, I'll go with Ground
      • 2017-05-29 14913, 2017

      • ruaok
        UPS in the states is quite reliable.
      • 2017-05-29 14958, 2017

      • alastairp
        oh, its a holiday today, right?
      • 2017-05-29 14905, 2017

      • ruaok
        yes.
      • 2017-05-29 14910, 2017

      • alastairp
        feh
      • 2017-05-29 14912, 2017

      • alastairp
        ohwell
      • 2017-05-29 14916, 2017

      • ruaok
        and not just a bank holiday. everyone is fecking off.
      • 2017-05-29 14954, 2017

      • alastairp
        ordered!
      • 2017-05-29 14959, 2017

      • alastairp
        just like christmas
      • 2017-05-29 14918, 2017

      • alastairp
        (it's the correct temperature for me for christmas too)
      • 2017-05-29 14924, 2017

      • ruaok
        I've got a radar sensor waiting for me at home. that should be fun.
      • 2017-05-29 14930, 2017

      • ruaok
        detects human movement.
      • 2017-05-29 14944, 2017

      • CatQuest
        what if a cat moves?
      • 2017-05-29 14954, 2017

      • ruaok
        detects that too.
      • 2017-05-29 14955, 2017

      • zas
        ruaok: that's ok for me
      • 2017-05-29 14908, 2017

      • zas
        (about lb stuff)
      • 2017-05-29 14922, 2017

      • iliekcomputers
        sounds okay to me too
      • 2017-05-29 14925, 2017

      • ruaok
        zas: ok, good. how do we go about filtering the lb.org/1/* requests to be denied?
      • 2017-05-29 14944, 2017

      • alastairp
        oh, that's cute. adafruit include tutorials for each of the things that you bought in the order at the bottom of the confirmation email
      • 2017-05-29 14947, 2017

      • ruaok
        (they should go to api.lb.org/1)
      • 2017-05-29 14958, 2017

      • iliekcomputers
        mostly because I don't have to do anything ;)