1:18 AM
Nyanko-sensei joined the channel
2017-07-16 19735, 2017
1:19 AM
D4RK-PH0ENiX has quit
2017-07-16 19730, 2017
1:31 AM
MajorLurker joined the channel
2017-07-16 19721, 2017
1:33 AM
Major_Lurker has quit
2017-07-16 19745, 2017
1:53 AM
Major_Lurker joined the channel
2017-07-16 19749, 2017
1:56 AM
MajorLurker has quit
2017-07-16 19725, 2017
2:09 AM
Nyanko-sensei has quit
2017-07-16 19754, 2017
2:09 AM
D4RK-PH0ENiX joined the channel
2017-07-16 19702, 2017
2:28 AM
Major_Lurker has quit
2017-07-16 19755, 2017
3:51 AM
drsaunders has quit
2017-07-16 19745, 2017
3:53 AM
MajorLurker joined the channel
2017-07-16 19732, 2017
3:59 AM
yurrriq has quit
2017-07-16 19758, 2017
3:59 AM
LordSputnik has quit
2017-07-16 19700, 2017
4:00 AM
discopatrick has quit
2017-07-16 19759, 2017
4:55 AM
drsaunders joined the channel
2017-07-16 19735, 2017
5:57 AM
Nyanko-sensei joined the channel
2017-07-16 19725, 2017
5:58 AM
D4RK-PH0ENiX has quit
2017-07-16 19735, 2017
6:04 AM
Nyanko-sensei has quit
2017-07-16 19745, 2017
6:15 AM
D4RK-PH0ENiX joined the channel
2017-07-16 19712, 2017
6:16 AM
D4RK-PH0ENiX has quit
2017-07-16 19719, 2017
6:16 AM
D4RK-PH0ENiX joined the channel
2017-07-16 19757, 2017
6:16 AM
drsaunders has quit
2017-07-16 19702, 2017
6:44 AM
samj1912 joined the channel
2017-07-16 19713, 2017
6:51 AM
zas
samj1912: ping
2017-07-16 19707, 2017
7:54 AM
samj1912
Pong
2017-07-16 19722, 2017
7:54 AM
samj1912
zas: Morning o/
2017-07-16 19720, 2017
7:55 AM
zas
bitmap: json ws is returning null values when entity is undefined, for example "end" : null, is this the result of a design choice ? In JSON APIs there are 2 approachs in this field, one is to always provide known keys and their value (including null meaning undefined), or just omit the key when the value is undefined. See
2017-07-16 19720, 2017
7:55 AM
zas
2017-07-16 19731, 2017
7:56 AM
samj1912
zas: the way its done currently is a Bitch weird
2017-07-16 19738, 2017
7:56 AM
samj1912
Some fields are absent
2017-07-16 19742, 2017
7:56 AM
samj1912
Some are null
2017-07-16 19701, 2017
7:57 AM
samj1912
*bit
2017-07-16 19703, 2017
7:57 AM
zas
interesting, it would mean it wasn't really "designed"
2017-07-16 19741, 2017
7:57 AM
zas
i tend to prefer the field omission, because it reduces the payload (=cost reduction, or more stuff done for the same price)
2017-07-16 19723, 2017
7:58 AM
zas
samj1912: i tested it widely this morning
2017-07-16 19741, 2017
7:58 AM
zas
apart issues you already reported it looks ok to me
2017-07-16 19720, 2017
8:01 AM
zas
i noticed 2 QT5 related issues: a SSL2 warning one can removed with QT_LOGGING_RULES=qt.network.ssl.warning=false, and one "QApplication: invalid style override passed, ignoring it." prolly because the qt5 from pypy doesn't include gtk3 style or whatever. Not much important.
2017-07-16 19725, 2017
8:04 AM
samj1912
Okay
2017-07-16 19757, 2017
8:04 AM
samj1912
I have to fix the rating submission
2017-07-16 19740, 2017
8:22 AM
drsaunders joined the channel
2017-07-16 19718, 2017
8:25 AM
zas
samj1912: can you give examples of cases where fields are absent (instead of null) ? I think whatever we choose, it has to be consistent
2017-07-16 19719, 2017
8:26 AM
samj1912
I will have to check
2017-07-16 19747, 2017
8:28 AM
drsaunders has quit
2017-07-16 19700, 2017
8:30 AM
samj1912
I think pregap and data tracks are some of them
2017-07-16 19757, 2017
8:30 AM
samj1912
Although I think everything that is the basic property of an entity is present
2017-07-16 19711, 2017
8:31 AM
samj1912
And they can be null
2017-07-16 19727, 2017
8:31 AM
samj1912
Anything which is a special case is absent
2017-07-16 19755, 2017
8:31 AM
samj1912
Eg - user-tags
2017-07-16 19719, 2017
8:32 AM
samj1912
These are the only ones I can think of
2017-07-16 19726, 2017
8:42 AM
lazka joined the channel
2017-07-16 19726, 2017
8:52 AM
Mineo
2017-07-16 19754, 2017
8:53 AM
Mineo
I don't even have access to the setting of picard on github and codacy
2017-07-16 19716, 2017
8:59 AM
zas
Mineo: same for me for the Details link, not sure if we have any control on this
2017-07-16 19750, 2017
9:02 AM
agentsim has quit
2017-07-16 19719, 2017
9:21 AM
UmkaDK joined the channel
2017-07-16 19717, 2017
9:32 AM
samj1912
Mineo: that is weird, it takes me to meb picard
2017-07-16 19704, 2017
9:33 AM
D4RK-PH0ENiX has quit
2017-07-16 19716, 2017
9:33 AM
samj1912
zas: Mineo I think you need to switch your codacy account to meb
2017-07-16 19725, 2017
9:33 AM
samj1912
its there on the top left corner
2017-07-16 19730, 2017
9:49 AM
D4RK-PH0ENiX joined the channel
2017-07-16 19721, 2017
10:03 AM
agentsim joined the channel
2017-07-16 19743, 2017
10:07 AM
agentsim has quit
2017-07-16 19707, 2017
10:08 AM
Nyanko-sensei joined the channel
2017-07-16 19703, 2017
10:09 AM
D4RK-PH0ENiX has quit
2017-07-16 19716, 2017
10:12 AM
Mineo
well, now it seems to have fixed itself magically
2017-07-16 19743, 2017
10:26 AM
drsaunders joined the channel
2017-07-16 19703, 2017
10:57 AM
drsaunders has quit
2017-07-16 19702, 2017
10:58 AM
D4RK-PH0ENiX joined the channel
2017-07-16 19756, 2017
10:58 AM
Nyanko-sensei has quit
2017-07-16 19742, 2017
11:04 AM
agentsim joined the channel
2017-07-16 19757, 2017
11:08 AM
agentsim has quit
2017-07-16 19709, 2017
11:10 AM
UmkaDK has quit
2017-07-16 19746, 2017
11:11 AM
UmkaDK joined the channel
2017-07-16 19721, 2017
11:14 AM
samj1912
2017-07-16 19726, 2017
11:14 AM
samj1912
have CAA on
2017-07-16 19757, 2017
11:15 AM
UmkaDK has quit
2017-07-16 19708, 2017
11:18 AM
MajorLurker
samj1912, gives me an error if that helps
2017-07-16 19738, 2017
11:18 AM
samj1912
hmm, there is something weird with that
2017-07-16 19710, 2017
11:19 AM
MajorLurker
Quite...
2017-07-16 19723, 2017
11:19 AM
samj1912
there release's CAA gives a 404
2017-07-16 19738, 2017
11:19 AM
samj1912
which causes an error in picard
2017-07-16 19710, 2017
11:20 AM
MajorLurker
hmmm yeah I can see the log is saying "Not found" right at end
2017-07-16 19751, 2017
11:27 AM
zas
yes, index.json is missing, i think something went wrong, and never got generated
2017-07-16 19751, 2017
11:27 AM
Mineo
that error is legitimate - the mb webservice claims that there's artwork in the caa, but the caa claims there isn't
2017-07-16 19716, 2017
11:28 AM
samj1912
hmm
2017-07-16 19734, 2017
11:28 AM
samj1912
Mineo: unable to generate those bugs
2017-07-16 19741, 2017
11:28 AM
Mineo
?
2017-07-16 19744, 2017
11:28 AM
samj1912
s/generate/reproduce
2017-07-16 19751, 2017
11:28 AM
samj1912
the ones that required additional error handling
2017-07-16 19702, 2017
11:29 AM
samj1912
but I remember picard crashing due to those errors
2017-07-16 19718, 2017
11:29 AM
samj1912
I loaded a bunch of releases at once (around 200)
2017-07-16 19723, 2017
11:29 AM
samj1912
dont remember which one caused it
2017-07-16 19757, 2017
11:30 AM
zas
bitmap: do we have an easy mean to force index.json regeneration ?
2017-07-16 19716, 2017
11:31 AM
Mineo
zas, you can change the image type or add a comment and remove it again
2017-07-16 19729, 2017
11:31 AM
Mineo
2017-07-16 19729, 2017
11:31 AM
BrainzBot
CAA-80: Image types not updated properly
2017-07-16 19717, 2017
11:32 AM
Mineo
samj1912, I have to admit I would prefer to not have safeguards against errors that we can neither reproduce nor even understand in the least
2017-07-16 19743, 2017
11:32 AM
samj1912
just that media one then?
2017-07-16 19746, 2017
11:32 AM
samj1912
anything else?
2017-07-16 19704, 2017
11:36 AM
agentsim joined the channel
2017-07-16 19706, 2017
11:37 AM
Mineo
I thought you couldn't reproduce any of the problems?
2017-07-16 19737, 2017
11:39 AM
samj1912
I can give the logic for them though
2017-07-16 19759, 2017
11:40 AM
samj1912
media error occurs on clusters
2017-07-16 19729, 2017
11:41 AM
samj1912
when one of the files has a totaltracks attribute but a compared releases does not have a media tag
2017-07-16 19730, 2017
11:47 AM
samj1912
I think its good practice to handle nulls passed as arguments ( for the compare_to_track error)
2017-07-16 19730, 2017
11:52 AM
Mineo
both calls to compare_to_track in the codebase look like there's something seriously wrong if they're calling compare_to_track with None as track
2017-07-16 19756, 2017
11:52 AM
samj1912
IIRC it was the searchdialog one that caused it
2017-07-16 19706, 2017
11:55 AM
samj1912
cant seem to reproduce it
2017-07-16 19744, 2017
11:55 AM
samj1912
We can just revert the changes if you want
2017-07-16 19702, 2017
11:56 AM
samj1912
these 2 are the only cause of concern?
2017-07-16 19725, 2017
12:06 PM
Mineo
yes
2017-07-16 19722, 2017
12:11 PM
Mineo
2017-07-16 19731, 2017
12:24 PM
samj1912
The import line?
2017-07-16 19738, 2017
13:01 PM
samj1912
Mineo: done
2017-07-16 19752, 2017
13:13 PM
lazka has quit
2017-07-16 19704, 2017
13:14 PM
UmkaDK joined the channel
2017-07-16 19736, 2017
13:18 PM
UmkaDK has quit
2017-07-16 19710, 2017
13:27 PM
D4RK-PH0ENiX has quit
2017-07-16 19752, 2017
13:37 PM
D4RK-PH0ENiX joined the channel
2017-07-16 19705, 2017
13:42 PM
D4RK-PH0ENiX has quit
2017-07-16 19735, 2017
13:44 PM
drsaunders joined the channel
2017-07-16 19746, 2017
13:49 PM
D4RK-PH0ENiX joined the channel
2017-07-16 19701, 2017
14:17 PM
UmkaDK joined the channel
2017-07-16 19735, 2017
14:21 PM
UmkaDK has quit
2017-07-16 19751, 2017
14:45 PM
drsaunders has quit
2017-07-16 19744, 2017
14:50 PM
drsaunders joined the channel
2017-07-16 19722, 2017
15:21 PM
drsaunders has quit
2017-07-16 19749, 2017
15:25 PM
drsaunders joined the channel
2017-07-16 19740, 2017
15:28 PM
zas
2017-07-16 19758, 2017
15:28 PM
zas
2017-07-16 19756, 2017
15:29 PM
agentsim has quit
2017-07-16 19759, 2017
15:29 PM
zas
Basically a number per customer (i think) followed by " Records DK"
2017-07-16 19742, 2017
15:34 PM
saifulbkhan joined the channel
2017-07-16 19728, 2017
15:40 PM
anshuman73 has quit
2017-07-16 19701, 2017
15:41 PM
UmkaDK joined the channel
2017-07-16 19747, 2017
15:59 PM
anshuman73 joined the channel
2017-07-16 19747, 2017
15:59 PM
anshuman73 has quit
2017-07-16 19747, 2017
15:59 PM
anshuman73 joined the channel
2017-07-16 19747, 2017
15:59 PM
anshuman73 has quit
2017-07-16 19747, 2017
15:59 PM
anshuman73 joined the channel
2017-07-16 19704, 2017
16:14 PM
MajorLurker has quit
2017-07-16 19717, 2017
16:23 PM
magerharz joined the channel
2017-07-16 19752, 2017
16:28 PM
magerharz has quit
2017-07-16 19728, 2017
16:34 PM
CatQuest
so they should be merged (when we have label credits) into a "distrokid" type label
2017-07-16 19730, 2017
16:34 PM
CatQuest
?
2017-07-16 19713, 2017
16:35 PM
CatQuest
or "Records DK" distrokid sometething
2017-07-16 19735, 2017
16:43 PM
drsaunders has quit
2017-07-16 19707, 2017
16:56 PM
drsaunders joined the channel
2017-07-16 19733, 2017
17:21 PM
deep-book-gk_ joined the channel
2017-07-16 19751, 2017
17:22 PM
deep-book-gk_ has quit
