great, thanks. that's probably our fault and we can fix it then
I'll let ruaok chime in when he's had more coffee
we can configure the rate limiting values, perhaps it's more strict on beta than non-beta
pprkut
I don't necessarily a problem with the 429 response itself, but how the status widget deals with them
*don't think it's
alastairp
iliekcomputers: perhaps if the error is 429 1) we shouldn't show "an error occurred", and 2) we should anticipate the rate limiting and slow down before we get the error
pprkut: ^ I was getting to that next :)
pprkut
:)
also, if there's still requests being made, the widget shouldn't really show "Import finished!" either
ruaok
Was that an alpha import? Or last.fm import?
pprkut
last.fm
ruaok
K
429 means the scraper is making requests of beta.lb too fast.
It shouldn't happen.
alastairp
ruaok: do you have different limits on beta?
(though yeah, the importer should back off, right?)
pprkut
according to chromium's console it was making roughly 40-50 requests / second
ruaok
let me look at the limits. either way the scraper should not have problems...
pprkut: ah yes, then there is a problem.
there is one fix that I haven't deployed. let me try and do that now.
this shouldn't be pageDone(), it should be submitListens(), pageDone increases the count of the number of pages done which is why the import message flashes, i think
*import finished message
pprkut
should I wait?
SothoTalker_ joined the channel
SothoTalKer has quit
ruaok
pprkut: yeah, what iliekcomputers is interesting.
alastairp
11:39 AM <pprkut> also, if there's still requests being made, the widget shouldn't really show "Import finished!" either
iliekcomputers: I'll open a ticket for that... ?
or have you already fixed it?
ruaok
iliekcomputers may be onto the fix.
iliekcomputers
fixing, one line change really
ruaok
want me to make the change and deploy it, iliekcomputers?
ok
the api-docs PR has been updated too, iliekcomputers.
wording was in fact confusing. :)
iliekcomputers
awesome :)
github joined the channel
github
[listenbrainz-server] paramsingh opened pull request #229: Change pageDone to submitListens (master...page-done-submit-listens) https://git.io/vQbBm
github has left the channel
ruaok
ok, will look.
lets see if we can both of these merged right now, shall we?
iliekcomputers
okay
ruaok
formatting is crap on my URLs, but good enough for right now
github joined the channel
github
[listenbrainz-server] mayhem closed pull request #220: API docs (master...api-docs) https://git.io/vQw2H
the business that was sold to Warner is the business that uses our data. we should hang tight until the acquisition is complete, then we'll hit warner.
ruaok cackles and evil laugh
-d
iliekcomputers
ahahah nice
ferbncode
Freso: I might not be able to make it to the meeting tonight.
(travelling back to college, so not sure about the network in train.)