#metabrainz

(broken for people who have a browser not supporting const anyway)

Funnily enough, it was CatQuest who found the issue we patched with jsesc, and then CatQuest who found the issues with jsesc :D Who needs unit tests? :P

Unit quests? :P

unit quests?

</bad pun>

OK, so search is fixed on bb.org now

Now to get on to approving tasks

Currentl 38 BB tasks in progress :o

CatQuest: taken you off "Add 5 books..." as you requested :)

i guess GCI will help out with the beta testing for BB :)

SothoTalKer: just a bit. So far 46 new editors in 2 days

(at least)

are there any documentation tasks for BB? :)

method docs yeah but we could also use some higher level doc tasks

arthelon[m]: problem with high level doc tasks is they require a greater level of familiarity with the project, I think

They may be too challenging for GCI

yup

(actually, number of new editors since the start of GCI is closer to 80, which is over 10% of the total editor count)

we can split our ideas for docs into smaller tasks though (i.e. write instructions and common errors for installing postgres on different environments)

patch should be done soon

just testing it atm

OK, I'm going to bed now... don't worry about rushing too much :)

[metabrainz.org] LeoVerto opened pull request #290: Right-align finance values in yearly reports, fix minor mistakes in 2015 report (master...master) https://git.io/vbtoT

ruaok: https://github.com/metabrainz/metabrainz.org/pu...

Freso: The three links given in this task: https://goo.gl/L8bhXy all are the exact same link, it seems

Freso: The correct links for it are: (bigquery-writer https://goo.gl/uqaQxM), (influx-writer https://goo.gl/4RyfYE), (webserver https://goo.gl/Xca1qi)

[musicbrainz-server] mwiencek opened pull request #572: Update React to v16.2.0 (master...react-16.2) https://git.io/vbtF6

Freso: Hey, just wanted to double-check that https://goo.gl/NYRSFA isn't claimed. I'm starting work on it today.

naiveaiguy: if you know any JavaScript, there's also a BB task about removing duplication

LordSputnik: yeah, but I'm planning to finish off 3-4 LB tasks before I move to BB/whipper

also, javascript is a pain to work with :P

LordSputnik: do you guys have a policy on third-party libs? what factors should I consider before including one?

For BB, or MetaBrainz in general?

For LB

or even MB in general really

I have a habit of including third party stuff all willy-nilly but I know I can't do that here

I don't know for sure about that I'm afraid, but I'd guess don't add unnecessary dependencies is probably the answer

If it's a really tiny thing you want to do, don't throw a huge library at it

hmm

If it's something complex that has the potential for lots of bugs, and there's a well tested python library designed exactly to do what you're looking for, do use that :)

LordSputnik: in this case it's pretty simple, so I might as well just create a small class for it on my own.

naiveaiguy: when sending the PR, mention "this could alternatively use library X" and they can tell you if they'd rather you used that I guess? :)

reosarevok: oh, that's a good idea! thanks :)

naiveaiguy: If it's available for you to claim, it's available for you to claim.

Freso: Oh, now I feel stupid. Sorry for disturbing you.

:P

naiveaiguy: No worries. :)

(I also fixed the links in the task btw. Thanks!)

Project bookbrainz-site build #1381: passed in 3 min 42 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

Hi all!

LordSputnik: et al. when the relationship linking is fixed, we should comment on those tasks where students comment on it

(this to make them link their authors with works)

CatQuest: it may be a month or more. My idea with getting them to comment links is that we don't need to rush the relationship editor out this way

Leo_Verto: thanks for the PR!

> Can one of the admins verify this patch?

how does one do that? can someone nudge it for me?

ruaok: @brainzbot, add to whitelist is the command, although I'm not sure I have privilege to do that.

thanks, see if I do.

[metabrainz.org] mayhem closed pull request #290: Right-align finance values in yearly reports, fix minor mistakes in 2015 report (master...master) https://git.io/vbtoT

zas: ping.

LordSputnik: ah, good idea