I thought +250 would sweeten the deal for him, but no, he's like top 5% already, it's small beans for him :P
2018-01-20 02031, 2018
naiveai
but when someone that experinenced describes this as a "feat", you know you're gonna have a bad time
2018-01-20 02033, 2018
Leo_Verto
well, you're always going to have problems with py2 and unicode
2018-01-20 02053, 2018
naiveai
the problem with stackoverflow bountying is that it doesn't really help all that much - it's still one of the questions in a pack of - what? 366 now! a lot of which have insane bounties like +500
2018-01-20 02052, 2018
naiveai
well, not a lot, only 2 have +500 currently, but still >-<
Leo_Verto: there is very small modification to DummyApp required to make the tests pass
2018-01-20 02023, 2018
naiveai
like, one characther
2018-01-20 02006, 2018
Leo_Verto
okay, I'm going to let this one slide but don't add any more features :P
2018-01-20 02026, 2018
naiveai
yeah, but I mean come on, 👍 is crucial, it's the intuitive way people vote
2018-01-20 02031, 2018
naiveai
and also, VICTORY
2018-01-20 02042, 2018
naiveai
my stackoverflow repuation SAVED THE DAY :D::D::D:D:D::D:D
2018-01-20 02057, 2018
naiveai
jesus christ, this is not what normal 14-year-olds are happy about
2018-01-20 02058, 2018
Leo_Verto
I want just 👍
2018-01-20 02001, 2018
Leo_Verto
to work for binary votes
2018-01-20 02003, 2018
naiveai
yeah, np
2018-01-20 02005, 2018
SothoTalKer
i never vote wirh emiticons
2018-01-20 02007, 2018
naiveai
it's a regex change
2018-01-20 02015, 2018
naiveai
SothoTalKer: don't ruin this for me
2018-01-20 02020, 2018
naiveai
seriously, sotho
2018-01-20 02026, 2018
naiveai
d00d.
2018-01-20 02033, 2018
SothoTalKer
just saying i dont :)
2018-01-20 02046, 2018
Leo_Verto
SothoTalKer: emojis are a vital part of any tech company in this day and age
2018-01-20 02048, 2018
naiveai
Leo_Verto: that'll be no problem. Am I allowed to push directly to the master?
2018-01-20 02053, 2018
naiveai
probably not
2018-01-20 02053, 2018
Leo_Verto
why else is everyone using slack?
2018-01-20 02054, 2018
naiveai
but still
2018-01-20 02057, 2018
SothoTalKer
because my client does not support them ;p
2018-01-20 02008, 2018
Leo_Verto
just add it to the PR
2018-01-20 02036, 2018
naiveai
well, it's kind of unrelated... but ok
2018-01-20 02044, 2018
KassOtsimine
!m naiveai
2018-01-20 02044, 2018
BrainzBot
You're doing good work, naiveai!
2018-01-20 02049, 2018
naiveai
:D
2018-01-20 02052, 2018
SothoTalKer
typing +1 or yes is faster than looking up some unicode emoticon
2018-01-20 02007, 2018
KassOtsimine
NOW FEATURE FREEZE ZOMG :P
2018-01-20 02021, 2018
SothoTalKer
but young people are all in for the graphics
2018-01-20 02030, 2018
naiveai
KassOtsimine: excuse to me, I do recall you saying that that should work :P
2018-01-20 02056, 2018
KassOtsimine
i took it back when leo sid it would be hard D:
2018-01-20 02016, 2018
naiveai
Leo_Verto: are you sure I shouldn't open a different PR? :P It changes self.output('something') to self.output(u'something')
2018-01-20 02019, 2018
KassOtsimine
right. now I go outside to overcome my fear of snow
2018-01-20 02028, 2018
KassOtsimine
\o
2018-01-20 02033, 2018
KassOtsimine
wish me luck!
2018-01-20 02039, 2018
Leo_Verto
okay, make a new PR then
2018-01-20 02047, 2018
Leo_Verto
good luck, KassOtsimine !
2018-01-20 02014, 2018
outsidecontext joined the channel
2018-01-20 02029, 2018
Leo_Verto
so I just introduces naiveai to the skin colour modifier for emojis :P
2018-01-20 02036, 2018
Leo_Verto
s/introduces/introduced
2018-01-20 02025, 2018
drsaunders has quit
2018-01-20 02046, 2018
naiveai
KILL ME
2018-01-20 02021, 2018
SothoTalKer
will do :3
2018-01-20 02058, 2018
naiveai
it's getting split again :(
2018-01-20 02024, 2018
Leo_Verto
back to stackoverflow then :P
2018-01-20 02026, 2018
drsaunders joined the channel
2018-01-20 02048, 2018
UmkaDK joined the channel
2018-01-20 02015, 2018
outsidecontext has quit
2018-01-20 02038, 2018
naiveai
Leo_Verto: where should I keep utilities functions that are not specific to a particular plugin but are still needed for mine?
2018-01-20 02010, 2018
Leo_Verto
either base.py or make a new file in that dir and import it in base.py
2018-01-20 02042, 2018
kartikeyaSh_ircc joined the channel
2018-01-20 02048, 2018
naiveai
the function is a regex escape function, will it fit in base.py (i am aware of re.escape, it does not work with unicode very well)
2018-01-20 02031, 2018
suriv has quit
2018-01-20 02050, 2018
Leo_Verto
then just put it in a utils.py and import that in the plugin
2018-01-20 02014, 2018
SothoTalKer
you should make an upstream patch then to make re.escape work better ;)
2018-01-20 02030, 2018
Leo_Verto
or that :P
2018-01-20 02040, 2018
Leo_Verto
do you know if it's better in recent py3 versions?
2018-01-20 02003, 2018
SothoTalKer
both parallel is best ^^
2018-01-20 02058, 2018
naiveai
Leo_Verto: actually, even on py3.6 it's not exactly as I need it to be
2018-01-20 02045, 2018
naiveai
the problem is re.escape(u"\U0001f44d\U0001f3fb") results in the backslashes being escaped
2018-01-20 02055, 2018
naiveai
which in our case is completely wrong
2018-01-20 02057, 2018
Leo_Verto
why do you even need to escape that?
2018-01-20 02005, 2018
naiveai
Not that particularly
2018-01-20 02025, 2018
naiveai
But the thing is, in the VOTE_SHORTUCT_TO_NAME dictionary, there is an entry for "+" and "-"
2018-01-20 02037, 2018
naiveai
which do need to be escaped for my general solution to work
2018-01-20 02046, 2018
naiveai
I don't wanna duplicate information in the regex and dictionary, ideally
2018-01-20 02055, 2018
naiveai
But it looks like that might be my only real option
2018-01-20 02021, 2018
naiveai
also, the order is important which also complicates things
2018-01-20 02023, 2018
Leo_Verto
yeah, just store them in escaped form
2018-01-20 02047, 2018
naiveai
but then when they're checked in the _parse_vote, they will be in the escaped form
2018-01-20 02001, 2018
naiveai
the other option is to re.escape the option in _parse_vote as well
2018-01-20 02010, 2018
naiveai
but that won't work, actually
2018-01-20 02015, 2018
naiveai
because of the same unicode issue
2018-01-20 02021, 2018
UmkaDK has quit
2018-01-20 02016, 2018
naiveai
ok, there has to be an elegant solution here, even more issues are popping up...
2018-01-20 02007, 2018
Leo_Verto
and your github profile pic comes into play again :P
2018-01-20 02014, 2018
KassOtsimine has quit
2018-01-20 02046, 2018
KassOtsimine joined the channel
2018-01-20 02011, 2018
naiveai
this was already an issue before this, it just got exposed here
2018-01-20 02024, 2018
naiveai
it's somewhat true, but it's a good challenge
2018-01-20 02011, 2018
naiveai
if it was easy, none of us would get paid :D
2018-01-20 02018, 2018
naiveai
well, I'm not, but you get what I mean
2018-01-20 02033, 2018
Leo_Verto
neither am I :P
2018-01-20 02057, 2018
naiveai
well, not for open-source, but presumably you do have a day job
2018-01-20 02014, 2018
Wizzup gets paid to work on open source
2018-01-20 02024, 2018
naiveai
too many clasues :P
2018-01-20 02036, 2018
Slurpee has quit
2018-01-20 02059, 2018
Leo_Verto
nope, I'm a poor student :P
2018-01-20 02014, 2018
Leo_Verto
but at least I'm not accumulating student loans like bitmap is :D
2018-01-20 02058, 2018
naiveai
YUROP
2018-01-20 02048, 2018
naiveai
Leo_Verto: the best solution is indeed to use a custom escape function, it's the cleanest one. re.escape inserting unncessary backslashes is a well-documented problem, but an upstream patch probably won't get accepted since it's a breaking change
Leo_Verto: i'm really crying for you poor student now :p
2018-01-20 02046, 2018
Leo_Verto
eh, at least I'm eligible for GSoC :D
2018-01-20 02003, 2018
SothoTalKer
what for? a free tshirt? :D
2018-01-20 02007, 2018
naiveai
free tshirt is literally the bomb by the way
2018-01-20 02025, 2018
SothoTalKer
i know
2018-01-20 02036, 2018
Leo_Verto
SothoTalKer: mostly, but also that sweet Google money
2018-01-20 02053, 2018
SothoTalKer
wanna get money from the devil? (:
2018-01-20 02002, 2018
naiveai
Leo_Verto: as it turns out, I am stupid and re.escape works fine
2018-01-20 02015, 2018
Leo_Verto
nice :P
2018-01-20 02051, 2018
SothoTalKer
hehe
2018-01-20 02031, 2018
UmkaDK joined the channel
2018-01-20 02034, 2018
naiveai
Leo_Verto: I'm rebasing and force-pushing one last time, because I was doing it earlier anyway, but I won't do it in future PRs
2018-01-20 02025, 2018
Leo_Verto
okay
2018-01-20 02016, 2018
KassOtsimine has quit
2018-01-20 02047, 2018
KassOtsimine joined the channel
2018-01-20 02051, 2018
UmkaDK has quit
2018-01-20 02020, 2018
samj1912
naiveai: was prefixing the strings with u the problem?
2018-01-20 02036, 2018
samj1912
(in py3)
2018-01-20 02048, 2018
naiveai
samj1912: in py3 the solution is a lot lot cleaner
2018-01-20 02005, 2018
samj1912
I would assume so
2018-01-20 02031, 2018
naiveai
in py2 (in narrow python installations, like the one on my computer) if you put an two-char emoji into [], they will be interpreted as two seperate characters to match
