#metabrainz

but it just doesn't make sense to have so many related global variables and not put them under a class

i was pondering on having a defaultdict with a namedtuple (since all those globals are defaultdict with shared keys)

hmm, I was thinking of having a rate control class per api_helper

since it makes sense

not sure really

so convert to class and instancy ?

and we still dont handle ratecontrol when different methods have different rate limits

zas: yes, it will also allow us to configure rate control easily for auth-api with better rate limits

ok, i'll first rename (again) ;)

let me know what you think

lol, just rebase :P

well, current use doesn't require a class, but i think it'd be useful to have usual class/instances too

[picard] samj1912 opened pull request #816: Optimize imports and follow PEP-8 (master...pep8imp) https://git.io/vNDBT

Freso! I got a very mean message from sigyn :C

alastairp: spike load is high, not sure what is going on, have a look please

this isn't cool

[listenbrainz-server] paramsingh opened pull request #340: LB-285: Improve logging in listens dumps for user (master...LB-285) https://git.io/vND0C

zas: is there something weird with the way your editor inserts spaces after `#` in comments

pylint refuses to recognise them as a space

zas: the spaces inserted in comments by your editor are `\xC2\xA0` instead of the usual `\x20`

can you check what's up

apparently its a https://en.wikipedia.org/wiki/Non-breaking_space

alastairp: but the export would already be done inside the containers in docker

so the command prefix is just `flask`, instead of `python manage.py`

alastairp: evaluate.py showing "no pending datasets", even though status is "running" on local server. why is it so?

RashiSah[m]: it has to be in state 'pending' for evaluate.py to process it

zas: postgres using a lot of CPU, but otherwise not a lot that I can see

not sure why. we have a huge database now, it's getting a bit out of hand I think

iliekcomputers: yeah, that's true

perhaps it's the idea of the 'flask' prefix, even for pure AB processing scripts that makes me feel weird

iliekcomputers: any preference for separating AB commands behind an 'ab' command class?

and other tools (hl extractor, dataset evaluator) behind another commndclass? or part of 'ab'?

samj1912: i doubt that's my editor (vim), can you point me at code having those ?

zas: I recently corrected it in my latest commit

for eg. see picard/disc.py

the attribution text with your name

i just did a test, and clearly there's no such character inserted

weird, this particular line on my pc treats it as a nbsp

yes, it was in a commit 5 years ago, may be something by this time, but atm i don't think my editor is inserting those characters, i'll recheck

we should search/replace all those ofc

I did

see https://github.com/metabrainz/picard/pull/816

i saw, but it is a bit huge to find all replacements

I mean, I made all the replacements

did you change the script generating picard/const/attributes.py ?

samj1912: did you use autopep8 to ensure things you changed are preserved ?

preserved as in?

and no I did not change the scripts generating the files

I should

zas: I was finally able to use pyinstaller :D \o/

it works on linux

trying to port it to windows now

[picard] samj1912 opened pull request #817: [WIP] Use pyinstaller to package builds (master...pyinstaller) https://git.io/vND2W

[picard] yagyanshbhatia opened pull request #818: PICARD-1067: Visual bug after un-checking an installed plugin (master...PICARD-1067) https://git.io/vND2h

zas: managed to package an exe for windows https://ci.appveyor.com/api/buildjobs/8bw00k6e4...

now lets test if it is actually working

anyone on windows here?

not me ;)

https://www.codacy.com/app/MetaBrainz/picard/pu... <--- Redefining built-in 'SyntaxError'

may be renamed it to ScriptSyntaxError and get rid of that

samj1912: can test on Windows, have Windows on my spare laptop

vishalchoudhary[: nvm

borrowed one from my friend

samj1912: ok let me know if you need next time.

well, that's my nanodegree finally wrapped up

does/will LB care about the user agent on WS requests (for rate limiting ec) the way MB does? (mainly so I know whether my C# API should require/allow one to be set)

Sigh zas this whole packaging business is a hell hole :/

Random window dll dependencies

Would be nice if someone could help us with this

picard on windows?

Yeah it works on pip

But trying to package it... Sigh

Oh wait, I finally succeeded \o/

glad i could help :]

[picard-website] mineo opened pull request #109: Remove mention of picard_dev (master...no-picard-dev) https://git.io/vNDKY

if you have a non-pip build ready i can test it

SothoTalker pushed the latest changes

Will update appveyor in a while

alastairp: getting "Recording not found" error here - http://0.0.0.0:8080/datasets/create# , although mbids are getting submitted and same mbid is showing recording details here - https://musicbrainz.org/recording/mbid as well.

[listenbrainz-server] paramsingh opened pull request #341: LB-270: Add documentation about ListenBrainz data dumps (master...listen-dumps-docs) https://git.io/vNDDd

SothoTalKer: https://ci.appveyor.com/api/buildjobs/xh4kh2c0y...

try this

samj1912: i will. does it use a different config location/name than 1.4.2? :)

SothoTalKer: hmm, it doesn't seem to be working

1 min

sure (:

samj1912: that's a long minute, hehe

SothoTalKer: I can build it on my pc

but the appveyor build doesnt run

it crashes immediately

trying to debug it