#metabrainz

/

      • Freso
        Alright, vishichoudhary_, go. :p
      • 2018-02-12 04346, 2018

      • vishichoudhary_
        Hi everyone
      • 2018-02-12 04348, 2018

      • haruute[m]
        Okay, ferbncode?
      • 2018-02-12 04351, 2018

      • Freso
        haruute[m]: spellew just said he doesn't have an update. :)
      • 2018-02-12 04306, 2018

      • vishichoudhary_
        me or ferbncode?
      • 2018-02-12 04311, 2018

      • Freso
        vishichoudhary_: You.
      • 2018-02-12 04327, 2018

      • vishichoudhary_
        Ok , was looking for some bugs in picard.
      • 2018-02-12 04345, 2018

      • vishichoudhary_
        Added some keyboard shortcut keys in picard
      • 2018-02-12 04348, 2018

      • Freso
        ferbncode will go after. (And is last one up, so if anyone else wants to give reviews (dpmittal or rsh7[m] maybe?), now is the time to let me know.)
      • 2018-02-12 04312, 2018

      • vishichoudhary_
        apart from that read about picard coverart part
      • 2018-02-12 04316, 2018

      • vishichoudhary_
        that's it
      • 2018-02-12 04327, 2018

      • vishichoudhary_
        ferbncode, go
      • 2018-02-12 04338, 2018

      • ferbncode
        Hi o/
      • 2018-02-12 04344, 2018

      • dpmittal
        may I?
      • 2018-02-12 04352, 2018

      • ferbncode
        This week, I created a PR (https://github.com/metabrainz/critiquebrainz/pull…) in CB for creating db tables in test container before the tests run. This would prevent tests failing due to code running while running and setting up the test app (as in https://github.com/metabrainz/critiquebrainz/pull…) Will try to improve this by adding test.sh (like in LB, AB), so that there is no need to remove containers explicitly.
      • 2018-02-12 04353, 2018

      • dpmittal
        ferbncode, you go first
      • 2018-02-12 04300, 2018

      • ferbncode
        fin!
      • 2018-02-12 04306, 2018

      • ferbncode
        dpmittal: go! :)
      • 2018-02-12 04319, 2018

      • dpmittal
        I was not so active these days but I was setting up CB locally and will start contributing again soon...
      • 2018-02-12 04334, 2018

      • dpmittal
        That's it :P
      • 2018-02-12 04344, 2018

      • Freso
        Alright!
      • 2018-02-12 04355, 2018

      • Freso
        That's everyone for reviews! Thanks everyone!
      • 2018-02-12 04301, 2018

      • Freso
        Theveryone!
      • 2018-02-12 04310, 2018

      • rsh7[m]
        hi! I have worked on some open issues, and working on a new one
      • 2018-02-12 04310, 2018

      • Freso
        chhavi_: GSoC idea design tickets!
      • 2018-02-12 04314, 2018

      • Freso
        Oh.
      • 2018-02-12 04315, 2018

      • chhavi_
        hii again
      • 2018-02-12 04323, 2018

      • Freso
        chhavi_: After rsh7[m] :p
      • 2018-02-12 04325, 2018

      • chhavi_
        Freso: should I go?
      • 2018-02-12 04329, 2018

      • chhavi_
        aah okay.
      • 2018-02-12 04329, 2018

      • reosarevok
        AWAY, yes
      • 2018-02-12 04335, 2018

      • reosarevok
        (no, stay, we like you)
      • 2018-02-12 04339, 2018

      • Freso
        /kick reosarevok
      • 2018-02-12 04342, 2018

      • Prakriti has quit
      • 2018-02-12 04345, 2018

      • chhavi_
        reosarevok: who will make you banners? :p
      • 2018-02-12 04357, 2018

      • reosarevok
        Well, Freso will ban me, almost the same
      • 2018-02-12 04357, 2018

      • Freso
        rsh7[m]: Got more? :)
      • 2018-02-12 04338, 2018

      • reosarevok
        !m rsh7[m] for making alastairp work, in any case
      • 2018-02-12 04338, 2018

      • BrainzBot
        You're doing good work, rsh7[m] for making alastairp work, in any case!
      • 2018-02-12 04355, 2018

      • Freso
        I guess that was all from rsh7[m] maybe.
      • 2018-02-12 04304, 2018

      • Freso
        So chhavi_, take it away. Sorry about the interruption.
      • 2018-02-12 04317, 2018

      • chhavi_
        np :)
      • 2018-02-12 04327, 2018

      • chhavi_
        So some of our ideas on GSoC page require a UX component. Yvanzo has linked them, I have left some initial comments/mockups. It will be nice if we can have feedback on them. Will help someone be more productive with their proposal/coding time.
      • 2018-02-12 04333, 2018

      • rsh7[m]
        Freso: yeah done!
      • 2018-02-12 04339, 2018

      • chhavi_
        Here's one.
      • 2018-02-12 04339, 2018

      • chhavi_
      • 2018-02-12 04339, 2018

      • BrainzBot
        MBS-9613: Redesign of "All Edits" Page
      • 2018-02-12 04342, 2018

      • Freso
        rsh7[m]: Cool, thanks! :)
      • 2018-02-12 04356, 2018

      • chhavi_
        And the other is the setlist editor.
      • 2018-02-12 04356, 2018

      • chhavi_
      • 2018-02-12 04357, 2018

      • BrainzBot
        MBS-9533: Adding a "Setlist"
      • 2018-02-12 04301, 2018

      • Prakriti joined the channel
      • 2018-02-12 04313, 2018

      • chhavi_
        That would be all Freso :)
      • 2018-02-12 04319, 2018

      • Freso
        Cool.
      • 2018-02-12 04329, 2018

      • Freso
        Leo_Verto: syswiki for community-run services!
      • 2018-02-12 04339, 2018

      • Leo_Verto
        I'm doing a fresh install of BrainzBot and samj asked me to document it, where should I do that? The syswiki seems like the obvious place but I don't (and definitely shouldn't) have access to it. This seems like it'd affect all projects run by non-MeB employees (e.g. also BookBrainz). Should this kind of info go into the project repositories? The wiki? I'd love to just have a central place for storing and finding that kind of info.
      • 2018-02-12 04316, 2018

      • dpmittal_ joined the channel
      • 2018-02-12 04337, 2018

      • Freso
        bitmap, yvanzo, ruaok, samj1912: Ping ^ I guess.
      • 2018-02-12 04345, 2018

      • Freso
        Oh, and zas.
      • 2018-02-12 04356, 2018

      • Leo_Verto
        also is there any monitoring stuff that we should plan to integrate?
      • 2018-02-12 04319, 2018

      • bitmap
        I'd say having the install documentation in the project repos make sense
      • 2018-02-12 04326, 2018

      • samj1912
        same thoughts
      • 2018-02-12 04328, 2018

      • zas
        Leo_Verto: yes, please document in-repo
      • 2018-02-12 04332, 2018

      • dpmittal_
        ferbncode[m]: Thanks to your help I was able to set up CB locally but I am unable to import CB database.. When I was following the docs It said to use the python3 manage.py export importer command... but after using it I got this error https://pastebin.com/LCZTaadJ
      • 2018-02-12 04341, 2018

      • reosarevok
        dpmittal_: post-meeting pls ;)
      • 2018-02-12 04344, 2018

      • Freso
        dpmittal_: Please, after the meeting.
      • 2018-02-12 04346, 2018

      • yvanzo
        +1
      • 2018-02-12 04355, 2018

      • yvanzo
        (for doc in the repo)
      • 2018-02-12 04302, 2018

      • dpmittal_
        Ahh, Sorry
      • 2018-02-12 04304, 2018

      • Leo_Verto
        install yes, but I was more thinking along the lines of deployed services on specific vms
      • 2018-02-12 04319, 2018

      • Leo_Verto
        e.g. users, directories, upstart/systemd services
      • 2018-02-12 04330, 2018

      • Leo_Verto
        should that also go in-repo?
      • 2018-02-12 04339, 2018

      • zas
        if there's nothing secret, yes
      • 2018-02-12 04341, 2018

      • yvanzo
        Everything except credentials.
      • 2018-02-12 04356, 2018

      • samj1912
        Leo_Verto: it would be nice to move to docker
      • 2018-02-12 04308, 2018

      • Leo_Verto
        okay, great, that answers my question
      • 2018-02-12 04309, 2018

      • samj1912
        if that is at all possible :P
      • 2018-02-12 04313, 2018

      • iliekcomputers
        Leo_Verto I think having a prod dir with docs would be good
      • 2018-02-12 04313, 2018

      • Leo_Verto
        yeah, that too :P
      • 2018-02-12 04318, 2018

      • Freso
        Leo_Verto: So fin?
      • 2018-02-12 04335, 2018

      • kartikeyaSh_ircc
        My turn !!!!!!!!!!!!!
      • 2018-02-12 04338, 2018

      • Leo_Verto
        yep
      • 2018-02-12 04339, 2018

      • iliekcomputers
        Huh maybe my message was too late here, nvm
      • 2018-02-12 04352, 2018

      • Freso
        kartikeyaSh_ircc: Okay, go. :)
      • 2018-02-12 04359, 2018

      • Freso
        Then we close after kartikeyaSh_ircc's review.
      • 2018-02-12 04311, 2018

      • dpmittal has quit
      • 2018-02-12 04321, 2018

      • dpmittal_ is now known as dpmittal
      • 2018-02-12 04329, 2018

      • kartikeyaSh_ircc
        This week I created 3 tickets(LB 308,309,310) and created 3 PR's on LB (LB-148,308,309). these deal with Last.fm compatible API. I need to discuss some problems that i'm facing then continue further work.
      • 2018-02-12 04329, 2018

      • BrainzBot
        LB-148: Add integration tests to api_compat feature https://tickets.metabrainz.org/browse/LB-148
      • 2018-02-12 04341, 2018

      • Freso
        kartikeyaSh_ircc: Got more?
      • 2018-02-12 04315, 2018

      • kartikeyaSh_ircc
        Freso: No that's it
      • 2018-02-12 04318, 2018

      • yvanzo
        !m kartikeyaSh_ircc
      • 2018-02-12 04318, 2018

      • BrainzBot
        You're doing good work, kartikeyaSh_ircc!
      • 2018-02-12 04323, 2018

      • iliekcomputers
        kartikeyaSh_ircc: let's discuss tomorrow
      • 2018-02-12 04325, 2018

      • iliekcomputers
        :)
      • 2018-02-12 04336, 2018

      • kartikeyaSh_ircc
        iliekcomputers: okay
      • 2018-02-12 04337, 2018

      • naiveai has quit
      • 2018-02-12 04338, 2018

      • Freso
        kartikeyaSh_ircc: Alright, be sure to say "fin" or "done" or something when you're done, so we know you're done and can move on. :)
      • 2018-02-12 04302, 2018

      • Freso
        kartikeyaSh_ircc: Also, we usually do reviews at the beginning of the meeting, so if you can, try and be around that time next time. :)
      • 2018-02-12 04307, 2018

      • Freso
        kartikeyaSh_ircc: Either way, thanks!
      • 2018-02-12 04312, 2018

      • akhilesh
        I would also like to take part in the meeting today (For Reviews)
      • 2018-02-12 04313, 2018

      • Freso
        And with that!
      • 2018-02-12 04314, 2018

      • kartikeyaSh_ircc
        Freso: I'll remember that from next time
      • 2018-02-12 04315, 2018

      • Freso
        Oh.
      • 2018-02-12 04321, 2018

      • Freso
        akhilesh: Alright, go.
      • 2018-02-12 04331, 2018

      • Freso
        Then we'll close after akhilesh, maybe…
      • 2018-02-12 04336, 2018

      • Freso
        kartikeyaSh_ircc: 👍 :)
      • 2018-02-12 04316, 2018

      • akhilesh
        I worked for bookbrainz, and I Sent this PR (https://github.com/bookbrainz/bookbrainz-site/pul…) for improving search Results
      • 2018-02-12 04304, 2018

      • Freso
        akhilesh: Fin?
      • 2018-02-12 04315, 2018

      • akhilesh
        yes
      • 2018-02-12 04328, 2018

      • Freso
        akhilesh: Alright, be sure to say "fin" or "done" or something when you're done, so we know you're done and can move on.
      • 2018-02-12 04356, 2018

      • Freso
        Also, try and be around for the beginning of the meeting next time, so we can do all the reviews together.
      • 2018-02-12 04359, 2018

      • Freso
        Anyway.
      • 2018-02-12 04309, 2018

      • Freso
        Thanks for all the reviews and everyone's time!
      • 2018-02-12 04311, 2018

      • Freso
        </BANG>
      • 2018-02-12 04317, 2018

      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: Reviews, OTHER-77: MarkBrainz (yvanzo)
      • 2018-02-12 04317, 2018

      • akhilesh
        ok Thanks
      • 2018-02-12 04328, 2018

      • Freso
        OTHEr-77
      • 2018-02-12 04331, 2018

      • Freso
        OTHER-77
      • 2018-02-12 04332, 2018

      • iliekcomputers
        Thanks Freso
      • 2018-02-12 04332, 2018

      • BrainzBot
        OTHER-77: Unify all markup syntax to simple markdown syntax https://tickets.metabrainz.org/browse/OTHER-77
      • 2018-02-12 04337, 2018

      • Freso
        :o
      • 2018-02-12 04337, 2018

      • chhavi_
        Freso thanks for your patience and awesomeness :D
      • 2018-02-12 04348, 2018

      • Freso
        chhavi_: :$
      • 2018-02-12 04305, 2018

      • yvanzo
        Freso: It is actually a prerequisite for some Design changes such as MBS-9533 chhavi_ mentionned earlier.
      • 2018-02-12 04305, 2018

      • BrainzBot
      • 2018-02-12 04301, 2018

      • Leo_Verto
        zas: is a page in the brainzbot readthedocs okay for you?
      • 2018-02-12 04344, 2018

      • reosarevok
        Unify all the things. Except Spain and Catalonia
      • 2018-02-12 04302, 2018

      • zas
        I think so, if brainzbot has already one, better keep infos together
      • 2018-02-12 04339, 2018

      • yvanzo
        reosarevok: did you invent the event setlist syntax from scratch, or has it any legacy motivation (from last.fm or anything else)?
      • 2018-02-12 04301, 2018

      • reosarevok
        I think it was a bit related to setlist.fm maybe? But it's shit, so you can change it
      • 2018-02-12 04320, 2018

      • samj1912
        bitmap: I was having some trouble fixing a ws/js test
      • 2018-02-12 04347, 2018

      • samj1912
      • 2018-02-12 04351, 2018

      • reosarevok
        It confuses people anyway :)
      • 2018-02-12 04306, 2018

      • yvanzo
        It’s an opportunity to add new features at the same time.
      • 2018-02-12 04331, 2018

      • bitmap
        samj1912: did you add any new keys to existing TO_JSON subroutines? or remove keys
      • 2018-02-12 04357, 2018

      • bitmap
        looks like there are some failures related to 'is_special_purpose'
      • 2018-02-12 04301, 2018

      • samj1912
        yeah
      • 2018-02-12 04304, 2018

      • samj1912
        I did add a key
      • 2018-02-12 04310, 2018

      • samj1912
        although I fixed it in a new commit
      • 2018-02-12 04314, 2018

      • samj1912
        I am still getting an error locally
      • 2018-02-12 04317, 2018

      • bitmap
        (you have to click on 'View as plain text' in the side to see the actual errors
      • 2018-02-12 04320, 2018

      • bitmap
        )
      • 2018-02-12 04332, 2018

      • samj1912
      • 2018-02-12 04325, 2018

      • bitmap
        hmm, not sure yet, but actually I would implement that in JavaScript instead
      • 2018-02-12 04357, 2018

      • UmkaDK has quit
      • 2018-02-12 04357, 2018

      • samj1912
        okay
      • 2018-02-12 04321, 2018

      • iliekcomputers
        12:02 AM <reosarevok> !m rsh7[m] for making alastairp work, in any case
      • 2018-02-12 04326, 2018

      • bitmap
        in general I would not serialize anything from a method, I would port the method to JS (though there may be exceptions)
      • 2018-02-12 04336, 2018

      • iliekcomputers
        I do that too sometimes ;)