samj1912: lgtm other than the one comment I just left I think
2018-02-27 05803, 2018
samj1912
Cool
2018-02-27 05825, 2018
dragonzeron has quit
2018-02-27 05849, 2018
fhe joined the channel
2018-02-27 05803, 2018
bitmap
(plus the other one comment I just left)
2018-02-27 05854, 2018
samj1912
bitmap: how do I enable i18n on my local setup?
2018-02-27 05818, 2018
samj1912
I don't have the drop-down on the top right.
2018-02-27 05819, 2018
bitmap
I think the instructions under 'Translations' in INSTALL.md should work
2018-02-27 05825, 2018
bitmap
although you don't need transifex
2018-02-27 05843, 2018
bitmap
make -C po deploy; and set MB_LANGUAGES
2018-02-27 05838, 2018
bitmap
on ubuntu I think you do need those language packs
2018-02-27 05836, 2018
github joined the channel
2018-02-27 05836, 2018
github
[listenbrainz-server] Uditgulati opened pull request #368: LB-322: Add import and sign in buttons to error pages (master...LB-322) https://git.io/vA6lL
2018-02-27 05836, 2018
github has left the channel
2018-02-27 05813, 2018
samj1912
bitmap: updated, one thing I noticed if lp_* functions are passed undef, it throws an error, can it silently just output a blank string or return undef too instead?
also, it would be nice to write a couple of wrappers around l* functions as we discussed
2018-02-27 05809, 2018
samj1912
including support for template strings if its possible
2018-02-27 05818, 2018
bitmap
hm, well returning a blank string could work for lp_attributes (and other domains extracted from the db), though for l() throwing an exception makes sense since it's a bug in the code
2018-02-27 05818, 2018
bitmap
though I guess it wouldn't hurt to change all of them, if you don't see any output it should be clear something is wrong
2018-02-27 05850, 2018
samj1912
it shows an error screen and an exception with jed
2018-02-27 05812, 2018
samj1912
ill make a small PR for this behaviour atleast
2018-02-27 05841, 2018
bitmap
how do you propose template strings are supposed to work with gettext?
2018-02-27 05838, 2018
bitmap
if you're generating a translated string dynamically, you're doing something wrong
2018-02-27 05813, 2018
samj1912
hmm, but its useful in some cases like multiline strings without \
2018-02-27 05828, 2018
samj1912
hmm, but yeah, not sure how to extract dynamic strings
2018-02-27 05834, 2018
bitmap
yeah, that's about the only use they have there, although we need to write our own extractor before we can put newlines in strings anyway
2018-02-27 05833, 2018
bitmap
similar to po/extract_pot_templates which extracts strings from .tt for us and collapses whitespace
2018-02-27 05806, 2018
bitmap
for the .js we just use xgettext which is a bit more primitive
ruaok: re blogpost, aside from a typo here and there (which I've fixed), the only thing that comes to mind that we haven't mentioned is the bigquery-writer batch submitting listens feature (although it isn't user facing, so we don't want to mention it maybe)
2018-02-27 05811, 2018
samj1912
bitmap: ^^
2018-02-27 05851, 2018
bitmap
as long as it doesn't choke on jsx/our other es.$version additions and collapses newlines/spaces
2018-02-27 05840, 2018
samj1912
hmm, let me see if that works
2018-02-27 05833, 2018
CatQuest has quit
2018-02-27 05810, 2018
CatQuest joined the channel
2018-02-27 05810, 2018
CatQuest has quit
2018-02-27 05810, 2018
CatQuest joined the channel
2018-02-27 05820, 2018
uditgulati0[m]
iliekcomputers: how can I check that error is 500 in flask template?
iliekcomputers: thanks for the review on the blog post. I'll add the bg stuff to it. it is worth mentioning.
2018-02-27 05802, 2018
ruaok
oh and Mooooin!
2018-02-27 05820, 2018
iliekcomputers
moin!
2018-02-27 05823, 2018
iliekcomputers
back in BCN?
2018-02-27 05844, 2018
ruaok
reosarevok or anyone, actually: do you know of a currently working site that uses our data to make a spammy site with ads and/or malware?
2018-02-27 05816, 2018
ruaok
iliekcomputers: yes. its a balmy 3C here. I walked home from the bus without a jacket it was so nice, compared to zurich. :)
2018-02-27 05836, 2018
iliekcomputers
if you find 3C balmy, you'll boil in Delhi :D
2018-02-27 05843, 2018
iliekcomputers
it is 25C here rn :P
2018-02-27 05815, 2018
ruaok
compared to the -9C that I left in Zürich, 3C was really pleasant. :)
2018-02-27 05829, 2018
ruaok
but yes, 25C is going to be a bit of a shock. :)
2018-02-27 05830, 2018
iliekcomputers
:)
2018-02-27 05851, 2018
iliekcomputers
ruaok: the good food here will make up for it :)
2018-02-27 05823, 2018
ruaok
sooo happy about that.
2018-02-27 05850, 2018
iliekcomputers
i have a place with the most delicious biryani in mind ;)
2018-02-27 05804, 2018
jwf
Save some for me :P
2018-02-27 05839, 2018
ruaok
hey jwf, long time no see. :)
2018-02-27 05851, 2018
jwf waves
2018-02-27 05839, 2018
jwf
Sorry I haven't been around as much. Started a new job in January and it's taken a big bite out of my time. :-(
2018-02-27 05832, 2018
ruaok
no worries.
2018-02-27 05835, 2018
ruaok
jobs are good.
2018-02-27 05820, 2018
github joined the channel
2018-02-27 05820, 2018
github
[listenbrainz-server] mayhem closed pull request #366: Tune crontab to be easy to grasp for humans (master...crontab-tuning) https://git.io/vAoJr
2018-02-27 05820, 2018
github has left the channel
2018-02-27 05837, 2018
iliekcomputers
they pay for the food :)
2018-02-27 05842, 2018
iliekcomputers
(and the drinks)
2018-02-27 05857, 2018
ruaok
and internet. :
2018-02-27 05800, 2018
github joined the channel
2018-02-27 05800, 2018
github
[listenbrainz-server] mayhem closed pull request #365: Modify test_user.py to check for not calculated artist_count in user.py (master...user_test) https://git.io/vAa6k
2018-02-27 05800, 2018
github has left the channel
2018-02-27 05800, 2018
ruaok
:)
2018-02-27 05821, 2018
github joined the channel
2018-02-27 05821, 2018
github
[listenbrainz-server] mayhem closed pull request #367: Merge production into master before beta release (master...merge-branch) https://git.io/vAKoq
2018-02-27 05821, 2018
github has left the channel
2018-02-27 05857, 2018
adhawkins
Morning all. Anyone here who knows about the coverart backend?
"Download Musicbrainz Test Artist It Is Time file type: mp3 - download Musicbrainz Test Artist It Is Time bitrate: 320 kbps Full Album Kualitas HD" (https://www.mp3i.me › Music)
2018-02-27 05814, 2018
reosarevok
They have a Test Artist album in fucking HD. Wow! :D
