Well, my week was kind of a mess, spent way too much time travelling between the city I come from and the one I study in but at least I got to see a concert in the large hall of https://musicbrainz.org/place/8da8cd3d-6162-4714-….
2018-06-25 17610, 2018
Leo__Verto
On the SpamBrainz side of things, I've gotten most of the API so far done but I'm struggling a bit with how to use Flask Blueprints (just takes a while to figure stuff out).
2018-06-25 17615, 2018
reosarevok
That's the super cool looking one, right? With all the levels
I also forgot to commit my WIP work so I couldn't work on the train which had a lovely 50 minute delay at 1 in the night, yay!
2018-06-25 17655, 2018
Leo__Verto
fin.
2018-06-25 17607, 2018
Freso
(Only rsh7 and bukwurm / bukwurm_ left on my list.)
2018-06-25 17617, 2018
Leo__Verto
rsh7, go!
2018-06-25 17618, 2018
Freso
(Anyone else, speak up ASAP.)
2018-06-25 17625, 2018
rsh7
hey
2018-06-25 17651, 2018
rsh7
Last week I completed the work of importing the MB metadata in AB database. Then worked on the script to update the musicbrainz schema by importing the new data corresponding to a recording whenever there is any new recording insertion in acousticbrainz db.
2018-06-25 17623, 2018
rsh7
And read about replication packets and figured out a little on how would i write a script to apply the packets to keep the musicbrainz data in AB db updated with the actual MB database
2018-06-25 17659, 2018
rsh7
I have some questions regarding replication packets. bitmap: if you are free for a short discussion after this meeting, please let me know :)
2018-06-25 17616, 2018
bitmap
yup, after the meeting :)
2018-06-25 17623, 2018
rsh7
fin! bukwurm?
2018-06-25 17630, 2018
bukwurm
Hi
2018-06-25 17634, 2018
rsh7
bitmap: thanks :)
2018-06-25 17608, 2018
bukwurm
This week on mostly code refactoring and improving mapping.
2018-06-25 17622, 2018
bukwurm
I set up test environment, wrote some tests.
2018-06-25 17612, 2018
bukwurm
I am wrapping up last phase objectives.
2018-06-25 17637, 2018
bukwurm
Documentation and improvement of mapping of some dumps is on radar for this week.
2018-06-25 17643, 2018
iliekcomputers
last phase of gsoc?
2018-06-25 17657, 2018
bukwurm
last == previous
2018-06-25 17614, 2018
bukwurm
So that's it for this week. :)
2018-06-25 17637, 2018
iliekcomputers
oh. ok.
2018-06-25 17603, 2018
Freso
bukwurm: So… fin?
2018-06-25 17610, 2018
bukwurm
Freso: Yeah
2018-06-25 17612, 2018
bukwurm
:)
2018-06-25 17614, 2018
Freso
Alright, great!
2018-06-25 17616, 2018
Freso
No one else is left on my list and I haven't seen anyone else asking to go, so…
2018-06-25 17616, 2018
Freso
Thanks bukwurm and everyone else for your reviews!
it seems to be an "art instalment thing" to me which could be served fine with Instrument credits (see my comments on the ticket)
2018-06-25 17642, 2018
CatQuest
However, I am not certain certain, so incase someone has any counteropinions, _now_ is the time to speak up! :)
2018-06-25 17611, 2018
CatQuest
freso, you commented on it al ong time ago, do oyu have any imput at all?
2018-06-25 17630, 2018
Freso
CatQuest: Not really. I looked at the ticket again, but I don't know either which way.
2018-06-25 17632, 2018
CatQuest
a long time ago, you input*
2018-06-25 17606, 2018
CatQuest
i fear is that it will basically become a dumping ground for any "guitar played some other way" credits
2018-06-25 17618, 2018
CatQuest
"altered guitar" i belive we eiher already have or there is a ticket for it
2018-06-25 17625, 2018
reosarevok
I think I'm happy with ACs (ICs?), unless it becomes common enough, in which case we can review
2018-06-25 17637, 2018
Freso
Same.
2018-06-25 17634, 2018
CatQuest
any one else?
2018-06-25 17636, 2018
Freso
If there is a generic "guitar derivative"/"altered guitar" then the actualy "backwards guitar" instrument can be put there with AC/IC, and guitars played backwards can be AC/IC'd to regular "guitar"/"electric guitar".
2018-06-25 17603, 2018
CatQuest
yes
2018-06-25 17649, 2018
Freso
And as reosarevok said, we can review later with more data.
2018-06-25 17626, 2018
CatQuest
it's an archived rquest and noone else has looked at is since atleast before 2014
2018-06-25 17645, 2018
CatQuest
so deff. if suddenly it becomes popular or something. reopen or make an ew ticket
2018-06-25 17651, 2018
CatQuest
a new*
2018-06-25 17608, 2018
Freso
I'm sure we have plenty of ew tickets already. :)
2018-06-25 17629, 2018
CatQuest
extra props to HibiscusKazeneko for also replying ot this ticket
2018-06-25 17644, 2018
CatQuest
Freso: deff 😅
2018-06-25 17645, 2018
Freso
So done with this DR?
2018-06-25 17650, 2018
CatQuest
yup, seems liek it
2018-06-25 17652, 2018
CatQuest
like*
2018-06-25 17654, 2018
Freso
Alright!
2018-06-25 17658, 2018
CatQuest
thnak you everyone
2018-06-25 17658, 2018
Freso
Thanks for your time everyone!
2018-06-25 17600, 2018
Freso
</BANG>
2018-06-25 17604, 2018
CatQuest
\o/
2018-06-25 17632, 2018
iliekcomputers
thanks Freso
2018-06-25 17611, 2018
CatQuest
yes, thanks freso, threso
2018-06-25 17604, 2018
kartikeyaSh
iliekcomputers: hey!
2018-06-25 17614, 2018
bitmap
rsh7: you had questions about replication?
2018-06-25 17645, 2018
kartikeyaSh
I'm going to delete that table now. Won't take much time
2018-06-25 17607, 2018
rsh7
bitmap: yeah, hi!
2018-06-25 17639, 2018
bitmap
hey
2018-06-25 17647, 2018
rsh7
actually I was working on importing the Musicbrainz data in Acousticbrainz database and now i need to add a functionality to keep musicbrainz schema in AB updated with the actual Musicbrainz database
2018-06-25 17653, 2018
rsh7
and I would use replication packets to apply in musicbrainz schema tables
2018-06-25 17616, 2018
iliekcomputers
kartikeyaSh: awesome.
2018-06-25 17652, 2018
rsh7
bitmap: so, i was thinking that from which replication packet should i start to apply? I thought to go with the latest packets but I read that the new replication packet is applied only when the previous one is already applied to the database. So, from where should i start?
2018-06-25 17657, 2018
bitmap
you start by importing a data dump, and the last replication sequence applied to that dump is stored in that dump (in the replication_control table)
the tools provided by mb (admin/replication/LoadReplicationChanges) automatically know what replication packet to download and apply
2018-06-25 17622, 2018
bitmap
I assume you're using mb's tools, or mbslave, and not writing your own :)
2018-06-25 17639, 2018
rsh7
oh okay.
2018-06-25 17651, 2018
rsh7
No, actually I didn't use mbslave
2018-06-25 17651, 2018
rsh7
We needed few tables from MB, so I created a schema for only those tables and wrote a script to import the data
2018-06-25 17641, 2018
bitmap
from the fullexport dumps?
2018-06-25 17654, 2018
rsh7
and I was testing with sample MB dumps, I found that the replication_control table is empty there.
2018-06-25 17611, 2018
bitmap
right
2018-06-25 17619, 2018
bitmap
it seems like it would be better to add an option to mb's import script to specify which tables you want to import, instead of reinventing the wheel, but maybe you have other requirements
2018-06-25 17606, 2018
iliekcomputers
we only wanted those rows that were relevant to us (for ex: only info about recordings that are in AB)
2018-06-25 17635, 2018
rsh7
yeah
2018-06-25 17652, 2018
rsh7
Alright! So, now I am thinking if I create one more table in musicbrainz schema which will store replication sequence number and stuff and then downloads the new packet and script to apply it on the tables and then update the sequence number. But the problem is, what replication packet to start from.
what happens when a recording is added to ab but it doesn't exist in the musicbrainz schema because you didn't import it?
2018-06-25 17625, 2018
iliekcomputers
bitmap: we plan to have a script running that finds such recordings and imports their data.
2018-06-25 17610, 2018
iliekcomputers
kartikeyaSh: thanks.
2018-06-25 17653, 2018
bitmap
where will you import it from?
2018-06-25 17630, 2018
iliekcomputers
production MB, the way CB reads it rn.
2018-06-25 17604, 2018
bitmap
cool
2018-06-25 17659, 2018
bitmap
soo this import_mb_data.py script is also reading from the production mb database, not importing from a data dump
2018-06-25 17611, 2018
bitmap
if that's the case then you can get replication_control.current_replication_sequence at the beginning of the script, and that's the sequence you start from
2018-06-25 17655, 2018
bitmap
there will likely be conflicts (data already existing) when the next packet is released, and you'll need to expect and handle those
2018-06-25 17640, 2018
rsh7
Alright, got it!
2018-06-25 17656, 2018
rsh7
Thank you :)
2018-06-25 17612, 2018
bitmap
seems like a good argument for keeping all meb projects in one database though
2018-06-25 17638, 2018
iliekcomputers
yeah.
2018-06-25 17610, 2018
iliekcomputers
we came across some issues that are hard to solve efficiently still in CB because we can't join tables across projects.