No iso codes there currently. Which makes me wonder, why do we use the iso codes there anyway? (of course, we also don't have the translated names there, so)
2018-09-05 24823, 2018
reosarevok
Also bitmap: have you written anything for link_iswc yet, or should I just do it myself? :)
2018-09-05 24841, 2018
bitmap
lemme see
2018-09-05 24835, 2018
bitmap
ah we already have root/static/scripts/common/components/CodeLink.js for that
2018-09-05 24847, 2018
bitmap
used for ISRCs too
2018-09-05 24843, 2018
reosarevok
Ok :) What about the languages? I'm not fully sure how to even load the codes etc for them :/
yeah, you don't really need the conditional since the html will just be empty in that case
2018-09-05 24818, 2018
reosarevok
I was getting an Error: No translation key found. otherwise though
2018-09-05 24842, 2018
bitmap
ah, you're right
2018-09-05 24815, 2018
CatQuest
instrument thing
2018-09-05 24818, 2018
CatQuest
?
2018-09-05 24839, 2018
CatQuest
what are you doooing?
2018-09-05 24851, 2018
reosarevok
CatQuest: updating the instrument search results to React. So, nothing visible
2018-09-05 24851, 2018
CatQuest
:D
2018-09-05 24854, 2018
reosarevok
(if I don't mess up)
2018-09-05 24800, 2018
CatQuest
:P
2018-09-05 24800, 2018
CatQuest
and aww
2018-09-05 24832, 2018
reosarevok
Well, maybe a tiny increase in loading speed of the search? :D
2018-09-05 24836, 2018
reosarevok
But like, tiny
2018-09-05 24853, 2018
CatQuest
Y U do dis? T__T
2018-09-05 24820, 2018
reosarevok
Because if they're all done, yvanzo said we can get an "all" search :p
2018-09-05 24827, 2018
CatQuest
i thought the point was react was better, faster, stronger.. last thing
2018-09-05 24830, 2018
reosarevok
(ok, not only that, but that'd be neat)
2018-09-05 24847, 2018
reosarevok
Well, it is, I just don't think the instrument search load was particularly slow
2018-09-05 24853, 2018
CatQuest
so why increase in loading?
2018-09-05 24858, 2018
reosarevok
duh
2018-09-05 24801, 2018
reosarevok
decrease :D
2018-09-05 24806, 2018
reosarevok
Sorry
2018-09-05 24810, 2018
CatQuest
oh
2018-09-05 24810, 2018
CatQuest
duh
2018-09-05 24810, 2018
CatQuest
now i get it
2018-09-05 24811, 2018
CatQuest
:D
2018-09-05 24812, 2018
reosarevok
increase in the speed
2018-09-05 24815, 2018
reosarevok
Decrease in the time
2018-09-05 24818, 2018
reosarevok
Whatevers :D
2018-09-05 24825, 2018
reosarevok wasn't too clear
2018-09-05 24838, 2018
CatQuest
sorry cannot parse that as anything but "increase = longer" :D
2018-09-05 24839, 2018
CatQuest
ya, u wasn't :P
2018-09-05 24846, 2018
CatQuest
\m/ BrainZ \m/
2018-09-05 24821, 2018
culinko has quit
2018-09-05 24852, 2018
reosarevok
bitmap: what's the reason for us to have separate inline-results-release.tt and the like?
2018-09-05 24827, 2018
bitmap
reosarevok: separate from where?
2018-09-05 24852, 2018
reosarevok
results-release is basically just a wrapper with [% INCLUDE 'search/lib/inline-results-release.tt' %]
2018-09-05 24829, 2018
bitmap
oh, hmm
2018-09-05 24847, 2018
bitmap
they are also used by root/taglookup/results.tt
2018-09-05 24804, 2018
bitmap
but I guess only certain types
2018-09-05 24819, 2018
reosarevok
We only have that for recording and release
2018-09-05 24824, 2018
reosarevok
(also why I haven't touched them yet :p )
2018-09-05 24848, 2018
bitmap
artist, recording, release
2018-09-05 24818, 2018
reosarevok
But artist is already made
2018-09-05 24834, 2018
reosarevok
Which I guess means "do it the standard way and leave this behind for taglookup" or?
2018-09-05 24843, 2018
reosarevok
(since AFAICT that's what happened with artist)
2018-09-05 24803, 2018
bitmap
yeah, that makes sense
2018-09-05 24822, 2018
bitmap
taglookup won't be too hard to convert in any case but we can leave the inline files it needs for now
2018-09-05 24848, 2018
Sophist-UK has quit
2018-09-05 24806, 2018
reosarevok
bitmap: any suggestions for [%- IF c.try_get_session('tport') -%] <th>[% l('Tagger') %]</th> [%- END %] on recording?
2018-09-05 24821, 2018
reosarevok
It's always been a bit weird for me that this affects search result display in this way tbh :/
2018-09-05 24813, 2018
bitmap
the equivalent check in JS would be $c.session && $c.session.tport, and there's a TaggerIcon component already if you need that
2018-09-05 24817, 2018
reosarevok
Also, <th class="t pos">[% l('Track') %]</th> - is there a way to send a class for a column of PaginatedSearchResults? I guess not currently. Should I add one?
2018-09-05 24814, 2018
bitmap
hmm, I guess so
2018-09-05 24815, 2018
reosarevok
Also II, is there a way to add *optional* columns? (for the Tagger thing)
