Not sure if this output doesn't map properly to our tests or I just can't read it yet, but I have no idea where to look for "50 not ok" on the file - what's 50? :D
Cyna has quit
bukwurm has quit
yvanzo
reosarevok: not sure what 50 refers to but you have to update t/script/DumpJSON.t which has tags only not genres
code_master5 joined the channel
reosarevok
Ok, I'll look at that (but still would love to understand how this shit works on jenkins at some point :D )
yvanzo
From what I’ve found, 50 might stands for test ran from the line 161 of DumpJSON.t.
antara has quit
thefar8 joined the channel
Leo_Verto
CatQuest, in German we use "Spanish" instead :P
Mr_Monkey
Leo_Verto, CatQuest : In french, something I don't understand would be "du Chinois".
c1e0 joined the channel
reosarevok
yvanzo: lol, I added genres to stuff and now I have more errors
(and I can't test this locally, it seems, it just fails)
c1e0 has quit
yvanzo
reosarevok: you should update tested code too, that is everything about Dump under lib/MusicBrainz/Script/ :)
c1e0 joined the channel
CallerNo6 has quit
Hello29 joined the channel
Hello29 has quit
code_master5
Anyone? I'm just ...
reosarevok
code_master5: ? :)
code_master5
alone!
reosarevok: Sorry.
c1e0 has quit
iliekcomputers
Proxy.listenbrainz wasn't returning data for some reason, restarted container fixed.
code_master5: hi! =)
Mr_Monkey
code_master5: I agree, it's pretty quiet out here…
thefar8 has quit
c1e0 joined the channel
CatQuest
Leo_Verto, Mr_Monkey: and I belive the chinese say something like "it's heavenly script"
Mr_Monkey
That's great !
CatQuest
george: hi!
george
CatQuest: Hello :)
CatQuest
well what can I say, like the others saying, you do great work!
(I only wish you'd picked a less ambigious instrument for me ot decide on :D)
it's really interesting ,but also balances on the nife-edge of the "novelty" clause :D
knife*
george
Thank you!! I had quite a hard time finding an instrument not already in musicbrainz tbh
No worries, I'm happy to research another this evening just to be safe
CatQuest
heh. I'm asking with reo (the other mentor) about this. in any case i hope you'll do more instrument tasks evne still :)
if you're looking for instruments to add tickets for there is actually a ticket with some suggstions.. let me see
(I'm trying to convince you to claim more "instrument" tasks after this one, if it's not obvious ;))
george
Haha I'm definitely planning to :)
CatQuest
:D
iliekcomputers
zas: can you look at what's happening with proxy.listenbrainz.org on lemmy once? requests don't actually seem to reach the container, i had restarted it, which fixed it for a while but the error is back.
CatQuest: I’ve submitted one of the ones from the list that you sent anyways 👍
rdswift
Yeah, it's one I requested. No problem with taking so long. I just want to finalize the instrument credits on the release whenever a decision is made whether or not this should be added.
CatQuest
the version is up for after this one
rdswift
I'm not in any real rush. Just thought I heard that people were running out of instruments to reasearch. Quite possible I misunderstood, because I just skimmed the conversation quickly.
CatQuest
heh
ohnestly there are *so* many instruments we still don't have. also there are many isntrments to still research. that one, https://tickets.metabrainz.org/browse/INST-183 for example. etc many things
BrainzBot
INST-183: Player Piano
CatQuest
george: that ticket can be a subticket! (I don't know if you have the availablility to "convert to sub-task" here so i'll do it)
george
Great, thanks!
rdswift
Oh yeah, I remember that I owe you some things on this. I have to get away for an hour or so for some lab tests, but will try to get you my thoughts after that.
CatQuest
cheers!
(to both of you ;))
zas
iliekcomputers: i didn't set up this stuff, why do you ask me ? ;)
from listenbrainz-api-compat-prod container on lemmy
btw is listenbrainz-api-compat-nginx using an hardcoded ip/port ?
i restarted both containers, and it seems to be back
iliekcomputers: but people who actually set up those services have to look what was the issue
michelv joined the channel
Freso: discourse upgrade procedure was fixed, i deployed it.
CatQuest
for a sec i read "I destroyed it" :D
spuniun has quit
c1e0
CatQuest: Me too! :D
CatQuest
:D
zas
well, that was 2 days ago ;)
CatQuest
you destroyed it two days ago? :O
:D
spuniun joined the channel
Mineo
I intermittently saw some protocol errors from firefox/curl instead of the usual "you've reached a sleepy server" message during the upgrade. was that intentional?
CatQuest
i love he "sleepy server" thing. but i wnat the sleepy cat one
creature_ joined the channel
creature has quit
creature_ is now known as creature
creature has quit
creature joined the channel
c1e0 has quit
code_master5 has quit
michelv has quit
rdswift
CatQuest, my opinions regrading Player Piano... First, it is a piano (upright piano are the only ones I've seen). It is played as a piano -- you press the keys, they activate the hammers which strike the strings, thus creating the sound.
The only difference with a player piano is that there is an additional mechanism installed to press the keys based upon a set program (the paper roll fed through the mechanism).
If it's the "player piano" portion of the instrument we're talking about, it isn't played so much as it's actually programmed.
I can't immediately think of another instrument to use as an analogy.
You can program a drum track, but it doesn't actually play a drumset by striking the drums, symbols, etc with drumsticks to create the sound. It's all done electronically.