#metabrainz

/

      • iliekcomputers
        *i can
      • ruaok
        "I understand the difference between a commercial and non-commercial integration" oh, I like that box!
      • keys transmitted as per usual janky out of band method!
      • akhilesh
        Mr_Monkey: oh Sorry!
      • Mr_Monkey
        No, my bad akhilesh I only thought about it too late :)
      • Yes, that's great
      • iliekcomputers
        ruaok: got it.
      • akhilesh
        Mr_Monkey: Ok, I will show you for all entities one by one. Please finalize those also
      • zas
        iliekcomputers: no idea about https://github.com/metabrainz/docker-server-con..., dunno why this is needed at all
      • Mr_Monkey
        akhilesh: Sure thing. I'm off for now but will have a look this weekend.
      • Maybe post the screenshots on the ticket, it'll be easier to see them all together
      • iliekcomputers
        new beta containers for LB deployed.
      • and for CB.
      • akhilesh
        Mr_Monkey: I posted the screenshots for the creator sort name. Could you see please?
      • ruaok
        there are no new user facing features, right?
      • akhilesh
        In the #BB-298
      • BrainzBot
        BB-298: Display sort names *somewhere* https://tickets.metabrainz.org/browse/BB-298
      • iliekcomputers
        ruaok: there are two new endpoints
      • for LB
      • ruaok
        k
      • iliekcomputers
        and a few user facing features for CB
      • (related to comments on reviews)
      • ruaok
        just checking there are no new shiny buttons to push. :)
      • its blank. though I am listening to music. that sync is on beta.lb, so why is it blank?
      • iliekcomputers
        ruaok: now playing is a different listen type
      • ruaok
        stored in redis, yes?
      • iliekcomputers
        Your client doesn't seem to using it.
      • ruaok: yes
      • ruaok
        oh boo. our spotify service doesn't support it.
      • iliekcomputers
        Ticket :)
      • ruaok
      • BrainzBot
        LB-414: Spotify listen recording service should sent "now listening" info
      • reosarevok
        bitmap: so I guess I should be updating other PRs to also pass entity instead of releaseGroup, right?
      • (other RG related PRs)
      • (asking in case the aliasing thing does something about that, but I'm assuming not)
      • bitmap
        yeah but we can merge this one first if it matters
      • Gazooo has quit
      • reosarevok
        Not really, to me, just making sure
      • Gazooo joined the channel
      • bitmap: updated that PR
      • Also the aliases one, for the new change
      • Protab joined the channel
      • Rotab has quit
      • bitmap
        when do you use the N/A gender btw? non-person characters? (didn't follow the discussion but I assume it doesn't mean agender)
      • reosarevok
        Stuff like companies entered as Other
      • Possibly also characters for which gender doesn't apply at all, yes
      • bitmap: "/account/subscriptions/${entityType}/remove?id=${entity.id}" - huh, is $ then better than having ' + whatever + ' ?
      • I don't think I've ever used the $ thing :)
      • bitmap
        not really better, but maybe easier to read in some cases where you have to quote/unquote a lot
      • (to use ${} the string has to be inside `backticks`)
      • reosarevok
        Backticks sound more confusing, I'll stick to + if that's ok :D
      • bitmap
        sure :P
      • chirlu has quit
      • reosarevok
        bitmap: waaait. Is there actually any reason to do all the N_ln thing?
      • Can't we just do There is currently {num} user subscribed to {entity}?
      • I mean, that's going to get replaced anyway...
      • bitmap
        the string is? and not sure re what languages actual use the entity type for context
      • reosarevok
        'There is currently {num} user subscribed to {artist}:',
      • 'There are currently {num} users subscribed to {artist}:',
      • 'There are currently no users subscribed to {artist}.
      • The construction is exactly the same, I'd be very surprised if different languages did it differently depending on if it's artist, series or label...
      • bitmap
        probably true, not sure what you mean by "going to get replaced anyway" though
      • reosarevok
        That it's not printed, it's just a variable name
      • So the printed / translated string is just the same, effectively
      • bitmap
        ah right. (unless it's useful for context, but you're probably right that it's not very useful)
      • can check git grep -3F 'user subscribed to' -- po/*.po I guess
      • the only advantage to not changing the strings then is that we can keep the old translations
      • reosarevok
        I know, but it seems like adding a relatively complicated code bit for that is a bit pointless
      • Finnish does currently do it as "Artist {artist} is being followed by {num} users" etc, but I don't think that's a necessary requirement of Finnish :)
      • Seems to be the only language that makes any difference at all
      • bitmap
        german is slightly different for collection/series too, but yeah
      • reosarevok
        I think we can change it, and if someone complains the translation doesn't work in their language we split it :)
      • bitmap
        sounds good to me
      • reosarevok
        Ok, sent
      • bitmap
        cool, checking the tags one first
      • reosarevok
        (I'm starting to think the layouts *themselves* could be turned into just one but :p)
      • bitmap
        heh, I mean maybe
      • akhilesh has quit
      • code_master5 has quit
      • Dr-Flay joined the channel
      • rdswift has quit
      • Dr-Flay has left the channel
      • nawcom_ has quit
      • nawcom joined the channel
      • nawcom has quit
      • nawcom joined the channel
      • Protab is now known as Rotab
      • rdswift joined the channel