#metabrainz

[listenbrainz-server] paramsingh opened pull request #480: LB-414: Spotify now playing (master...spotify-now-playing) https://git.io/fh0nl

[listenbrainz-server] paramsingh opened pull request #481: Get duration for `duration_ms` for playing_now listens (master...now-playing-durations) https://git.io/fh0c8

[listenbrainz-server] paramsingh opened pull request #482: LB-407: Flake8 errors (master...flake8-errors) https://git.io/fh0cD

[listenbrainz-server] paramsingh opened pull request #483: LB-409: Import correct repository key to fix travis build errors (master...travis-key-errors) https://git.io/fh0cp

[listenbrainz-server] paramsingh opened pull request #484: Only display spotify logo for listens with spotify IDs (master...spotify-logos) https://git.io/fh0C5

[listenbrainz-server] vansika opened pull request #485: LB-406: Stops import if listen count is zero (master...lastfm-imports) https://git.io/fh0No

Hi I am a react developer and I want to contribute to the musicbrainz code , the code is confusing where should I start

hi I am a react developer and want to contribute to the musicbrainz project

where should I start

@/UNIGNORE BestSteve

hi mohn

you could start @https://musicbrainz.org/doc/Development

or https://tickets.metabrainz.org/browse/MBS-9907?...

MBS-9907: New report: Places without coordinates

(tickets labeled "good first bug")

thanks

Is anyone working to improve the musicbrainz website

It's not even responsive

I would like to fix that aspect

Then you might want to start with getting a development server running locally

If you search tickets.metabrainz for "react", you should find a pretty good to-do list :-)

thanks

Maybe ping yvanzo when Europe wakes up

mo''in'

mohn (if you read chatlogs): mobile is not supported yet, that would be very welcome!

chinu (if you read chat logs): probably with https://musicbrainz.org/doc/Development and https://tickets.metabrainz.org/browse/MBS-8609

MBS-8609: Convert templates to React

Mr_Monkey: I have opened 2 issue BB-321 and BB-322. If this issue makes sense then I would love to make PR for this.

BB-321: Begin Date, Begin Area to Born on, Born at https://tickets.metabrainz.org/browse/BB-321

BB-322: flexible input for date of birth https://tickets.metabrainz.org/browse/BB-322

can you please review those mentioned issue :)

bitmap, yvanzo: huh, do we intentionally not translate relationship names? https://beta.musicbrainz.org/report/DeprecatedR...

reosarevok: oh right, relationship type names are missing from pot files

I always thought that was a bug from relationship type documentation pages

RT linking phrases are usually preferred to RT names for data display/edit

Sure, but this is specifically "this is the relationship"

So it makes sense to show the title here (and IMO we should be translating those)

How could I make those translatable?

(also, https://tickets.metabrainz.org/browse/MBS-9990 - wtf :D )

MBS-9990: Make formatUserDate error rather than return wrong date if given object

Yes it makes sense and it should be translatable, just saying it probably appears at specific places only.

Sure :)

So, how do I make something translatable like that? I've never tried yet :)

extract_pot_db needs a fix

like adding 'name' column of 'link_type' table at line #79

Ok, will check :)

thanks!

alastairp: Around?

wow. iliekcomputers. did you sleep at all?

[listenbrainz-server] paramsingh closed pull request #483: LB-409: Import correct repository key to fix travis build errors (master...travis-key-errors) https://git.io/fh0cp

ruaok: slept all afternoon lol

I see. :)

hella productive, my friend.

Yooo :)

Don't burn out / make us look bad!

naw, this isn't burning out, just kicking ass from what I can see. :)

Sure, just making sure he takes rests :p

yeah, him and samj1912 are two very different people.

in a way, both you and iliekcomputers have one thing in common.

inherent slackers. 🤣

We don't listen to you too much?

iliekcomputers still needs to learn that one more.

😂😂

Mr_Monkey: Around?

Hi akhilesh ! Not around for very long, but go ahead !

https://usercontent.irccloud-cdn.com/file/U5vaH... https://usercontent.irccloud-cdn.com/file/tc873... https://usercontent.irccloud-cdn.com/file/6vReL... https://usercontent.irccloud-cdn.com/file/31NhC...

Mr_Monkey: Is anymore changes require?

akhilesh: I suppose those were all easier than the Edition, that's good.

It looks fine to me !

Mr_Monkey: for creator, Is require to change begin date -> birth date and begin area -> birth place ?

akhilesh: kartikpandey2 is already on the case for that one: BB-321

BB-321: Begin Date, Begin Area to Born on, Born at https://tickets.metabrainz.org/browse/BB-321

FWIW: we don't actually show the sort name on MusicBrainz when it's just the same as the main name. But I guess in this case it might make sense, since you have a specific space for it

Also, akhilesh: publisher has Sort Nmae ;)

Good catch, thanks reosarevok

Thanks reosarevok to catch this!

happy birthday chhavi!

reosarevok: I assumed the reason we don't translate them is that they're mostly just used as identifiers (we return them in the web service), so it would be weird if you couldn't find that identifier (as english) in the relationship docs. and since we can't change them, some have weird names (like 'recording of' is performance) so aren't as useful for display. I didn't know we displayed them anywhere

outside the docs

it is also displayed in artist's relationships tab, as group title in the appearances table

indeed

makes sense to translate them and just add a separate row for the english id to the doc page I guess? and maybe have some display string overrides for performance and other edge cases

dear god, we're almost at MBS-10000

congrats

🙃

same as with LB commits number, we shall not accept any further ticket after that

man, our projects are reaching maturity so fast!

surely 10,000 bugs is enough for any project