[picard-plugins] dseomn opened pull request #202: instruments: Add a new plugin to populate an ~instruments tag. (2.0...instruments) https://git.io/fhaOh
2019-01-23 02333, 2019
github has left the channel
2019-01-23 02329, 2019
kepstin
ah, the dream is dead. I can't do oauth login in javascript: "Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://beta.musicbrainz.org/oauth2/token. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing)."
2019-01-23 02326, 2019
kepstin
of course, this seems fixable on the mbz server side :)
2019-01-23 02347, 2019
kepstin
actually, wait, this request *might* work in no-cors mode, let me try that
2019-01-23 02314, 2019
kepstin
oh, wait no. in no-cors mode I can't read the response, so i can't get the token back
I kinda wish I'd taken a look at this earlier, because I suspect I'm gonna run into a few issues trying to get this to work, and it's kind of the last minute before you remove /ws/1 now :)
(you'll want to have the browser console open with persistent logs enabled)
2019-01-23 02322, 2019
kepstin
another thing i'm wondering - once i've done the oauth flow, how do I find out the username of the logged in user? There's no docs under /ws/2 for any user or profile related info
2019-01-23 02337, 2019
kepstin
the oauth docs mention an otherwise undocumented /ws/2/user endpoint, but if I make a call to that with no other parameters, it just hangs until a timeout, then gives a 502 error
2019-01-23 02300, 2019
Leo_Verto_ joined the channel
2019-01-23 02308, 2019
Leo_Verto has quit
2019-01-23 02309, 2019
Leo_Verto_ is now known as Leo_Verto
2019-01-23 02333, 2019
bitmap
kepstin: dang, I'll look into MBS-9993. re getting the user, there is an /oauth2/userinfo endpoint. I'm not aware of a /ws/2/user ever existing, so that's another bug in the docs. :(
goddamn williams is shot, can't even access test.mb right now
2019-01-23 02318, 2019
kepstin
this looks interesting: some folks are working on a doc of best practices for implementing oauth2 flows involving javascript single-page apps like magicisrc: https://tools.ietf.org/html/draft-parecki-oauth-b…
yvanzo, zas: I am getting a URI mismatched error in OAuth signin.
2019-01-23 02349, 2019
amCap1712
I have checked with android and need to set a custom host callback url.
2019-01-23 02352, 2019
amCap1712
I have chosen "musicbrainz://callback"
2019-01-23 02338, 2019
amCap1712
In desktop application I do not get option to set a callback uri and in web application, I need to specify a HTTP or HTTPS url
2019-01-23 02304, 2019
amCap1712
Any suggestions?
2019-01-23 02336, 2019
bitmap
amCap1712: for desktop applications, we support a special redirect uri, 'urn:ietf:wg:oauth:2.0:oob'. it'll present the user with an auth code that they have to manually copy into you app. I'm not sure if there's any better method.
2019-01-23 02350, 2019
amCap1712
bitmap: I know that but it will be upset the user experience. I am trying to find a way around so that user dosen't need to copy the code manually.
2019-01-23 02307, 2019
amCap1712
bitmap: So there is no way to use a custom protocol uri?
2019-01-23 02339, 2019
bitmap
no, I don't believe so
2019-01-23 02315, 2019
amCap1712
bitmap: Ok. I'll try to find a solution on client side
2019-01-23 02330, 2019
michelv joined the channel
2019-01-23 02308, 2019
bitmap
perhaps mbs should check if the return uri protocol is http(s), and if not, show a page where they can click the custom link to return to the app
2019-01-23 02313, 2019
amCap1712
bitmap: it is a possibility
2019-01-23 02333, 2019
amCap1712
actually most vendors check 3 cases, http uri (web), urn:ietf:wg:oauth:2.0:oob (desktop) or custom uri (android and ios platform)
2019-01-23 02342, 2019
MajorLurker joined the channel
2019-01-23 02323, 2019
Major_Lurker has quit
2019-01-23 02303, 2019
outsidecontext joined the channel
2019-01-23 02319, 2019
D4RK-PH0ENiX has quit
2019-01-23 02316, 2019
D4RK-PH0ENiX joined the channel
2019-01-23 02315, 2019
madmouser1 joined the channel
2019-01-23 02337, 2019
D4RK-PH0ENiX has quit
2019-01-23 02321, 2019
D4RK-PH0ENiX joined the channel
2019-01-23 02306, 2019
amCap1712 has quit
2019-01-23 02349, 2019
DjSlash has quit
2019-01-23 02347, 2019
DjSlash joined the channel
2019-01-23 02349, 2019
Nyanko-sensei joined the channel
2019-01-23 02335, 2019
Nyanko-sensei has quit
2019-01-23 02355, 2019
Nyanko-sensei joined the channel
2019-01-23 02348, 2019
D4RK-PH0ENiX has quit
2019-01-23 02359, 2019
CatQuest
amcap: but I haven't a new apk :D (you should link it here in the chat everytime you have one )
2019-01-23 02359, 2019
CatQuest
however not until you've re-written it as part of gsoc perhaps.. it's a complete rewrite so maybe it should have a new name and versioning idk
2019-01-23 02359, 2019
CatQuest
anyway is it possibl to upload things with irccloud ? do you know ruaok iliekcomputers etc? you use irccloud a lot
2019-01-23 02304, 2019
reosarevok
Yes
2019-01-23 02304, 2019
iliekcomputers
CatQuest: yeah, there is an option to upload files
2019-01-23 02342, 2019
CatQuest
then amcap can probably upload the apk-as-you-go to irccloud instead of trying to find a server always (it was google drive before but it was very slow :D)
2019-01-23 02305, 2019
CatQuest
someone can point it to them later
2019-01-23 02311, 2019
CatQuest just woke up
2019-01-23 02330, 2019
CatQuest
hello reosarevok and iliekcomputers 🙋
2019-01-23 02357, 2019
iliekcomputers
Hi CatQuest :)
2019-01-23 02333, 2019
Mr_Monkey
Moin moin !
2019-01-23 02327, 2019
iliekcomputers
Moin!
2019-01-23 02357, 2019
pristine_
Morning :)
2019-01-23 02350, 2019
Mr_Monkey
iliekcomputers: Today I'll endeavour to add React to the listens page. Having a reactive page will be helpful :)
2019-01-23 02315, 2019
Mr_Monkey
It doesn't look all that painful, so hopefully I'll also be able to make some good progress on the UI in general
2019-01-23 02326, 2019
iliekcomputers
Mr_Monkey: that would be great 🤩
2019-01-23 02313, 2019
iliekcomputers
I'll merge pristine_'s PR and hopefully that fixes your and ruaok's build issues.
2019-01-23 02345, 2019
ruaok
\ø/
2019-01-23 02357, 2019
ruaok
moooin
2019-01-23 02305, 2019
iliekcomputers
Moin!
2019-01-23 02316, 2019
ruaok
I was happy to see the fix for that mysterious issue come in.
2019-01-23 02339, 2019
zas
Mooin
2019-01-23 02343, 2019
ruaok
thanks for that pristine_
2019-01-23 02310, 2019
ruaok
hola zas, hace muy frío aquí!
2019-01-23 02334, 2019
pristine_
You're welcome ruaok :)
2019-01-23 02334, 2019
ruaok
and I'm going to continue working with Mr_Monkey on the work from yesterday and at the same time help you release LB.
2019-01-23 02301, 2019
ruaok
unless you want to keep hacking and release mañana. :)
2019-01-23 02307, 2019
iliekcomputers
B
2019-01-23 02348, 2019
kartikeyaSh joined the channel
2019-01-23 02306, 2019
ruaok
C++
2019-01-23 02310, 2019
akhilesh
Mr_Monkey: Hi.., I made 3 changes in eslintrc file, Please see and reply. Is these changes tolerable to you? 1. Increase function paths count, 2. Increase max length of line up to 150. 3. Allow inline comment. See at https://github.com/bookbrainz/bookbrainz-site/pul…
2019-01-23 02325, 2019
github joined the channel
2019-01-23 02325, 2019
github
[listenbrainz-server] paramsingh closed pull request #495: Fix Werkzeug TypeError: '<' not supported between instances of 'str' and 'int (master...Werkzeug-TypeError) https://git.io/fh2yz
2019-01-23 02325, 2019
github has left the channel
2019-01-23 02327, 2019
iliekcomputers
ruaok: Mr_Monkey: merged.
2019-01-23 02347, 2019
ruaok
yay
2019-01-23 02346, 2019
amCap1712 joined the channel
2019-01-23 02358, 2019
amCap1712
hi all
2019-01-23 02317, 2019
ruaok
iliekcomputers: merged into master? web-sockets?
2019-01-23 02343, 2019
iliekcomputers
merged into master, want me to rebase web-sockets once?
2019-01-23 02346, 2019
iliekcomputers
amCap1712: hi!
2019-01-23 02356, 2019
amCap1712
I have an idea. I can upload the apk in alpha testing to play store in my personal account and then push changes to it. This way those who want to test can download from play store and i will push updates to it directly. I can also limit the visibility of the app to specific users. Is it ok?
2019-01-23 02323, 2019
ruaok
iliekcomputers: sure.
2019-01-23 02310, 2019
amCap1712
CatQuest: ^^
2019-01-23 02344, 2019
ruaok
amCap1712: sounds good to me.
2019-01-23 02323, 2019
amCap1712
ok , i'll set it up. It will take a couple of daya to set up. I'll notify when ready.
2019-01-23 02301, 2019
Nyanko-sensei has quit
2019-01-23 02349, 2019
amCap1712
bitmap, zas: is it worth to allow custom redirdcts uri in oauth in future?
2019-01-23 02312, 2019
D4RK-PH0ENiX joined the channel
2019-01-23 02347, 2019
Gazooo joined the channel
2019-01-23 02301, 2019
amCap1712 has quit
2019-01-23 02327, 2019
amCap1712 joined the channel
2019-01-23 02305, 2019
amCap1712 has quit
2019-01-23 02334, 2019
iliekcomputers got some data sent to the listens page
2019-01-23 02336, 2019
iliekcomputers
🎉
2019-01-23 02344, 2019
iliekcomputers
some actual listen data.
2019-01-23 02344, 2019
github joined the channel
2019-01-23 02344, 2019
github
[listenbrainz-server] paramsingh opened pull request #496: Submit data coming from RMQ to the socketio server (web-sockets...submit-listens-to-socket-server) https://git.io/fhaoy
2019-01-23 02344, 2019
github has left the channel
2019-01-23 02320, 2019
travis-ci joined the channel
2019-01-23 02321, 2019
travis-ci
metabrainz/picard#4220 (master - df3f3b2 : Laurent Monin): The build passed.
