#metabrainz

[picard-plugins] dseomn opened pull request #202: instruments: Add a new plugin to populate an ~instruments tag. (2.0...instruments) https://git.io/fhaOh

ah, the dream is dead. I can't do oauth login in javascript: "Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://beta.musicbrainz.org/oauth2/token. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing)."

of course, this seems fixable on the mbz server side :)

actually, wait, this request *might* work in no-cors mode, let me try that

oh, wait no. in no-cors mode I can't read the response, so i can't get the token back

:/

MBS-9993

MBS-9993: MusicBrainz server should allow CORS requests to /oauth/token https://tickets.metabrainz.org/browse/MBS-9993

I kinda wish I'd taken a look at this earlier, because I suspect I'm gonna run into a few issues trying to get this to work, and it's kind of the last minute before you remove /ws/1 now :)

if anyone's curious about what I've got so far, I put it up at https://magicisrc-beta.kepstin.ca/

(you'll want to have the browser console open with persistent logs enabled)

another thing i'm wondering - once i've done the oauth flow, how do I find out the username of the logged in user? There's no docs under /ws/2 for any user or profile related info

the oauth docs mention an otherwise undocumented /ws/2/user endpoint, but if I make a call to that with no other parameters, it just hangs until a timeout, then gives a 502 error

kepstin: dang, I'll look into MBS-9993. re getting the user, there is an /oauth2/userinfo endpoint. I'm not aware of a /ws/2/user ever existing, so that's another bug in the docs. :(

MBS-9993: MusicBrainz server should allow CORS requests to /oauth/token https://tickets.metabrainz.org/browse/MBS-9993

goddamn williams is shot, can't even access test.mb right now

this looks interesting: some folks are working on a doc of best practices for implementing oauth2 flows involving javascript single-page apps like magicisrc: https://tools.ietf.org/html/draft-parecki-oauth...

kepstin: when it's working again, you can check if CORS is working here https://test.musicbrainz.org/

interesting, thanks for the link

json dumps are running on williams rn, so test.mb is comatose atm

they say that for browser based apps, you should implement https://tools.ietf.org/html/rfc7636 as an extra protection for the code

which i think requires both client and server changes

CatQuest: You need to install new apk for that

well, I'll give the test.musicbrainz.org a try tomorrow. g'night.

thanks, nn

yvanzo, zas: I am getting a URI mismatched error in OAuth signin.

I have checked with android and need to set a custom host callback url.

I have chosen "musicbrainz://callback"

In desktop application I do not get option to set a callback uri and in web application, I need to specify a HTTP or HTTPS url

Any suggestions?

amCap1712: for desktop applications, we support a special redirect uri, 'urn:ietf:wg:oauth:2.0:oob'. it'll present the user with an auth code that they have to manually copy into you app. I'm not sure if there's any better method.

bitmap: I know that but it will be upset the user experience. I am trying to find a way around so that user dosen't need to copy the code manually.

bitmap: So there is no way to use a custom protocol uri?

no, I don't believe so

bitmap: Ok. I'll try to find a solution on client side

perhaps mbs should check if the return uri protocol is http(s), and if not, show a page where they can click the custom link to return to the app

bitmap: it is a possibility

actually most vendors check 3 cases, http uri (web), urn:ietf:wg:oauth:2.0:oob (desktop) or custom uri (android and ios platform)

amcap: but I haven't a new apk :D (you should link it here in the chat everytime you have one )

however not until you've re-written it as part of gsoc perhaps.. it's a complete rewrite so maybe it should have a new name and versioning idk

anyway is it possibl to upload things with irccloud ? do you know ruaok iliekcomputers etc? you use irccloud a lot

Yes

CatQuest: yeah, there is an option to upload files

then amcap can probably upload the apk-as-you-go to irccloud instead of trying to find a server always (it was google drive before but it was very slow :D)

someone can point it to them later

hello reosarevok and iliekcomputers 🙋

Hi CatQuest :)

Moin moin !

Moin!

Morning :)

iliekcomputers: Today I'll endeavour to add React to the listens page. Having a reactive page will be helpful :)

It doesn't look all that painful, so hopefully I'll also be able to make some good progress on the UI in general

Mr_Monkey: that would be great 🤩

I'll merge pristine_'s PR and hopefully that fixes your and ruaok's build issues.

\ø/

moooin

Moin!

I was happy to see the fix for that mysterious issue come in.

Mooin

thanks for that pristine_

hola zas, hace muy frío aquí!

You're welcome ruaok :)

and I'm going to continue working with Mr_Monkey on the work from yesterday and at the same time help you release LB.

unless you want to keep hacking and release mañana. :)

B

C++

Mr_Monkey: Hi.., I made 3 changes in eslintrc file, Please see and reply. Is these changes tolerable to you? 1. Increase function paths count, 2. Increase max length of line up to 150. 3. Allow inline comment. See at https://github.com/bookbrainz/bookbrainz-site/p...

[listenbrainz-server] paramsingh closed pull request #495: Fix Werkzeug TypeError: '<' not supported between instances of 'str' and 'int (master...Werkzeug-TypeError) https://git.io/fh2yz

ruaok: Mr_Monkey: merged.

yay

hi all

iliekcomputers: merged into master? web-sockets?

merged into master, want me to rebase web-sockets once?

amCap1712: hi!

I have an idea. I can upload the apk in alpha testing to play store in my personal account and then push changes to it. This way those who want to test can download from play store and i will push updates to it directly. I can also limit the visibility of the app to specific users. Is it ok?

iliekcomputers: sure.

CatQuest: ^^

amCap1712: sounds good to me.

ok , i'll set it up. It will take a couple of daya to set up. I'll notify when ready.

bitmap, zas: is it worth to allow custom redirdcts uri in oauth in future?

🎉

some actual listen data.

[listenbrainz-server] paramsingh opened pull request #496: Submit data coming from RMQ to the socketio server (web-sockets...submit-listens-to-socket-server) https://git.io/fhaoy

metabrainz/picard#4220 (master - df3f3b2 : Laurent Monin): The build passed.

Change view : https://github.com/metabrainz/picard/compare/e4...

Build details : https://travis-ci.org/metabrainz/picard/builds/...