#metabrainz

/

      • zas
        git repo driven
      • deploy on client in few commands
      • can be tune to backup (or exclude) whatever you want
      • Slurpee has quit
      • pristine_
        ruaok: could we talk about spark contributions after the meeting?
      • ruaok
        pristine_: possibly.
      • on the backups...
      • please take a look at the doc and at least jot down what you know of that needs backing up.
      • zas
        for the rest, ask me, it's still evolving, but it runs.
      • ruaok
        then it can be on zas' radar and we can work to implement it.
      • the parts that are not complete yet are backups for postgres and influx.
      • to be completed.
      • fin. freso?
      • zas
        backups will happen every day between 2am UTC & 8am UTC
      • Freso
        And onwards to…
      • amCap1712: Feedback on OAuth login (MusicBrainz for Android)
      • ruaok
        oh sorry zas.
      • zas
        np ;) done
      • amCap1712
        Hi everyone
      • pristine_
        ruaok: okay:)
      • CatQuest
        hi!
      • amCap1712
        I have implemented the OAuth login in the app
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: Feedback on OAuth login (MusicBrainz for Android) (amCap1712), "DR": MBS-9557 - Disallow "special" characters for new accounts (Freso)
      • Here is a demo of how it works
      • CatQuest
        I tried doing this and had soem issues
      • that is why amCap1712 made the video
      • amCap1712
        plz everyone see the video to better understand the issue
      • CatQuest
        you will need to use a browser that will let you use a different app to accept the one url on mb
      • amCap1712 wants to. work on making that fina lstep unecessary but
      • amCap1712?
      • amCap1712
        towards the end of video, after clicking on allow access. the phone will either redirect to default browser or ask for option to go to mb app or browser
      • this hijacks the ux
      • Freso
        That seems fine and how other apps work too?
      • amCap1712
        all other apps use custom uris
      • Freso
        I wouldn't want it to use an in-app browser which doesn't have my saved password.
      • Mr_Monkey
        If I stay logged in, that wouldn't bother me to do once in a while.
      • amCap1712
        that allows automatic redirect
      • To make the last step obsolete, I need to an option to allow custom callback uri
      • Slurpee joined the channel
      • feature addition
      • CatQuest
        my problem was that it didn't get asked to use the "confirm" url in the app, but it simply redirected me to a localhsost page in the browser
      • amCap1712
        MBS-9999
      • BrainzBot
        MBS-9999: Add option for Mobile application while registering applications with MusicBrainz https://tickets.metabrainz.org/browse/MBS-9999
      • amCap1712
        The problem is if a user has set a default browser or click always in the last step, he/she will never be redirected to mb app
      • reosarevok
        The part where you have to "open with Log In" is super weird
      • CatQuest
        yes
      • reosarevok
        That's the one you mean, right?
      • CatQuest
        yes!
      • reosarevok
        If we can avoid that, we should
      • amCap1712
        yes I want to remove it
      • CatQuest nods
      • for that I have been researching for last 3 days
      • Freso
        amCap1712: I'm not sure what kind of feedback you want. :) MBS-9999 should (obviously?) get implemented.
      • yvanzo
        !m amCap1712
      • BrainzBot
        You're doing good work, amCap1712!
      • amCap1712
        Freso: Yes. I mean if anybody has suggestions to implement the login flow otherwise
      • Freso
        I doubt there's another (better) way.
      • Mr_Monkey
        Agreed
      • yvanzo
        That's the usual login flow for other apps?
      • (right?)
      • amCap1712
        The way I proposed. I must say yes
      • Freso
        Yeah.
      • yvanzo
        Then we will follow this, np.
      • amCap1712
        I have read through a dozen other apis of unicorns
      • so yes
      • Till then I can move onto other parts. When MBS-9999 is done, I will come back to this.
      • BrainzBot
        MBS-9999: Add option for Mobile application while registering applications with MusicBrainz https://tickets.metabrainz.org/browse/MBS-9999
      • Freso
        amCap1712: Can you work on other things until this gets fixed in MBS?
      • amCap1712
        Yes
      • Freso
        Perfect. :)
      • I guess that's all for this topic?
      • Mr_Monkey
        !m amCap1712
      • BrainzBot
        You're doing good work, amCap1712!
      • amCap1712
        Thats all.
      • Freso
        Alright!
      • Then we move on to…
      • Freso: "DR": MBS-9557 - Disallow "special" characters for new accounts
      • BrainzBot
        MBS-9557: Disallow "special" characters for new accounts https://tickets.metabrainz.org/browse/MBS-9557
      • CatQuest
        well
      • honestly I think it's kinda fun that we allow just about anything in our usernames
      • but I do understand that this possess a problem. so, how about we grep for a selection of punctuation to find some that is definitely *not* in use by any of our user and then ban such from now on.
      • so that way we can make sure han no users have theri names altered or what
      • Freso
        I noticed an issue with usernames on Discourse a while back and have put this ticket in here a couple of times, but it never really got any response.
      • I noticed earlier this week that now there have also been some username concerns with ListenBrainz URL scheming.
      • code_master5
        Yup, similar ticket for CB!
      • Mr_Monkey
        We're implementing a follow feature and want to be able to pass usernames as url query parameters like this: `follow/user1,user2,user3`
      • michelv has quit
      • Freso
        So maybe it's time to properly consider whether this is something we want to do or not. My immediate proposal, as mentioned on the ticket, is that we prevent new usernames from having whatever set of characters we deem unwanted/problematic, but grandfather old users to let them have it.
      • Mr_Monkey
        Which could be a problem if a user is allowed to be called `user1,user2`
      • CatQuest
        yea
      • Mr_Monkey
        I think that's acceptable
      • CatQuest
        my idea was then to see for some spesific punctiuation that it's sure noone has already
      • Freso
        CatQuest: One of the problematic characters is ` `, which is in use by a good amount of users.
      • CatQuest
        and use that and ban that fro mnow on also
      • yes
      • code_master5
        Mr_Monkey: Usernames can be same for different accounts. Right?
      • Mr_Monkey
        I was under the impression the nales were unique, but I'm not the person to ask
      • names*
      • code_master5
        That is the case with CB though!
      • Freso
        I'm thinking that URL special characters and HTML/XML special characters and Unicode control characters should be not allowed.
      • MB usernames are unique.
      • CatQuest
        ya
      • that was my idea too
      • sorry i pasted it in right away
      • but i think it's best if we find soem that is *not in use*
      • because if not, thne soem user will have a problem and wil ahve to be renamed
      • Freso
        bitmap, yvanzo, ruaok, reosarevok, (alastairp): Thoughts from you?
      • ruaok
        I don't think now is the time to open this can of worms.
      • reosarevok
        Is there a point disabling these for new editors if we don't disable them for old editors?
      • Freso
        I can whip up a list in put it in the ticket if we agree that it's something we want to do at all.
      • reosarevok
        We'll have exactly the same issues
      • CatQuest
        exactly
      • i mena there has got to be soem glyps not in use
      • reosarevok
        If we have a good reason to change them for everyone, I would
      • ruaok
        everyone is busy with other massive projects. soon we will need to move the user/OAuth stuff to the MEB domain and then I think we should address this issue.
      • Freso
        reosarevok: Sure, but we won't have people intentionally making (more) weird usernames to mess with the system.
      • Mr_Monkey
        It'll be harder to create usernames especially to break a new feature
      • ruaok
        we gain nothing by addressing this now, except to dilute our current focus.
      • reosarevok
        Agreed to look at it during MeB migration
      • That's also the ideal point to tell people "during this conversion, we'll ask those of you with these characters to change them" if we want
      • CatQuest
        not a bad compromise maybe
      • Freso
        Alright, I'll leave it hanging for now then.
      • Mr_Monkey
        *backburner*
      • Freso
        That's all for tonight's meeting then!
      • Thank you for your time everyone!
      • </BANG>
      • yvanzo
        Thank you Freso
      • Mr_Monkey
        Thanks Fresh !
      • CatQuest
        thanks Freso
      • code_master5
        🤣
      • amCap1712
        !m Freso
      • BrainzBot
        You're doing good work, Freso!
      • CatQuest
        threso
      • code_master5
        Thanks Freso!
      • TOPIC: MetaBrainz Community and Development channel | MusicBrainz non-development: #musicbrainz | GSoC https://goo.gl/7jsjG2 | Meeting agenda: Reviews
      • yvanzo
        zas: I'd like to update sir/solr soon, can we schedule this?
      • zas
        you mean solr cloud?
      • yvanzo
        as well
      • zas
        tomorrow morning?
      • yvanzo
        ok
      • amCap1712
        yvanzo: what is mb migration? just curious
      • ruaok
        pristine_: let's talk tomorrow, ok?
      • sorry for the delays. :(
      • yvanzo
        amCap1712: meb migration
      • MeB stands for MetaBrainz, while MB stands for Musicbrainz
      • amCap1712
        yeah, a typo
      • yvanzo
        It's about migrating auth from MusicBrainz to MetaBrainz
      • pristine_
        ruaok: sure :) Not a problem at all. The hack day has kept you occupied. I will wait :)