oh, yes current status needs to go into the menu. thanks
2019-01-29 02917, 2019
CatQuest
cool, I've really missed a link to that!
2019-01-29 02924, 2019
Freso
I reckon so that they're more readily available. One click instead of two.
2019-01-29 02936, 2019
ruaok
More visible is the most important.
2019-01-29 02949, 2019
ruaok
we will retain a link in the <user> menu
2019-01-29 02956, 2019
CatQuest
ohh
2019-01-29 02917, 2019
CatQuest
i mena i tihkn of "your listens" is basically "my profile page" wich probably i'd expect to find if i click my name on the sidbar
2019-01-29 02919, 2019
yvanzo
reosarevok: Understood, I mean the test is likely to fail on your PR because of this.
2019-01-29 02904, 2019
yvanzo
You can probably test it with prove -l t/js.t
2019-01-29 02907, 2019
ruaok
I flushed out the <user> menu, which was missing its child items.
2019-01-29 02914, 2019
CatQuest
I mean after logging in, I'm activly looking for "my name" on a sidebar to click to go to *my* profile where i expect osee *my listens*
2019-01-29 02947, 2019
CatQuest
(well unless the login actulaly brings me there already)
2019-01-29 02902, 2019
ruaok
thats not a bad idea, actually.
2019-01-29 02906, 2019
Mr_Monkey
CatQuest: From a user perspective, apart from initial sign-up/account sync,there's not much else to do on LB than look at your or other peoples listens, hence making ing it more prominent
2019-01-29 02926, 2019
CatQuest
and on my profile i expect to see my listen and a big fat button says "import from ...." (that woudl take me directly to the last.fm page or if we in th future have other imports pages)
2019-01-29 02938, 2019
Mr_Monkey
But I'm not opposed to having "your listens" also appear in the user submenu
2019-01-29 02938, 2019
CatQuest
Mr_Monkey: I'm a user
2019-01-29 02945, 2019
CatQuest
and i'm telling oyu *my* expectations
2019-01-29 02905, 2019
CatQuest
that's all :)
2019-01-29 02920, 2019
Mr_Monkey
I like a good debate :)
2019-01-29 02945, 2019
Mr_Monkey
I do think arriving on the listens page after you log in is ideal
2019-01-29 02947, 2019
CatQuest
it's frankly much more.. obvious and clear with a user menu with optinos that are clear and make sence, thna having a "your lsitens" and thne my username with another name and such. having my listens on the front page as a button next to "import" woudl make evne more sence
2019-01-29 02948, 2019
CatQuest
oh i'm liking the way that user menu is looking in the doc now
2019-01-29 02950, 2019
Freso
I'd suggest switching Import and About around. It seems like the most important ones are "your own listens", "everyone else's listens", "import more listens", "contributing in general", and then "more information about the project". OTOH, MB and MeB have About as the left-most item, BB and CB don't have one – LB, MsB, and AB are down (known?) so I can't see how they are currently. So the ones that do have it currently have "About"
2019-01-29 02950, 2019
Freso
all the way to the left, it does feel a bit weird (to me at least) to shift it around here, though I do agree it's not the most important item. 🤔
2019-01-29 02952, 2019
Mr_Monkey also notes using "My listens" instead of "Your listens"
2019-01-29 02959, 2019
CatQuest
yes
2019-01-29 02956, 2019
CatQuest
I also except to see "about" as one of the last if not the rightmost item
2019-01-29 02903, 2019
CatQuest
rightmost i except the user menu
2019-01-29 02940, 2019
CatQuest
general menu left aligned with information and stuff then a right- aligned menu with user stuff
2019-01-29 02951, 2019
CatQuest
what's the diff with "info and listens though?
2019-01-29 02956, 2019
CatQuest
like
2019-01-29 02903, 2019
CatQuest
if it means "edit your profile" yo ushoudl call it profile
2019-01-29 02943, 2019
Mr_Monkey
Noted
2019-01-29 02918, 2019
CatQuest
(personally i dislike ownership pronomen in cases lie kthis (my, your etc ) but that is a personal opinion. it's very clearly and often used so it's probably something peopel will expect )
2019-01-29 02931, 2019
Freso
(Is it known that LB, MsB, and AB are down? I don't see any obvious chatter about it in the backlog.)
[acousticbrainz-server] mayhem opened pull request #317: Point to our own redis service (master...ab-redis) https://git.io/fhXgD
2019-01-29 02928, 2019
github has left the channel
2019-01-29 02903, 2019
ruaok
alastairp: That will come in docker-service configs that zas is currently working on.
2019-01-29 02907, 2019
alastairp
nice
2019-01-29 02907, 2019
ruaok
ok to merge then?
2019-01-29 02928, 2019
alastairp
yes
2019-01-29 02932, 2019
ruaok
merged. thanks.
2019-01-29 02939, 2019
github joined the channel
2019-01-29 02939, 2019
github
[acousticbrainz-server] mayhem closed pull request #317: Point to our own redis service (master...ab-redis) https://git.io/fhXgD
2019-01-29 02939, 2019
github has left the channel
2019-01-29 02900, 2019
alastairp
as an aside, the fact that zas' magic service discovery "just worked" with the wrong data is pretty awesome
2019-01-29 02946, 2019
ruaok
I dont think this was a bug per se, just not a well thought out re-use. :)
2019-01-29 02909, 2019
alastairp
or iliekcomputers missed it when copying the file
2019-01-29 02918, 2019
alastairp
it's OK, we don't keep anything important in the cache
2019-01-29 02933, 2019
ruaok
I'm going to wait for iliekcomputers to deploy this.
2019-01-29 02952, 2019
alastairp
good idea
2019-01-29 02952, 2019
akhilesh joined the channel
2019-01-29 02954, 2019
amCap1712 joined the channel
2019-01-29 02900, 2019
amCap1712
ruaok: do you have time to try recover the google account?
2019-01-29 02917, 2019
ruaok
not currently. I'm double subscribed. gimme a bit.
2019-01-29 02938, 2019
amCap1712
ok. ping me when get time.
2019-01-29 02922, 2019
ruaok
Mr_Monkey: queremos ir por un poquito de comida?
2019-01-29 02911, 2019
Mr_Monkey
ruaok: con placer
2019-01-29 02943, 2019
kartikpandey2 joined the channel
2019-01-29 02957, 2019
outsidecontext
zas: I get the same error here on my mac when trying to install PyInstaller 3.4. not really sure which part changed, there hasn't been a change to pyinstaller. maybe a pip bug? I'll try to find out
I think this PR require little more attention for review.
2019-01-29 02946, 2019
Mr_Monkey
Nice, thanks. I'll test it out and review within the next few days. Another good feature !
2019-01-29 02953, 2019
Mr_Monkey
akhilesh: ^^
2019-01-29 02939, 2019
Mr_Monkey
ruaok: LGTM.
2019-01-29 02944, 2019
ruaok
thx
2019-01-29 02929, 2019
madmouser1 joined the channel
2019-01-29 02941, 2019
jket joined the channel
2019-01-29 02913, 2019
github joined the channel
2019-01-29 02913, 2019
github
[listenbrainz-server] mayhem opened pull request #501: Revamp how the menus are organized. (listen-page-player...listen-page-player-navbar-revamp) https://git.io/fhXDD
