oh, yes current status needs to go into the menu. thanks
CatQuest
cool, I've really missed a link to that!
Freso
I reckon so that they're more readily available. One click instead of two.
ruaok
More visible is the most important.
we will retain a link in the <user> menu
CatQuest
ohh
i mena i tihkn of "your listens" is basically "my profile page" wich probably i'd expect to find if i click my name on the sidbar
yvanzo
reosarevok: Understood, I mean the test is likely to fail on your PR because of this.
You can probably test it with prove -l t/js.t
ruaok
I flushed out the <user> menu, which was missing its child items.
CatQuest
I mean after logging in, I'm activly looking for "my name" on a sidebar to click to go to *my* profile where i expect osee *my listens*
(well unless the login actulaly brings me there already)
ruaok
thats not a bad idea, actually.
Mr_Monkey
CatQuest: From a user perspective, apart from initial sign-up/account sync,there's not much else to do on LB than look at your or other peoples listens, hence making ing it more prominent
CatQuest
and on my profile i expect to see my listen and a big fat button says "import from ...." (that woudl take me directly to the last.fm page or if we in th future have other imports pages)
Mr_Monkey
But I'm not opposed to having "your listens" also appear in the user submenu
CatQuest
Mr_Monkey: I'm a user
and i'm telling oyu *my* expectations
that's all :)
Mr_Monkey
I like a good debate :)
I do think arriving on the listens page after you log in is ideal
CatQuest
it's frankly much more.. obvious and clear with a user menu with optinos that are clear and make sence, thna having a "your lsitens" and thne my username with another name and such. having my listens on the front page as a button next to "import" woudl make evne more sence
oh i'm liking the way that user menu is looking in the doc now
Freso
I'd suggest switching Import and About around. It seems like the most important ones are "your own listens", "everyone else's listens", "import more listens", "contributing in general", and then "more information about the project". OTOH, MB and MeB have About as the left-most item, BB and CB don't have one – LB, MsB, and AB are down (known?) so I can't see how they are currently. So the ones that do have it currently have "About"
all the way to the left, it does feel a bit weird (to me at least) to shift it around here, though I do agree it's not the most important item. 🤔
Mr_Monkey also notes using "My listens" instead of "Your listens"
CatQuest
yes
I also except to see "about" as one of the last if not the rightmost item
rightmost i except the user menu
general menu left aligned with information and stuff then a right- aligned menu with user stuff
what's the diff with "info and listens though?
like
if it means "edit your profile" yo ushoudl call it profile
Mr_Monkey
Noted
CatQuest
(personally i dislike ownership pronomen in cases lie kthis (my, your etc ) but that is a personal opinion. it's very clearly and often used so it's probably something peopel will expect )
Freso
(Is it known that LB, MsB, and AB are down? I don't see any obvious chatter about it in the backlog.)
[acousticbrainz-server] mayhem opened pull request #317: Point to our own redis service (master...ab-redis) https://git.io/fhXgD
github has left the channel
ruaok
alastairp: That will come in docker-service configs that zas is currently working on.
alastairp
nice
ruaok
ok to merge then?
alastairp
yes
ruaok
merged. thanks.
github joined the channel
github
[acousticbrainz-server] mayhem closed pull request #317: Point to our own redis service (master...ab-redis) https://git.io/fhXgD
github has left the channel
alastairp
as an aside, the fact that zas' magic service discovery "just worked" with the wrong data is pretty awesome
ruaok
I dont think this was a bug per se, just not a well thought out re-use. :)
alastairp
or iliekcomputers missed it when copying the file
it's OK, we don't keep anything important in the cache
ruaok
I'm going to wait for iliekcomputers to deploy this.
alastairp
good idea
akhilesh joined the channel
amCap1712 joined the channel
amCap1712
ruaok: do you have time to try recover the google account?
ruaok
not currently. I'm double subscribed. gimme a bit.
amCap1712
ok. ping me when get time.
ruaok
Mr_Monkey: queremos ir por un poquito de comida?
Mr_Monkey
ruaok: con placer
kartikpandey2 joined the channel
outsidecontext
zas: I get the same error here on my mac when trying to install PyInstaller 3.4. not really sure which part changed, there hasn't been a change to pyinstaller. maybe a pip bug? I'll try to find out
I think this PR require little more attention for review.
Mr_Monkey
Nice, thanks. I'll test it out and review within the next few days. Another good feature !
akhilesh: ^^
ruaok: LGTM.
ruaok
thx
madmouser1 joined the channel
jket joined the channel
github joined the channel
github
[listenbrainz-server] mayhem opened pull request #501: Revamp how the menus are organized. (listen-page-player...listen-page-player-navbar-revamp) https://git.io/fhXDD