CatQuest: nothing abnormal on our side afaik, regarding community.mb.o
2019-02-21 05227, 2019
zas
outsidecontext: there's no urge, if you think you can provide a fix, please do. It's a long-standing issue and users will be happy if it is fixed.
2019-02-21 05231, 2019
ruaok
zas: then why do you keep pressing me about it?
2019-02-21 05217, 2019
zas
ruaok: i don't ;) (or it wasn't my intention at all)
2019-02-21 05239, 2019
ruaok
ok. :)
2019-02-21 05218, 2019
zas
outsidecontext: i'll make a blog post announcing imminent release, asking translators to update
2019-02-21 05254, 2019
pulkit6559 has quit
2019-02-21 05213, 2019
zas
alastairp: about jenkins, i didn't deploy it, i think it was gentlecat, and i don't know much about it. I just discovered dockerized jenkins is running docker... (containers running containers running containers... where are we going...)
2019-02-21 05235, 2019
zas
alastairp: what do you need exactly?
2019-02-21 05238, 2019
alastairp
yes, I remember talking with him about it when it was set up
2019-02-21 05216, 2019
alastairp
zas: we're using a feature in docker-compose.yml which requires a newer version of docker than that which is installed in the current image
2019-02-21 05249, 2019
alastairp
however, because it's connecting to the docker server on williams (via a volume docker.sock), we're actually acting with a more recent version of docker
2019-02-21 05224, 2019
alastairp
so the only recommendation that I have is to update the docker client in the jenkins container some time for compatibility reasons (my PR), I expect that everything should continue working fine
2019-02-21 05218, 2019
Leo_Verto has quit
2019-02-21 05224, 2019
pulkit6559 joined the channel
2019-02-21 05247, 2019
Leo_Verto joined the channel
2019-02-21 05227, 2019
bitmap has quit
2019-02-21 05250, 2019
bitmap joined the channel
2019-02-21 05203, 2019
reosarevok
Hey ruaok, come on, zas has the right to a free press
2019-02-21 05212, 2019
Leo_Verto has quit
2019-02-21 05241, 2019
Leo_Verto joined the channel
2019-02-21 05218, 2019
alastairp
Mr_Monkey: hello?
2019-02-21 05227, 2019
Mr_Monkey
Howdy alastairp
2019-02-21 05241, 2019
alastairp
remind me again, you showed me how to set dev mode _and_ set the env variable when building webpack?
2019-02-21 05222, 2019
alastairp
I have to do both, right?
2019-02-21 05216, 2019
Mr_Monkey
Right. Here's what we now do on LB, a combination of two things:
> invariant.js:39 Uncaught Invariant Violation: Objects are not valid as a React child (found: object with keys {error, success}).
2019-02-21 05203, 2019
alastairp
which I'm not surprised by, but this code was before my time. I'm sure all I need to do is dereference something, right?
2019-02-21 05247, 2019
michelv has quit
2019-02-21 05218, 2019
alastairp
so, I fixed it by printing out {this.state.errorMsg.error} instead, but that seems a bit sketchy, what if by some unknown error, this json no longer has a 'error' key? Can I catch this?
2019-02-21 05227, 2019
alastairp
I guess it's just clear that I don't understand jsx :)
2019-02-21 05207, 2019
Leo_Verto has quit
2019-02-21 05214, 2019
Leo_Verto joined the channel
2019-02-21 05251, 2019
Mr_Monkey
Woop, just saw this. Let me see…
2019-02-21 05213, 2019
Mr_Monkey
alastairp: You can do this: `{ this.state.errorMsg && this.state.errorMsg.error }
2019-02-21 05239, 2019
Mr_Monkey
if `.error`is undefined, it won't create any node there.
2019-02-21 05229, 2019
Mr_Monkey
Also we want to make sure `errorMsg`is defined, otherwise calling `errorMsg.error` will throw.
2019-02-21 05226, 2019
Mr_Monkey
I it grows from there and becomes more complexe, create a getter in your class that will return the right sub-property or null.
2019-02-21 05256, 2019
Mr_Monkey
For now, I think you could wrap the entire `<p>` tag like this `{this.state.errorMsg && <p ...` and in it use `{this.state.errorMsg.error }` directly
2019-02-21 05223, 2019
Dr-Flay joined the channel
2019-02-21 05228, 2019
CatQuest
[19:21] <reosarevok> Hey ruaok, come on, zas has the right to a free press
2019-02-21 05228, 2019
CatQuest
🤣
2019-02-21 05249, 2019
Dr-Flay has left the channel
2019-02-21 05225, 2019
bitmap
alastairp: would 18.06.0-ce work? I could update to that inside the image
2019-02-21 05221, 2019
bitmap
oh I guess you already mentioned it is (it's the same version running on the host)
2019-02-21 05232, 2019
alastairp
bitmap: the jenkins container uses alpine, not ubuntu
2019-02-21 05247, 2019
alastairp
but it looks like they have pretty good forward/backward compatibility between the api
2019-02-21 05200, 2019
alastairp
(see for example us using client v 1.12 and server v 1.43242 or somethign
2019-02-21 05216, 2019
pristine_ has quit
2019-02-21 05219, 2019
alastairp
Mr_Monkey: thanks :)
2019-02-21 05227, 2019
alastairp
I fixed it, I'm going to make a PR and tag you to review it
