[Bookbrainz] I was trying to build the website using docker but its giving the error fs.js not found, which auto closes the container, any help would be appreciated as i was looking forward to contrinute to the project
Mr_Monkey: technically, in your case, it's because you decided to move to Spain and not, like, the UK :p
rihan_
Mr_Monkey: I am interested in undertaking 'Solr search engine' project under gsoc 2019! I have previous experience on nodejs/expressjs/mongodb but not with elasticsearch/solr. Any thoughts/suggestions ?
Mr_Monkey
reosarevok: True :D . Although the same thing happened to France during German occupation, moved to GMT+2 for a while.
rihan_: I think that might be a hard uphill battle. I don't know much about Solr but it seemed to me to be a complicated project to set up properly.
Can I get a second opinion from someone?
In any case, I think the first step would be to read some Solr intros and docs
amCap1712
gr0uch0mars: yes
gr0uch0mars
hi. Yesterday I tried with the code and didn't make it work
amCap1712
the latest commit
in which I create new live data in the repository method
itworked
but I really feel its entirely forfeits the purpose of reactive programming
I found something on the internet to notify observer when a field in live data changes
a custom implementation of live data like singleLiveEvent
gr0uch0mars
yes, and I thought that maybe we could structure in some other way. I think there must be another (easier) way
amCap1712
yes there should be. its not that an obscure case. someone might have encountered it before
the thing is I couldn't any SO post on it.
gr0uch0mars
I thought of another workflow while reading on the internet. Something like I'm doing with Rx in Flutter. That may work…
reosarevok
Mr_Monkey: would samj1912 be able to mentor such a thing (or at least co-mentor)?
gr0uch0mars
If not, let's post a SO question. Maybe someone has encountered the same problem
Mr_Monkey
reosarevok: We approached the subject and he was receptive to it. I need to chase him down.
amCap1712
ok lets discuss your workflow, then we'll ask a question if it dosen't?
samj1912
Ssup?
Mr_Monkey
Hiya !
gr0uch0mars
amCap1712: Please take a look at this thread I've created to discuss this very specific topic. I thought it would be a good idea to share everything we find there: https://community.metabrainz.org/t/android-app-...
samj1912: We talked previously about you helping out to mentor a GSOC project to move BookBrainz to use Solr instead of ElasticSearch. Would you still be open to it?
samj1912
I can help, but I would mostly be able to do so during weekends
amCap1712
gr0uch0mars: yeah, sure.
i have a question. we are using a viewpager. so extra fragments are loaded off screen. That shouldn't be a problem right?
Mr_Monkey
Thanks samj1912 ! I think that would be fine.
rihan_
Mr_Monkey: Alright. I will do some reading on Solr. Btw, I came across a post from last year gsoc 2018 here https://community.metabrainz.org/t/gsoc-2018-we.... You are repeating the project for this year as well ?
hmm never worked with viewpager, so I hadn't thought about that problem :(
Mr_Monkey
That's correct amCap1712 and rihan_
amCap1712
gr0uch0mars: ok lets try this out first
gr0uch0mars: the only problem is the onResume gets called even when we are off screen. though I found a solution to it.
create a custom page listener.
rihan_
amCap1712: is the same person interested in undertaking this project this year ?
amCap1712
rihan_: I don't know :D
samj1912
Mr_Monkey: it might be an uphill battle if they have very little experience with solr. Not sure if it would be doable in a single gsoc season.
gr0uch0mars
maybe, to exclude ViewPager from the equation, we could try a simple example with a raw activity/fragment. And investigate from easiest to hardes
amCap1712
I'm a student and GSoC aspirant too rihan_ :) .
rihan_
amCap1712: cool to hear that!
michelv has quit
amCap1712
yes gr0uch0mars thats probably the best. we can then be clear at debugging
Mr_Monkey
Thanks samj1912 I suspected so. I had a hard time wrapping my head around all the moving parts during the summit.
reosarevok
samj1912: how much of the MB setup can just be shamelessly copied? :p
samj1912
reosarevok: the problem is AFAIR BB doesn't have an api
That might also be a blessing though
We can directly use the solr json writer instead of writing our own writer
That might simplify a lot of things
But the last time we met, this wasn't decided
lollet joined the channel
amCap1712
gr0uch0mars: so lets start. Where to begin with?
Mr_Monkey
samj1912: Woudl you have some time to discuss this with me this week-end?
lollet has quit
rihan_
samj1912: Thanks for the info on Solr project. Basically, I am interested in that project but I dont have upfront knowledge about it.
samj1912
Sure, I can do Sunday if you are available
Mr_Monkey
Yes, Sunday's good. Any preferred time?
gr0uch0mars
amCap1712: have you read the thread? If so, I though of creating a new activity that will be the new ARtist Detail (without ViewPager, just some field to show Artist Name/ Birth date, for example) and a List below (releases). What do you think? Would it be an easy example?
samj1912
12 ish Barcelona time?
In the afternoon
amCap1712
gr0uch0mars: How about moving just moving the release fragment to below artist info?
gr0uch0mars
yes, that would be fine too
let's keep it easy at first
amCap1712
the viewpager gets removed and the fragment lifecycle isn't effected
Mr_Monkey
samj1912 12-ish is indeed "Barcelona time" :+1:
rihan_
Mr_Monkey: is the same person interested in implementing the 'web API project' from last gsoc 2018 ?
Mr_Monkey
rihan_: I haven't had news about that. If you want to start a plan for that go right ahead
I read it yesterday. I looks relevant, as it fetches de ViewModel in the adapter. But I wanted to try something “bigger”: to not need it in the adapter, and pass the final/updated list to it.
Anyway, I'll paste it on the thread, to collect references for future information.
amCap1712
ok. I couldn't understand much of the code in the post as I was overwhelmed with Kotlin :)
gr0uch0mars
heheh the opposit for me with Java LOL
Kotlin is more natural for me, like Swift, JS…
(If I had time, I would like to make a clone of the app in Kotlin, so you can compare and see if it looks more readable)
amCap1712
Java is my first language. thats why
rihan_
Mr_Monkey: okay! I will start my plan on that project.
amCap1712
but definitely kotlin is more readable
i'll learn that side by side. and later we can utilize it in the project.
rihan_
samj1912: thats true. I am just curious and looking to explore. I will do a pet project with elasticsearch. Maybe I can make my markdown notes search with elasticsearch :) :p
amCap1712
gr0uch0mars: actually, the problem for us is that
we want to query only viewholder binds a release
so we need to notify the viewmodel of querying
and then the viewmodel should notify the recyclerview of the result
thats a 2 way dependency
rihan_
Mr_Monkey: I need clarification, here is my git log. I have forked your the BB project. I have 2 remotes setup 1. origin -> points to upstream official BB 2. fork -> points to upstream fork. The latest commit is the merge commit PR and the 2nd one is also the same. should I combine them both ? is my git setup right ? here's the gist to git log
amCap1712: something like if viewholder asks the viewModel to update release X with its cover art --> viewModel re-emits the same release list (but that release item will have URL info) --> notifies the recyclerview -> viewholder now binds an item that has URL inside on it!
rihan_
the 2nd commit is the fast-forward merge into local master from my topic-branch(update-readme) to issue the PR.
