(dammit, my Cyrillic M can't be told apart from a normal M :p )
2019-03-08 06711, 2019
reosarevok
(well I tried!)
2019-03-08 06723, 2019
ruaok
heh
2019-03-08 06739, 2019
amCap1712
we could use a List<Pair<Release,Url>>
2019-03-08 06712, 2019
amCap1712
and check if the url is not empty, query the url, otherwise hide the ImaeView
2019-03-08 06718, 2019
amCap1712
what say gr0uch0mars
2019-03-08 06731, 2019
amCap1712
moin ruaok
2019-03-08 06759, 2019
gr0uch0mars
well, that could work too
2019-03-08 06702, 2019
Gazooo has quit
2019-03-08 06707, 2019
gr0uch0mars
I was thiking about inserting the URL inside the Release because I was already thinking of a future cache, where it would be a simple Room query of a release, and the result would be a Release with URL already inside. But that DB/cache response could be mapped to `Pair<Release,Url>`
2019-03-08 06735, 2019
Mr_Monkey
rihan_: I'm a bit confused with your remotes. In theory, 'origin' should point to your fork, and 'upstream' should point to the original repo. Then you can do `git fetch upstream && git pull upstream master` which will pull the commits from upstream into your master branch, then `git push origin HEAD` to push to your repo.
2019-03-08 06702, 2019
Mr_Monkey
But I think if both your trees look the same, you're probably doing it right :)
2019-03-08 06702, 2019
gr0uch0mars
let's focus now on “if I don't have the URL, query it”, no matter how we store for this Rx test. Once we see everything working we focus on organizing it better
2019-03-08 06700, 2019
Gazooo joined the channel
2019-03-08 06711, 2019
amCap1712
yes, fine. I will create a new branch and I'll now move the fragments to the same page and remove the pager.
Mr_Monkey: you are right about the remotes upstream and origins. I just added fork as a remote to my upstream fork. I will change that. What do you think about the commits 4498bddf and 69ee9fc1 ? They are the same right ? just that the former one is a merge commit
2019-03-08 06701, 2019
Mr_Monkey
Not quite the same, but they should both be there :)
2019-03-08 06702, 2019
gr0uch0mars
great. I think there's too much code from the legacy app that may be complicating this transition to Rx
2019-03-08 06739, 2019
amCap1712
yes, its more of delete old and write new, rather than porting
now, tbh there is more code in the comments than outside it
2019-03-08 06719, 2019
gr0uch0mars
and one of my next proposals will be reorganizing folders: to have everything of an Artist together (Activity, ViewModel, Adapter, RecyclerView…). So we don't have to navigate through folders forth and back. It'll make it simpler
2019-03-08 06723, 2019
travis-ci joined the channel
2019-03-08 06724, 2019
travis-ci
metabrainz/picard#4411 (master - f90718a : Laurent Monin): The build passed.
hmm, I would start with the activity and then move to Fragments (but that's my opinion). If you want to keep Fragments and, if it gets harder, remove them
2019-03-08 06706, 2019
Mr_Monkey
rihan_: Pretty slick, as the author says! Personally I don't bother rewriting my topic branch history if I don't have to, to avoid headaches, but that does mean I have to be more conscious of my individual commits.
2019-03-08 06740, 2019
amCap1712
gr0uch0mars: lets start with an activity
2019-03-08 06758, 2019
gr0uch0mars
👌
2019-03-08 06720, 2019
travis-ci joined the channel
2019-03-08 06721, 2019
travis-ci
metabrainz/picard#4412 (master - 4ba06e8 : Laurent Monin): The build passed.
[Bookbrainz] I am a gsoc aspirant and was interested in the web api project. I have previously implemented some data retreival apis from mongodb using node/express returned as json, the knowledge of which i think can be used to do this project too. Is returning json kind of the vision you had in mind or you'd prefer something else?
2019-03-08 06728, 2019
Mr_Monkey
ruaok: Possibly an adblocker extension you have?
2019-03-08 06756, 2019
ruaok
I uninstalled ublock origin yesterday, but have pi-hole running on my network now.
2019-03-08 06758, 2019
Mr_Monkey
Hi baniket, welcome !
2019-03-08 06708, 2019
aniket_ joined the channel
2019-03-08 06712, 2019
ruaok
privacy badger. why did it freak out now. sigh.
2019-03-08 06714, 2019
ruaok
thanks! :)
2019-03-08 06737, 2019
aniket_ has quit
2019-03-08 06753, 2019
Mr_Monkey
Phew, NMC (Not My Code) !
2019-03-08 06734, 2019
baniket has quit
2019-03-08 06720, 2019
ruaok
Mr_Monkey: ok, those errors are gone, but the play buttons never appear when I hover over the listens.
2019-03-08 06728, 2019
ruaok
hard reload, check.
2019-03-08 06716, 2019
Mr_Monkey
ruaok: I'm seeing the same, that's a regression. Ticket please :)
hey mr_monkey. So what do you think about the api implementation? Any vision in mind?
2019-03-08 06732, 2019
Mr_Monkey
Hi again :) Yes, the API will be sending out JSON
2019-03-08 06717, 2019
baniket
great!! Is anyone else working on this project already?
2019-03-08 06714, 2019
Mr_Monkey
There has been some interest in the project (I think mainly because there aren't a lot of projects in the ideas page…) but we're still some ways away from any selection.
2019-03-08 06711, 2019
djwhitey_ joined the channel
2019-03-08 06742, 2019
djwhitey has quit
2019-03-08 06725, 2019
baniket
Alright, so do you have any recommendations for the orm we'll have to use?
Sorry, my fault, i wasn't cloning the submodules (Working on a project with submodules for the first time)
2019-03-08 06714, 2019
baniket_ has quit
2019-03-08 06745, 2019
baniket_ joined the channel
2019-03-08 06708, 2019
baniket_ has quit
2019-03-08 06707, 2019
aniket__ has quit
2019-03-08 06708, 2019
pac23 joined the channel
2019-03-08 06725, 2019
ruaok
beta updated, now listening.
2019-03-08 06736, 2019
ruaok
err, skipping Mr_Monkey's loud nonsense.
2019-03-08 06746, 2019
ruaok
finally working. :)
2019-03-08 06705, 2019
pac23
good evening/morning/afternoon folks
2019-03-08 06714, 2019
ruaok
moin moin!
2019-03-08 06723, 2019
ruaok
alastairp: any response from philip yet?
2019-03-08 06741, 2019
CatQuest
(dammit, my Cyrillic M can't be told apart from a normal M :p )
2019-03-08 06741, 2019
CatQuest
I saw the diff :o
2019-03-08 06711, 2019
CatQuest
reosarevok:
2019-03-08 06718, 2019
CatQuest
well i guess you're afk now :(
2019-03-08 06734, 2019
reosarevok
CatQuest: hah, neat
2019-03-08 06743, 2019
reosarevok
ruaok: they're doing work TWICE?
2019-03-08 06746, 2019
reosarevok
That doesn't sound like Spain
2019-03-08 06700, 2019
ruaok
well, that isn't the full story.
2019-03-08 06726, 2019
ruaok
some guy rented the space which is designated as an office, not a dwelling. in order for that to work he had to have lied to the mangement company.
2019-03-08 06746, 2019
ruaok
he got it all setup. then the city rolls in for an inspection and it is clearly a dwelling. he gets tossed.
2019-03-08 06723, 2019
ruaok
then they make noise cleaning up for 2 weeks. and now the tiles that have been put in are the wrong shade of mauve, so they must all get pounded out again.
2019-03-08 06734, 2019
ruaok
does that sound more like spain?
2019-03-08 06740, 2019
ruaok
🤣
2019-03-08 06745, 2019
reosarevok
You got me up to "the city rolls in for an inspection"
