#metabrainz

/

      • reosarevok
        Well
      • 2019-04-08 09833, 2019

      • reosarevok
        # assertEval target="window.document.getElementsByClassName('edit-list').length" value="1" not ok 56 should be equal
      • 2019-04-08 09842, 2019

      • reosarevok
        Sounds like the edit-list hasn't loaded?
      • 2019-04-08 09808, 2019

      • Mr_Monkey
        baniket: I just want to see it first; i'll let you estimate the time you need
      • 2019-04-08 09847, 2019

      • yvanzo
        bitmap: is anything missing for https://github.com/metabrainz/musicbrainz-server/… besides install doc?
      • 2019-04-08 09813, 2019

      • baniket
        Mr_Monkey: okay, Also, the add button in public collections, I had two things in mind, first could be that we just copy the items the original owner of the collection had in his/her collection and create a new collection with a new id for a user that is completely independent from the original collection, i.e. user can add remove items from it later
      • 2019-04-08 09840, 2019

      • bitmap
        yvanzo: I think it's still waiting for search.mb.org/wstest/2 to be finished or deployed
      • 2019-04-08 09851, 2019

      • yvanzo
        oh ok, thanks
      • 2019-04-08 09821, 2019

      • bitmap
        reosarevok: could be that, or an old edit still displaying for some reason, or something else entirely since the logs can be deceiving sometimes
      • 2019-04-08 09837, 2019

      • bitmap
        but I would assume it's just a timing issue too
      • 2019-04-08 09826, 2019

      • baniket
        The second implementation is to have a another column in the collection table, which refers to the collection id of the owner. To put in other words the collection table will have collection_id col and a collection_parent_id. The collection parent id will refer to the collection of the original owner so when the original owner edits his/her collection, the user who added it will automatically get changes in their
      • 2019-04-08 09826, 2019

      • baniket
        collection.
      • 2019-04-08 09825, 2019

      • baniket
        Collection_item table will thus refer to collection_parent_id instead of collection_id
      • 2019-04-08 09820, 2019

      • chhavi_ has quit
      • 2019-04-08 09833, 2019

      • chhavi_ joined the channel
      • 2019-04-08 09848, 2019

      • outsidecontext_ joined the channel
      • 2019-04-08 09827, 2019

      • outsidecontext has quit
      • 2019-04-08 09827, 2019

      • outsidecontext_ is now known as outsidecontext
      • 2019-04-08 09855, 2019

      • moinmoi joined the channel
      • 2019-04-08 09817, 2019

      • reosarevok
        bitmap: I'm a bit confused about the +variable in https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-08 09821, 2019

      • reosarevok
        Can you help? :)
      • 2019-04-08 09857, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #998 (master…MBS-8360): MBS-8360: Add BookBrainz to the sidebar https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-08 09858, 2019

      • BrainzBot
        MBS-8360: Show BookBrainz relationships in the sidebar https://tickets.metabrainz.org/browse/MBS-8360
      • 2019-04-08 09808, 2019

      • bitmap
        those would convert e.g. '5' to 5 so +'5' === 5 in case one's a string and one's an integer for some reason
      • 2019-04-08 09816, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok merged pull request #999 (master…MBS-10101): MBS-10101 / MBS-9082: SecondHandSongs cleanup and autoselect additions https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-08 09818, 2019

      • BrainzBot
        MBS-10101: Allow SecondHandSongs performance URLs for Recordings https://tickets.metabrainz.org/browse/MBS-10101
      • 2019-04-08 09818, 2019

      • BrainzBot
        MBS-9082: Standardize SecondHandSongs URLs https://tickets.metabrainz.org/browse/MBS-9082
      • 2019-04-08 09821, 2019

      • bitmap
        though I don't know if it's needed...
      • 2019-04-08 09844, 2019

      • bitmap
        (I mean if that actually happens, though if it was added it's possible)
      • 2019-04-08 09800, 2019

      • reosarevok
        yvanzo: can we close https://tickets.metabrainz.org/browse/MBS-9082 without the bot being run?
      • 2019-04-08 09804, 2019

      • reosarevok
        Or should we leave it open?
      • 2019-04-08 09825, 2019

      • reosarevok
        bitmap: I guess I'll re-add them then
      • 2019-04-08 09850, 2019

      • bitmap
        alright
      • 2019-04-08 09822, 2019

      • reosarevok
        Done
      • 2019-04-08 09814, 2019

      • yvanzo
        reosarevok: I guess we should have separate task ticket for updating data.
      • 2019-04-08 09843, 2019

      • yvanzo
        reosarevok: Oh wait, we could render SecondHandSongs URLs almost clean already.
      • 2019-04-08 09847, 2019

      • reosarevok
        bitmap: did you see yvanzo's earlier question about the two schema change branches,b tw?
      • 2019-04-08 09803, 2019

      • bitmap
        I didn't, sorry
      • 2019-04-08 09820, 2019

      • Cyna
        bitmap: could you suggest me some tasks I could do as bonus please
      • 2019-04-08 09838, 2019

      • yvanzo
      • 2019-04-08 09823, 2019

      • HorusHorrendus joined the channel
      • 2019-04-08 09844, 2019

      • bitmap
        Cyna: I don't think you need bonus tasks for you proposal (there's enough work already), you just need more details overall. I'm writing a more detailed reply on the forums
      • 2019-04-08 09857, 2019

      • reosarevok
        bitmap: we already had a 2018-q4 branch, apparently
      • 2019-04-08 09807, 2019

      • yvanzo
      • 2019-04-08 09816, 2019

      • bitmap
        oh
      • 2019-04-08 09823, 2019

      • bitmap
        does it have anything in it?
      • 2019-04-08 09829, 2019

      • reosarevok
        yvanzo: is there a point, if they're already being converted?
      • 2019-04-08 09830, 2019

      • Cyna
        great thanks
      • 2019-04-08 09838, 2019

      • bitmap
        looks like it
      • 2019-04-08 09821, 2019

      • bitmap
        it's only 3 commits ahead master with the changes for Figure out what all the files have to be editing or added and also complete setting up my laptop for working during the entire Google Summer of Code period.
      • 2019-04-08 09827, 2019

      • yvanzo
        reosarevok: converted to?
      • 2019-04-08 09830, 2019

      • bitmap
        whoops
      • 2019-04-08 09811, 2019

      • yvanzo
        yeah, fortunately it’s not much :)
      • 2019-04-08 09831, 2019

      • bitmap
        it's only 3 commits ahead master with the changes for MBS-9664
      • 2019-04-08 09832, 2019

      • BrainzBot
        MBS-9664: Add database constraints to disallow loop relationship https://tickets.metabrainz.org/browse/MBS-9664
      • 2019-04-08 09856, 2019

      • bitmap
        so I guess we can just merge that into 2019-q2 and delete this branch
      • 2019-04-08 09801, 2019

      • Gazooo has quit
      • 2019-04-08 09852, 2019

      • Gazooo joined the channel
      • 2019-04-08 09819, 2019

      • Cyna
        whenever I create a React component, how do I write tests for it ? I've writing test cases using Jest
      • 2019-04-08 09822, 2019

      • travis-ci joined the channel
      • 2019-04-08 09822, 2019

      • travis-ci
        Project bookbrainz-data-js build #1014: passed in 1 min 56 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…
      • 2019-04-08 09822, 2019

      • travis-ci has left the channel
      • 2019-04-08 09806, 2019

      • reosarevok
        yvanzo: with FresoBot
      • 2019-04-08 09847, 2019

      • yvanzo
        reosarevok: ooh sorry, it would still help as www. subdomain might not be being converted.
      • 2019-04-08 09807, 2019

      • reosarevok
        Freso: ^ can you check that? :p
      • 2019-04-08 09852, 2019

      • bitmap
        Cyna: I'd prefer we focus on adding Selenium (integration) tests rather than testing individual components, which provides much more limited value
      • 2019-04-08 09804, 2019

      • yvanzo
      • 2019-04-08 09825, 2019

      • akhilesh joined the channel
      • 2019-04-08 09828, 2019

      • bitmap
        Cyna: our Selenium tests are located under t/selenium
      • 2019-04-08 09842, 2019

      • Cyna
        I'll have a look into selenium tests. I havent used selenium befre
      • 2019-04-08 09846, 2019

      • Cyna
        *before
      • 2019-04-08 09855, 2019

      • reosarevok
        Freso: where do I send a PR to also fix secondhandsongs URLs? :p
      • 2019-04-08 09854, 2019

      • Cyna
        I can see only html pages there
      • 2019-04-08 09816, 2019

      • kieto joined the channel
      • 2019-04-08 09806, 2019

      • bitmap
        yep, those are the tests executed by t/selenium.js
      • 2019-04-08 09850, 2019

      • yvanzo
        Freso, reosarevok: added current SHS URLs stats at https://tickets.metabrainz.org/browse/MBS-9082?fo…
      • 2019-04-08 09851, 2019

      • BrainzBot
        MBS-9082: Standardize SecondHandSongs URLs
      • 2019-04-08 09857, 2019

      • akhilesh
        Mr_Monkey: Around?
      • 2019-04-08 09825, 2019

      • rdswift_ joined the channel
      • 2019-04-08 09813, 2019

      • rdswift has quit
      • 2019-04-08 09820, 2019

      • rdswift_ is now known as rdswift
      • 2019-04-08 09854, 2019

      • aliamo joined the channel
      • 2019-04-08 09804, 2019

      • Wizzup has quit
      • 2019-04-08 09811, 2019

      • aliamo has quit
      • 2019-04-08 09850, 2019

      • reosarevok
      • 2019-04-08 09810, 2019

      • reosarevok
        ruaok, iliekcomputers: do we need docs for LB? If so ^
      • 2019-04-08 09817, 2019

      • reosarevok
        alastairp, iliekcomputers: docs for AB? ^
      • 2019-04-08 09829, 2019

      • reosarevok
        yvanzo, bitmap: what do you think we could add for MB?
      • 2019-04-08 09843, 2019

      • Wizzup joined the channel
      • 2019-04-08 09846, 2019

      • reosarevok
        ruaok: does MeB need any further guides on supporting or whatnot?
      • 2019-04-08 09853, 2019

      • reosarevok
        zas: more Picard documentation?
      • 2019-04-08 09800, 2019

      • reosarevok
        Freso: in general, suggestions? :)
      • 2019-04-08 09841, 2019

      • CallerNo6 's ears prick up
      • 2019-04-08 09832, 2019

      • CallerNo6
        I'd love to see better docs on how to use picard scripting.
      • 2019-04-08 09825, 2019

      • rdswift
        ...and plugin development
      • 2019-04-08 09830, 2019

      • CallerNo6
        (since the advice is generally "please follow the style guide; use scripting to tweak your local tags)
      • 2019-04-08 09815, 2019

      • CallerNo6
        reosarevok, does GSoD have any overlap with https://wiki.musicbrainz.org/Development/Summer_o… ?
      • 2019-04-08 09824, 2019

      • CallerNo6 doesn't know how fully-formed the "embed the docs" plan is.
      • 2019-04-08 09819, 2019

      • aliamo joined the channel
      • 2019-04-08 09857, 2019

      • reosarevok
        Not specifically, because we don't know if it will get done - I don't think we've gotten any proposals for that yet? yvanzo or bitmap would know for sure
      • 2019-04-08 09838, 2019

      • aliamo has quit
      • 2019-04-08 09840, 2019

      • reosarevok
        We might of course decide to work on it during the summer ourselves if it's not picked
      • 2019-04-08 09805, 2019

      • yvanzo
        reosarevok, bitmap: Could Selenium (or similar Web browser automation) be used to generate video tutorials?
      • 2019-04-08 09843, 2019

      • rdswift has quit
      • 2019-04-08 09811, 2019

      • Mr_Monkey
        akhilesh: Not around, but ask your question, i'll read it in the morning
      • 2019-04-08 09821, 2019

      • akhilesh
        Mr_Monkey: nothing important, I will comment my query and suggestions at your rename_entity PR.
      • 2019-04-08 09836, 2019

      • Mr_Monkey
        Ok, thanks :)
      • 2019-04-08 09811, 2019

      • CallerNo6
        reosarevok, okay, got it. I've been looking at frameworks. Nothing seems perfect.
      • 2019-04-08 09814, 2019

      • CallerNo6
        (so far)
      • 2019-04-08 09832, 2019

      • aliamo joined the channel
      • 2019-04-08 09858, 2019

      • aidanlw17 joined the channel
      • 2019-04-08 09828, 2019

      • CallerNo6
        I like https://docusaurus.io/ as far as it goes, but would (personally) want "includes" capability. (like wiki transclusion)
      • 2019-04-08 09839, 2019

      • yvanzo
        CallerNo6: if you want to share, please feel free to create a ticket or a wiki page about that
      • 2019-04-08 09843, 2019

      • yvanzo
        or here sure :)
      • 2019-04-08 09802, 2019

      • rdswift joined the channel
      • 2019-04-08 09803, 2019

      • CallerNo6
        yvanzo, which part?
      • 2019-04-08 09833, 2019

      • CallerNo6
        I'm just thinking out loud. Will bring it up in a meeting when I know what my opinion is.
      • 2019-04-08 09852, 2019

      • yvanzo
        doc frameworks IIUC
      • 2019-04-08 09857, 2019

      • yvanzo
        Thanks :)
      • 2019-04-08 09827, 2019

      • CallerNo6
        Would be curious to know, how important is it that it be react-based?
      • 2019-04-08 09841, 2019

      • yvanzo
        It’s not except if we have to code it on our own.
      • 2019-04-08 09831, 2019

      • aliamo has quit
      • 2019-04-08 09808, 2019

      • CallerNo6
        Got it. Presumably a lot of you are also comfortable with jinja2 at this point?
      • 2019-04-08 09856, 2019

      • CallerNo6 is happy to limit his research to react if that simplifies life.
      • 2019-04-08 09856, 2019

      • bitmap
        yvanzo: that's an interesting idea. lack of fluid cursor movement might be visually confusing, but
      • 2019-04-08 09824, 2019

      • CallerNo6
        Is "survey and evaluate doc-generating frameworks" something to make into a ticket?
      • 2019-04-08 09848, 2019

      • bitmap
        reosarevok: development-wise, documentation for the JSON ws is severely lacking, and we don't any info about seeding non-release entities to my knowledge either. unsure about more user-specific docs
      • 2019-04-08 09849, 2019

      • yvanzo
        CallerNo6: that might fit in MBS-1406
      • 2019-04-08 09850, 2019

      • BrainzBot
        MBS-1406: Devise a way to allow translation of documentation https://tickets.metabrainz.org/browse/MBS-1406
      • 2019-04-08 09806, 2019

      • kepstin
        documentation for using oauth with either xml or json api is incomplete or misleading/wrong in places :/
      • 2019-04-08 09837, 2019

      • yvanzo
        reosarevok: would MBS-6516 be an acceptable candidate for GSoD?
      • 2019-04-08 09838, 2019

      • BrainzBot
        MBS-6516: MusicBrainz Programming Guide https://tickets.metabrainz.org/browse/MBS-6516
      • 2019-04-08 09853, 2019

      • yvanzo
        CallerNo6: that’s probably worth a separate ticket though, also related to OTHER-77 btw.
      • 2019-04-08 09854, 2019

      • BrainzBot
        OTHER-77: Unify all markup syntax to simple markdown syntax https://tickets.metabrainz.org/browse/OTHER-77
      • 2019-04-08 09838, 2019

      • CallerNo6
        ^ oh yeah, I always liked that one :-)
      • 2019-04-08 09859, 2019

      • moinmoi has quit
      • 2019-04-08 09826, 2019

      • CallerNo6
        regarding 1406 (doc translation), a lot of frameworks have built-in search/i18n and/or versioning. I'm looking at it with all those in mind.
      • 2019-04-08 09857, 2019

      • aliamo joined the channel
      • 2019-04-08 09828, 2019

      • aliamo has quit
      • 2019-04-08 09842, 2019

      • aliamo joined the channel
      • 2019-04-08 09807, 2019

      • ayerhart has quit
      • 2019-04-08 09808, 2019

      • aliamo has quit
      • 2019-04-08 09847, 2019

      • reosarevok
        yvanzo: I think so? :)
      • 2019-04-08 09856, 2019

      • ayerhart joined the channel
      • 2019-04-08 09823, 2019

      • aliamo joined the channel
      • 2019-04-08 09849, 2019

      • reosarevok
        bitmap: are the changes in https://github.com/metabrainz/musicbrainz-server/… ok now?
      • 2019-04-08 09856, 2019

      • reosarevok is going to bed but feel free to merge if they are
      • 2019-04-08 09806, 2019

      • reosarevok
        Dunno if yvanzo still wants to release beta tonight, but :)
      • 2019-04-08 09830, 2019

      • travis-ci joined the channel
      • 2019-04-08 09831, 2019

      • travis-ci
        Project bookbrainz-data-js build #1015: passed in 1 min 34 sec: https://travis-ci.org/bookbrainz/bookbrainz-data-…