#metabrainz

/

      • Gazooo has quit
      • 2019-04-09 09958, 2019

      • Mr_Monkey
        aidanlw17: Confirmed
      • 2019-04-09 09908, 2019

      • Mr_Monkey
        Oops, lagging :p
      • 2019-04-09 09911, 2019

      • ruaok
        and that was all folks!
      • 2019-04-09 09918, 2019

      • ruaok hits the fail all button and goes home
      • 2019-04-09 09934, 2019

      • Gazooo joined the channel
      • 2019-04-09 09938, 2019

      • code_master5
        Times up! ⚔️
      • 2019-04-09 09941, 2019

      • aidanlw17
        Mr_Monkey: Haha thank you for confirming!
      • 2019-04-09 09951, 2019

      • aliamo has quit
      • 2019-04-09 09901, 2019

      • ruaok
        first time we got a proposal from Nairobi!
      • 2019-04-09 09957, 2019

      • code_master5
        Great! 👏
      • 2019-04-09 09933, 2019

      • anshuman73
        code_master5: Yep ! You too I presume?
      • 2019-04-09 09953, 2019

      • code_master5
        anshuman73: Nope! I'm just a contributor... 😅
      • 2019-04-09 09958, 2019

      • anshuman73
        ah
      • 2019-04-09 09957, 2019

      • code_master5
        Anyways, in that case.. I got someone to `pass on the torch` to ... 🤣
      • 2019-04-09 09912, 2019

      • anshuman73
        looking forward to it :smirk:
      • 2019-04-09 09903, 2019

      • code_master5
        anshuman73: Hey you participated in code-in earlier.. If I remember!?? 🤔
      • 2019-04-09 09915, 2019

      • anshuman73
        code_master5: yep, I did. Worked on CB mostly then too
      • 2019-04-09 09930, 2019

      • code_master5
        Oh! And the results?
      • 2019-04-09 09941, 2019

      • anshuman73
        late 2016, I'm surprised you remember ! Don't remember seeing you around much at that time I think
      • 2019-04-09 09956, 2019

      • anshuman73
        code_master5: I was a winner from MeB :)
      • 2019-04-09 09918, 2019

      • code_master5
        anshuman73: Wow! congrats.. 👏 I'm lates 😅
      • 2019-04-09 09921, 2019

      • code_master5
        *late
      • 2019-04-09 09958, 2019

      • anshuman73
        late as in term of participating for GCI ?
      • 2019-04-09 09914, 2019

      • code_master5
        late for congratulating..
      • 2019-04-09 09950, 2019

      • anshuman73
        code_master5: ah 😂
      • 2019-04-09 09919, 2019

      • anshuman73
        someone found a backdoor for submitting proposals on #gsoc lmao
      • 2019-04-09 09938, 2019

      • code_master5
        anshuman73: In case you thinking how I r emember you,.. actually, I'm a close friend of ferbncode and iliekcomputers ... And I used to have a look at how their work was going on with MeB..
      • 2019-04-09 09939, 2019

      • Gazooo has quit
      • 2019-04-09 09958, 2019

      • code_master5
        So I remember.. they mentioned you quite a few times
      • 2019-04-09 09910, 2019

      • Gazooo joined the channel
      • 2019-04-09 09954, 2019

      • BrainzGit
        [musicbrainz-server] mwiencek merged pull request #1001 (master…mbs-10102): MBS-10102: Artist/label containing country stats https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-09 09955, 2019

      • BrainzBot
        MBS-10102: Artist and label country statistics should count the containing country area if possible https://tickets.metabrainz.org/browse/MBS-10102
      • 2019-04-09 09951, 2019

      • aliamo joined the channel
      • 2019-04-09 09927, 2019

      • rdswift has quit
      • 2019-04-09 09913, 2019

      • rdswift joined the channel
      • 2019-04-09 09909, 2019

      • aliamo has quit
      • 2019-04-09 09921, 2019

      • reosarevok
        yvanzo: beta tonight?
      • 2019-04-09 09956, 2019

      • Gazooo has quit
      • 2019-04-09 09923, 2019

      • Gazooo joined the channel
      • 2019-04-09 09940, 2019

      • Gazooo has quit
      • 2019-04-09 09911, 2019

      • Gazooo joined the channel
      • 2019-04-09 09914, 2019

      • reosarevok
        Also, yvanzo, bitmap: is there a reason we usually merge the PR with an extra commit rather than a rebase?
      • 2019-04-09 09918, 2019

      • bitmap
        I only use squash & merge if there's one commit (or if they're meant to be squashed, like fixup commits)
      • 2019-04-09 09942, 2019

      • bitmap
        if they commits are meant to be separate I use a merge commit
      • 2019-04-09 09946, 2019

      • bitmap
        the*
      • 2019-04-09 09905, 2019

      • aliamo joined the channel
      • 2019-04-09 09955, 2019

      • reosarevok
        Yeah, but github seems to have a third option which if I understood is just "put all these commits in without an extra commit for the PR merge"
      • 2019-04-09 09916, 2019

      • CatQuest
        [13:12] <reosarevok> Ok, subscriptions dealt with. Time to convert more stuff to React
      • 2019-04-09 09917, 2019

      • CatQuest
        [13:12] <reosarevok> Wololo!
      • 2019-04-09 09917, 2019

      • CatQuest
        I Know That Reference!
      • 2019-04-09 09932, 2019

      • reosarevok
        Fiiinally
      • 2019-04-09 09934, 2019

      • bitmap
        ah right
      • 2019-04-09 09941, 2019

      • reosarevok
      • 2019-04-09 09949, 2019

      • reosarevok
        CatQuest: I was hoping someone would get it :p
      • 2019-04-09 09952, 2019

      • bitmap
        I just like having a merge commit since it provides context (links to the PR) and makes it easier to revert if necessary
      • 2019-04-09 09955, 2019

      • reosarevok
        Ok :)
      • 2019-04-09 09938, 2019

      • alastairp
        I like merge commits too
      • 2019-04-09 09908, 2019

      • alastairp
        but if it turns out to be a ff (because there have been no other commits since that PR was started), then I don't force a merge
      • 2019-04-09 09905, 2019

      • alastairp
        and I'll occasionally suggest that a contributor squash some of their PR if there's a stupid number of commits, and we often ask them to rebase agains master if it takes me months and months to get to reviewing it and it potentially has merge conflicts
      • 2019-04-09 09903, 2019

      • reosarevok
        I often rebase against master anyway every time I change something in a PR, even if there's no conflicts, because why not
      • 2019-04-09 09909, 2019

      • reosarevok
        (is there a why not?)
      • 2019-04-09 09941, 2019

      • alastairp
        I guess it makes it more possible that you'll get a ff instead of a merge commit
      • 2019-04-09 09901, 2019

      • rdswift has quit
      • 2019-04-09 09913, 2019

      • alastairp
        a possible why-not is if someone else made a really important change, and they want to deal with any potential merge conflicts themselves because they don't trust you
      • 2019-04-09 09930, 2019

      • alastairp
        (not saying anything about your merging skills there...)
      • 2019-04-09 09948, 2019

      • CatQuest
        wololo! aeeiaaaaoohh, wololo
      • 2019-04-09 09946, 2019

      • reosarevok
        alastairp: haha, I see
      • 2019-04-09 09954, 2019

      • reosarevok
      • 2019-04-09 09914, 2019

      • Cyna
        My proposal is submitted right ?
      • 2019-04-09 09936, 2019

      • alastairp
        reosarevok: another against rebase may be that github could get confused tracking comments and previous edits
      • 2019-04-09 09948, 2019

      • reosarevok
        I haven't had issues so far that I can remember
      • 2019-04-09 09956, 2019

      • alastairp
        yeah, me neither
      • 2019-04-09 09959, 2019

      • rdswift joined the channel
      • 2019-04-09 09958, 2019

      • reosarevok
        rdswift: looking at https://tickets.metabrainz.org/browse/STYLE-1176 - the name seems odd
      • 2019-04-09 09958, 2019

      • Gazooo has quit
      • 2019-04-09 09959, 2019

      • BrainzBot
        STYLE-1176: Add new coverart type "Press Kit"
      • 2019-04-09 09926, 2019

      • Gazooo joined the channel
      • 2019-04-09 09943, 2019

      • reosarevok
        With that name, I'd expect a bunch of materials sent to the press, like a promo CD and an artist bio and some crap
      • 2019-04-09 09949, 2019

      • reosarevok
        Not some high quality images
      • 2019-04-09 09909, 2019

      • aidanlw17 has quit
      • 2019-04-09 09912, 2019

      • reosarevok
        bitmap: how horribly hard would be to do the same for language as we do for instrument, and turn it into its own searchable attribute?
      • 2019-04-09 09933, 2019

      • aliamo has quit
      • 2019-04-09 09905, 2019

      • aliamo joined the channel
      • 2019-04-09 09943, 2019

      • reosarevok
      • 2019-04-09 09944, 2019

      • BrainzBot
        STYLE-1162: Language attribute on (translated) liner notes relationship
      • 2019-04-09 09946, 2019

      • aliamo has quit
      • 2019-04-09 09942, 2019

      • Gazooo has quit
      • 2019-04-09 09956, 2019

      • bitmap
        reosarevok: probably not terribly difficult if we just add a direct search endpoint for it
      • 2019-04-09 09911, 2019

      • Gazooo joined the channel
      • 2019-04-09 09922, 2019

      • alastairp
        ahahah: after our April 1 blog post, https://twitter.com/mozhacks/status/1115649013456…
      • 2019-04-09 09929, 2019

      • alastairp
        "Teaching machines to triage Firefox bugs - meet BugBug - 🐞🐞#machinelearning for a better Bugzilla"
      • 2019-04-09 09938, 2019

      • Gazooo has quit
      • 2019-04-09 09909, 2019

      • Gazooo joined the channel
      • 2019-04-09 09941, 2019

      • aliamo joined the channel
      • 2019-04-09 09942, 2019

      • Gazooo has quit
      • 2019-04-09 09915, 2019

      • Gazooo joined the channel
      • 2019-04-09 09921, 2019

      • aliamo has quit
      • 2019-04-09 09902, 2019

      • Gazooo has quit
      • 2019-04-09 09954, 2019

      • Gazooo joined the channel
      • 2019-04-09 09957, 2019

      • aidanlw17 joined the channel
      • 2019-04-09 09942, 2019

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1003 (master…MBS-9849): MBS-9849: Convert RG index page to React https://github.com/metabrainz/musicbrainz-server/…
      • 2019-04-09 09943, 2019

      • BrainzBot
        MBS-9849: Convert the release group public pages to React https://tickets.metabrainz.org/browse/MBS-9849
      • 2019-04-09 09936, 2019

      • travis-ci joined the channel
      • 2019-04-09 09936, 2019

      • travis-ci
        metabrainz/picard#4625 (master - a1a7965 : Philipp Wolfer): The build passed.
      • 2019-04-09 09936, 2019

      • travis-ci
      • 2019-04-09 09936, 2019

      • travis-ci
      • 2019-04-09 09936, 2019

      • travis-ci has left the channel
      • 2019-04-09 09906, 2019

      • aliamo joined the channel
      • 2019-04-09 09913, 2019

      • aliamo has quit
      • 2019-04-09 09957, 2019

      • aidanlw17 has quit
      • 2019-04-09 09925, 2019

      • reosarevok
        Heh, JSON LD issues. Will have to check that tomorrow then :)
      • 2019-04-09 09925, 2019

      • aidanlw17 joined the channel
      • 2019-04-09 09909, 2019

      • aidanlw17 has quit
      • 2019-04-09 09958, 2019

      • aliamo joined the channel
      • 2019-04-09 09910, 2019

      • aliamo has quit
      • 2019-04-09 09919, 2019

      • aliamo joined the channel
      • 2019-04-09 09904, 2019

      • madmouser1_ has quit
      • 2019-04-09 09932, 2019

      • madmouser1_ joined the channel
      • 2019-04-09 09954, 2019

      • alastairp
        Mr_Monkey: wow, that double ipa really is something
      • 2019-04-09 09913, 2019

      • aidanlw17 joined the channel
      • 2019-04-09 09901, 2019

      • letaiv joined the channel
      • 2019-04-09 09912, 2019

      • ferbncode has quit
      • 2019-04-09 09907, 2019

      • rdswift
        <reosarevok> With that name, I'd expect a bunch of materials sent to the press... Yeah, perhaps not the best name. That's what people called it when it was discussed. I'm okay with a different name. The intent was for things like original digital artwork which may have been used for printing covers and such.
      • 2019-04-09 09950, 2019

      • rdswift
        For example, the original artwork may be square, but was cropped for a gatefold cover or what not. That would currently be disallowed because it didn't exactly match the format of the release. Not sure if it would be accepted as "other".
      • 2019-04-09 09936, 2019

      • letaiv has quit
      • 2019-04-09 09910, 2019

      • code_master5 has quit
      • 2019-04-09 09940, 2019

      • spellew has quit
      • 2019-04-09 09952, 2019

      • akhilesh has quit
      • 2019-04-09 09944, 2019

      • aliamo has quit
      • 2019-04-09 09919, 2019

      • aliamo joined the channel
      • 2019-04-09 09934, 2019

      • antfoo joined the channel
      • 2019-04-09 09919, 2019

      • baniket has quit
      • 2019-04-09 09912, 2019

      • aliamo has quit
      • 2019-04-09 09916, 2019

      • aliamo joined the channel
      • 2019-04-09 09952, 2019

      • Cyna has quit
      • 2019-04-09 09940, 2019

      • aliamo has quit
      • 2019-04-09 09913, 2019

      • aliamo joined the channel
      • 2019-04-09 09920, 2019

      • aliamo has quit
      • 2019-04-09 09939, 2019

      • aliamo joined the channel
      • 2019-04-09 09921, 2019

      • aidanlw17 has quit
      • 2019-04-09 09958, 2019

      • aliamo has quit
      • 2019-04-09 09937, 2019

      • Gazooo has quit
      • 2019-04-09 09911, 2019

      • Gazooo joined the channel
      • 2019-04-09 09911, 2019

      • aliamo joined the channel
      • 2019-04-09 09921, 2019

      • aliamo has quit
      • 2019-04-09 09903, 2019

      • aliamo joined the channel
      • 2019-04-09 09907, 2019

      • aliamo has quit
      • 2019-04-09 09902, 2019

      • aliamo joined the channel
      • 2019-04-09 09926, 2019

      • aliamo has quit