#metabrainz

reosarevok: looks like https://sentry.metabrainz.org/metabrainz/musicb... is from your cjs patch, if you wanna take a look

[musicbrainz-server] mwiencek opened pull request #1035 (schema-change-2019-q2…mbs-5387): MBS-5387: Show edits pending on artist credits https://github.com/metabrainz/musicbrainz-serve...

MBS-5387: ACs being edited aren't marked as having pending edits on the aliases tab https://tickets.metabrainz.org/browse/MBS-5387

yvanzo: your sortable collections stuff depends on the -list.tt conversion prs too, right? can you review/approve those?

reosarevok needs them for his ui work too

bitmap: yes, will do

👍👍

can you also review gh:MBS#1033 which fixes a display bug in beta?

MBS-10136: Properly display descriptions with HTML: https://github.com/metabrainz/musicbrainz-serve...

lgtm

Ok, we are all set to release a new version of MBS today!

I think guess feat. buttons are broken on beta (see the sentry link above) but reo can prob look into that pretty quickly

ferbncode: CB PR merged

i'll deploy once I fix SEC-3 and SEC-4

SEC-3: Upgrade Jinja2 to version 2.10.1 or later. https://tickets.metabrainz.org/browse/SEC-3

SEC-4: Upgrade SQLAlchemy to version 1.3.0 or later https://tickets.metabrainz.org/browse/SEC-4

iliekcomputers: cool, thanks :)

’night!

mo’’in’

Oh no. I knew the feat buttons didn't work.... I just thought it was a userscript!!!!

Will check. And gn bitmap

[musicbrainz-server] reosarevok merged pull request #1033 (beta…MBS-10136): MBS-10136: Properly display descriptions with HTML https://github.com/metabrainz/musicbrainz-serve...

MBS-10136: Beta: relationship descriptions with HTML not expanded in [?] popup https://tickets.metabrainz.org/browse/MBS-10136

yvanzo, bitmap: fixed that actual error (that's easy) but the feat button still doesn't update the actual AC displayed. I can look into that later, breakfast now though.

today and in the weekend it fill finaly rain here!

hasn't rained for a month :(

over a*

I like sun. but tha's not right. epecially this: it's 10 to 17 degrees here ..

it's stil APRIL

mad https://www.yr.no/sted/Norge/Oslo/Oslo/Oslo/met...

[musicbrainz-server] reosarevok opened pull request #1036 (beta…name-guessFeat-function): Name guessFeat function so it can be called in the same file https://github.com/metabrainz/musicbrainz-serve...

yvanzo, bitmap ^ this should fix the new regressions included in beta

There's a related bug in prod, https://tickets.metabrainz.org/browse/MBS-10137 - I'm not sure how to fix that one, so maybe one of you two can look into it eventually

MBS-10137: Guess feat button doesn't change AC on recording pages

But since it's already broken in prod, we don't need to fix it before releasing beta, so yay I guess?

CatQuest: no rain here yet. Just sun, sun, sun forever

yvanzo, bitmap: only that tests are failing, sigh :p

It worked locally, wonder wtf

tests are failing for a good reason, yay!

yvanzo: how did I run a specific js test?

yvanzo: I want to run root/static/scripts/tests/guessFeat.js locally

From the CLI

But https://github.com/reosarevok/musicbrainz-serve... isn't really helping

reosarevok: D:

do you have drought and foresfire warnings?

Not yet

We do get the warnings every summer, but we haven't gotten them so far

yvanzo: seems it passed fine now :p

we are now at orange warning levle :/

level*

eg https://www.yr.no/sted/Norge/Oslo/Oslo/Oslo/tim...

... "Wednesday April 24, 2019 at 1 pm - The father is increasing"

oh no

it's a dadpuns

(faren means both danger and the father)

also wtf translating our 24h clock to am/pm nonnsense

tests are passing, yay!

hi yvanzo !

hi

mooooin!

Mr_Monkey: fancy lunch? I'm finally ready for chinese food. :)

Moin ruaok ! Yeah, I could be tempted. Still @ home currently, but I'll be over @OfficeBrainz before spanish lunchtime

sweet

[bookbrainz-site] MonkeyDo merged pull request #276 (master…hetzner-migration): Consul: Beta and test container configurations https://github.com/bookbrainz/bookbrainz-site/p...

Project bookbrainz-site build #2128: passed in 3 min 44 sec: https://travis-ci.org/bookbrainz/bookbrainz-sit...

yvanzo (and cc: reosarevok): I never received an e-mail about https://tickets.metabrainz.org/browse/PICARD-1506 :( Only saw zas’ response because I checked “manually”.

PICARD-1506: Picard’s tests fail based on configuration in $HOME

hi Freso!

Freso, reosarevok: Ok, I disabled batching email notifications, seems buggy.

hi alastairp!

yvanzo: thanks, let's see how it works :)

iliekcomputers: you'd be very helpful to me if you could look at https://github.com/metabrainz/metabrainz.org/pu...

that lets me get on with my tasks for the afternoon.

" # get rid of some really pesky warning. Remove this in April 2020, when it shouldn't be needed anymore." lol

ruaok: oh i thought i approved it.

Did you make any other changes other than the docstring

Feel free to merge

not really.

thanks!

[metabrainz.org] mayhem merged pull request #319 (master…add-top-token-stats): Add top token stats https://github.com/metabrainz/metabrainz.org/pu...

Question, is MBS-8393 something we can work on after schema change this spring? Or is it not planned for the upcoming schema change?

MBS-8393: Extend dynamic attributes to all entities https://tickets.metabrainz.org/browse/MBS-8393

Lotheric: it's already schema changed

Needs UI, so it can worked on wherever

*whenever

Well, wherever too I guess :p

aah, I saw "schema change" linked to the ticket. Didn't know it was already changed :)

[12:44] <yvanzo> Freso, reosarevok: Ok, I disabled batching email notifications, seems buggy.

:O

(lo y no ping me abotu this :PP)

anyway YES

reosarevok pong

Lotheric: It was part of the last schema change (like… 2 years ago?), but the UI was never finished… :|

yvanzo: Thanks! And yes, let’s. Already one more notifications I should have gotten that I didn’t, but that was a bit too close to when you changed it to say anything definite. I’ll keep an eye out to see how if I miss more mails. :)

We just created an instrument ticket

I am definitly more happy about non-grouped emails from jira

Haven't gotten notified so far

But let's wait a bit

reosarevok: also remember ot edit it

"it"?

The ticket.

The ticket? We should get notified of creation, that's how it used to work

yus

(I assume.)

yes

reosarevok: It also used to work with notifying on edits.

yes isntead of making one

well i got a "reosarevok created a" tambora ticket

notification

Huh, I didn't maybe it's because it was me

But I haven't gotten an email yet

(I used to get them for my own tickets too IIRC)

hmm i don't usualyl get emails for tickets i create myself tho

reosarevok: I mean, you usually don’t get e-mails from changes you make yourself.

Ah.

shrug

Huh, maybe not then.