#metabrainz

Project bookbrainz-data-js build #1038: passed in 2 min 47 sec: https://travis-ci.org/bookbrainz/bookbrainz-dat...

From support@: "This is an awesome project. I use it for educational purposes in my research on software architecture. I just downloaded the server and it worked perfectly out of the box." :)

yvanzo: are you assigned to https://tickets.metabrainz.org/browse/MBS-9762 because you're working on it?

MBS-9762: Songkick URL Cleanup misses URLs with/without artist name

yvanzo: https://github.com/metabrainz/musicbrainz-serve... updated, please check if that's what you wanted before I merge :)

Freso: :D

yvanzo: duh I'm an idiot, thanks for finding what I forgot

Other than that it's fine? If so I'll change those and merge

reosarevok: yup, about TODO notes, I made only one comment but it applies to all

Fair enough

If the TT tag ends by the end of the line, the comment has to be put before the ending mark, e.g. [% Be.hungry() # TODO: eat %]

Yup. Done, should be fine now, feel free to make sure

About Songkick, the only way to avoid duplicates would be to remove the slug from the end of the URL. Would that be alright?

reosarevok: any reason to put comment on pager? # is just for the rest of the line, not for the rest of the tag (except if the whole tag is a comment).

Because it makes it more visible

And the whole thing is converted as one anyway

You can put it on its own line if you prefer, just avoid adding tag markers if possible [% %]

Otherwise you need to scroll to see it, so it's easier to miss

So I'd just leave it on the pager line unless that causes problems

Removing the slug is fine if just the ID works anyway

yvanzo: want me to move the comments or can they stay where they are? :)

(I'm fine with either, just let me know)

Actually nevermind, I'm already having to edit the stuff again because I was stupid, so I might as well move them

reosarevok: found a fatal typo, made a comment about that comments ;)

yvanzo: yeah, that was the "because I was stupid"

I think it should be fine now

[musicbrainz-server] reosarevok merged pull request #970 (master…MBS-10066): MBS-10066: Convert release_groups-list.tt to React https://github.com/metabrainz/musicbrainz-serve...

MBS-10066: Convert release_groups-list.tt to React https://tickets.metabrainz.org/browse/MBS-10066

!m yvanzo

You're doing good work, yvanzo!

lol, it's your good work :)

Rebased https://github.com/metabrainz/musicbrainz-serve...

iliekcomputers, ruaok: is there any way to use ListenBrainz with VLC at the moment?

[musicbrainz-server] anirudhjain75 opened pull request #1049 (master…FormConvert): [WIP] Convert form.tt and edit.tt in admin attributes to React https://github.com/metabrainz/musicbrainz-serve...

Hi reosarevok yvanzo bitmap, Could you check the PR please, currently the forms only work for edit... Will make some changes so it can work for create too. Till then please review the edit form

Project bookbrainz-data-js build #1039: passed in 1 min 39 sec: https://travis-ci.org/bookbrainz/bookbrainz-dat...

[musicbrainz-server] reosarevok opened pull request #1050 (master…MBS-8867): MBS-8867: Don't uppercase "C'mon" https://github.com/metabrainz/musicbrainz-serve...

MBS-8867: Guess Case normalizes "C'mon" as "C'Mon" https://tickets.metabrainz.org/browse/MBS-8867

I'm having problem with Flow Types.. If anyone can help me, it would be great

problem is in form.js in admin attributes

What's the specific problem?

Im having problem with types on Script and Language as they are confusing each other

Confusing each other?

Elements in Language are comparing their types in Script

and vice versa

Oh. You'll probably need bitmap or yvanzo for that, I struggled with something similar recently IIRC

Quickly looking at your form component: I'd expect it'd be simpler to follow if you created three extra components (in the same file) for each form, and just called them from your case, rather than having all forms there

Im trying to figure out the Flow errors

For those, I'd expect something closer to this:

I'm not sure you need string|null, btw - it might be that "null" here is just the empty string and just FieldT<string> is fine

okay

But leave it as is for now

Since I'm not sure :)

bitmap can help later

There is an issue with addColon( ) too

What issue?

It does not return a string type

Then use addColonText IIRC

it returns AnyReactElem

Other forms seem to be using addColonText so yeah, that's probably better

You're doing options={{options: parentOptions}} for the select

Just build a proper options object earlier IMO and pass that, clearer

So

Or something :)

Also, do not hardcode the entityOptions

Do the same as with the other, with options_entity_type

So $form->options_entity_type (no need to pass a model to this one)

[musicbrainz-server] reosarevok opened pull request #1051 (schema-change-2019-q2…MBS-9491-last-updated): MBS-9491: Add last_updated column to genre https://github.com/metabrainz/musicbrainz-serve...

MBS-9491: Move hardcoded genres to a database table https://tickets.metabrainz.org/browse/MBS-9491

yvanzo, bitmap ^ let's try to get this one reviewed and merged today :)

(or not-merged, if you don't think it's a good idea, but either way)

yvanzo: is all your SQL merged by now?

Or do you still have something left to send?

bitmap: let's get https://github.com/metabrainz/musicbrainz-serve... rebased + merged? :)

yvanzo: can you review https://github.com/metabrainz/musicbrainz-serve... today?

Then we can at least try to merge all the SQL tomorrow, and we know *that* at least is done

ohhai bitmap, sneakily grumbling on my PRs before coming here

:p

(on it)

Heh, I also forgot to add that trigger for last_updated of the alias

bitmap: should be good now I think

lgtm

Thanks!

darn Cpanel::JSON::XS issue is failing all my prs again

yvanzo: also this yarn workaround in the dockerfile breaks now ;_; https://gist.github.com/mwiencek/6bc9d801f66983...

was trying to rebuild the -tests image (again) but I think I'll have to remove that line

it doesn't always fail due to "No data," usually it's "Cannot assign requested address"

bitmap: Cannot assign requested address as in pool key server doesn’t respond?