From support@: "This is an awesome project. I use it for educational purposes in my research on software architecture. I just downloaded the server and it worked perfectly out of the box." :)
yvanzo: duh I'm an idiot, thanks for finding what I forgot
2019-05-02 12254, 2019
reosarevok
Other than that it's fine? If so I'll change those and merge
2019-05-02 12250, 2019
yvanzo
reosarevok: yup, about TODO notes, I made only one comment but it applies to all
2019-05-02 12213, 2019
reosarevok
Fair enough
2019-05-02 12203, 2019
yvanzo
If the TT tag ends by the end of the line, the comment has to be put before the ending mark, e.g. [% Be.hungry() # TODO: eat %]
2019-05-02 12226, 2019
reosarevok
Yup. Done, should be fine now, feel free to make sure
2019-05-02 12257, 2019
yvanzo
About Songkick, the only way to avoid duplicates would be to remove the slug from the end of the URL. Would that be alright?
2019-05-02 12243, 2019
yvanzo
reosarevok: any reason to put comment on pager? # is just for the rest of the line, not for the rest of the tag (except if the whole tag is a comment).
2019-05-02 12257, 2019
reosarevok
Because it makes it more visible
2019-05-02 12219, 2019
reosarevok
And the whole thing is converted as one anyway
2019-05-02 12236, 2019
yvanzo
You can put it on its own line if you prefer, just avoid adding tag markers if possible [% %]
2019-05-02 12241, 2019
reosarevok
Otherwise you need to scroll to see it, so it's easier to miss
2019-05-02 12256, 2019
reosarevok
So I'd just leave it on the pager line unless that causes problems
2019-05-02 12208, 2019
reosarevok
Removing the slug is fine if just the ID works anyway
2019-05-02 12207, 2019
reosarevok
yvanzo: want me to move the comments or can they stay where they are? :)
2019-05-02 12215, 2019
reosarevok
(I'm fine with either, just let me know)
2019-05-02 12248, 2019
reosarevok
Actually nevermind, I'm already having to edit the stuff again because I was stupid, so I might as well move them
2019-05-02 12237, 2019
Freso_ joined the channel
2019-05-02 12234, 2019
yvanzo
reosarevok: found a fatal typo, made a comment about that comments ;)
Hi reosarevok yvanzo bitmap, Could you check the PR please, currently the forms only work for edit... Will make some changes so it can work for create too. Till then please review the edit form
I'm having problem with Flow Types.. If anyone can help me, it would be great
2019-05-02 12235, 2019
Cyna
problem is in form.js in admin attributes
2019-05-02 12250, 2019
reosarevok
What's the specific problem?
2019-05-02 12222, 2019
Cyna
Im having problem with types on Script and Language as they are confusing each other
2019-05-02 12241, 2019
reosarevok
Confusing each other?
2019-05-02 12242, 2019
Cyna
Elements in Language are comparing their types in Script
2019-05-02 12247, 2019
Cyna
and vice versa
2019-05-02 12246, 2019
reosarevok
Oh. You'll probably need bitmap or yvanzo for that, I struggled with something similar recently IIRC
2019-05-02 12252, 2019
reosarevok
Quickly looking at your form component: I'd expect it'd be simpler to follow if you created three extra components (in the same file) for each form, and just called them from your case, rather than having all forms there
reosarevok was porting a similar form recently, did it like that: https://github.com/metabrainz/musicbrainz-server/pull/1047/files#diff-3ca82e486fb132e9671b65b1971c037bR29
2019-05-02 12216, 2019
reosarevok
Also, do not hardcode the entityOptions
2019-05-02 12254, 2019
reosarevok
Do the same as with the other, with options_entity_type
2019-05-02 12228, 2019
reosarevok
So $form->options_entity_type (no need to pass a model to this one)
