14:14 PM
kgz joined the channel
2019-05-21 14123, 2019
14:16 PM
kgz has quit
2019-05-21 14137, 2019
14:16 PM
kragniz joined the channel
2019-05-21 14158, 2019
14:18 PM
reosarevok
Whichever way you do it, if we want to display the preview of the edits that will be entered, we will need to convert the edit display templates
2019-05-21 14106, 2019
14:20 PM
kragniz is now known as kgz
2019-05-21 14157, 2019
14:37 PM
antlarr2 is now known as antlarr
2019-05-21 14103, 2019
14:51 PM
Cyna
and display the changes in the edit note section
2019-05-21 14112, 2019
14:51 PM
Cyna
or tab whichever is used
2019-05-21 14143, 2019
14:54 PM
reosarevok
Sure. So please start with the edit templates, which are easier to convert, and many should already be testable in the current release editor :)
2019-05-21 14107, 2019
14:55 PM
reosarevok
(and in any case, for testing, you can just enter the edit locally, then look at the edit history to see how it looks)
2019-05-21 14120, 2019
14:55 PM
reosarevok
(since the template is the same for previewing than displaying the edit later)
2019-05-21 14117, 2019
15:11 PM
Cyna
2019-05-21 14146, 2019
15:16 PM
BrainzGit
2019-05-21 14106, 2019
15:42 PM
spellew
ferbncode: Ok, I'll take a look at it
2019-05-21 14119, 2019
15:55 PM
yvanzo
Cyna: that would be a good start :)
2019-05-21 14109, 2019
16:09 PM
bitmap
Cyna: as we talked about yesterday, root/edit/details/add_remove_alias.tt
2019-05-21 14133, 2019
16:13 PM
Cyna
Ohh... I'm trying to make sense out of the TT file
2019-05-21 14153, 2019
16:13 PM
Cyna
Its difficult to figure out what is happening there
2019-05-21 14143, 2019
16:16 PM
bitmap
anything in particular you find confusing?
2019-05-21 14107, 2019
16:17 PM
bitmap
some of the macros might be unfamiliar, but
2019-05-21 14108, 2019
16:33 PM
Cyna
Most of it is unfamiliar... I'm trying to figure it out
2019-05-21 14156, 2019
16:36 PM
bitmap
if you don't know what something does just ask and I'll help :)
2019-05-21 14100, 2019
16:53 PM
pristine__
2019-05-21 14106, 2019
16:53 PM
pristine__
ruaok: ^^
2019-05-21 14142, 2019
16:54 PM
BrainzGit
2019-05-21 14123, 2019
16:59 PM
BrainzGit
2019-05-21 14124, 2019
16:59 PM
BrainzBot
2019-05-21 14102, 2019
17:10 PM
ruaok
pristine__: Im still snowed under and still not functioning 100%. :(
2019-05-21 14111, 2019
17:18 PM
ruaok
zas: for the API-compat container on lemmy, did you actually enter into the container and verify the the config.py file was missing?
2019-05-21 14145, 2019
17:18 PM
ruaok
most of the values are properly filled out, but the QLALCHEMY_DATABASE_URI is missing sometimes.
2019-05-21 14146, 2019
17:18 PM
ruaok
which is odd
2019-05-21 14118, 2019
17:19 PM
ruaok
because we do loop to wait for the file to appear -- that code is in place and deployed.
2019-05-21 14154, 2019
17:19 PM
ruaok
it is all based on the same image, really.
2019-05-21 14156, 2019
17:21 PM
zas
i did, but the file was there and complete
2019-05-21 14158, 2019
17:22 PM
ruaok
2019-05-21 14131, 2019
17:23 PM
ruaok
when the api-compat restarts, there is not pgbouncer-master service running, so that block is left empty.
2019-05-21 14154, 2019
17:23 PM
ruaok
which then later dies and the container exits.
2019-05-21 14101, 2019
17:24 PM
ruaok
then it should re-run and recover.
2019-05-21 14105, 2019
17:24 PM
ruaok
but it doesn't.
2019-05-21 14117, 2019
17:24 PM
ruaok
but, why is pgbouncer freaking out?
2019-05-21 14133, 2019
17:24 PM
ruaok
to me the api-compat issue looks to be a symptom, not the cause.
2019-05-21 14136, 2019
17:24 PM
zas
pgbouncer-master = bowie's one ?
2019-05-21 14148, 2019
17:24 PM
ruaok
yes
2019-05-21 14151, 2019
17:24 PM
zas
it's enough if an health check fails
2019-05-21 14122, 2019
17:25 PM
zas
i'm off to diner, i'll have a look after
2019-05-21 14127, 2019
17:25 PM
ruaok
k, me too.
2019-05-21 14129, 2019
17:34 PM
ruaok
pristine__: how do you define "candidate_recordings" ?
2019-05-21 14146, 2019
17:34 PM
ruaok
22M candidate recordings sounds... too big.
2019-05-21 14101, 2019
17:35 PM
pristine__
ruaok: recording which the user has never listened to
2019-05-21 14150, 2019
17:35 PM
pristine__
All recordings - user recordings
2019-05-21 14159, 2019
17:35 PM
ruaok
ok, got it.
2019-05-21 14112, 2019
17:36 PM
ruaok
10m just for that step. oy
2019-05-21 14122, 2019
17:36 PM
pristine__
Yup and get well soon.
2019-05-21 14125, 2019
17:36 PM
pristine__
Yes ruaok
2019-05-21 14128, 2019
17:36 PM
pristine__
Nice idea
2019-05-21 14140, 2019
17:36 PM
ruaok
ok, these reports are now living up to what I wanted them to do. well done.
2019-05-21 14146, 2019
17:36 PM
reosarevok
2019-05-21 14148, 2019
17:36 PM
ruaok
I can follow the process and ask better questions.
2019-05-21 14103, 2019
17:37 PM
pristine__
We could reduce the number from 22M to make the process fast
2019-05-21 14108, 2019
17:37 PM
pristine__
Can*
2019-05-21 14113, 2019
17:37 PM
pristine__
Thanks :)
2019-05-21 14120, 2019
17:37 PM
ruaok
reosarevok: you can just ship a size XL to the office in lieu of chocolate. thanks. :)
2019-05-21 14139, 2019
17:37 PM
ruaok
Reducing the 22M would be one goal, yes.
2019-05-21 14117, 2019
17:38 PM
ruaok
ok, I need to go now.
2019-05-21 14125, 2019
17:38 PM
ruaok
but tomorrow let me review the trello task list.
2019-05-21 14133, 2019
17:38 PM
pristine__
I mean first we will subtract user recordings from all recordings, get the candidate recording and filter around 10M rows
2019-05-21 14136, 2019
17:38 PM
pristine__
Sure
2019-05-21 14139, 2019
17:38 PM
ruaok
but we should work on merging open PRs now before we open any new ones.
2019-05-21 14150, 2019
17:38 PM
ruaok runs off
2019-05-21 14157, 2019
17:38 PM
pristine__
Did you read the dependent idea?
2019-05-21 14108, 2019
17:39 PM
pristine__
Oh lol. Bye ruaok :)
2019-05-21 14120, 2019
17:39 PM
ruaok
bye. mañana!
2019-05-21 14149, 2019
17:50 PM
BrainzGit
2019-05-21 14110, 2019
18:15 PM
Cyna
The edit templates in `/root/edit/details/` are the ones that get displayed after edit is submitted right. reosarevok
2019-05-21 14151, 2019
18:16 PM
Cyna
Im currently working on a different approach... will bounce back in a day or two with results
2019-05-21 14149, 2019
18:17 PM
bitmap
Cyna: yes, and they're the same ones used for previewing in the release editor
2019-05-21 14119, 2019
18:18 PM
bitmap
we'd rather not have two different approaches to previewing the same edits
2019-05-21 14119, 2019
18:19 PM
bitmap
so please work on converting these and not go off on a tangent :)
2019-05-21 14130, 2019
18:19 PM
Cyna
By using the other I will propose it would get easier to make it work with other entities... Its hard to understand what macros.tt
2019-05-21 14156, 2019
18:19 PM
Cyna
Okay I am trying to figure out the meaning of stuff in macros.tt
2019-05-21 14156, 2019
18:19 PM
reosarevok
Well, macros.tt will eventually all be converted to JS
2019-05-21 14104, 2019
18:20 PM
reosarevok
Just ask if you have doubts! :)
2019-05-21 14126, 2019
18:20 PM
Cyna
Guessing it should be first converted to JS before converting the other templates
2019-05-21 14151, 2019
18:20 PM
Cyna
what is Diff class ?
2019-05-21 14138, 2019
18:21 PM
reosarevok
We generally convert the macros one at a time when we need them
2019-05-21 14146, 2019
18:21 PM
bitmap
most likely lib/MusicBrainz/Server/Plugin/Diff.pm
2019-05-21 14108, 2019
18:22 PM
bitmap
I mentioned this yesterday but I have a branch to convert the diff macros to React
2019-05-21 14137, 2019
18:22 PM
bitmap
hence starting with root/edit/details/add_remove_alias.tt so that you don't need those yet
2019-05-21 14104, 2019
18:24 PM
Cyna
Ohh
2019-05-21 14101, 2019
18:27 PM
MusicbrainzB0T1 joined the channel
2019-05-21 14123, 2019
18:28 PM
Zialus has quit
2019-05-21 14112, 2019
18:29 PM
Zialus joined the channel
2019-05-21 14127, 2019
18:30 PM
MusicbrainzB0T has quit
2019-05-21 14154, 2019
18:36 PM
BrainzGit
2019-05-21 14151, 2019
18:39 PM
reosarevok
yvanzo: around? :)
2019-05-21 14123, 2019
18:42 PM
BrainzGit
2019-05-21 14125, 2019
18:42 PM
BrainzBot
2019-05-21 14159, 2019
19:00 PM
BrainzGit
2019-05-21 14100, 2019
19:01 PM
BrainzBot
2019-05-21 14152, 2019
19:06 PM
Gazooo joined the channel
2019-05-21 14101, 2019
19:14 PM
iliekcomputers
upgraded api-compat-prod with latest mbdata
2019-05-21 14107, 2019
19:17 PM
zas
ruaok: i think issues with lemmy are related to docker-proxy (at least for failing nagios checks)
2019-05-21 14129, 2019
19:17 PM
zas
it's relaying all incoming connections on port 80 to docker container
2019-05-21 14135, 2019
19:19 PM
zas
and i noticed lemmy sysctl values were almost all by default, i set much higher values for such server (accepting a lot of connections), it was very needed (at least maxconn, it was on default 128, which is far too low, now 4096)
2019-05-21 14102, 2019
19:20 PM
zas
2019-05-21 14122, 2019
19:30 PM
ruaok
Yes, we've never tweaked anything. Is it happy now?
2019-05-21 14133, 2019
19:38 PM
iliekcomputers
We should move api compat to gateways, no idea why it needs direct connection with lemmy
2019-05-21 14133, 2019
19:45 PM
zas
ruaok: dunno, but i think issue is related to docker-proxy, which is used because we don't allow docker to modify iptables (=firewalls), this is something bothering me since a while.
2019-05-21 14119, 2019
19:48 PM
zas
I found
https://github.com/chaifeng/ufw-docker which basically solves this issue (ufw + docker without disabling iptables in docker conf), i'll prolly give it a try, but deploying such stuff in prod will have to be done very carefully. Getting rid of docker-proxy and relying on iptables instead is very likely more efficient. Plus docker-proxy is known to be rather memory hungry.
2019-05-21 14118, 2019
19:50 PM
zas
Experience show that running docker with iptables=false create more issues and only solves one: without, docker messes with iptables and leads to a serious security risk (basically it defeats firewall rules)
2019-05-21 14117, 2019
19:52 PM
zas
Letting docker play with iptables is the way to go, it is meant to do that. But a proper firewalling solution is still required,
https://github.com/chaifeng/ufw-docker is an attempt to address this issue.
2019-05-21 14125, 2019
19:53 PM
zas
So i'll dig this, and see where it goes. I'm rather reluctant to play with iptables on production systems... it can easily turn into a nightmare ;)
2019-05-21 14117, 2019
19:58 PM
zas
2019-05-21 14115, 2019
20:46 PM
spellew
ferbncode: I've been playing around with the code, but I haven't been able to reproduce the CB bug to test it. I did do some reading on it though, and it seems the solution here is to provide an expression to `join(tag_model)` as the second parameter. So, `join(tag_model, entity_model.id == tag_model.release_group_id)`.
2019-05-21 14106, 2019
20:47 PM
spellew
Of course, it would also have to be changed so other entities are supported.
2019-05-21 14113, 2019
22:39 PM
reosarevok
yvanzo: marked some things as resolved in your comments to the collections pr that I didn't get to push yet, will do in the morning
2019-05-21 14117, 2019
22:49 PM
D4RK-PH0ENiX has quit
2019-05-21 14123, 2019
23:12 PM
D4RK-PH0ENiX joined the channel
