It seems to be the entire diff, not one side of it?
Or oh, no, ok, it's one side
But then it's confusing :D
bitmap
yeah, I think I just used the TT names
reosarevok
Wouldn't it be easier to have the old and new be one thing, instead of passing the stuff twice one with DELETE and one with INSERT?
bitmap
I don't remember, will have to check :) pretty sure that's how the TT does it though
also it's memorial day here so everyone is slacking off & I might be afk during the meeting today
Gore|work has quit
reosarevok
haha
reosarevok had to go search what that was. Some military thing. Ok then! It still feels a bit weird to an European to have a specific holiday for that but :D (make sure to send Freso something if you are away ;) )
Mr_Monkey
Hi akhilesh !
alastairp
iliekcomputers: ready when you are
spellew
Hi o/
ferbncode: I do have a few questions
I'm a bit confused about works, and the difference between a work and a recording. Especially when a work is a song.
Is there enough distinction to write reviews?
pristine__
iliekcomputers: hey
let me know when you're up?
I am facing some problem, since ruaok is afk maybe we can try to debug.
aidanlw17
alastairp: After setting up the database with the dumps, I get `ERROR: permission denied for relation x` when querying unless I use super user. Any idea how I can correct this?
ferbncode
spellew: A work could be a novel, play, poem or essay, later recorded as an oratory or audiobook. (From https://musicbrainz.org/doc/Work). For example: https://musicbrainz.org/work/65f77aa0-d805-4798... is a work of type prose. I think there is a good line that we want to support review for work. IIUC, A work of type song might be completely different from a original recording by the same artist.
because you ran the import as the postgres user to correctly install all of the extensions, for some reason it seems to have left all of the tables owned by the postgres user
so the regular user can't read them
so you can change all of them, using something like the linked answer
aidanlw17
alastairp: thanks I'll check that out. Do you know why `GRANT ALL PRIVILEGES ON ALL TABLES IN SCHEMA public TO acousticbrainz;` does not give us the result?
spellew
ferbncode: I get it now, thanks.
amCap1712
hi all
pristine__
amCap1712: hey :)
amCap1712
hi pristine__
alastairp
good question, I'm not sure from the back of my head
amCap1712
how are you doing
iliekcomputers
alastairp: hi, sorry, i'm here.
pristine__: yep, sure, as soon as I'm done with AB stuff.
alastairp
OK. so where are we at? I see a tag from v-2019-03-05.0. is that our last release?
iliekcomputers
alastairp: yes, that fixed the SEC issues
as far as I remember.
alastairp
I don't think so. I think that was from much earlier
the previous SEC fixes we made haven't been merged yet
one thing that's missing is we still don't have `psql` in the web container
the script to run is a one-liner, so maybe we can run it some other way? Otherwise I'm happy to put it back into the image if this works best for how you deploy/manage the app
iliekcomputers
that should not be a big problem.
i can run it inside the postgres container.
alastairp
OK
so do you want to tag + build?
iliekcomputers
one sec, i was just looking for the schema change script.
should I do the schema change before deploying the new container or after?
alastairp
ah, sorry - I don't think you're up to date with how we did this patch
it's in 3 parts
first part adds the table, and has a script to populate it. nothing read/writes this column
second part we will do a small downtime and run the script one last time before deploying, then submissions will start to write this column
last part will read from the column
iliekcomputers
ah. okay.
alastairp
so for now, let's release with minimal downtime. it doesn't matter if we run the migration script after the deploy
iliekcomputers
so it doesn't matter right now
alastairp
yep
iliekcomputers
hmm, great minds :)
i'll do the schema change first then.
alastairp
merging the second part will have a small downtime while we populate any missing values (but this should be very short as we can run it one last time while AB is still up before we do the deploy)
akhilesh: I think as we discussed previously, you should start by outlining and setting up the general structure of the project (seeing what parts of the code you will be reusing/refactoring from the sebsite code), and start writing test outlines (only the description for the test) for one entity endpoint.
akhilesh: Yes, start a new branch and open a W.I.P PR. Eventually it will get merged into master. We may also consider closing that PR and opening new ones if there are clear standalon units of work, but we'll see when we get to it.
pristine__
ummm.....but I somehow managed
see you at the meeting :)
alastairp
iliekcomputers: whoops, missed your messages
thanks
we have some new features, I'll tweet when i get home