#metabrainz

/

      • Cyna
        bitmap, reosarevok: I finished converting edit_alias.tt. Tested it too

        • 2019-05-30 15051, 2019

      • Cyna
        Im not raising a PR as bitmap hasnt merged his PR with addition of Diff, FullChangeDiff components

        • 2019-05-30 15004, 2019

      • Cyna
        What should I get on with next ?

        • 2019-05-30 15054, 2019

      • bitmap
        amCap1712: it'll return a 401 saying the credentials could not be verified

        • 2019-05-30 15032, 2019

      • amCap1712
        thanks bitmap

        • 2019-05-30 15057, 2019

      • bitmap
        Cyna: well we'll need to convert the alias add/edit forms to React, under root/entity/alias/

        • 2019-05-30 15013, 2019

      • bitmap
        then implement a preview component that displays the edits you converted

        • 2019-05-30 15049, 2019

      • Cyna
        Hmm... I'll get on the conversion tomorrow after my Practicals

        • 2019-05-30 15030, 2019

      • Cyna
        what is script_manifest(...) ?

        • 2019-05-30 15014, 2019

      • Cyna
        https://github.com/anirudhjain75/musicbrainz-serv…

        • 2019-05-30 15031, 2019

      • bitmap
        it looks up a script and returns the public, versioned URL for it

        • 2019-05-30 15036, 2019

      • bitmap
        like https://staticbrainz.org/MB/common-800e685.js

        • 2019-05-30 15014, 2019

      • Cyna
        dont understand

        • 2019-05-30 15016, 2019

      • bitmap
        (and outputs a <script> tag for it)

        • 2019-05-30 15029, 2019

      • bitmap
        it takes a file name relative to root/static/scripts/, so that refers to root/static/scripts/edit.js

        • 2019-05-30 15042, 2019

      • bitmap
        this is the entry point for a webpack bundle

        • 2019-05-30 15051, 2019

      • bitmap
        the actual bundle file as served to the public will have a hash added for caching, and a URL, in this case on https://staticbrainz.org/MB/

        • 2019-05-30 15047, 2019

      • Cyna
        so its basically `publicUrl + something`

        • 2019-05-30 15007, 2019

      • Cyna
        something is derived from the script

        • 2019-05-30 15008, 2019

      • Cyna
        right ?

        • 2019-05-30 15041, 2019

      • bitmap
        basically

        • 2019-05-30 15045, 2019

      • bitmap
        the "manifest" is https://staticbrainz.org/MB/rev-manifest.json

        • 2019-05-30 15053, 2019

      • amCap1712
        bitmap: if the authorization header is set to empty that is also considered inavlid access token

        • 2019-05-30 15012, 2019

      • bitmap
        that has scripts/edit.js: "scripts/edit-4da2c51e9d.js"

        • 2019-05-30 15049, 2019

      • bitmap
        so it knows the edit bundle will be named like scripts/edit-4da2c51e9d.js at the public url

        • 2019-05-30 15013, 2019

      • xarph has quit

        • 2019-05-30 15042, 2019

      • bitmap
        and it's a hash of the file contents, so if the bundle changes, so will the hash (and clients will download the new copy instead of the old, since it has a different name)

        • 2019-05-30 15040, 2019

      • spellew
        ferbncode: iliekcomputers: I've opened the draft pr

        • 2019-05-30 15028, 2019

      • bitmap
        amCap1712: it also returns a 401, but with a different message ("You are not authorized to access this resource.")

        • 2019-05-30 15053, 2019

      • amCap1712
        ok thanks again

        • 2019-05-30 15021, 2019

      • amCap1712
        is there any other documentation on Oauth other than https://musicbrainz.org/doc/Development/OAuth2

        • 2019-05-30 15036, 2019

      • bitmap
        I don't think so

        • 2019-05-30 15011, 2019

      • amCap1712
        okay, i asked because i couldn't find any info or error codes there

        • 2019-05-30 15025, 2019

      • Cyna
        edit.js in /root/static/server/ is a bunch of import commands and nothing else

        • 2019-05-30 15056, 2019

      • Cyna
        edit_form.tt runs the script manifest command on edit.js

        • 2019-05-30 15032, 2019

      • Cyna
        hows does it get reflected on add alias form page ?

        • 2019-05-30 15031, 2019

      • Cyna
        amCap1712: the error code are based on standards right ? https://www.tutorialspoint.com/http/http_status_c…

        • 2019-05-30 15034, 2019

      • iliekcomputers
        spellew: thanks. :)

        • 2019-05-30 15037, 2019

      • bitmap
        it's not including or running that file directly - edit.js is the entry point for a webpack bundle

        • 2019-05-30 15054, 2019

      • bitmap
        webpack is run via ./script/compile_resources.sh and the bundles go to root/static/build/

        • 2019-05-30 15034, 2019

      • bitmap
        script_manifest simply looks up edit.js in the manifest and outputs a <script> tag pointing to the bundle url

        • 2019-05-30 15003, 2019

      • Cyna
        Ohh so its basically converting the js file to a script tag and placing it there ?

        • 2019-05-30 15015, 2019

      • amCap1712
        cyna: yes, i meant like the error messages to be specific like bitmap told above about 401 for two scenarios but different error msg to distinguish

        • 2019-05-30 15046, 2019

      • Cyna
        ohh

        • 2019-05-30 15050, 2019

      • bitmap
        well it doesn't convert the file there, that's done by ./script/compile_resources.sh

        • 2019-05-30 15029, 2019

      • Cyna
        How do I put it in react file then 🤔

        • 2019-05-30 15038, 2019

      • bitmap
        it's taking the js file *name* and outputting a script tag

        • 2019-05-30 15007, 2019

      • bitmap
        those utilities have already been converted to JS at root/static/manifest.js

        • 2019-05-30 15024, 2019

      • bitmap
        git grep -F manifest.js

        • 2019-05-30 15026, 2019

      • Cyna
        thanks

        • 2019-05-30 15030, 2019

      • Cyna
        Will check it out

        • 2019-05-30 15055, 2019

      • ferbncode
        spellew: thanks :)

        • 2019-05-30 15054, 2019

      • gr0uch0mars has quit

        • 2019-05-30 15042, 2019

      • SothoTalKer
        just in case someone is using docker for anything :p https://seclists.org/oss-sec/2019/q2/131

        • 2019-05-30 15047, 2019

      • zas
        SothoTalKer: thanks ;)

        • 2019-05-30 15034, 2019

      • D4RK-PH0ENiX has quit

        • 2019-05-30 15022, 2019

      • Freso
        "<pristine__> any user must have listened to a song that involves various artists, we can then get similar artists from the histogram project and recommend songs from a pool which belong to these related artists" I think the VA based histogram project is very cool, but I also feel like this approach (of using VA albums as a base for artist similarity) may exclude a lot of smaller and newer or just straight up less mainstream (with

        • 2019-05-30 15022, 2019

      • Freso
        "mainstream" meaning "mainstream in Western mostly-English locales") artists. Both based on bias of more mainstrain = on more compilations (incl. on compilations at all!) and also of the bias in the data available/the historical userbase. It also excludes artists that aren’t following the typical Release workflow, but only does standalone recordings on SoundCloud or YouTube etc. I'd rather get recommended smaller, less mainstreamy

        • 2019-05-30 15022, 2019

      • Freso
        artists than artists that happen to have been on dozens of compilations.

        • 2019-05-30 15022, 2019

      • Freso
        Anyway, I also realize that this is a difficult problem, so I’m not saying to drop this approach; I just really hope all the downfalls of this approach won’t be forgotten once there is something Good Enough™ in place. :) (And I’m sure you and Rob have thought about these limitations, I just didn’t see either of you express them here in the channel.)

        • 2019-05-30 15030, 2019

      • ZaphodBeeblebrox
        oh definitly.

        • 2019-05-30 15044, 2019

      • ZaphodBeeblebrox
        I'm thinking about Mash-upers like who have a lot of standalone recordings