spellew: the tests use a redis docker container and need to get the docker image. Tests should run properly once the image is downloaded and containers are launched. Could you paste the output the next time you try to run the tests?
"01:35:08 <zarcade_droid> It's just a bit sad that that link isn't shown on the sidebar" - note that the relationship type and whether a link is shown in the sidebar are generally not related ("official homepage" excepted). Sub-Fandom pages could be added to the sidebar while still using "fan page" or "biography" links.
MBS-9512: Changing recording name to empty string should not be allowed
2019-06-04 15532, 2019
yvanzo
yes
2019-06-04 15556, 2019
reosarevok
Ok :)
2019-06-04 15503, 2019
reosarevok
(was wondering since it said "mitigate" at first)
2019-06-04 15518, 2019
yvanzo
ya but bitmap found a definitive fix after all :)
2019-06-04 15548, 2019
Darkloke has quit
2019-06-04 15554, 2019
akhilesh
Mr_Monkey: did you tried endpoint implemented until. Only relationship of work lookup is left. I am reading about caching which is our next task. I understand the storing and getting data from cache but still confused with invalidation of cache? Have you any idea about cache invalidation for existing setup?
2019-06-04 15516, 2019
Mr_Monkey
akhilesh: Haven't tried the endpoints since yesterday, I was waiting for work to be done to review more thoroughly.
2019-06-04 15534, 2019
Mr_Monkey
As for cache, I'm not the best person to ask. My knowledge of it is limited. zas has recently been testing setting up cache at the gateway level, so I think it would be better to keep cache implementation for a later date and move forward on the endpoints.
2019-06-04 15515, 2019
akhilesh
Sounds good to me for now!
2019-06-04 15519, 2019
Mr_Monkey
We might end up not needing to set up cache for any endpoint
2019-06-04 15507, 2019
Mr_Monkey
You will need a cursory understanding of redis as the cache layer for credentials, but api/app.js is already set up for that as it is now.
2019-06-04 15500, 2019
Mr_Monkey
Hi bukwurm ! You wanted to talk shop?
2019-06-04 15540, 2019
reosarevok
yvanzo: thanks for the hints re: the constants for select! :)
2019-06-04 15544, 2019
reosarevok
Should be good now
2019-06-04 15545, 2019
akhilesh
Mr_Monkey: Ok, but it is good to me if you will check implemented endpoint and see the output and give your valuable suggestions please. It will help me to speed up the project.
2019-06-04 15553, 2019
bukwurm
Mr_Monkey: Hey
2019-06-04 15513, 2019
Mr_Monkey
OK akhilesh. I'll do a full review tomorrow
2019-06-04 15517, 2019
bukwurm
Are you available right now?
2019-06-04 15517, 2019
Mr_Monkey
Hi bukwurm
2019-06-04 15520, 2019
Mr_Monkey
Yup
2019-06-04 15525, 2019
bukwurm
Great
2019-06-04 15506, 2019
Mr_Monkey
So what can I help you with for the import project?
2019-06-04 15536, 2019
bukwurm
I was thinking of moving in the direction of final import process.
2019-06-04 15511, 2019
bukwurm
First of all, do you have anything specific direction for the project?
2019-06-04 15550, 2019
Mr_Monkey
Not at this point, no
2019-06-04 15503, 2019
bukwurm
Alright
2019-06-04 15510, 2019
Mr_Monkey
But the direction you were going previously seemed right to me
2019-06-04 15520, 2019
bukwurm
Ok
2019-06-04 15545, 2019
Mr_Monkey
I think there are some questions regarding the UI I would propose to make sketches for
2019-06-04 15500, 2019
bukwurm
Ok
2019-06-04 15514, 2019
bukwurm
First, I'd like to talk about the importer
2019-06-04 15540, 2019
bukwurm
The changes since then that have been made are:
2019-06-04 15508, 2019
bukwurm
1. Moving the project under a new repository - bookbrainz-utils
2019-06-04 15558, 2019
bukwurm
2. Adding a `cleaner` sub-project (apparantly in typescript) which doesn't appear to have much functionality as of now
So there are some fundamental changes I am thinking of making
2019-06-04 15512, 2019
bukwurm
Back then I had just started out with nodejs , so a number of issues had crept in
2019-06-04 15508, 2019
bukwurm
First change I'd like to have is a separate micro-service for consumer (one that pushes the data into db)
2019-06-04 15511, 2019
Mr_Monkey
How is it currently run?
2019-06-04 15545, 2019
bukwurm
Currently, it's coupled with a lot of things
2019-06-04 15525, 2019
bukwurm
Presently it's just a script, which can fail silently
2019-06-04 15503, 2019
bukwurm
It can be very easily set up as a separate service/worker
2019-06-04 15508, 2019
bukwurm
Nothing much needs to be changed
2019-06-04 15519, 2019
bukwurm
It can be even set up as a cron
2019-06-04 15520, 2019
Mr_Monkey
Yup
2019-06-04 15519, 2019
bukwurm
We can even run it at will though right now
2019-06-04 15559, 2019
bukwurm
But I imagine a situation where 3rd party individuals can use the API to import data from any place
2019-06-04 15536, 2019
bukwurm
The server pushes the request and data to queue, and the workers listening can feed that into the db
2019-06-04 15555, 2019
bukwurm
But it's not really really needed right now
2019-06-04 15521, 2019
Mr_Monkey
It's a potential future goal, yes
2019-06-04 15536, 2019
bukwurm
The next thing is - we should ideally have an error queue which we can monitor
2019-06-04 15512, 2019
bukwurm
In case an import fails, it could be possibly due to some bug. Instead of logging it - we can ideally push it to the queue.
2019-06-04 15534, 2019
Mr_Monkey
OK, sounds sane
2019-06-04 15540, 2019
Mr_Monkey
Easy to monitor
2019-06-04 15521, 2019
bukwurm
If errors exceed while monitoring and in case we find there's an issue - we can just start some worker to refeed the message back to the original queue
2019-06-04 15530, 2019
bukwurm
after fixing it
2019-06-04 15539, 2019
bukwurm
Else we can simply flush the queue
2019-06-04 15553, 2019
bukwurm
Again, not a critical change but good to have
2019-06-04 15532, 2019
bukwurm
Next thing - and a major one
2019-06-04 15541, 2019
bukwurm
The other end of importer
2019-06-04 15550, 2019
bukwurm
Is the auto import we were running
2019-06-04 15508, 2019
bukwurm
By reading and parsing the dumps from OpenLibrary
2019-06-04 15521, 2019
Mr_Monkey
Right
2019-06-04 15542, 2019
bukwurm
When I was writing the code I had little knowledge of event loop and all
2019-06-04 15555, 2019
Cyna
bitmap: I still dont understand how do i get $form
2019-06-04 15511, 2019
bukwurm
So I wrote a fairly complicated code for multiprocessing and what now
2019-06-04 15528, 2019
Cyna
I've put the statement you told me, in the required place.
2019-06-04 15539, 2019
bukwurm
I don't think it's effective in a resource constraint project such as bookbrainz
2019-06-04 15548, 2019
Mr_Monkey
I was looking through it, yeah, it seemed pretty complex
2019-06-04 15506, 2019
bitmap
Cyna: push the code again and I'll check :)
2019-06-04 15511, 2019
bukwurm
It's clumsy, and as there were no threads then in js
2019-06-04 15514, 2019
Cyna
Sure
2019-06-04 15527, 2019
bukwurm
It's not async
2019-06-04 15536, 2019
bukwurm
I think we can get rid of the module
2019-06-04 15553, 2019
bukwurm
And replace it with a much cleaner worker threads now stable
2019-06-04 15510, 2019
Mr_Monkey
OK, that sounds like an important job, and a good idea
