#metabrainz

host and Referer were just examples of that inconsistency

so I'd just say something along those lines

So "This allows to consistently access headers, solving an issue where they were expected uppercased in some places and lowercased in others"?

capitalized would be more accurate than uppercased, but sounds good

yvanzo: ^?

+1

Ok

Thank you :)

Pushed

do we have time for https://github.com/metabrainz/musicbrainz-serve... ? might be a tricky one

Well, I think your idea made it worse.

in what way?

It computes the entire list whereas it used not to compute it in most cases.

right, but I'm not sure computing the list is an expensive operation

the list will be very small in most cases

I attempted to rewrite it to avoid that, but it doesn't work yet and doesn't look pretty either.

alastairp: what you say makes sense. But a thought crossed my mind, do we need to replace days here. My goal is to collect dataframes of last X months from the present month, so even if it is 30-07-2019, a month before it will be 30-06-2019. Date doesn't matter here, no?

FWIW, in the real life cases where I tested it, the recursion didn't seem to make it particularly slow or anything

As I mentioned, the chances it needs to hit more than two loops are small

I mean, realistically it could hit a few levels of recursion at most

Yup, but it seems just unsafe to have a recursion based on user input.

I mean, what's the worst that can happen?

At most it can run for a few hundred times, if someone does try to troll by adding redirects to every wikipedia language on one WD item

And that seems like a trolling so weird, not even dseomn would bother :p

it's still bound by what languages are actually available though

reosarevok: made some comments on the 1st PR, probably just minor changes

Ok, will check

I will try to make my own version work and push it (for the latest PR)

how will you avoid calculating the list?

bitmap: blacklisting unwanted languages

Want to quickly look through a couple tiny PRs from the newer batches too?

pristine__: right, if you're interested in collection information related to some number of months, you probably don't need the date in any of your queries

(I'm also happy to look at more old ones if you're not in a hurry)

don't you have to calculate unwanted languages then?

are you interested in knowing "statistics in the last 30 days until today" or "statistics for June"?

bitmap: not all of these, just the ones we checked

About https://github.com/metabrainz/musicbrainz-serve... I started to refactor entity lists

let's wait until next time for #1015 then

yvanzo: to share more code between the lists?

Yep, we currently have separate components for search results, reports, entity tabs, and collection.

Hmm

(collection currently share code with entity tabs, but that component cannot be used without the kludge I made)

Not quite true, in most cases

Oh

Then yes :p

Which PRs have higher priority among https://github.com/metabrainz/musicbrainz-serve... ?

React edit diffs is needed by Cyna's gsoc work, though I eventually made a separate branch to merge his stuff into

Ok (none of these PRs are mine)

the autocomplete one just makes it easier to convert edit pages that use autocompletes (release/relationship editors) to react

and I was hoping to start converting the release editor soon so I can integrate alt. tracklists there

the navbar one isn't urgent

those are the only ones from me

Is there any other PR or ticket that should be considered before updating beta?

yvanzo: tiny things that improve things for users and bitmap has already approved: https://github.com/metabrainz/musicbrainz-serve... https://github.com/metabrainz/musicbrainz-serve...

reosarevok: did you have time to look into the itunes issues? (seems to be a style issue too)

A bit but not enough

It's weird because it's not clear iTunes should even be autoselecting purchase anymore

bitmap: https://github.com/metabrainz/musicbrainz-serve... seems mergeable?

yup

yvanzo: https://github.com/metabrainz/musicbrainz-serve... also tiny / approved

So is https://github.com/metabrainz/musicbrainz-serve...

And https://github.com/metabrainz/musicbrainz-serve...

BrainzGit seems to be off.

And https://github.com/metabrainz/musicbrainz-serve... too

That's it now :p

(no need to check them all now or anything, just might be easy pickings before beta

)

reosarevok: listing all of your PRs don't help with prioritizing :P

That's not all, that's short ones with one approval :p

will review these and check URL cleanup tickets then

Thanks!

(about itunes, the only way out without a style decision would be to disable auto-select for itunes/apple music URLs)

I know

Give me one more release cycle to figure out wtf

The links can be automatically cleaned up anyway AFAICT

itunes ftw

sounds like we have enough work for now anyway :)

Sure

yvanzo: updated the doc PR

we could go through more old PRs on friday if you'd like

I'm at Wikimedia Eesti Summer Days on Friday

yay! ty

So maybe not? :)

oh okay

(but if you can look at some of mine without me and complain, I'll deal with them once I'm back!)

I will try to push a new beta this week after having reviewed/merged what can be.

If you both approve something of mine, feel free to merge without waiting for me

(during Fri - Sun)

ferbncode: Is there anything I should be doing while waiting for pull requests to be reviewed?

spellew: iliekcomputers would help us merge the approved PRs by tomorrow and then we can start with the new tasks. Till then, could you also attach a screenshot of how the artist review page looks like? (If you have it locally). I checked the code and will add the review tomorrow

ferbncode: Sure thing

Thanks! :)

reosarevok: you're right that *I* wouldn't do that, but I do know a couple people who might ;)

ferbncode: It's looking like this, I added the review button. https://usercontent.irccloud-cdn.com/file/88YeW...