There's been a lot of work on dates generally, so small issues found themselves part of a longer testing/release cycle
D4RK-PH0ENiX has quit
pristine__
ruaok: moin
ruaok
moin!
pristine__
> so, given that you have data that has an array of mbids, it needs to be matched an artist_credit. this avoids the explosion problem.
I am still not sure how to do it. Can you give a lil example about what is there in your mind, I mean any pseudo query involving ar-ar JSON and ar-credit JSON?
ruaok
here is what I am going to do to make this easier...
BestSteve has quit
I'm going to have the MSID mapping output artist_credit_is, instead of an array of artist MBIDs.
_id
that should make this change trivial for you, yes?
BestSteve joined the channel
D4RK-PH0ENiX joined the channel
D4RK-PH0ENiX has quit
D4RK-PH0ENiX joined the channel
pristine__
ruaok: so I match the artist_credit_ids to get artist_names from artist_credit_relation? Can you make a gist a with a sample table of a few rows ( like I posted one before with A,B,C) so that we better understand everything and know what suits us best before you start on modifying mapping or stuff? So in particular a gist of MSID mapping output artist_credit_id with correct col names but random col values, I can then just
perform joins and stuff on that gist and inference results so that in order to make things better we don't miss out on some points and land on the point from where we started.
Also, you have been putting in so much time so let's just be sure.
thomasross has quit
thomasross joined the channel
ruaok
ok, i'll get you something in the course of the day.
pristine__: honestly, I can't even follow your comments right now.
pristine__
:(
I wish I could explain you face to face with pen and paper. Okay give me some time
ruaok
what is more important? the artist_credit mapping stuff or providing feedback on this PR?
pristine__
I will prepare a gist with tables and every step
former
ruaok
no, please don't.
pristine__
Okay.
abhishekpanwar
Mr_Monkey: Do you have a minute to talk?
ruaok
I just want to ask you questions.
Mr_Monkey
abhishekpanwar: I do !
ruaok
but first, what should I focus on first?
pristine__
cool. Sounds good
ruaok
PR or ac question?
pristine__
artist_credit IMO
ruaok
ok.
abhishekpanwar
Yeah So I think there is something wrong in hosts used in the config
pristine__
:)
abhishekpanwar
Like when I do what is mentioned in the new debug docs then debugging works fine but normal develop.sh dont
But If I follow normal setup procedure then debug doesnt work but develop.sh works
Regarding elasticsearch
I think the hosts are not matching
Somewhere elasticsearch:9200 is usedand somewhere localhist:9200
*localhost
Do you think there is a chance of some descrepancy?
I dont think this issue is only specific to me
Mr_Monkey
Right. So if you're using develop.sh, everything is run using Docker, so the hostnames in the config should be the same as the docker container names (defined in docker-compose.yml).
If you're running the server locally with node, or through vscode, then you need to modify the config to point to `localhost` instead of the container names, which won't mean anything in that case.
Does that clarify things for you?
abhishekpanwar
So we can make them the same so we dont have to switch the config file everytime we debug or develop?
Mr_Monkey
So depending on which way you run the server, you'll need to change the config accordingly
I'm afraid we cannot make them the same
But I sure can try to document it better
abhishekpanwar
I guess if someone has basics of docker clear, might be able to understand it. Ill look into docker I guess.
Thanks
sbvkrishna
If you want, you can create two configurations and just switch the file names depending on debug or develop
abhishekpanwar
Yeah, good idea. Will do this only.
Mr_Monkey
That's also what I do, but I agree it's cumbersome. I'll think of a way to start the server and pass a config file path to load. Ideally, develop.sh would work the same as today, and you'll also be able to run, say `npm start --config ./config/config.local.json`
abhishekpanwar
Yes, would be great if it was an option
sbvkrishna
To make it more clear for you, assuming all dependencies are running in docker. If you run 'develop.sh', server will run inside docker, thus to connect to other docker instances (dependencies), we need to tell it their 'names'. If we run the server locally, it's outside of docker, and it doesn't understand those 'docker names' we have given before, so we pass the location they are running (localost with port)
I was curious to know that when schema of MusicBrainz, LB and other projects was built how did the developers interacted with each other to arrive on a sol and make each other understand there thought process? I mean was/is there a dedicated platform? might help.
Pac23 joined the channel
abhishekpanwar
Good, It would make the development process easier.
iliekcomputers
IRC?
pristine__
:(
ruaok
well, the MB schema was far more than that.
pristine__
then I don't know how to explain :(
ruaok
5 years of planning and 3 separate in person summits focused on the new schema.