I don't like it, so I'd rather not make that change myself
2019-12-06 34021, 2019
reosarevok
I won't block it if someone else does though :)
2019-12-06 34043, 2019
reosarevok
But in that case we should still drop that specific commit, so :)
2019-12-06 34003, 2019
yvanzo
I mean, it still detects unwrapped iif.
2019-12-06 34020, 2019
c1e0 joined the channel
2019-12-06 34054, 2019
reosarevok
Sure, that's why I won't block it if you want to send a PR to change our eslintrc :)
2019-12-06 34037, 2019
yvanzo
Would you prefer to takeover the react-table thing?
2019-12-06 34059, 2019
yvanzo
I would focus on SIR/VM stuff instead.
2019-12-06 34053, 2019
reosarevok
If you're willing to help a bit if and when I get stuck, I can - sir and the vm do need the work too
2019-12-06 34007, 2019
reosarevok
(and I'm more likely to be able to do react-table than those)
2019-12-06 34053, 2019
D4RK-PH0ENiX joined the channel
2019-12-06 34034, 2019
yvanzo
Ok, but I have no clue about the current error. That should be debugged one column after another.
2019-12-06 34027, 2019
yvanzo
The weird bit is all columns are defined with id and string accessor.
2019-12-06 34059, 2019
yvanzo
Ooh, got it.
2019-12-06 34058, 2019
nav2002_ has quit
2019-12-06 34057, 2019
CatQuest
ack, i just tried the AcousticBrainz client thing. and I can't actually access the folder where the music is because i can't select volume (it's on an extHD)
2019-12-06 34057, 2019
CatQuest
if it'd a way to see "invisible" folders I could use the "go through system and volumes there" trick. but no luck there either
2019-12-06 34026, 2019
CatQuest
I tried copying the AcousticBrainz client to the extHD and run it from there. this stil doenst work
2019-12-06 34033, 2019
CatQuest
or if it had could jsut use the system's file browser isntead!
2019-12-06 34048, 2019
Wassabi has quit
2019-12-06 34005, 2019
Wassabi joined the channel
2019-12-06 34056, 2019
nav2002_ joined the channel
2019-12-06 34039, 2019
antara joined the channel
2019-12-06 34052, 2019
ZoeB joined the channel
2019-12-06 34002, 2019
ZoeB
Whoever added the ability for MB recordings to link to the IMDB entries of films they sampled, thank you!
google wouldn't have this problem if we had lyrics :P
2019-12-06 34052, 2019
CODEin_JDB joined the channel
2019-12-06 34058, 2019
sangeetk has quit
2019-12-06 34030, 2019
ZoeB
I've been vying for lyrics specifically in the cases of artists who explicitly allow them to be published anywhere. It amazes me how many people don't see it as free advertising, but there you go.
2019-12-06 34044, 2019
reosarevok
yvanzo: do you have an updated commit? (since it sounds like you found the issue)
2019-12-06 34018, 2019
ZoeB
Ah, further down that thread, he shows that Rap Genius has a licensing deal with music publishers. Nevermind then.
2019-12-06 34041, 2019
ruaok
iliekcomputers: yep, I did.
2019-12-06 34004, 2019
ruaok
ZoeB: lyrics are one of the few aspects of copyright that are being strictly enforced and are making money for them. this is why they are fully overprotective of it. because, as usual, they cannot see that they could be making more money by being open. as per usual we will have to force them to earn more money. 🙄
2019-12-06 34034, 2019
ZoeB
Sounds about right!
2019-12-06 34054, 2019
ruaok
hmmm. crashed the 64gigger. again. time to refactor this code for more mild memory usage.
2019-12-06 34000, 2019
ruaok
^^ pristine__
2019-12-06 34001, 2019
ruaok
:(
2019-12-06 34055, 2019
reosarevok
yvanzo: nvm, saw you have a branch. I'll look into it
2019-12-06 34020, 2019
pristine__
ruaok: which code?
2019-12-06 34001, 2019
ruaok
messybrainz-labs, the mappings. I tried something new and it works so well that 💥