#metabrainz

How do I update the docker engine?

> How do I update the docker engine?

Docker engine and docker compose are different things :)

Once the downloads are finish let me know, we will set up labs then. Also, you can contribute to listenbrainz-server as well if you wish to since you have it on your machine now

Yes sure.

It is more organized and have plenty of open tickets. If you want I can provide the link of ticktes :)

Ohh

I'll try

Yaa great ;)

Its done.

:)

Now clone listenbrainz-labs

Okay

Git clone https://github.com/metabrainz/listenbrainz-labs

Inside the listenbrainz-server or seperately?

Inside /home..... i.e. separately

Yes its done

Run `sudo ./develop.sh build`

Inside labs/

Yes

?

And if you want to contribute to server also, follow the remaining steps of read the docs whenever you wish to.

Okay

Hi, I am encountering an issue when submitting AcoustIDs for which I could not find any existing threads or issues:

When clicking submit in picard, I get the error "E: 12:54:36,545 /usr/lib/python3.8/site-packages/picard/acoustid/manager.__fingerprint_submission_finished:98: AcoustID: submission failed with error 'Error transferring http://api.acoustid.org:80/v2/submit - server replied: INTERNAL SERVER ERROR': internal error"

NomebodyNocks: Please have a look at Help > Show Error/Debug Log, there should be details about the failed request.

If you can show the output there I can probably tell if this is something that could be fixed in Picard (e.g. wrong data getting submitted) or if it is something that should be reported for the AcoustId sserver on https://github.com/acoustid/acoustid-server/issues

The output is:

E: 12:54:36,544 /usr/lib/python3.8/site-packages/picard/webservice/__init__._handle_reply:386: Network request error for http://api.acoustid.org:80/v2/submit: Error transferring http://api.acoustid.org:80/v2/submit - server replied: INTERNAL SERVER ERROR (QT code 401, HTTP code 500)E: 12:54:36,545

/usr/lib/python3.8/site-packages/picard/acoustid/manager.__fingerprint_submission_finished:98: AcoustID: submission failed with error 'Error transferring http://api.acoustid.org:80/v2/submit - server replied: INTERNAL SERVER ERROR': internal error

I cannot find additional details in the debug log

would there be any advantage if I checked the exact submission through wireshark or similar?

NomebodyNocks: You should start Picard with the --debug flag or change the Verbosity in the log window to debug, then try again, then you should see the request data

I'm AFK, but if you write here I will look at it later

sarthak_jain: if you wish to contribute to labs here is the ticket

LB-474: ListenBrainz-Labs: Write tests for stats module

Please assign the ticket to yourself.

outsidecontext ah, thanks! here is the dubug log:

D: 13:08:25,636 /usr/lib/python3.8/site-packages/picard/ui/itemviews.dropMimeData:569: Drop target = <Track 150ced6c-1632-4a04-a184-e4c3839b48d4 'Long Elevator'>D: 13:08:25,637 /usr/lib/python3.8/site-packages/picard/ui/itemviews.drop_urls:530: Dropped the URL: 'file:///mnt/media/music/library/Toby Fox/UNDERTALE Soundtrack/70 - Long

Elevator.flac'D: 13:08:25,638 /usr/lib/python3.8/site-packages/picard/file.move:508: Moving <FLACFile '70 - Long Elevator.flac'> from <Cluster 'Unclustered Files'> to <Track 150ced6c-1632-4a04-a184-e4c3839b48d4 'Long Elevator'>D: 13:08:27,456 /usr/lib/python3.8/site-packages/picard/acoustid/manager.submit:79: AcoustID: submitting ...D: 13:08:27,457

/usr/lib/python3.8/site-packages/picard/webservice/__init__.post:461: POST-DATA 'user=VnELKKxLKk&fingerprint.0=AQAAjEkySemSJOiFy_BxHMRB4TgOHwcBGzwO-Dh4gIdxHD6OA7BxHPBxAziMH_BxHDiMA_BxADbwAz6OA4dxHD6OA4dxHIePA7BxAMbBAweF4_Bx8MBB4Tjg4wZwGD_g4zhwGD8A_zgAe-DB8YcO__ihI89xUDh3FFcmIfku5AAjtVXKmrOUM9sKYc22ypqtlBXaKmWVskJbpazZVilrzlLWCmXNtkJZs5WyQlulrFBCeYB

AMxYRg6xhzAgM&duration.0=20&mbid.0=150ced6c-1632-4a04-a184-e4c3839b48d4&client=v8pQ6oyB&clientversion=2.2.3.final0&format=json'D: 13:08:27,458 /usr/lib/python3.8/site-packages/picard/webservice/ratecontrol.get_delay_to_next_request:115: ('api.acoustid.org', 80): Last request was 20002 ms ago, starting another oneD: 13:08:27,458

/usr/lib/python3.8/site-packages/picard/webservice/ratecontrol.increment_requests:135: ('api.acoustid.org', 80): Incrementing requests to: 1D: 13:08:27,582 /usr/lib/python3.8/site-packages/picard/webservice/ratecontrol.decrement_requests:143: ('api.acoustid.org', 80): Decrementing requests to: 0E: 13:08:27,583

/usr/lib/python3.8/site-packages/picard/webservice/__init__._handle_reply:386: Network request error for http://api.acoustid.org:80/v2/submit: Error transferring http://api.acoustid.org:80/v2/submit - server replied: INTERNAL SERVER ERROR (QT code 401, HTTP code 500)E: 13:08:27,583

/usr/lib/python3.8/site-packages/picard/acoustid/manager.__fingerprint_submission_finished:98: AcoustID: submission failed with error 'Error transferring http://api.acoustid.org:80/v2/submit - server replied: INTERNAL SERVER ERROR': internal errorD: 13:08:27,583 /usr/lib/python3.8/site-packages/picard/webservice/ratecontrol._slow_down:185:

('api.acoustid.org', 80): slowdown; delay: 333ms -> 1000ms; ssthresh: 51; cws: 1.000

not familiar with IRC, sorry for the unformatted log output

NomebodyNocks: I think it would be good to use gist.github.com

for pasting logs

oh, true! my bad

np :)

outsidecontext Next try: https://gist.github.com/FelixRilling/ab83c413e3...

pristine__ how do I assign the ticket ?

open the link, you will see assign option in right side of the page

for that you should be logged in

so make an account on jeera

assign the ticket only if you wish to work on it :)

Yes, I will make an account on JIRA

sarthak_jain: Labs is a part of Listenbrainz project so they are linked. We have recently started writing tests for labs so it maybe possible that you don't have much to explore. I will recommend reading and understanding tests in Listenbrainz-server to figure out how it actually works, the flow etc

There are multiple tests folders inside lb-server directory which you can refer to

Yaaa

Also, since this is your first task, you may have to spend a week in just reading and understanding the codebase which is an important part of development.

you can run tests using `sudo ./test.sh`

there will be few downloads the first time you run the command, so after you write any test you can run the command to know how the tests are working.

I need need to write tests for stats ?

did you open the links in the tickte.

Stats is a module in labs

Yes

so you should write tests for scripts in the stats modul

I should begin with init?

you can start with __init__.py since it has few functions to test

yes

I will recommend you to read the codebase, read how tests are written (in python) google your doubts or post them here and then start writing tests.

Yes sure

You can filter ListenBrainz issues on jeera if you want to work on someother ticket

I am off for today

Are there any tests already written which I can refer

?

in case you have any doubt, post it here on the main channel, i will surely reply tomorrow.

> Are there any tests already written which I can refer

there is a link in the ticket

this

As i said we have just started writing tests for labs, you can refer to server to understand the flow. Let me give you some links

The codebase is all yours, spend some time reading it. See you tomorrow (post doubts here and just mention me) :)

Great. I guess this should get me started.

Thanks :)

Have a great evening

[bookbrainz-site] ruinername opened pull request #334 (master…font-awesome-migration): BB-369 - FontAwesome migration https://github.com/bookbrainz/bookbrainz-site/p...

BB-369: subtask-3 https://tickets.metabrainz.org/browse/BB-369

@pristine__ https://gist.github.com/sjainit/d72e15f53ebdf9f...

I wrote a sample test case for a function

If you could check and tell

The test case is for a function in stats module

sarthak_jain: your reviews on your code you need to make a pull request

That will require lil knowledge of git.

Lemme share a link

This is a really good resource

> If you could check and tell

You should run ./test.sh to validate your tests :)

pristine__ I couldnt make much sense

Did you go through the test?

Does it look fine?

sarthak_jain: what does not makes sense to you?

Did you run ./test.sh to validate your code

where do I need to create the file test.sh?

Code is generally not reviewed on gists. Please make pull request and I will review

> where do I need to create the file test.sh?

You don't have to create it... It is inside listenbrainz-labs

Ya got it

You just need to run `sudo ./test.sh`

Where do I need to write my code?

I mean the test case I have written

> Where do I need to write my code?

Did you read pytest docs?

Yes

How pytest discovers test files

Yes

Here.

Please go through it. And have a look how other test dirs are saved. If you are writing tests for stats module you should have a tests folder inside stats module and inside that tests folder you should have tests scripts for each script of stats.

And remember the name of script should be test_*

It can be test_init.py

Ohh

That is why I said go through the codebase and figure out patterns :)

That is how I do it :p

Should I do changes by adding a new branch?

Yes....one should avoid making changes in master

Yas