0:39 AM
nav2002__ has quit
1:02 AM
chaban has quit
1:03 AM
d4rkie joined the channel
1:05 AM
D4RK-PH0ENiX has quit
1:26 AM
d4rkie has quit
1:27 AM
D4RK-PH0ENiX joined the channel
1:40 AM
nav2002__ joined the channel
1:45 AM
rahul24 joined the channel
1:46 AM
Cathain joined the channel
1:47 AM
Cathain
Trying to set up an acousticbrainz server but during the docker build, I get the error "ERROR: Service 'webserver' failed to build: The command '/bin/sh -c git clone
https://github.com/MTG/gaia /tmp/gaia && cd /tmp/gaia && ./waf configure --with-python-bindings && ./waf && ./waf install && cd / && rm -r /tmp/gaia' returned a non-zero code: 1" Any direction how to debug
1:47 AM
it?
1:49 AM
rahul24
hi
2:38 AM
rahul24 has quit
2:40 AM
rahul24 joined the channel
2:40 AM
Cathain
I think my problem has to do with step 10 of the build stating eigen3 is not found despite me having libeigen3-dev installed
2:54 AM
rahul24 has quit
3:05 AM
rahul24 joined the channel
3:23 AM
Cathain has quit
3:39 AM
leonardo has quit
3:59 AM
rdswift_ joined the channel
4:01 AM
nav2002__ has quit
4:01 AM
rdswift has quit
4:01 AM
rdswift_ is now known as rdswift
4:06 AM
nav2002_ joined the channel
4:08 AM
yokel has quit
4:08 AM
madmouser1 has quit
4:08 AM
bitmap has quit
4:08 AM
moufl has quit
4:08 AM
niceplace has quit
4:08 AM
crashtestdummy has quit
4:09 AM
nawcom has quit
4:09 AM
navap has quit
4:09 AM
pprkut has quit
4:41 AM
sarthak_jain joined the channel
4:42 AM
sarthak_jain
pristine__ Hey
4:43 AM
I think the problem is I am trying to access the __init.py__ in my test script my calling the module listenbrainz_spark.stats
4:43 AM
But it doesnt identify it
4:45 AM
pristine__
sarthak_jain: since it is your first attempt, copy your code on gist, I will have a look but from next time please make a PR.
4:50 AM
sarthak_jain
Thankss
4:50 AM
4:54 AM
pristine__
Whenever we import/call a module the __init__.py gets called executed first, like a constructor so you should jmport it like this
4:54 AM
4:54 AM
And use like this
4:55 AM
4:55 AM
Also don't forget to create a __init__.py file in your tests folder even if it is empty.
4:56 AM
Otherwise the dirs won't be recognized as modules
4:59 AM
sarthak_jain
I checked the LB server test files.
5:00 AM
BrainzGit
5:03 AM
pristine__
> I checked the LB server test files.
5:04 AM
Which file
5:04 AM
Also, some changes have been recently merged into master so you should consider them pulling into your branch
5:04 AM
sarthak_jain: ^
5:08 AM
That may solve your path problem
5:08 AM
sarthak_jain
Should I pull first and then try
5:09 AM
pristine__
Yes. And did you create __init__.py in your tests folder
5:09 AM
?
5:09 AM
Add a remote and pull from labs master branch
5:10 AM
> I checked the LB server test files.
5:10 AM
Can you link the file?
5:11 AM
sarthak_jain
I pulled the changes into the master branch
5:11 AM
I created an empty __init.py__ file in tests folder.
5:13 AM
pristine__
You have to pull the changes in your current branch :(
5:13 AM
:)
5:13 AM
So that you have recent changes
5:16 AM
sarthak_jain
what is the remote I have to add? :P
5:18 AM
pristine__
5:33 AM
sarthak_jain
Okay done the pulling
5:33 AM
Now should I try running ./test.sh script again
5:34 AM
c1e0 joined the channel
5:36 AM
5:37 AM
Still getting the same import errors
5:37 AM
Now for request_consumer test file as well
5:38 AM
pristine__
I have to go out for some work. I will get back to you by evening :)
5:38 AM
sarthak_jain
Okay
5:38 AM
:)
5:51 AM
Anyone who can help with the import errors that I'm getting/
5:51 AM
6:05 AM
pristine__
sarthak_jain: do you have a config.py file
6:05 AM
In labs
6:07 AM
You must have have config.py.sample
6:07 AM
You need to make a copy of the file and save it as config.py
6:08 AM
sarthak_jain
Ohh
6:09 AM
Where do I need to save it
6:09 AM
at the same location as config.py.sample/
6:09 AM
?
6:09 AM
pristine__
`cp listenbrainz_spark/config.py.sampke listenbrainz_spark/config.py`
6:09 AM
11:39:25 <pristine__> `cp listenbrainz_spark/config.py.sample listenbrainz_spark/config.py`
6:10 AM
> at the same location as config.py.sample/
6:10 AM
Yes
6:10 AM
sarthak_jain
Yes done that
6:11 AM
Yes, I guess tests are happening now
6:16 AM
sbvkrishna joined the channel
6:25 AM
Yes, it worked
6:26 AM
What is the percentage thing that comes while testing?
6:30 AM
The two test functions are working fine
6:30 AM
Should I raise a PR for you to verify?
6:53 AM
pristine__
All test cases should pass
6:53 AM
> Should I raise a PR for you to verify?
6:53 AM
Yes
6:55 AM
d4rkie joined the channel
6:57 AM
D4RK-PH0ENiX has quit
7:16 AM
sarthak_jain
So, init had 4 functions
7:17 AM
I am trying to understand the run_query function
7:17 AM
Rest 3 test cases pass
7:18 AM
Can you guide me on how to raise a PR?
7:19 AM
Also can you help me about what the percentages represent
7:19 AM
for test_utils its 100%, for test_init(the one I've written) its 46%
7:46 AM
7:48 AM
Wassabi joined the channel
7:48 AM
leonardo joined the channel
7:48 AM
pristine__
> for test_utils its 100%, for test_init(the one I've written) its 46%
7:49 AM
Paste the percentage lines
7:49 AM
> Can you guide me on how to raise a PR?
7:50 AM
Please google it. If you want to practice ones make a test PR on your github account.
7:50 AM
There are many videos resources out there.
7:50 AM
Please try to learn from them, if you still get stuck then ping me :)
7:50 AM
sarthak_jain
Initially I forked the main repo
7:50 AM
pristine__
> I am trying to understand the run_query function
7:51 AM
sarthak_jain
Is that a problem?
7:51 AM
pristine__
That requires knowledge of spark. You will have to research a lil
7:51 AM
sarthak_jain
I dint fork it. I just cloned it directly from the main repo
7:52 AM
7:52 AM
Is that a problem
7:53 AM
pristine__
No
7:53 AM
sarthak_jain
How will I raise a PR then?
7:53 AM
pristine__
Read about fork and clone. You should always, always google stuff or try to find out yourself before asking here
7:54 AM
> How will I raise a PR then?
7:54 AM
Google
7:54 AM
I am off now :)
7:54 AM
sarthak_jain
Okayy :)
8:08 AM
d4rkie has quit
8:08 AM
D4RK-PH0ENiX joined the channel
8:27 AM
I raised a PR.
8:30 AM
>Paste the percentage lines
8:30 AM
8:42 AM
Sophist-UK has quit
8:43 AM
Sophist-UK joined the channel
8:48 AM
pristine__
I don't see any PR
8:49 AM
You pushed changes and they will be reflected in your github, from there you have to make PR in labs master
8:49 AM
sarthak_jain
8:49 AM
VxJasonxV has quit
8:51 AM
VxJasonxV joined the channel
8:51 AM
pristine__
That's is my github account
8:51 AM
That I have forked
8:51 AM
8:52 AM
PRs have to be made here. Please get a few tutorials on github.
8:52 AM
BrainzGit
8:53 AM
sarthak_jain
Now, check!
8:53 AM
pristine__
While making the PR you have to follow the format, write a lil description, prob, solution action if any
8:54 AM
> Now, check!