0:39 AM
nav2002__ has quit
2019-12-16 35017, 2019
1:02 AM
chaban has quit
2019-12-16 35006, 2019
1:03 AM
d4rkie joined the channel
2019-12-16 35033, 2019
1:05 AM
D4RK-PH0ENiX has quit
2019-12-16 35052, 2019
1:26 AM
d4rkie has quit
2019-12-16 35028, 2019
1:27 AM
D4RK-PH0ENiX joined the channel
2019-12-16 35001, 2019
1:40 AM
nav2002__ joined the channel
2019-12-16 35051, 2019
1:45 AM
rahul24 joined the channel
2019-12-16 35026, 2019
1:46 AM
Cathain joined the channel
2019-12-16 35051, 2019
1:47 AM
Cathain
Trying to set up an acousticbrainz server but during the docker build, I get the error "ERROR: Service 'webserver' failed to build: The command '/bin/sh -c git clone
https://github.com/MTG/gaia /tmp/gaia && cd /tmp/gaia && ./waf configure --with-python-bindings && ./waf && ./waf install && cd / && rm -r /tmp/gaia' returned a non-zero code: 1" Any direction how to debug
2019-12-16 35051, 2019
1:47 AM
Cathain
it?
2019-12-16 35022, 2019
1:49 AM
rahul24
hi
2019-12-16 35056, 2019
2:38 AM
rahul24 has quit
2019-12-16 35006, 2019
2:40 AM
rahul24 joined the channel
2019-12-16 35015, 2019
2:40 AM
Cathain
I think my problem has to do with step 10 of the build stating eigen3 is not found despite me having libeigen3-dev installed
2019-12-16 35014, 2019
2:54 AM
rahul24 has quit
2019-12-16 35048, 2019
3:05 AM
rahul24 joined the channel
2019-12-16 35033, 2019
3:23 AM
Cathain has quit
2019-12-16 35013, 2019
3:39 AM
leonardo has quit
2019-12-16 35016, 2019
3:59 AM
rdswift_ joined the channel
2019-12-16 35017, 2019
4:01 AM
nav2002__ has quit
2019-12-16 35017, 2019
4:01 AM
rdswift has quit
2019-12-16 35021, 2019
4:01 AM
rdswift_ is now known as rdswift
2019-12-16 35012, 2019
4:06 AM
nav2002_ joined the channel
2019-12-16 35057, 2019
4:08 AM
yokel has quit
2019-12-16 35057, 2019
4:08 AM
madmouser1 has quit
2019-12-16 35057, 2019
4:08 AM
bitmap has quit
2019-12-16 35058, 2019
4:08 AM
moufl has quit
2019-12-16 35058, 2019
4:08 AM
niceplace has quit
2019-12-16 35058, 2019
4:08 AM
crashtestdummy has quit
2019-12-16 35012, 2019
4:09 AM
nawcom has quit
2019-12-16 35012, 2019
4:09 AM
navap has quit
2019-12-16 35012, 2019
4:09 AM
pprkut has quit
2019-12-16 35025, 2019
4:41 AM
sarthak_jain joined the channel
2019-12-16 35019, 2019
4:42 AM
sarthak_jain
pristine__ Hey
2019-12-16 35004, 2019
4:43 AM
sarthak_jain
I think the problem is I am trying to access the __init.py__ in my test script my calling the module listenbrainz_spark.stats
2019-12-16 35015, 2019
4:43 AM
sarthak_jain
But it doesnt identify it
2019-12-16 35058, 2019
4:45 AM
pristine__
sarthak_jain: since it is your first attempt, copy your code on gist, I will have a look but from next time please make a PR.
2019-12-16 35029, 2019
4:50 AM
sarthak_jain
Thankss
2019-12-16 35031, 2019
4:50 AM
sarthak_jain
2019-12-16 35037, 2019
4:54 AM
pristine__
Whenever we import/call a module the __init__.py gets called executed first, like a constructor so you should jmport it like this
2019-12-16 35053, 2019
4:54 AM
pristine__
2019-12-16 35057, 2019
4:54 AM
pristine__
And use like this
2019-12-16 35022, 2019
4:55 AM
pristine__
2019-12-16 35048, 2019
4:55 AM
pristine__
Also don't forget to create a __init__.py file in your tests folder even if it is empty.
2019-12-16 35005, 2019
4:56 AM
pristine__
Otherwise the dirs won't be recognized as modules
2019-12-16 35042, 2019
4:59 AM
sarthak_jain
I checked the LB server test files.
2019-12-16 35039, 2019
5:00 AM
BrainzGit
2019-12-16 35057, 2019
5:03 AM
pristine__
> I checked the LB server test files.
2019-12-16 35001, 2019
5:04 AM
pristine__
Which file
2019-12-16 35030, 2019
5:04 AM
pristine__
Also, some changes have been recently merged into master so you should consider them pulling into your branch
2019-12-16 35041, 2019
5:04 AM
pristine__
sarthak_jain: ^
2019-12-16 35009, 2019
5:08 AM
pristine__
That may solve your path problem
2019-12-16 35028, 2019
5:08 AM
sarthak_jain
Should I pull first and then try
2019-12-16 35044, 2019
5:09 AM
pristine__
Yes. And did you create __init__.py in your tests folder
2019-12-16 35045, 2019
5:09 AM
pristine__
?
2019-12-16 35058, 2019
5:09 AM
pristine__
Add a remote and pull from labs master branch
2019-12-16 35036, 2019
5:10 AM
pristine__
> I checked the LB server test files.
2019-12-16 35041, 2019
5:10 AM
pristine__
Can you link the file?
2019-12-16 35012, 2019
5:11 AM
sarthak_jain
I pulled the changes into the master branch
2019-12-16 35045, 2019
5:11 AM
sarthak_jain
I created an empty __init.py__ file in tests folder.
2019-12-16 35007, 2019
5:13 AM
pristine__
You have to pull the changes in your current branch :(
2019-12-16 35011, 2019
5:13 AM
pristine__
:)
2019-12-16 35024, 2019
5:13 AM
pristine__
So that you have recent changes
2019-12-16 35009, 2019
5:16 AM
sarthak_jain
what is the remote I have to add? :P
2019-12-16 35001, 2019
5:18 AM
pristine__
2019-12-16 35035, 2019
5:33 AM
sarthak_jain
Okay done the pulling
2019-12-16 35047, 2019
5:33 AM
sarthak_jain
Now should I try running ./test.sh script again
2019-12-16 35032, 2019
5:34 AM
c1e0 joined the channel
2019-12-16 35044, 2019
5:36 AM
sarthak_jain
2019-12-16 35001, 2019
5:37 AM
sarthak_jain
Still getting the same import errors
2019-12-16 35009, 2019
5:37 AM
sarthak_jain
Now for request_consumer test file as well
2019-12-16 35014, 2019
5:38 AM
pristine__
I have to go out for some work. I will get back to you by evening :)
2019-12-16 35041, 2019
5:38 AM
sarthak_jain
Okay
2019-12-16 35044, 2019
5:38 AM
sarthak_jain
:)
2019-12-16 35016, 2019
5:51 AM
sarthak_jain
Anyone who can help with the import errors that I'm getting/
2019-12-16 35027, 2019
5:51 AM
sarthak_jain
2019-12-16 35007, 2019
6:05 AM
pristine__
sarthak_jain: do you have a config.py file
2019-12-16 35009, 2019
6:05 AM
pristine__
In labs
2019-12-16 35033, 2019
6:07 AM
pristine__
You must have have config.py.sample
2019-12-16 35054, 2019
6:07 AM
pristine__
You need to make a copy of the file and save it as config.py
2019-12-16 35050, 2019
6:08 AM
sarthak_jain
Ohh
2019-12-16 35000, 2019
6:09 AM
sarthak_jain
Where do I need to save it
2019-12-16 35012, 2019
6:09 AM
sarthak_jain
at the same location as config.py.sample/
2019-12-16 35016, 2019
6:09 AM
sarthak_jain
?
2019-12-16 35025, 2019
6:09 AM
pristine__
`cp listenbrainz_spark/config.py.sampke listenbrainz_spark/config.py`
2019-12-16 35043, 2019
6:09 AM
pristine__
11:39:25 <pristine__> `cp listenbrainz_spark/config.py.sample listenbrainz_spark/config.py`
2019-12-16 35013, 2019
6:10 AM
pristine__
> at the same location as config.py.sample/
2019-12-16 35015, 2019
6:10 AM
pristine__
Yes
2019-12-16 35050, 2019
6:10 AM
sarthak_jain
Yes done that
2019-12-16 35059, 2019
6:11 AM
sarthak_jain
Yes, I guess tests are happening now
2019-12-16 35049, 2019
6:16 AM
sbvkrishna joined the channel
2019-12-16 35030, 2019
6:25 AM
sarthak_jain
Yes, it worked
2019-12-16 35044, 2019
6:26 AM
sarthak_jain
What is the percentage thing that comes while testing?
2019-12-16 35016, 2019
6:30 AM
sarthak_jain
The two test functions are working fine
2019-12-16 35027, 2019
6:30 AM
sarthak_jain
Should I raise a PR for you to verify?
2019-12-16 35043, 2019
6:53 AM
pristine__
All test cases should pass
2019-12-16 35054, 2019
6:53 AM
pristine__
> Should I raise a PR for you to verify?
2019-12-16 35055, 2019
6:53 AM
pristine__
Yes
2019-12-16 35019, 2019
6:55 AM
d4rkie joined the channel
2019-12-16 35027, 2019
6:57 AM
D4RK-PH0ENiX has quit
2019-12-16 35053, 2019
7:16 AM
sarthak_jain
So, init had 4 functions
2019-12-16 35012, 2019
7:17 AM
sarthak_jain
I am trying to understand the run_query function
2019-12-16 35029, 2019
7:17 AM
sarthak_jain
Rest 3 test cases pass
2019-12-16 35005, 2019
7:18 AM
sarthak_jain
Can you guide me on how to raise a PR?
2019-12-16 35027, 2019
7:19 AM
sarthak_jain
Also can you help me about what the percentages represent
2019-12-16 35052, 2019
7:19 AM
sarthak_jain
for test_utils its 100%, for test_init(the one I've written) its 46%
2019-12-16 35007, 2019
7:46 AM
sarthak_jain
2019-12-16 35014, 2019
7:48 AM
Wassabi joined the channel
2019-12-16 35023, 2019
7:48 AM
leonardo joined the channel
2019-12-16 35058, 2019
7:48 AM
pristine__
> for test_utils its 100%, for test_init(the one I've written) its 46%
2019-12-16 35011, 2019
7:49 AM
pristine__
Paste the percentage lines
2019-12-16 35021, 2019
7:49 AM
pristine__
> Can you guide me on how to raise a PR?
2019-12-16 35016, 2019
7:50 AM
pristine__
Please google it. If you want to practice ones make a test PR on your github account.
2019-12-16 35024, 2019
7:50 AM
pristine__
There are many videos resources out there.
2019-12-16 35045, 2019
7:50 AM
pristine__
Please try to learn from them, if you still get stuck then ping me :)
2019-12-16 35057, 2019
7:50 AM
sarthak_jain
Initially I forked the main repo
2019-12-16 35058, 2019
7:50 AM
pristine__
> I am trying to understand the run_query function
2019-12-16 35003, 2019
7:51 AM
sarthak_jain
Is that a problem?
2019-12-16 35020, 2019
7:51 AM
pristine__
That requires knowledge of spark. You will have to research a lil
2019-12-16 35052, 2019
7:51 AM
sarthak_jain
I dint fork it. I just cloned it directly from the main repo
2019-12-16 35000, 2019
7:52 AM
sarthak_jain
2019-12-16 35006, 2019
7:52 AM
sarthak_jain
Is that a problem
2019-12-16 35022, 2019
7:53 AM
pristine__
No
2019-12-16 35047, 2019
7:53 AM
sarthak_jain
How will I raise a PR then?
2019-12-16 35052, 2019
7:53 AM
pristine__
Read about fork and clone. You should always, always google stuff or try to find out yourself before asking here
2019-12-16 35001, 2019
7:54 AM
pristine__
> How will I raise a PR then?
2019-12-16 35002, 2019
7:54 AM
pristine__
Google
2019-12-16 35009, 2019
7:54 AM
pristine__
I am off now :)
2019-12-16 35020, 2019
7:54 AM
sarthak_jain
Okayy :)
2019-12-16 35003, 2019
8:08 AM
d4rkie has quit
2019-12-16 35051, 2019
8:08 AM
D4RK-PH0ENiX joined the channel
2019-12-16 35046, 2019
8:27 AM
sarthak_jain
I raised a PR.
2019-12-16 35032, 2019
8:30 AM
sarthak_jain
>Paste the percentage lines
2019-12-16 35042, 2019
8:30 AM
sarthak_jain
2019-12-16 35042, 2019
8:42 AM
Sophist-UK has quit
2019-12-16 35004, 2019
8:43 AM
Sophist-UK joined the channel
2019-12-16 35024, 2019
8:48 AM
pristine__
I don't see any PR
2019-12-16 35000, 2019
8:49 AM
pristine__
You pushed changes and they will be reflected in your github, from there you have to make PR in labs master
2019-12-16 35027, 2019
8:49 AM
sarthak_jain
2019-12-16 35057, 2019
8:49 AM
VxJasonxV has quit
2019-12-16 35006, 2019
8:51 AM
VxJasonxV joined the channel
2019-12-16 35026, 2019
8:51 AM
pristine__
That's is my github account
2019-12-16 35042, 2019
8:51 AM
pristine__
That I have forked
2019-12-16 35057, 2019
8:51 AM
pristine__
2019-12-16 35020, 2019
8:52 AM
pristine__
PRs have to be made here. Please get a few tutorials on github.
2019-12-16 35035, 2019
8:52 AM
BrainzGit
2019-12-16 35015, 2019
8:53 AM
sarthak_jain
Now, check!
2019-12-16 35053, 2019
8:53 AM
pristine__
While making the PR you have to follow the format, write a lil description, prob, solution action if any
2019-12-16 35002, 2019
8:54 AM
pristine__
> Now, check!
