#metabrainz

/

      • ishaanshah[m]
        Ohk
      • 2020-01-26 02643, 2020

      • iliekcomputers
        is there a reason you went with getting ALL of them and then sending them?
      • 2020-01-26 02615, 2020

      • ishaanshah[m]
        No particular reason as such
      • 2020-01-26 02651, 2020

      • ishaanshah[m]
        Just thought it would be easier to handle all the fetches and then deal with the sending part
      • 2020-01-26 02617, 2020

      • iliekcomputers
        in that case, i'd prefer to not change current functionality, as it might confuse users who are used to thinking that if a page was done by the importer, it must have been imported.
      • 2020-01-26 02623, 2020

      • iliekcomputers
        I was definitely confused for a second :D
      • 2020-01-26 02633, 2020

      • ishaanshah[m]
        Ohk
      • 2020-01-26 02639, 2020

      • ishaanshah[m]
        How about this
      • 2020-01-26 02658, 2020

      • ishaanshah[m]
        I get 10 pages, send those and get next
      • 2020-01-26 02658, 2020

      • ishaanshah[m]
        10
      • 2020-01-26 02605, 2020

      • ishaanshah[m]
        And so on
      • 2020-01-26 02640, 2020

      • iliekcomputers
        let me look up what exactly we do currently.
      • 2020-01-26 02613, 2020

      • iliekcomputers
        ruaok: zas: could we deploy https://livegrep.com/search/linux for our codebases? :D
      • 2020-01-26 02622, 2020

      • iliekcomputers
      • 2020-01-26 02636, 2020

      • iliekcomputers
        would make life much better when searching code :D :D
      • 2020-01-26 02605, 2020

      • zas
        since it has github integration and docker images, I guess it is feasible
      • 2020-01-26 02602, 2020

      • zas
        What are the advantages over gtihub searches?
      • 2020-01-26 02617, 2020

      • iliekcomputers
        zas: it's miles better than github search
      • 2020-01-26 02635, 2020

      • iliekcomputers
        github is bad at searching for files by name
      • 2020-01-26 02656, 2020

      • iliekcomputers
        here's a search for the file "scraper.js": https://github.com/metabrainz/listenbrainz-server…
      • 2020-01-26 02620, 2020

      • iliekcomputers
        also has cool stuff like search in this directory or in these type of files etc.
      • 2020-01-26 02609, 2020

      • iliekcomputers
        this is the file I was looking for btw: https://github.com/metabrainz/listenbrainz-server…
      • 2020-01-26 02613, 2020

      • iliekcomputers
        nowhere in the github search :(
      • 2020-01-26 02633, 2020

      • iliekcomputers
        https://livegrep.com/search/linux?q=file%3A.json%… (stuff like this is just not possible with github search)
      • 2020-01-26 02638, 2020

      • iliekcomputers
        ishaanshah[m]: i would prefer to get 1 page, submit 1 page, update the message, get another, submit another, update message for now.
      • 2020-01-26 02647, 2020

      • iliekcomputers
        because that's what we do right now.
      • 2020-01-26 02604, 2020

      • ishaanshah[m]
        Ok.
      • 2020-01-26 02628, 2020

      • iliekcomputers
        zas: should I open an MBH ticket?
      • 2020-01-26 02640, 2020

      • ishaanshah[m]
        I will make the necessary changes.
      • 2020-01-26 02657, 2020

      • ishaanshah[m]
        I just changed the flow of the code a bit
      • 2020-01-26 02615, 2020

      • abhishekpanwar joined the channel
      • 2020-01-26 02648, 2020

      • ishaanshah[m]
        So as to make it easy to read.
      • 2020-01-26 02655, 2020

      • iliekcomputers
        ishaanshah[m]: thanks!
      • 2020-01-26 02626, 2020

      • iliekcomputers
        once you change the behaviour to get 1 page, submit 1 page, request a review again.
      • 2020-01-26 02631, 2020

      • ishaanshah[m]
        Can you just take a look at the flow and tell me if it is fine
      • 2020-01-26 02644, 2020

      • abhishekpanwar has quit
      • 2020-01-26 02621, 2020

      • iliekcomputers
        ishaanshah[m]: do you have specific commits you want me to look at?
      • 2020-01-26 02651, 2020

      • ishaanshah[m]
        Just tell me if what I am is correct
      • 2020-01-26 02601, 2020

      • ishaanshah[m]
        I am getting the total pages
      • 2020-01-26 02651, 2020

      • ishaanshah[m]
        Then I will get a single page
      • 2020-01-26 02604, 2020

      • ishaanshah[m]
        Encode it and submit it
      • 2020-01-26 02606, 2020

      • Nyanko-sensei has quit
      • 2020-01-26 02623, 2020

      • ishaanshah[m]
        Repeat this until everything is done
      • 2020-01-26 02651, 2020

      • iliekcomputers
        what do you mean by getting the total pages?
      • 2020-01-26 02611, 2020

      • ishaanshah[m]
        The total number of pages that Lastfm is gonna send
      • 2020-01-26 02625, 2020

      • iliekcomputers
        mhmm, that flow makes sense to me.
      • 2020-01-26 02643, 2020

      • ishaanshah[m]
        My only concern was that this would be a bit slow
      • 2020-01-26 02610, 2020

      • iliekcomputers
        ishaanshah[m]: why? we're making the same number of requests either way?
      • 2020-01-26 02658, 2020

      • ishaanshah[m]
        Coz we are not doing anything while the page is fetched we arent doing anything with the scrobbles waiting in the queue
      • 2020-01-26 02619, 2020

      • iliekcomputers
      • 2020-01-26 02620, 2020

      • BrainzBot
        MBH-532: Deploy a livegrep instance for our codebases at livegrep.metabrainz.org
      • 2020-01-26 02629, 2020

      • iliekcomputers
        ishaanshah[m]: but aren't we doing the same thing right now?
      • 2020-01-26 02620, 2020

      • ishaanshah[m]
        Ya we are
      • 2020-01-26 02626, 2020

      • iliekcomputers
        when we're fetching the scrobbles, we aren't doing anything with the scrobbles in the queue.
      • 2020-01-26 02638, 2020

      • iliekcomputers
        ishaanshah[m]: let's do the 1 page flow and see if it's very slow
      • 2020-01-26 02652, 2020

      • ishaanshah[m]
        Ok fine
      • 2020-01-26 02652, 2020

      • iliekcomputers
        if it is, we'll look into how to fix that.
      • 2020-01-26 02605, 2020

      • ishaanshah[m]
        Cool
      • 2020-01-26 02628, 2020

      • ishaanshah[m]
        I will let you know when I make the changes
      • 2020-01-26 02634, 2020

      • iliekcomputers
        awesome
      • 2020-01-26 02648, 2020

      • Nyanko-sensei joined the channel
      • 2020-01-26 02643, 2020

      • ayerhart has quit
      • 2020-01-26 02637, 2020

      • Zastai joined the channel
      • 2020-01-26 02625, 2020

      • rahul24 joined the channel
      • 2020-01-26 02659, 2020

      • rahul24 has quit
      • 2020-01-26 02642, 2020

      • prabal
        https://tickets.metabrainz.org/browse/BB-397 @Mr_Monkey What do you think of this
      • 2020-01-26 02643, 2020

      • BrainzBot
        BB-397: revisions in editor's profile can be improved
      • 2020-01-26 02627, 2020

      • prabal
        https://github.com/bookbrainz/bookbrainz-site/pul… Have a look at this when you're free. Also I made changes in revisionsPage PR :)
      • 2020-01-26 02657, 2020

      • prabal
        @rahul24 Hey sorry for late reply, I assigned myself only a few of them, you can have a look at the rest :)
      • 2020-01-26 02624, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #348 (master…react-fontawesome-#BB371): React fontawesome #bb371 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-01-26 02603, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #349 (master…react-fontawesome-#BB372): React fontawesome #bb372 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-01-26 02643, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #350 (master…react-fontawesome-BB373): React fontawesome bb373 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-01-26 02626, 2020

      • SothoTalKer
        outsidecontext: i personally think the Scan/AcoustID function in Picard needs more feedback for users
      • 2020-01-26 02650, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #351 (master…react-fontawesome-BB374): React fontawesome bb374 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-01-26 02637, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #352 (master…react-fontawesome-#BB376): React fontawesome #bb376 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-01-26 02608, 2020

      • BrainzGit
        [bookbrainz-site] prabalsingh24 opened pull request #353 (master…react-fontawesome-#BB375): React fontawesome #bb375 https://github.com/bookbrainz/bookbrainz-site/pul…
      • 2020-01-26 02601, 2020

      • SothoTalKer
        outsidecontext: also, when a DiscID does not exist, there are errors in the log - is this wanted? :)
      • 2020-01-26 02637, 2020

      • ayerhart joined the channel
      • 2020-01-26 02626, 2020

      • BrainzGit
        [listenbrainz-server] paramsingh merged pull request #708 (master…stream-export): LB-484: Stream response from /profile/export endpoint https://github.com/metabrainz/listenbrainz-server…
      • 2020-01-26 02627, 2020

      • BrainzBot
        LB-484: 504 Gateway Timeout when trying to export listens https://tickets.metabrainz.org/browse/LB-484
      • 2020-01-26 02658, 2020

      • pristine__
        shivam-kapila: you around?
      • 2020-01-26 02637, 2020

      • iliekcomputers
        someone messed the recents page up https://usercontent.irccloud-cdn.com/file/Xbu8ZQG…
      • 2020-01-26 02655, 2020

      • iliekcomputers
        CatQuest: I see a few unrelated issues in this epic: https://tickets.metabrainz.org/projects/LB/issues…
      • 2020-01-26 02656, 2020

      • BrainzBot
        LB-479: Ship user statistics
      • 2020-01-26 02612, 2020

      • pristine__
        shivam-kapila: Whenver you're up have a look at https://tickets.metabrainz.org/browse/LB-486 ( as per your wish to hold to a task in labs) .
      • 2020-01-26 02612, 2020

      • BrainzBot
        LB-486: Create dumps of candidate recordings
      • 2020-01-26 02638, 2020

      • pristine__
        if it makes sense to you, assign it to yourself, please :)
      • 2020-01-26 02607, 2020

      • amCap1712
        pristine__: iliekcomputers: i had a question about listens. say, a user pauses a song after listening to enough duration to count as a listen. he resumes the song but at a later time and again listens the song for enough duration to count as a listen. Should this be treated as a single listen or two different listens?
      • 2020-01-26 02605, 2020

      • iliekcomputers
        amCap1712: thinking about this holistically, i think it depends on the duration for which the song was paused.
      • 2020-01-26 02627, 2020

      • iliekcomputers
        if it was paused for like 30s, i'd prefer if it was counted as a single listen.
      • 2020-01-26 02650, 2020

      • iliekcomputers
        if it was longer, say a minute or 5 minutes, that's probably two listens.
      • 2020-01-26 02600, 2020

      • iliekcomputers
        amCap1712: is this about your vlc plugin?
      • 2020-01-26 02645, 2020

      • amCap1712
        iliekcomputers: yes, i was testing it out and found that vlc provides somes options to behave differently on pausing a song, manually stopping a song or when a song play fully. so i asked?
      • 2020-01-26 02600, 2020

      • iliekcomputers
        mhmm, makes sense.
      • 2020-01-26 02605, 2020

      • iliekcomputers
        If what I said is technically difficult to implement, I would tend towards recording them as two listens.
      • 2020-01-26 02635, 2020

      • amCap1712
        I'll try to implement so what should keep the cutoff time for two listens?
      • 2020-01-26 02615, 2020

      • iliekcomputers
        let's go with a minute
      • 2020-01-26 02625, 2020

      • iliekcomputers
        we can get user feedback later (once we release)
      • 2020-01-26 02629, 2020

      • amCap1712
        ok great
      • 2020-01-26 02634, 2020

      • iliekcomputers
        do you have source code somewhere, by any chance?
      • 2020-01-26 02648, 2020

      • amCap1712
        its a single file in C
      • 2020-01-26 02602, 2020

      • amCap1712
        I can send you the file if you want.
      • 2020-01-26 02658, 2020

      • iliekcomputers
        haha, np.
      • 2020-01-26 02607, 2020

      • iliekcomputers
        what's the plan tho?
      • 2020-01-26 02621, 2020

      • iliekcomputers
        are you gonna try to get it merged into vlc?
      • 2020-01-26 02625, 2020

      • amCap1712
        yes
      • 2020-01-26 02630, 2020

      • iliekcomputers
        because that would be amazing!
      • 2020-01-26 02635, 2020

      • iliekcomputers
        amCap1712: awesome!
      • 2020-01-26 02639, 2020

      • amCap1712
        its working fine on linux
      • 2020-01-26 02648, 2020

      • amCap1712
        i am testing windows at this moment
      • 2020-01-26 02659, 2020

      • amCap1712
        and then will check on mac
      • 2020-01-26 02602, 2020

      • iliekcomputers
        ah, awesome.
      • 2020-01-26 02626, 2020

      • iliekcomputers
        please link your PR whenever you create it.
      • 2020-01-26 02626, 2020

      • amCap1712
        if it goes well then i will ask the community to test and then submit it to vlc
      • 2020-01-26 02637, 2020

      • amCap1712
        yeah sure
      • 2020-01-26 02655, 2020

      • shivam-kapila
        pristine__: Hi. I am up now. I have had a look into the task. So I have to create data dumps just like the LB listens?
      • 2020-01-26 02615, 2020

      • pristine__
        > like LB listens?
      • 2020-01-26 02621, 2020

      • pristine__
        I am not sure what you mean.
      • 2020-01-26 02631, 2020

      • pristine__
        We want to create dumps of recordings
      • 2020-01-26 02655, 2020

      • pristine__
        shivam-kapila: ^
      • 2020-01-26 02637, 2020

      • shivam-kapila
        I meant like the data dumps on ftp server.
      • 2020-01-26 02653, 2020

      • iliekcomputers
        ruaok: a meeting tomorrow to catch up would be helpful.
      • 2020-01-26 02620, 2020

      • ruaok
        Perfect! Let's do it
      • 2020-01-26 02644, 2020

      • Cyna
        bitmap, reosarevok : would be great if you could review both PRs of Series entity. Soon after I'll push PRs for next set of entity type
      • 2020-01-26 02612, 2020

      • pristine__
        shivam-kapila: yeah. A good place to start with will be to get the desired attributes as in the schema
      • 2020-01-26 02615, 2020

      • pristine__
      • 2020-01-26 02653, 2020

      • rahul24 joined the channel
      • 2020-01-26 02649, 2020

      • shivam-kapila
        prabal: Thanks :)
      • 2020-01-26 02601, 2020

      • shivam-kapila
        Sorry wrong mention
      • 2020-01-26 02607, 2020

      • shivam-kapila
        pristine__: Thanks
      • 2020-01-26 02625, 2020

      • Zastai has quit
      • 2020-01-26 02625, 2020

      • c1e0 has quit
      • 2020-01-26 02617, 2020

      • ayerhart has quit
      • 2020-01-26 02639, 2020

      • ayerhart joined the channel
      • 2020-01-26 02626, 2020

      • reosarevok
        Cyna: I'll check in a bit, not sure if bitmap is around tonight or not though :)
      • 2020-01-26 02658, 2020

      • ruaok heads out to have lunch with bitmap
      • 2020-01-26 02615, 2020

      • NitricEster joined the channel
      • 2020-01-26 02610, 2020

      • reosarevok
        Oh
      • 2020-01-26 02615, 2020

      • reosarevok
        So, I guess he's not around right now :p
      • 2020-01-26 02630, 2020

      • Gazooo has quit
      • 2020-01-26 02611, 2020

      • Gazooo joined the channel
      • 2020-01-26 02647, 2020

      • NitricEster has quit
      • 2020-01-26 02611, 2020

      • iliekcomputers
        ruaok: I thought you were back in Europe lol
      • 2020-01-26 02613, 2020

      • zas
        he was, last week ;)
      • 2020-01-26 02606, 2020

      • iliekcomputers
        Haha
      • 2020-01-26 02609, 2020

      • ruaok
        Yep. And will be tomorrow.
      • 2020-01-26 02658, 2020

      • ruaok
        Lx9 leaves in 4:30. And stop this wild culture shock ride
      • 2020-01-26 02640, 2020

      • CatQuest
        iliekcomputers: ack. that would be GCI students messing things up
      • 2020-01-26 02633, 2020

      • iliekcomputers
        CatQuest: np, just wanted to flag the issue.
      • 2020-01-26 02654, 2020

      • CatQuest
        huh. say iliekcomputers can "epic" type ticekts have tickets that have sub-tiets in them?