#metabrainz

Moin!

[listenbrainz-server] paramsingh merged pull request #704 (master…param/make-rabbitmq-messages-smaller): Make stats rabbitmq messages smaller https://github.com/metabrainz/listenbrainz-serv...

ishaanshah[m]: are you around, by any chance?

pristine__: hi

I'm looking at trello and I see that you're working on automating dump imports into the cluser

cluster

is there anything I can take and push forward on this?

iliekcomputers: Hi, are you there

ishaanshah[m]: hi

iliekcomputers: I didn't get the chance to look at Trello but as of now I have enabled downloading and uploading dumps using spark_manage and from here I will be working for the release ( create recording dumps).

i've been testing the import PR

If you find anything suitable from here to work on, go ahead :(

:) *

and it seems to have the incremental import feature, i might have commented a bit too fast.

It has the incremental feature, but I realized that there is a minor bug in it.

is it getting old pages instead of new ones?

Suppose the user closes the window mid import, then the latest time won't be updated

ishaanshah[m]: that's ok for now.

ishaanshah[m]: have you tested the incremental import thing ?

But if I set the latest import time after each page,

The incremental import would work correctly even if it was cut of mid import

> have you tested the incremental import thing ?

ishaanshah[m]: that seems a bit too much. That would mean thousands of extra API requests per full import

Yes I hav

have*

we could however send a request to `latest-import` when the close button is clicked.

however, that seems like a future pr

i would first like tests for this one.

Ohk, fine.

So should I start looking into writing tests

there's a few minor indentation problems in the jsx

if you fix that, i'll merge this.

and then let's follow up with tests for this.

I will look into it.

Also is the update message thing acceptable now?

I think so, I still don't like the fact that we have jsx in the importer.js file to be honest, but we can fix that later.

also

i'm a bit uncomfortable that we've removed a test that tests behaviour for user with non-ascii usernames

I think testing that imports work for those users still work might be a good idea too.

Good point.

I will look into it

thx!

I knew that i18n is regarding internationalization, but I only now realized that it actually stands for 'i' + 18 characters + 'n'. Duh.

rdswift: there is also l10n :D

:-)

i14y a11y o11y k8s s5n E15

S9r

:-P

what the hell does those stand for

(you too Lotheric)

sothotalker

:p

s9r

heh

i14y – interoperability

a11y – accessibility^

o11y - Observability

k8s – Kubernetes

s5n – shorten

AAAAAAAND :D

b4r t2s

E15 – The Eyjafjallajökull volcano in Iceland

G13k

Gesamtkunstwerk!

Heftbeilage