I'm looking at trello and I see that you're working on automating dump imports into the cluser
2020-02-01 03220, 2020
iliekcomputers
cluster
2020-02-01 03234, 2020
iliekcomputers
is there anything I can take and push forward on this?
2020-02-01 03256, 2020
c1e0 has quit
2020-02-01 03208, 2020
ishaanshah[m]
iliekcomputers: Hi, are you there
2020-02-01 03216, 2020
iliekcomputers
ishaanshah[m]: hi
2020-02-01 03217, 2020
pristine__
iliekcomputers: I didn't get the chance to look at Trello but as of now I have enabled downloading and uploading dumps using spark_manage and from here I will be working for the release ( create recording dumps).
2020-02-01 03227, 2020
iliekcomputers
i've been testing the import PR
2020-02-01 03243, 2020
pristine__
If you find anything suitable from here to work on, go ahead :(
2020-02-01 03247, 2020
pristine__
:) *
2020-02-01 03203, 2020
iliekcomputers
and it seems to have the incremental import feature, i might have commented a bit too fast.
2020-02-01 03256, 2020
ishaanshah[m]
It has the incremental feature, but I realized that there is a minor bug in it.
2020-02-01 03230, 2020
iliekcomputers
is it getting old pages instead of new ones?
2020-02-01 03231, 2020
ishaanshah[m]
Suppose the user closes the window mid import, then the latest time won't be updated
2020-02-01 03257, 2020
iliekcomputers
ishaanshah[m]: that's ok for now.
2020-02-01 03225, 2020
iliekcomputers
ishaanshah[m]: have you tested the incremental import thing ?
2020-02-01 03241, 2020
ishaanshah[m]
But if I set the latest import time after each page,
2020-02-01 03208, 2020
ishaanshah[m]
The incremental import would work correctly even if it was cut of mid import
2020-02-01 03223, 2020
ishaanshah[m]
> have you tested the incremental import thing ?
2020-02-01 03229, 2020
iliekcomputers
ishaanshah[m]: that seems a bit too much. That would mean thousands of extra API requests per full import
2020-02-01 03229, 2020
ishaanshah[m]
Yes I hav
2020-02-01 03238, 2020
ishaanshah[m]
have*
2020-02-01 03256, 2020
iliekcomputers
we could however send a request to `latest-import` when the close button is clicked.
2020-02-01 03206, 2020
iliekcomputers
however, that seems like a future pr
2020-02-01 03213, 2020
iliekcomputers
i would first like tests for this one.
2020-02-01 03221, 2020
ishaanshah[m]
Ohk, fine.
2020-02-01 03249, 2020
ishaanshah[m]
So should I start looking into writing tests
2020-02-01 03255, 2020
iliekcomputers
there's a few minor indentation problems in the jsx
2020-02-01 03200, 2020
iliekcomputers
if you fix that, i'll merge this.
2020-02-01 03210, 2020
iliekcomputers
and then let's follow up with tests for this.
2020-02-01 03207, 2020
ishaanshah[m]
I will look into it.
2020-02-01 03244, 2020
ishaanshah[m]
Also is the update message thing acceptable now?
2020-02-01 03228, 2020
iliekcomputers
I think so, I still don't like the fact that we have jsx in the importer.js file to be honest, but we can fix that later.
2020-02-01 03236, 2020
iliekcomputers
also
2020-02-01 03214, 2020
iliekcomputers
i'm a bit uncomfortable that we've removed a test that tests behaviour for user with non-ascii usernames
2020-02-01 03230, 2020
iliekcomputers
I think testing that imports work for those users still work might be a good idea too.
2020-02-01 03213, 2020
ishaanshah[m]
Good point.
2020-02-01 03219, 2020
ishaanshah[m]
I will look into it
2020-02-01 03249, 2020
iliekcomputers
thx!
2020-02-01 03217, 2020
MajorLurker has quit
2020-02-01 03210, 2020
MajorLurker joined the channel
2020-02-01 03213, 2020
MajorLurker has quit
2020-02-01 03252, 2020
shivam-kapila joined the channel
2020-02-01 03214, 2020
sumedh joined the channel
2020-02-01 03249, 2020
sumedh has quit
2020-02-01 03237, 2020
iliekcomputers has quit
2020-02-01 03253, 2020
iliekcomputers joined the channel
2020-02-01 03256, 2020
djinni` has quit
2020-02-01 03230, 2020
djinni` joined the channel
2020-02-01 03247, 2020
discopatrick has quit
2020-02-01 03210, 2020
discopatrick joined the channel
2020-02-01 03255, 2020
defaultxr has quit
2020-02-01 03259, 2020
prabal has quit
2020-02-01 03249, 2020
madmouser1 has quit
2020-02-01 03214, 2020
madmouser1 joined the channel
2020-02-01 03215, 2020
sumedh joined the channel
2020-02-01 03244, 2020
sumedh has quit
2020-02-01 03200, 2020
moufl joined the channel
2020-02-01 03212, 2020
shivam-kapila has quit
2020-02-01 03225, 2020
shivam-kapila joined the channel
2020-02-01 03225, 2020
rdswift
I knew that i18n is regarding internationalization, but I only now realized that it actually stands for 'i' + 18 characters + 'n'. Duh.
2020-02-01 03248, 2020
rdswift feels like a dummy for not understanding that sooner.
