reosarevok: made the changes, and commented on 2 conversation. do have a look when you find time. PS I checked the ordering consistency and now its fine.
2020-02-08 03923, 2020
sumedh joined the channel
2020-02-08 03927, 2020
sumedh has quit
2020-02-08 03942, 2020
sumedh joined the channel
2020-02-08 03908, 2020
bitmap
Cyna: I left some comments too, I can check again in the morning
yvanzo, bitmap: see ticket comments - three times seems a bit much? :D
2020-02-08 03930, 2020
bitmap
hah
2020-02-08 03900, 2020
bitmap
though I'm not sure what's adding those, first I saw them
2020-02-08 03943, 2020
sampsyo has quit
2020-02-08 03947, 2020
abhishekpanwar has quit
2020-02-08 03903, 2020
yvanzo
bitmap, reosarevok: that’s a new automation rule, still debugging it atm.
2020-02-08 03905, 2020
prabal has quit
2020-02-08 03901, 2020
yvanzo
Ok, that’s yet another Automation bug, can try to work around it :(
2020-02-08 03957, 2020
yvanzo
reosarevok: as a workaround, you can add label and request reviews before creating the PR.
2020-02-08 03914, 2020
reosarevok
Ok
2020-02-08 03946, 2020
yvanzo
Issue here was PR creation, label, and review request were 3 events handled almost in parallel. Thus, even though the rule checks for existing comment, it added it 3 times.
2020-02-08 03931, 2020
yvanzo
reosarevok: with yours that was 4 comments, so I removed all of bot comments.
2020-02-08 03944, 2020
reosarevok
Thanks!
2020-02-08 03906, 2020
reosarevok
yvanzo: let me know if you want any help reviewing my stuff btw :)
2020-02-08 03927, 2020
Pac23
projects this year look intersting
2020-02-08 03932, 2020
Pac23
especially concurrency re-write and robustify sir
2020-02-08 03901, 2020
yvanzo
reosarevok: sure, are genres expected to be merged all together? or do other PRs have higher priority?
2020-02-08 03950, 2020
reosarevok
Well, I'd like to get all genre bits in in one go but it's not the end of the world
2020-02-08 03900, 2020
reosarevok
Feel free to check whatever from the milestone :)
2020-02-08 03940, 2020
bitmap
we have to update the mmd-schema submodule in the mb-solr repo for the mbs tests to pass in teh one pr
2020-02-08 03901, 2020
yvanzo
bitmap: Solr doesn’t have to deal with genres yet.
2020-02-08 03927, 2020
bitmap
yep
2020-02-08 03946, 2020
bitmap
it's just that mbs tests use the mmd-schema from mb-solr
bitmap: does it really help to have a production branch for mmd-schema?
2020-02-08 03927, 2020
yvanzo
since we now rely on tags.
2020-02-08 03901, 2020
bitmap
right. I think the original idea was it'd allow us to merge stuff to master without breaking mbs or solr, but since we use tags/submodules that are locked to specific commits, I less see the point
2020-02-08 03938, 2020
sumedh joined the channel
2020-02-08 03959, 2020
bitmap
if nothing is using it feel free to remove it since it's probably just confusing at this point
2020-02-08 03906, 2020
yvanzo
I would like to move tag v-2019-01-07 to ac9a0bdd209091a61c97915d8419180002e87931 (same commit but in master branch instead of production) and then delete production branch.
2020-02-08 03937, 2020
yvanzo
So we would still have both existing tags in master log.
2020-02-08 03928, 2020
bitmap
go for it
2020-02-08 03942, 2020
yvanzo
I will just have to update mb-rngpy not to follow production branch.
