#metabrainz

/

      • SothoTalKer has quit
      • shivam-kapila has quit
      • SothoTalKer joined the channel
      • D4RK-PH0ENiX has quit
      • rahul24 has quit
      • D4RK-PH0ENiX joined the channel
      • rahul24 joined the channel
      • agrochal joined the channel
      • agrochal has quit
      • rahul24 has left the channel
      • urluck has quit
      • urluck joined the channel
      • c1e0 joined the channel
      • c1e0_ joined the channel
      • c1e0 has quit
      • BestSteve has quit
      • Gore|woerk joined the channel
      • BrainzGit has quit
      • Gore has quit
      • shivam-kapila joined the channel
      • djwhitey has quit
      • sumedh joined the channel
      • shivam-kapila
        sarthak_jain: I have made a PR with front end part. You may proceed with the back end part now :)
      • bitmap
        yvanzo: the jira github bot is cool <3
      • c1e0_ has quit
      • c1e0 joined the channel
      • djwhitey joined the channel
      • BrainzGit joined the channel
      • shivam-kapila
        pristine__: I have updated the documentation PR too. Kindly take a look when you are free.
      • sampsyo has quit
      • sampsyo joined the channel
      • Darkloke joined the channel
      • sumedh has quit
      • sumedh joined the channel
      • sarthak_jain joined the channel
      • sarthak_jain
        Hey shivam-kapila
      • The build aint passing for the changes you made. Can you please check and then re-commit. When the build passes, I will commit the backend part !
      • shivam-kapila
        The build aint passing because `delete_listens_history` function doesn't exist. This function is to be added as in `user.py` file which constitutes the backend task. Once you make this function build will definitely pass. I tried it with a dummy function.
      • sarthak_jain has quit
      • sumedh has quit
      • prabal joined the channel
      • reosarevok
        yvanzo: please make sure to check https://github.com/metabrainz/musicbrainz-serve... so we can merge the regression fix and update beta :)
      • Etua joined the channel
      • yvanzo
        reosarevok: thanks, done!
      • pristine__
        shivam-kapila: Whenever you push commits please resolve conversations which have been addressed and leave the ones which need more discussion. Can you do that for *update doc PR*? Almost all the comments are unresolved which gives me a reflection that I should answer all, but when I see them I realise most of them have been answered :(
      • shivam-kapila
        pristine__: Oh sorry! I forgot to do that. Only 1-2 are unresolved.
      • pristine__
        shivam-kapila: no hurry. do it when you get the time.
      • shivam-kapila
        pristine__: I will do it after class.
      • ruaok
        this *looks* interesting, but I have no clue what it does. https://github.com/kingluo/pgcat
      • also, moooin!
      • Gazooo has quit
      • BrainzGit
        [musicbrainz-server] yvanzo opened pull request #1377 (master…fix-warnings): Reduce noise in server logs https://github.com/metabrainz/musicbrainz-serve...
      • Gazooo joined the channel
      • sumedh joined the channel
      • Darkloke has quit
      • sumedh has quit
      • sumedh joined the channel
      • agrochal joined the channel
      • agrochal has quit
      • D4RK-PH0ENiX has quit
      • eharris joined the channel
      • D4RK-PH0ENiX joined the channel
      • sumedh has quit
      • ruaok
      • we have a full board of directors again! :)
      • shivam-kapila has quit
      • yvanzo
        Welcome Paula!
      • zas
        I'd say "Welcome on board" ;)
      • Etua has quit
      • Etua joined the channel
      • shivam-kapila joined the channel
      • prabal has quit
      • ruaok
        zas: oh groan. :)
      • Etua has quit
      • Etua joined the channel
      • iliekcomputers
      • 😂
      • CODEin_JDB joined the channel
      • CODEin_JDB
        Hi Everyone!
      • Congrats to all the winners, runners up and finalists
      • I just want to say thank you to everyone who supported me in my code in journey.
      • c1e0_ joined the channel
      • For the mentors for guiding me in every task. and to the students who shared their experiences with me.
      • c1e0 has quit
      • it has been a really great journey so thanks again for that.
      • c1e0_ is now known as c1e0
      • i hope to work with you next year as well.
      • Good Bye!
      • CODEin_JDB has quit
      • Etua has quit
      • sumedh joined the channel
      • Etua joined the channel
      • outsidecontext
        I love the helpful Github Bot on JIRA :) was this freshly setup?
      • reosarevok
        Yes, thank yvanzo I think
      • iliekcomputers
        what github bot
      • c1e0 has quit
      • c1e0 joined the channel
      • yvanzo
        yup, I just mentionned it yesterday but set it up last Friday.
      • c1e0_ joined the channel
      • c1e0 has quit
      • ruaok
        zas: let's look at this LB load stuff.
      • when looking at back-end logs on lemmy, there are plenty of requests:
      • ... [Tue Feb 11 14:57:31 2020] POST /1/submit-listens => generated 16 bytes in 22 msecs (HTTP/2.0 200) 11 headers in 455 bytes (1 switches on core 0) ...
      • > docker logs --tail=1 -f listenbrainz-web-prod
      • to see those -- on lemmy
      • zas
        that's web traffic, but alerts are about rabbitmq queues, how does the app queue stuff? it would be interesting to check traffic incoming to rabbitmq as well
      • ruaok
        the -web-prod container sanity checks the data, then inserts it into the incoming rabbit mq queue.
      • so, those submit commands translate directly into rabbitmq traffic.
      • and I see some IPs that have been submitting data every second from... russia.
      • and none of this data ever makes it past the deduplication step.
      • if it did, we would see that data get passed onto the unique rabbit mq queue.
      • so, the first question is: why are these posts not showing up in the tops reports?
      • zas
        I don't know miuch about LB stuff, one single web request can store a lot of stuff at once, right?
      • ruaok
        yes
      • but, I think, that 1 request -> 1 rabbitmq packet.
      • zas
        I could capture traffic at ethernet level, and analyze using wireshark
      • ruaok
        let see why tops is not working. that is the first line report I want to see.
      • because I think we need to block some IPs.
      • and client IDs are in the Authorization headers -- if we can see which client IDs are high submitters, we can examine the accounts or revoke the IDs.
      • so, I would *really* like to make the top reports work.
      • zas
        first, ensure everything we need is logged on kiki
      • ruaok
        k, lemme look there.
      • remind me, where are log files stored on kiki?
      • I can never remember.
      • sarthak_jain joined the channel
      • sarthak_jain
        Hi pristine__
      • Meanwhile you review the PR, any other issue to work on, as I dont have much on my plate rn.
      • zas
        in /var/docker-logs/openresty-gateways/nginx
      • btw, I found something weird
      • traffic between kiki and lemmy (on lb container port) is much lower than traffic between lemmy and trille, is there any other container writing to rabbitmq?
      • pristine__
        sarthak_jain: weren't you working on #702?
      • ruaok
        zas: trille? is there something special about trille?
      • zas
        it hosts rabbitmq
      • sarthak_jain
        Yes, I am.
      • ruaok
        ah.
      • yes, lemmy does all sorts of writing and reading from rabbitmq, so I would expect that traffic to be higher.
      • sarthak_jain
        But shivam-kapila and I are both done with our parts, we're just looking forward on how to commit my backend part on his PR !
      • Meanwhile, I am open to new issues, if you've one for me !
      • ruaok
        for every inbound request, there will be 3+ round trips to trille.
      • doh.
      • the container traffic is split. I see now.
      • c1e0_ has quit
      • zas: can you please deploy the top stats on api.listenbrainz-web.access.log ?
      • that is what we were missing. for some reason I remembed it being a separate container, but its a separate entry on the gateway pointing to the same container.
      • sarthak_jain5 joined the channel
      • zas
        ok, let me see
      • sarthak_jain5
        pristine__, will you be reviewing #719 today?
      • sarthak_jain has quit
      • shivam-kapila
        sarthak_jain5: did you try making a PR onto my code? Or I will have to add you as contributor to my repo.
      • sarthak_jain5
        Add me as a contributor to your repo. That'll work. https://superuser.com/questions/1188943/can-i-s...