i'll try to incorporate now playing as well in the plugin after the tests complete.
2020-02-17 04828, 2020
iliekcomputers
now playing listens do not go into the permanent datastore btw, so each of them should be sent as a normal listen too.
2020-02-17 04839, 2020
iliekcomputers
once they're done playing or they meet the criterai
2020-02-17 04841, 2020
iliekcomputers
criteria
2020-02-17 04807, 2020
Freso
amCap1712: Okay, want me to do anything else? Also, what are the plans for upstreaming this? Have you already talked to VLC people? Just wondering if it’d make sense for me to make an ArchLinux package for it. :)
2020-02-17 04807, 2020
amCap1712
got it.
2020-02-17 04808, 2020
amCap1712
Freso: i have to talk with the VLC people. The plan is to include the plugin with future distributions. but before that i need to make sure the plugin works.
2020-02-17 04855, 2020
Freso
Alright. If you don’t mind possibly some more eyeballs on it, I’ll try and see if I can make a package and push it to the AUR. :)
2020-02-17 04827, 2020
amCap1712
yeah sure. the more testers the better.
2020-02-17 04855, 2020
amCap1712
also there are a few other cases to test
2020-02-17 04817, 2020
amCap1712
like playing songs in a playlist.
2020-02-17 04830, 2020
amCap1712
to make sure all songs meeting the criteria are submitted.
2020-02-17 04853, 2020
CatQuest
and thingslike short songs, and longsongs
2020-02-17 04802, 2020
amCap1712
pausing a song and resuming it to see if it works.
2020-02-17 04819, 2020
CatQuest
and playing a song several times
2020-02-17 04821, 2020
amCap1712
also, after discussing with iliekcomputers, we decided that if a song is resumed after pausing it for more than a minute, it should be considered a different listen.
2020-02-17 04825, 2020
rdswift
And restarting a song part way through.
2020-02-17 04833, 2020
amCap1712
yeah that also CatQuest and rdswift
2020-02-17 04838, 2020
amCap1712
so you now that you are setup,you can your time and let me know if anything does not work as intended
2020-02-17 04803, 2020
amCap1712
rdswift: by the way, listenbrainz for deadbeef is on the way as well
2020-02-17 04825, 2020
rdswift
\ o / Thank-you!
2020-02-17 04855, 2020
rdswift
I'm currently submitting using the last.fm pluging pointing to http://proxy.listenbrainz.org but the results are a bit hit-and-miss. Sometimes listens seem to get lost.
2020-02-17 04848, 2020
rdswift
Now playing seems to work consistently, but not always when the song is completed.
2020-02-17 04852, 2020
outsidecontext
zas: I am around now. I'll update translations and tag the Picard release, then we can continue with the website and blog post
2020-02-17 04837, 2020
amCap1712
rdswift: i'll keep that in mind and if you find a pattern between the lost listens, do let me know
2020-02-17 04837, 2020
rdswift
Will do. I'm just looking at setting up Wireshark to see what packets are being sent to see if it's an issue at this end.
reosarevok: thanks, I'll check the other ticket now
2020-02-17 04837, 2020
Freso
"we decided that if a song is resumed after pausing it for more than a minute, it should be considered a different listen." I disagree with this.
2020-02-17 04837, 2020
amCap1712
its not finalized. its yet to be discussed by the community.
2020-02-17 04852, 2020
amCap1712
but the current implementation.
2020-02-17 04802, 2020
Freso
I’ll try and play around with it more.
2020-02-17 04855, 2020
outsidecontext
Picard gained a 100% Malay translations since last week (from non existant previously), that's so great. awesome work
2020-02-17 04810, 2020
reosarevok
Whoo
2020-02-17 04854, 2020
prabal
@Mr_Monkey Hi
2020-02-17 04830, 2020
Mr_Monkey
Hi !
2020-02-17 04848, 2020
outsidecontext
It's a pitty translation work is happening so isolated and kind of anonymous. for most other contributions there is more interaction with the users and you somehow get to know the people behind it. but translations currently mostly just happen :(
Freso: to be exact, the current implementation is as follows, when the pause exceeds a minute. it is checked if the played part qualifies for a submission if yes then the the part is submitted and the played duration is reset. the part after the pause is treated as a new listen. but if the part before the pause does not qualify as a listen, then the whole playing time before and after the pause is considered as a whole.
2020-02-17 04820, 2020
prabal
This editor has only 3 revisions. In this case, `next` button in pager should be disabled
2020-02-17 04850, 2020
prabal
This is still fine, when the same thing happens with search result, clicking `next` gives 404 error.
2020-02-17 04837, 2020
Mr_Monkey
Good catch
2020-02-17 04846, 2020
prabal
You'll have to find some search result with exact 10 or 20 or 50 or 100 to test it
2020-02-17 04853, 2020
prabal
I tested locally
2020-02-17 04808, 2020
prabal
It's because `nextEnabled: data.length>=size`
2020-02-17 04836, 2020
Mr_Monkey
You mentionned previously fetching one more result and cropping the results
2020-02-17 04844, 2020
prabal
Yeah
2020-02-17 04849, 2020
Mr_Monkey
It's the only way I see to fix this issue
2020-02-17 04812, 2020
prabal
And because there can be atmost 100 results, I think slicing won't be a problem
2020-02-17 04849, 2020
prabal
We didn't use slicing with `revisionPage` remember? Because it wasn't scalable
2020-02-17 04842, 2020
Mr_Monkey
You can even use .pop(), it's fast
2020-02-17 04812, 2020
prabal
Hmm. Getting 1 more result seems the only way right?
2020-02-17 04846, 2020
Mr_Monkey
Yes
2020-02-17 04841, 2020
prabal
Alright. I will it now. Now that there is only one `pagerElement` it's easier to fix :)
I will create a ticket for that also. It's better if all html title are done in one PR, just like icons. Right?
2020-02-17 04824, 2020
Mr_Monkey
prabal: Well, I encourage you to open a ticket for anything you see that' can be improved, even if you're planning on working on it straight away (in which case, just assign it to yourself)
2020-02-17 04828, 2020
Mr_Monkey
Oh hey :)
2020-02-17 04839, 2020
Mr_Monkey
Yes, it's a good unit of work
2020-02-17 04810, 2020
amCap1712
Freso: can you check out the documentation for compiling and using the plugin
2020-02-17 04844, 2020
amCap1712
and give your feedback on anything that needs to be improved in the docs
[21:03] <Freso> amCap1712: Yeah. I would want it to count as one listen even if I pause it for 19 hours.
2020-02-17 04810, 2020
CatQuest definitely don't agree with that :)
2020-02-17 04814, 2020
CatQuest
(but i guess mostly this is because i would def play something else i between that)
2020-02-17 04820, 2020
Freso
CatQuest: Yeah, I get annoyed that my phone submits a new play when I continue playback when I’m travelling. It’s not that I chose to play this track again, it’s just that it didn’t finish last time it was playing.
2020-02-17 04846, 2020
Freso
If I stopped playing a song, and then start it over from the beginning later, then I’d be happy to have it count as a new listen.
2020-02-17 04851, 2020
CatQuest
hmm
2020-02-17 04808, 2020
CatQuest
good point
2020-02-17 04831, 2020
yvanzo
bitmap, reosarevok: thanks, reviewed both!
2020-02-17 04821, 2020
bitmap
👍
2020-02-17 04841, 2020
bitmap
there's one more PR against beta that fixes some broke selenium tests
reosarevok: maybe for dockerignore, but neither for flow nor eslint.
2020-02-17 04853, 2020
reosarevok
Ok
2020-02-17 04819, 2020
reosarevok
Approved then
2020-02-17 04808, 2020
rdswift
ruaok, I reopened LB-48 and attached a wireshark capture from my end that appears to show the submissions going through, but not all are appearing on my listen history. I hope the information helps. No real rush on this from my perspective, because I know that you have more important items to deal with. Thanks.
I see people doing imports from last.fm over the past few hours and that looks to be slowing us down with a limping DB.
2020-02-17 04800, 2020
rdswift
Are those the number of outstanding record updates? Looks like a bit of a backup alright.
2020-02-17 04859, 2020
rdswift
At least it looks like my stuff is in the queue. That's a good sign.
2020-02-17 04827, 2020
ruaok
correct on all counts.
2020-02-17 04858, 2020
ruaok
we've hit some sort of inflection point on the DB -- something has drastically cut its performance. now we have to dig why.
2020-02-17 04821, 2020
ruaok
5 people at the same time doing an import? also a good sign.
2020-02-17 04847, 2020
rdswift
👍
2020-02-17 04816, 2020
rdswift
zas, outsidecontext: Do you think there would be any value in reorganizing the funtions on the Scripting page into subsections (e.g. Basic, Arithmetic, Logic & Tests, Multi-Value, Loops, etc.)?
2020-02-17 04845, 2020
zas
actually I was thinking about sorting them at least while reviewing website
2020-02-17 04859, 2020
zas
but feel free to make a PR :)
2020-02-17 04819, 2020
outsidecontext
rdswift: yes, I think so. also maybe splitting functions away from rest of scripting implementation into separate file(s)
2020-02-17 04834, 2020
rdswift
Okay, I'll try to come up with a draft structure for you guys to review (to make sure I'm on the right track) before commiting the time to developing a full PR. Thanks.
