#metabrainz

we're still tiny in the grand scale of things

MediumData

that's us.

hey, mail!!

good bot

woof.

er. <bleep>

iliekcomputers: Finally pushed the test. The rebase was stuck as I had some commit in the branch locally that was causing conflict. Sorry for the fuss

shivam-kapila: already reviewed

lol

wow!

ruaok: did you see the warnings in sentry 🤣

ouch

for some definition of works

I didn't look. what happened?

iliekcomputers: How can I test whether the listens are deleted or not. Any reference in already existing tests?

there's a log for when a file doesn't exist in hdfs and we try to load it. we don't have any listens for the years of 2005 - 2007 i think, and we try to load it all.

so a bunch of "file doesn't exist" spam in sentry

shivam-kapila: hey

yes!

joy

the tests in this file use `send_data` to submit listens

there is prior art to check that the listens exist in this test: https://github.com/metabrainz/listenbrainz-serv...

after this, you'd probably submit a POST to the endpoint you added

and then call the get_listens endpoint again, which should this time not return any listens

does that make sense?

yeah. thanks a lot :)

shivam-kapila: also, if you're adding something that is user-facing, it is very helpful if you post a video / gif / screenshot showing what you've changed

Sure. Locked in mind from now.

The check that listens were deleted successfully are to be added to both tesh.sh and integration-test.sh. Right?

i don't think they'll work in test.sh

let's add an integration test

yeah I was also confused for the same reason.

this seems the relevant file

Okay thanks

shivam-kapila: did i ever follow up with you about the figma you made?

My fault here. I didnt discuss my status on it. Actually I am trying to remake the design using image based card view design. So as ruaok pointed out that there can be issues with loading so many images. So I am trying to optimise that. Also for the graph plotting I found http://recharts.org. But they dont have quite good docs so trying tweaking through that. I will finish that just after my exams.

question

can we do them one by one

You mean image loading?

like create a graph each in different react components, each on it's own page and then later add a dashboard

I guess yes.

Will try to separate the graph here and import it into the dashboard

recharts looks pretty nice

so

could we migrate this to recharts?

(or just react in general)

yeah sure. I will work on it too. Recharts has barcharts too so migrating this page wont be difficult

shivam-kapila: ok, cool.

so

here's what i think is the best way forward

assume you have data in the following format: [{artist_name: 'Kanye West', count: 10}, {'artist_name': 'Frank Ocean', count: 2}]

migrate the page I just linked to react

add tests (once ishaanshah[m]'s PR is merged)

once we have that, we'll know more about how usable recharts actually is.

then we can look into more graphs

does that make sense?

Got it. Thanks for the work plan. Will start this just after my exams.

sure.

thanks

A lil doubt here. For testing the invalid auth token. Is it okay if I append some unnecessary characters to the auth token?

anything invalid would work

obvious string is 'invalid-auth-token'

so that the reader understands what the test is doing

Makes sense.