#metabrainz

/

      • gr0uch0mars
        nevermind, anyone is welcome!
      • 2020-03-10 07052, 2020

      • shivam-kapila
        Pac23: Try notepad.pw. A pastebin with custom sharing links
      • 2020-03-10 07009, 2020

      • Pac23
        i wanna meet hte person who decided on creating such long link,literally no url shortner will accept this link except for bitly and they idk why wont update to a new shorted link
      • 2020-03-10 07034, 2020

      • ruaok
        Pac23: you could just post a screenshot.
      • 2020-03-10 07045, 2020

      • Pac23
        i can but then its bit wide so it wont look that clear,i thought so
      • 2020-03-10 07052, 2020

      • Pac23
        i can if you want
      • 2020-03-10 07004, 2020

      • ruaok
        is easier.
      • 2020-03-10 07047, 2020

      • _lucifer
        gr0uch0mars: we can do that but we need to make the "picard library" somewhat stable before
      • 2020-03-10 07051, 2020

      • Pac23
        yes it s
      • 2020-03-10 07053, 2020

      • Pac23
        *is
      • 2020-03-10 07005, 2020

      • ruaok
      • 2020-03-10 07029, 2020

      • ruaok
        Pac23: that is the basic outline of the ingestion pipeline.
      • 2020-03-10 07044, 2020

      • ruaok
        currently all of that is done via python.
      • 2020-03-10 07013, 2020

      • ruaok
        and the goal is to port this pipeline to go.
      • 2020-03-10 07054, 2020

      • Pac23
        yes,i did get that before itself , just had problems with understanding the rabbitmq thing
      • 2020-03-10 07002, 2020

      • gr0uch0mars
        _lucifer: how unstable is it now? I mean, could we try to set a roadmap/requirements to split into a library meanwhile?
      • 2020-03-10 07003, 2020

      • Pac23
        also can we go to dm
      • 2020-03-10 07018, 2020

      • Pac23
        just for couple of mins
      • 2020-03-10 07037, 2020

      • ruaok
        do you need to discuss something private? if not, lets stay here.
      • 2020-03-10 07042, 2020

      • Pac23
        yes\
      • 2020-03-10 07049, 2020

      • ruaok
        aight.
      • 2020-03-10 07008, 2020

      • _lucifer
        _lucifer: there a few bugs. I'll have a closer look over it by the end of week and let you know my thoughts
      • 2020-03-10 07049, 2020

      • gr0uch0mars
        great. I think next week would be fine to talk about all the things to be done
      • 2020-03-10 07020, 2020

      • _lucifer
        ruaok: if I am right, metabrainz has an android publishing account ?
      • 2020-03-10 07051, 2020

      • ruaok
        I bet google suspended it again for whatever bizarre and confusing reason.
      • 2020-03-10 07004, 2020

      • ruaok
        I gave up a long time ago trying to keep it above board.
      • 2020-03-10 07014, 2020

      • _lucifer
        Was that suspension in the email you forwarded to me the last year?
      • 2020-03-10 07043, 2020

      • ruaok
        one of many.
      • 2020-03-10 07050, 2020

      • _lucifer
        Oh ok.
      • 2020-03-10 07012, 2020

      • _lucifer
        I think the app was suspended not the account.
      • 2020-03-10 07045, 2020

      • _lucifer
        Do you want to move the app to metabrainz account in that case ?
      • 2020-03-10 07032, 2020

      • _lucifer
        The publishing account has organisational access features like IAM to restrict developer actions.
      • 2020-03-10 07002, 2020

      • _lucifer
        I mean you can invite me without sharing the account credentials or giving access to sensitive features.
      • 2020-03-10 07003, 2020

      • _lucifer
      • 2020-03-10 07004, 2020

      • BrainzGit
        [musicbrainz-server] reosarevok opened pull request #1417 (master…update-mapbox): MBS-10689: Update MapBox API calls https://github.com/metabrainz/musicbrainz-server/…
      • 2020-03-10 07005, 2020

      • BrainzBot
        MBS-10689: Update MapBox API calls https://tickets.metabrainz.org/browse/MBS-10689
      • 2020-03-10 07037, 2020

      • reosarevok
        yvanzo, bitmap ^ if we can merge that we'll get rid of the issue ruaok pointed out :)
      • 2020-03-10 07046, 2020

      • reosarevok
        also yvanzo, any idea why selenium is failing on https://github.com/metabrainz/musicbrainz-server/… ?
      • 2020-03-10 07019, 2020

      • yvanzo
        it sometimes fails for no reason, ignore that one
      • 2020-03-10 07048, 2020

      • yvanzo
        however, I just found an errant change in this PR ^^
      • 2020-03-10 07028, 2020

      • _lucifer
        yvanzo: i have updates the information on the musicbrainz android wiki page.
      • 2020-03-10 07038, 2020

      • yvanzo
        thanks, reviewing it
      • 2020-03-10 07026, 2020

      • sumedh joined the channel
      • 2020-03-10 07057, 2020

      • yvanzo
        _lucifer: does the app allow to search for any entity type?
      • 2020-03-10 07031, 2020

      • c1e0_ has quit
      • 2020-03-10 07046, 2020

      • _lucifer
        yvanzo: not all but most
      • 2020-03-10 07003, 2020

      • yvanzo
        this page is destinated to users not developers, so better list them please
      • 2020-03-10 07008, 2020

      • _lucifer
        should i add a specific list
      • 2020-03-10 07013, 2020

      • _lucifer
        👍
      • 2020-03-10 07003, 2020

      • gr0uch0mars
        how can I log into the Wiki? I tried long ago but no success, and now I'm trying again
      • 2020-03-10 07029, 2020

      • _lucifer
        a different account is needed for the wiki i think
      • 2020-03-10 07008, 2020

      • gr0uch0mars
        hmm I have a user/pass, I though they were from the wiki
      • 2020-03-10 07053, 2020

      • yvanzo
      • 2020-03-10 07024, 2020

      • _lucifer
        done yvanzo
      • 2020-03-10 07043, 2020

      • yvanzo
        _lucifer: thanks, does the app have versions?
      • 2020-03-10 07051, 2020

      • yvanzo
        I cannot find any from GitHub or Play store.
      • 2020-03-10 07051, 2020

      • gr0uch0mars
        yvanzo: tried but the Invalid password message appeared. I'll try to recover the password, maybe it's that
      • 2020-03-10 07030, 2020

      • _lucifer
        yvanzo: the app has versions but the play store allows users to download the latest version only
      • 2020-03-10 07026, 2020

      • yvanzo
        so what is the current version?
      • 2020-03-10 07050, 2020

      • gr0uch0mars
        _lucifer and SomalRudra I have answered in the proposal thread: https://community.metabrainz.org/t/gsoc-2020-desi…
      • 2020-03-10 07053, 2020

      • _lucifer
        2.4 yvanzo
      • 2020-03-10 07044, 2020

      • _lucifer
        I'll add a new screen shot but I need to compile the app for that. I'll do that soon
      • 2020-03-10 07034, 2020

      • yvanzo
        that would be nice to tag github repo accordingly too, e.g. 'v2.4'
      • 2020-03-10 07056, 2020

      • _lucifer
        will do that yvanzo
      • 2020-03-10 07008, 2020

      • _lucifer
        from now on for all future releases
      • 2020-03-10 07021, 2020

      • _lucifer
      • 2020-03-10 07031, 2020

      • gr0uch0mars
        _lucifer: something I wanted to have done for last GSoC was a CHANGELOG.md with all changes, and GitHub releases
      • 2020-03-10 07039, 2020

      • _lucifer
        the issue is react->java->C
      • 2020-03-10 07054, 2020

      • _lucifer
        I had that in a community post gr0uch0mars
      • 2020-03-10 07006, 2020

      • _lucifer
        and will add the rest from the git log
      • 2020-03-10 07045, 2020

      • _lucifer
        so as I was saying the issue with react is that we need to go react->java->C and back on the same route
      • 2020-03-10 07056, 2020

      • _lucifer
        for every call
      • 2020-03-10 07015, 2020

      • _lucifer
        we cannot eliminate the java codebase in any case
      • 2020-03-10 07039, 2020

      • _lucifer
        the react layer will add performance overheads.
      • 2020-03-10 07042, 2020

      • reosarevok
        yvanzo: oh, so you'd want to also paginate http://musicbrainz.org/user/jesus2099/tags or whatnot?
      • 2020-03-10 07050, 2020

      • reosarevok
        Didn't think of that, but maybe?
      • 2020-03-10 07008, 2020

      • gr0uch0mars
        I'll read the long article
      • 2020-03-10 07020, 2020

      • _lucifer
        and the java and C layer will need to be rewritten for the iOS app since that is what essentially cross compatibility
      • 2020-03-10 07036, 2020

      • reosarevok
        Also, what do you mean with "Please make URLs more user-friendly."?
      • 2020-03-10 07039, 2020

      • _lucifer
        *prevents cross compatibility
      • 2020-03-10 07045, 2020

      • gr0uch0mars
        I know the library would be java/swift->C. But I don't think the app itself has enough complexity to add overhead
      • 2020-03-10 07043, 2020

      • gr0uch0mars
        you're right that the hardest point would be frameworkXXX <-> library (java/swift)
      • 2020-03-10 07056, 2020

      • gr0uch0mars
        that's what I wanted to explore
      • 2020-03-10 07001, 2020

      • gr0uch0mars
        to see how far we could reach
      • 2020-03-10 07045, 2020

      • _lucifer
        i don't have any issues going with the react route than considering is it worth it. (also my personal hate for JS but I can keep that aside)
      • 2020-03-10 07057, 2020

      • _lucifer
        The point of contention is whether writing the UI twice or adding a UI layer using React is better.
      • 2020-03-10 07004, 2020

      • _lucifer
        and maintainable
      • 2020-03-10 07000, 2020

      • reosarevok
        yvanzo: I hadn't converted user/tags.tt at all as part of this, but maybe I should since it does hide the downvoted bits
      • 2020-03-10 07013, 2020

      • gr0uch0mars
        nono, that's why I asked about spliting the library
      • 2020-03-10 07014, 2020

      • reosarevok
        I'll make sure to make that a second commit though :p
      • 2020-03-10 07024, 2020

      • gr0uch0mars
        let's keep it this way and just be open to new ideas
      • 2020-03-10 07005, 2020

      • _lucifer
        yeah gr0uch0mars i understand.
      • 2020-03-10 07015, 2020

      • _lucifer
        yeah we should be open to new ideas.
      • 2020-03-10 07045, 2020

      • _lucifer
        we will need to rewrite the library part anyways for both patforms
      • 2020-03-10 07032, 2020

      • _lucifer
        I am in favour of splitting it.
      • 2020-03-10 07046, 2020

      • yvanzo
        reosarevok: I thought that ticket was about paginating that page, what am I missing?
      • 2020-03-10 07003, 2020

      • reosarevok
        It's about paginating the pages for the tags themselves, or at least that was my understanding
      • 2020-03-10 07037, 2020

      • reosarevok
        I never thought the user/tags page itself needed pagination :)
      • 2020-03-10 07049, 2020

      • reosarevok
        But looking at jesus' one, it might sometimes :D
      • 2020-03-10 07021, 2020

      • yvanzo
        reosarevok: please add example links for pages that are affected.
      • 2020-03-10 07058, 2020

      • reosarevok
        "For some test of how this works (better to use the RO Pink DB rather than the sample): /user/reosarevok/tag/to%20clean%20up (per-entity shorter lists + pagination), /user/reosarevok/tag/classical (upvoted vs downvoted)."
      • 2020-03-10 07000, 2020

      • reosarevok
        It's on the PR :p
      • 2020-03-10 07006, 2020

      • reosarevok
        As a comment, to be fair, but
      • 2020-03-10 07059, 2020

      • yvanzo
        '?showDownvoted=1' is not very user-friendly, it is debugger-friendly at best ;)
      • 2020-03-10 07028, 2020

      • reosarevok
        That's how we do it everywhere else though
      • 2020-03-10 07035, 2020

      • yvanzo
        a subpath '/downvoted' would probably be cleaner
      • 2020-03-10 07005, 2020

      • reosarevok
      • 2020-03-10 07012, 2020

      • reosarevok
        I was hoping to be consistent
      • 2020-03-10 07027, 2020

      • yvanzo
        yes but artist entry has tabs, not user tags tab
      • 2020-03-10 07045, 2020

      • sumedh has quit
      • 2020-03-10 07003, 2020

      • yvanzo
        it's just an example of potentially cleaner form, not sure it works for every case in this PR (given I did not even find affected pages)
      • 2020-03-10 07046, 2020

      • prabal joined the channel
      • 2020-03-10 07046, 2020

      • yvanzo
        and if it becomes an headache, give it away, it's not the most important. :)
      • 2020-03-10 07058, 2020

      • SothoTalKer has quit
      • 2020-03-10 07023, 2020

      • SothoTalKer joined the channel
      • 2020-03-10 07027, 2020

      • yvanzo
        reosarevok: Indeed downvoted subpath would probably clash with entity type
      • 2020-03-10 07016, 2020

      • yvanzo
      • 2020-03-10 07056, 2020

      • mudcrow joined the channel
      • 2020-03-10 07032, 2020

      • Cyna
        Hey _lucifer, I'd recommend finding a way to switch from Java to React Native which would help in being uniform with Musicbrainz project atleast. This would help up keep UI uniform as well as use most of the React features in RN
      • 2020-03-10 07005, 2020

      • Cyna
        Could you whip me up a diagram as to what features are included in the App and How they are linked ?
      • 2020-03-10 07029, 2020

      • Cyna
        reosarevok, bitmap There will be delay in other PRs to be raised. Laptop's charger busted.. 😅
      • 2020-03-10 07047, 2020

      • bitmap
        ah damn :/
      • 2020-03-10 07019, 2020

      • yvanzo
        _lucifer: made small changes (history section, command-line formating) and updated transclusion to https://musicbrainz.org/doc/MusicBrainz_for_Andro…
      • 2020-03-10 07016, 2020

      • _lucifer
        thanks yvanzo
      • 2020-03-10 07011, 2020

      • _lucifer
        Cyna: I don't have a diagram as of now
      • 2020-03-10 07019, 2020

      • _lucifer
        gr0uch0mars: do you happen to have one ?
      • 2020-03-10 07013, 2020

      • Cyna
        A rough one would also work... I just need to know how things are linked in an overview.. rest i can read code to understand
      • 2020-03-10 07019, 2020

      • yvanzo
        bitmap, reosarevok: random test failure at https://circleci.com/api/v1.1/project/github/meta…
      • 2020-03-10 07057, 2020

      • _lucifer
        Cyna: can we go the other way round ? can you take a quick glance at the app and the source code. I'll walk you through it.
      • 2020-03-10 07046, 2020

      • yvanzo
        “random” because this PR doesn’t change a single bit possibly related to the failed test and base commit passed tests at https://app.circleci.com/jobs/github/metabrainz/m…
      • 2020-03-10 07029, 2020

      • bitmap
        yeah I've seen that one before
      • 2020-03-10 07058, 2020

      • pristine__
        ruaok: there is a single command to create multiple spark sessions.
      • 2020-03-10 07015, 2020

      • yvanzo
        bitmap: do you know the proper way to rebuild in Jenkins? The “Rebuild” button seems to fail, e.g. 1417
      • 2020-03-10 07020, 2020

      • pristine__
        Using Spark API. Tadda!
      • 2020-03-10 07046, 2020

      • bitmap
        yvanzo: currently you have to comment on github "@brainzbot, retest this please"
      • 2020-03-10 07001, 2020

      • ruaok
        pristine__: great!
      • 2020-03-10 07010, 2020

      • bitmap
        I installed that rebuild plugin but it's buggy and doesn't work with the ghprb plugin :\
      • 2020-03-10 07025, 2020

      • yvanzo
        thanks
      • 2020-03-10 07031, 2020

      • pristine__
        ruaok: you great
      • 2020-03-10 07029, 2020

      • ruaok
        🧐
      • 2020-03-10 07015, 2020

      • SothoTalKer_ joined the channel
      • 2020-03-10 07003, 2020

      • gr0uch0mars
        Cyna: hi, I can help because as part of the mobile app mentorship I was going to make a diagram with all the parts and dependencies so more people could help with new ideas
      • 2020-03-10 07046, 2020

      • SothoTalKer has quit
      • 2020-03-10 07041, 2020

      • gr0uch0mars
        _lucifer: would you mind if I try to keep this organizational role, and let you develop and lead the programmning side? (Like moving the repo you did before, organizing the deploy to Google Play with a proper account, and so on)
      • 2020-03-10 07029, 2020

      • gr0uch0mars
        I think this way you could be more free of work and concentrate on pushing the app forward (which you rewrote last year! 💪🏼)
      • 2020-03-10 07020, 2020

      • _lucifer
        I don't have any issues with that gr0uch0mars
      • 2020-03-10 07031, 2020

      • _lucifer
        if ruaok agrees to move the app to metabrainz account, you can manage the deploy there
      • 2020-03-10 07044, 2020

      • gr0uch0mars
        Great!
      • 2020-03-10 07002, 2020

      • ruaok
        I'm happy to pass off the account tomorrow.
      • 2020-03-10 07007, 2020

      • _lucifer
        otherwise, if we keep the app in my account, i'll invite you to it