It seems to work fine locally, unless I'm missing some specific detail of the edits in question
2020-03-16 07613, 2020
ruaok
shivam-kapila: thanks! I think the profile page looks great now, but I think the confirmation page might really be a good idea.
2020-03-16 07615, 2020
ruaok
sorry!
2020-03-16 07607, 2020
shivam-kapila
ruaok: NP. I will add that back and push the code.
2020-03-16 07625, 2020
shivam-kapila
Thanks for the compliment too :D
2020-03-16 07617, 2020
alastairp
ruaok: that's an interesting thing that we've struggled with for a long time on these apps
2020-03-16 07638, 2020
ruaok
which thing?
2020-03-16 07603, 2020
alastairp
should confirmation be a simple javascript `confirm()`? should it be a complete new page (in which case we should use POST for forms, as it's a destructive action), should we use our own custom js popup? (bad for people who don't want js)
2020-03-16 07611, 2020
alastairp
confirmation page
2020-03-16 07629, 2020
alastairp
there are lots of buttons here and there that we have that should have confirmations, but they're all implemented quite inconsistently
2020-03-16 07636, 2020
ruaok
yes. agreed. but in the case of delete all, I think a separate page should be good.
and phone needs more cgarging becasue it was at 31 or something
2020-03-16 07650, 2020
blup
happy fixed phone is charging happily! :D
2020-03-16 07627, 2020
yvanzo
bitmap, reosarevok: most of recently resolved MBS tickets are not assigned, my guess is you were self-assigning it when submitting PRs but since transition is now automated, you just forgot about.
2020-03-16 07644, 2020
reosarevok
Oh, I thought the transition dealt with that
2020-03-16 07653, 2020
reosarevok
Can it?
2020-03-16 07601, 2020
reosarevok
Because if it can then it'd be great if it did
2020-03-16 07617, 2020
reosarevok
Otherwise it defeats the whole point of not needing to check the ticket :p
2020-03-16 07635, 2020
blup
idk, i think it can becasue I mean I am always assined inst tickets. that's a transition there
2020-03-16 07637, 2020
yvanzo
It is supposed to be assigned when you start working on it (not even having coded anything), our GitHub Bot is not brilliant enough to guess that. ;)
2020-03-16 07639, 2020
reosarevok
I mean, I never do that unless I have a reason to think someone might take the ticket, because I might end up not finding a good solution
2020-03-16 07644, 2020
shivam-kapila
ruaok: Added the confirmation page back :).
2020-03-16 07652, 2020
yvanzo
reosarevok: There is no user mapping between GitHub and MeB Tickets, that’s why it cannot automatically assign tickets anyway.
2020-03-16 07606, 2020
reosarevok
Oh, I see. I thought maybe it could map by email or somethig
2020-03-16 07609, 2020
reosarevok
*something
2020-03-16 07613, 2020
reosarevok
Damn
2020-03-16 07641, 2020
yvanzo
reosarevok: I most often work on tickets first and only self-assign if I have some work in progress, but not necessarily a PR.
2020-03-16 07617, 2020
reosarevok
Sure, if I think it's going to take long I'll also self-assign :)
2020-03-16 07621, 2020
yvanzo
(of course, for small fixes, it makes no difference)
shivam-kapila: the video looks good. let me give the PR the final review in a bit.
2020-03-16 07622, 2020
shivam-kapila
ruaok: Sure. Thanks. :)
2020-03-16 07652, 2020
reosarevok
I'll fix it
2020-03-16 07639, 2020
blup
ok, someone explain why peopel hoard *toilet* paper of all things. i don't et it, really
2020-03-16 07639, 2020
blup
so many things can get horded. why toiletpaper especially?
2020-03-16 07639, 2020
blup
I'f focus on things that is hard to come by, things that had long shelflife, things you could prepare witouth heat, etc. for hoarding "because the world is going to end!111bbq" or whatever peopel are doing
2020-03-16 07638, 2020
blup
toiletpaper isn't he first, second or evne third thing I think of
2020-03-16 07611, 2020
blup
¯\_(ツ)_/¯
2020-03-16 07659, 2020
yvanzo
reosarevok, bitmap: No objection onto releasing MBS-4090 now even though it did not pass beta? (since we usually don’t test reports in beta anyway)
Yea.. will remove it. Its was just for the local instance to have latest yarn modules to prevent any sort of error
2020-03-16 07602, 2020
Cyna
I'll make the changes and repush the PR
2020-03-16 07613, 2020
yvanzo
reosarevok: blog post draft available for completion
2020-03-16 07606, 2020
Cyna
Pushed.. I havent added the convertion function calls over there.. Will add those by tomorrow. Rest I have tested on my local instance and seems to work fine
2020-03-16 07603, 2020
Freso
<BANG>
2020-03-16 07603, 2020
Freso
It’s Freedom of Information Monday, but I’ll be sharing a video about corona. Please be sure to take care of yourselves everyone.
People up for review: pristine__, ruaok, bitmap, Freso, iliekcomputers, reosarevok, Mr_Monkey, zas, yvanzo, shivam-kapila,CatQuest, _lucifer, ishaanshah[m], Cyna – anyone else who wants to give review, just let me know.
2020-03-16 07603, 2020
Freso
(And if anyone isn’t here, no stress, we’ll just pass over you and continue with the next one.)
2020-03-16 07603, 2020
Freso
pristine__: Go!
2020-03-16 07605, 2020
Freso
pristine__ says:
2020-03-16 07605, 2020
Freso
"""
2020-03-16 07605, 2020
Freso
So I am again travelling to home. There are 117 cases of COVID-19 in India as of now, the govt has closed all schools, colleges till March 31. Last week I mostly read about spark sessions and context and opened a draft PR proposing possible solutions to enable leader to run multiple spark applications. Other than that I read a little about Corona. Be safe everyone. Lots of love.
2020-03-16 07605, 2020
Freso
"""
2020-03-16 07609, 2020
Freso
ruaok: Go!
2020-03-16 07645, 2020
ruaok
sorry, going
2020-03-16 07652, 2020
_lucifer
Summer of Code Applications open!!
2020-03-16 07604, 2020
iliekcomputers
Freso: Don't have anything this week.
2020-03-16 07611, 2020
ruaok
last week was speshul, in a way that is going to be fully ecipsed by the coming weeks.
2020-03-16 07612, 2020
Cyna
Wells its something to be excited of :)
2020-03-16 07637, 2020
shivam-kapila
yippee
2020-03-16 07651, 2020
ruaok
I did a pile of housework stuff, which has all been annililated by the current virus drama
2020-03-16 07615, 2020
ruaok
I did some work moving towards timescale and then thursday and friday I just prepped for the coming lockdown.
2020-03-16 07635, 2020
ruaok
today I finally caught up on some PRs and helping _lucifer get the android app signing settled.
2020-03-16 07652, 2020
ruaok
mb team: the syswiki now had a subdir called android-app
2020-03-16 07610, 2020
ruaok
this dir contains keys and signature files for signing apps, should you ever need that.
2020-03-16 07632, 2020
bitmap
gotcha
2020-03-16 07656, 2020
ruaok
well, I am settled into the lockdown and am working hard to concentrate, regardless of how difficult it can be at times.
2020-03-16 07624, 2020
ruaok
and, I see a lot of stupid things happening in the world right now.
2020-03-16 07632, 2020
zas
more than usual?
2020-03-16 07641, 2020
Mr_Monkey
More than usual.
2020-03-16 07644, 2020
Freso
More out in the open at least.
2020-03-16 07648, 2020
blup
same old shit imho
2020-03-16 07658, 2020
blup
let's move on
2020-03-16 07659, 2020
ruaok
but I want to remind you all that work is far far far distantly removed from personal and family safety.
2020-03-16 07625, 2020
ruaok
if there is ever a question on your mind about finishing a PR or looking after yourself or you family, let there be no doubt.
2020-03-16 07629, 2020
ruaok
you and your family come first.
2020-03-16 07632, 2020
reosarevok
I mean, other than needing the work for healthcare :D
